Testmerge #49042: 'Adds speech sounds'

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.

Moderators: MisterPerson, Code Maintainers

User avatar
Ghilker
 
Joined: Mon Apr 15, 2019 9:44 am
Byond Username: Ghilker

Testmerge #49042: 'Adds speech sounds'

Postby Ghilker » Fri Feb 07, 2020 8:50 am #540398

Those are really loud and annoying, please i dont want to hear me as AI going "HuH" for 2 hours straight.

Your choice of not adding a player OOC choice is stupid since (at least for me) those sounds are not adding much to the game, just more distraction.



User avatar
Armhulen
Github User
 
Joined: Thu Apr 28, 2016 4:30 pm
Byond Username: Armhulenn
Github Username: Armhulen

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Armhulen » Fri Feb 07, 2020 8:52 am #540399

needs a toggle, would like different styles like hud styles to pick from
support my friends website
are you saying that bah wip gla bloop shibbidy doo WTFRIGOLA i had an EWWWWSWORD and I got "STOONED" ???!?!?! wtf?!!!!?!!?! MORE RNG REQUIRDD till my text........ IS GREEN
Spoiler:
Image

User avatar
Super Aggro Crag
In Game PermaBanned
 
Joined: Sat Mar 21, 2015 9:47 pm
Byond Username: Super Aggro Crag

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Super Aggro Crag » Fri Feb 07, 2020 10:34 am #540421

The last time we did this the spacemen said "mememememe" which is better than HMMMMMM
Image
Image
Image
Image
Image
Image
Image

User avatar
Ghilker
 
Joined: Mon Apr 15, 2019 9:44 am
Byond Username: Ghilker

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Ghilker » Fri Feb 07, 2020 11:33 am #540439

imagine to have to bear this for an entire round of game
http://www.youtube.com/watch?v=vvQdtlW5yJU

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Fri Feb 07, 2020 12:44 pm #540452

You are welcome to read and comment on the PR as well, I wont bother repeating everything here.
https://github.com/tgstation/tgstation/pull/49042

Here's a summary:
I dont want a toggle because if you turn them off you are still going to be that annoying piece of shit that doesnt react when someone talks to you. See footsteps for some precedent.

All the sounds are up for discussion, but if you suggest something that is impossible to find source material for you better be willing to record some. The nice thing about hmms is they are simple and easy to record more of as we move forward.

Sound packs where players can pick how they sound is possible, although not implemented just yet. There is also a limited number of hmms available freely for use, so we would need to record some ourselves.

Tlaltecuhtli
 
Joined: Fri Nov 10, 2017 12:16 am
Byond Username: Tlaltecuhtli

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Tlaltecuhtli » Fri Feb 07, 2020 12:52 pm #540455

>I dont want a toggle because if you turn them off you are still going to be that annoying piece of shit that doesnt react when someone talks to you. See footsteps for some precedent.

maybe they dont want to speak to you just do like everyone else and spam pointing them until they stop hows writing in chat jdfakhjdfsj so you make a noise any better ?????

User avatar
Ghilker
 
Joined: Mon Apr 15, 2019 9:44 am
Byond Username: Ghilker

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Ghilker » Fri Feb 07, 2020 1:03 pm #540457

skoglol wrote:Sound packs where players can pick how they sound is possible, although not implemented just yet. There is also a limited number of hmms available freely for use, so we would need to record some ourselves.


I'll just use silent sounds so that i can ignore everyone and be that annoying piece of shit that doesnt react when someone talks to me.

like i said not making it toggleable is not good, imagine if you couldn't disable ship ambience, instruments, midis. It would be a fuck fest in my eardrums and i dont like it

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Cobby » Fri Feb 07, 2020 2:40 pm #540476

Cobby voice pack soon (tm)
Voted best trap in /tg/ 2014-current

Copybass
 
Joined: Thu Dec 01, 2016 6:37 pm
Location: Manitoba
Byond Username: Copybass

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Copybass » Fri Feb 07, 2020 3:17 pm #540485

skoglol wrote:You are welcome to read and comment on the PR as well, I wont bother repeating everything here.
https://github.com/tgstation/tgstation/pull/49042

Happy to read that Inflections are part of the current thoughts, it throws me off when I HMM? when I was meaning to HMM!!

I have a pro microphone but I have no knowledge of how to use it or my hmm voice properly.
Image

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby PKPenguin321 » Fri Feb 07, 2020 9:32 pm #540580

Copybass wrote:
skoglol wrote:You are welcome to read and comment on the PR as well, I wont bother repeating everything here.
https://github.com/tgstation/tgstation/pull/49042

Happy to read that Inflections are part of the current thoughts, it throws me off when I HMM? when I was meaning to HMM!!

I have a pro microphone but I have no knowledge of how to use it or my hmm voice properly.

if i had a better mic i'd do five real short sounds: "ah," "eh," "ee," "oh," and "ooh". easy enough that anyone can do it, short so perfect for talking sounds, sounds relatively natural as gibberishspeak because it's just vowels, can have its inflection changed to ? or ! very easily
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well
tell the best admin how good he is
Spoiler:
Image

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Fri Feb 07, 2020 9:49 pm #540587

In the interest of not bloating it too hard, inflection would have to be limited to already existing checks like we do for speech verb and span. So punctuation, whispering, that kinda thing. Worth looking into if there is interest in keeping this around, which there seems to be.

Ive mostly been hanging around event hall, and the hubbies seem to mostly enjoy it. Manuel wasnt quite as happy, but I think a lot stems from the choice of HMMM as the sound and that can be alleviated.

User avatar
RaveRadbury
In-Game Admin
 
Joined: Fri Mar 08, 2019 3:41 am
Byond Username: RaveRadbury
Github Username: RaveRadbury

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby RaveRadbury » Fri Feb 07, 2020 9:54 pm #540589

I found it to really add to immersion. I look forward to the full merge.
How's my administrating? Call 1-800-RADBURY
Image
Heart Emoji ~ Winter Ball Queen 2019

annoyinggreencatgirl
 
Joined: Mon Jan 28, 2019 7:55 pm
Byond Username: Uomo91

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby annoyinggreencatgirl » Sat Feb 08, 2020 12:09 am #540633

I think it's cool and improves the experience. Do wish it was more varied, like an adults talking in Charlie Brown kind of thing.
Don't Goon and VG do something along those lines?

User avatar
Arathian
 
Joined: Mon Apr 29, 2019 4:02 pm
Byond Username: Arathian

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Arathian » Sat Feb 08, 2020 12:47 am #540652

I really don't like it but I guess I can see how some would like it.

It doesn't have a direct gameplay effect (like footsteps do) so it should have a toggle option.
Iron, blood and spider armies

User avatar
CDranzer
 
Joined: Sun May 05, 2019 11:43 am
Byond Username: CDranzer

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby CDranzer » Sat Feb 08, 2020 1:27 am #540674

I heard somebody suggest they should make Don't Starve style instrument noises

User avatar
Dezupher
 
Joined: Tue Sep 17, 2019 11:08 am
Byond Username: Dezupher

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Dezupher » Sat Feb 08, 2020 2:42 am #540700

The last thing I want to hear when I scream "HELP MAINT" whilst I'm being murdered is an immersion breaking "hmm?".

If you're afraid almost everyone would turn off the speech sounds if you add a toggle, maybe the sounds shouldn't be added in the first place.

But if you add voice packs please add an animal crossing themed one I would love to play with that.

User avatar
Farquaar
 
Joined: Sat Apr 07, 2018 7:20 am
Location: Somewhere north of Hogtown
Byond Username: Farquaar

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Farquaar » Sat Feb 08, 2020 3:40 am #540729

CDranzer wrote:I heard somebody suggest they should make Don't Starve style instrument noises

Dezupher wrote:But if you add voice packs please add an animal crossing themed one I would love to play with that.

It’s not a bad idea. Just record a tone or sound that vaguely sounds like speech, and modulate the pitch of each successive “word” up or down randomly.

User avatar
Yenwodyah
 
Joined: Mon Jan 15, 2018 10:47 pm
Byond Username: Yenwodyah
Github Username: Yenwodyah

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Yenwodyah » Sat Feb 08, 2020 3:48 am #540732

CDranzer wrote:I heard somebody suggest they should make Don't Starve style instrument noises

Either this or the charlie brown adult noises

User avatar
cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby cacogen » Sat Feb 08, 2020 3:48 am #540733

don't mind the hmms like some people but i wish it was something more as it stands i don't really see the point especially when it isn't on every message
i like when you write hmm and your guy goes hmm and kind of wish common words/expressions had audio clips that triggered like that

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Cobby » Sun Feb 09, 2020 1:10 am #540947

all sounds have a gameplay aspect?

if I hear someone hmm I know someone is talking nearby.

if I hear footsteps I know someone is walking nearby.

If instruments could play preset arrangements and you couldn't have "bad" songs I would remove the pref for that too.
Voted best trap in /tg/ 2014-current

User avatar
Mickyan
Github User
 
Joined: Tue Oct 14, 2014 11:59 pm
Byond Username: Mickyan
Github Username: Mickyan

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Mickyan » Sun Feb 09, 2020 1:30 am #540953

Other than some of the inflections being distracting like already mentioned I don't mind these at all, the range and volume is low enough to not be an annoyance.
I think something you could consider making a preference is whether or not you get to hear your own character's chatter, if it's possible.

Only slightly related but while we're on the subject of making it easier to notice people talking I'd love if messages from nearby people (1-2 tiles) was bigger in size
ImageI play as Swanni, the brain-damaged moth.
Be nice to each other.

cybersaber101
 
Joined: Tue Nov 05, 2019 1:30 am
Location: Canada, eh?
Byond Username: Cybersaber101

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby cybersaber101 » Sun Feb 09, 2020 2:13 am #540958

I still dont see a reason to not have a toggle? if it bothers some people then let them opt in?

User avatar
deedubya
 
Joined: Wed Aug 15, 2018 2:05 am
Location: shitting up your thread
Byond Username: Deedubya

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby deedubya » Sun Feb 09, 2020 3:40 am #540967

Meanwhile at the HoP line:

Galatians 4:16 "Have I now become your enemy by telling you the truth?"

flattering compliments people have given me:
Spoiler:
oranges wrote:honestly holy shit deedubs you're a dent head

wesoda25 wrote:deedub is one of the people that makes me wish i could block users on forums

IkeTG wrote:every post from deedubya is worrying behavior

Super Aggro Crag wrote:you're a poo head!!!!!

TheMythicGhost wrote:You're a moron, but that's really nothing new since you're Deedubya, and really at this point I'm just playing an instrument by speaking since your head is so goddamn empty these words are resonating as they pass through.

Lazengann wrote:What's interesting about deedubya is the guy has no reading skills or comprehension and his ADHD is so severe he can't read through a single thread but he shows up to argue anyway

annoyinggreencatgirl wrote:you really are almost superhumanly retarded dude, holy smokes.

Image

User avatar
Anonmare
 
Joined: Sun Mar 15, 2015 8:59 pm
Location: Blighty
Byond Username: Anonmare

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby Anonmare » Sun Feb 09, 2020 1:49 pm #541036

I hate the AI talking noise. It sounds like a dog bark and it took me a while to realise it wasn't an admin playing the noise.
Image
Image
Image

User avatar
NecromancerAnne
In-Game Admin
 
Joined: Mon Sep 03, 2018 6:55 pm
Location: Don't touch me, motherfucker...
Byond Username: NecromancerAnne

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby NecromancerAnne » Sun Feb 09, 2020 3:03 pm #541078

It actually lets me know when people talk to me while I'm busy in another window or something. Kinda handy when distracted.

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Sun Feb 09, 2020 3:39 pm #541092

AI realizing how annoying it is when they speak. What can I say 8-)

Changed the title since this is not manuel exclusive. Its on EH as well.

User avatar
XivilaiAnaxes
 
Joined: Sat May 11, 2019 7:13 am
Byond Username: XivilaiAnaxes

Re: Manuel Testmerge #49042: 'Adds speech sounds'

Postby XivilaiAnaxes » Fri Feb 14, 2020 3:44 am #542478

skoglol wrote:AI realizing how annoying it is when they speak. What can I say 8-)

Changed the title since this is not manuel exclusive. Its on EH as well.


At the very least don't make the sentient machine god bark audibly every time it uses the radio - why doesnt it directly send the data across the radio transmitter anyway? What kind of machine design incorporates turning digital data analogue, sending it through the air into an adc to be sent via radio to yet another dac device for all the crew?

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Fri Feb 14, 2020 6:31 am #542490

Ask whoever put the intercoms around the AI core.

User avatar
Flatulent
 
Joined: Thu Nov 28, 2019 8:36 am
Location: Teaman Square, 1350
Byond Username: FlatulentIndustrialist

Re: Testmerge #49042: 'Adds speech sounds'

Postby Flatulent » Fri Feb 14, 2020 6:56 am #542494

the unending mmmmm sound makes me want to die but somehow i feel like it's intentional

honestly, add an option to mute all this bullshit in game preferences
bindy liberation front
imsxz wrote:I give up there’s too many furries

cacogen wrote:i asked oranges how often he plays and he deleted the post

User avatar
angelstarri
 
Joined: Sun Aug 26, 2018 4:03 am
Byond Username: Angelstarri

Re: Testmerge #49042: 'Adds speech sounds'

Postby angelstarri » Fri Feb 14, 2020 8:24 am #542504

add sounds from the sims please and thank you
Image
Code: Select all
I strongly suspected the borgs were one humaned by the Captain because of their increasingly strange behavior throughout the round after the Captain had entered their upload and seemingly changed the laws. I had asked twice if I could blow the borgs to no response (because there was no admin online apparently). They were constantly complimenting the Captain and calling her pretty and essentially threatening people who called the Captain ugly - Pepper Oni.

BadSS13Player
 
Joined: Fri Nov 15, 2019 5:03 pm
Byond Username: BadSS13Player

Re: Testmerge #49042: 'Adds speech sounds'

Postby BadSS13Player » Fri Feb 14, 2020 12:22 pm #542523

This is a cult nerf.

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: Testmerge #49042: 'Adds speech sounds'

Postby Cobby » Fri Feb 14, 2020 6:00 pm #542562

hearing the evil chants of cultists is emergent gameplay
Voted best trap in /tg/ 2014-current

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Fri Feb 14, 2020 6:11 pm #542566

It also cant be heard through walls or when you would otherwise not be able to hear what is being said, so how is it a cult nerf exactly? Stop being bad, BadSS13Player

User avatar
cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: Testmerge #49042: 'Adds speech sounds'

Postby cacogen » Sat Feb 15, 2020 6:59 am #542659

add common words

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: Testmerge #49042: 'Adds speech sounds'

Postby skoglol » Sat Feb 15, 2020 1:31 pm #542683

I'm away for a couple weeks, won't be done till I'm back. Untestmerged, I got the feedback I needed for now.

User avatar
Not-Dorsidarf
In-Game Admin
 
Joined: Fri Apr 18, 2014 4:14 pm
Location: Space outside the Brig
Byond Username: Dorsidwarf

Re: Testmerge #49042: 'Adds speech sounds'

Postby Not-Dorsidarf » Mon Feb 17, 2020 10:39 pm #543174

I dont like them but maybe some less sucky sounds could be found
Image
Still, my support will always go towards the rightful Lord of Yurop, God-Emperor Donald Trump the Trumpst. Trumpingrad for life. He'll make an indiscriminate number of countries great again.


Deadcomic

User avatar
Qustinnus
TGMC Maintainer
 
Joined: Tue Nov 07, 2017 12:30 am
Byond Username: Qustinnus

Re: Testmerge #49042: 'Adds speech sounds'

Postby Qustinnus » Tue Feb 18, 2020 5:06 pm #543329

I made some sounds for ethereals and I'm willing to make sounds for humans if someone has a good suggestion of a type of sound that's simple to make


Return to Coding Feedback

Who is online

Users browsing this forum: No registered users