Stock Market Removal

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.

Moderators: MisterPerson, Code Maintainers

User avatar
ohnopigeons
 
Joined: Thu Oct 16, 2014 11:22 pm
Byond Username: Ohnopigeons
Github Username: ohnopigeons

Stock Market Removal

Postby ohnopigeons » Tue Apr 24, 2018 3:52 pm #402636

https://github.com/tgstation/tgstation/pull/37414

Feedback from Cargo mains please.
Image



User avatar
SpaceInaba
 
Joined: Wed Sep 21, 2016 1:03 pm
Location: everyone's favorite sjw
Byond Username: SpaceInaba

Re: Stock Market Removal

Postby SpaceInaba » Tue Apr 24, 2018 3:53 pm #402637

I'm really bad at stocks so nothing really changes for me
Spoiler:
ImageImageImage
fuck,

User avatar
Armhulen
In-Game Game Master
 
Joined: Thu Apr 28, 2016 4:30 pm
Byond Username: Armhulenn
Github Username: it's a long story

Re: Stock Market Removal

Postby Armhulen » Tue Apr 24, 2018 3:54 pm #402638

yeah this is a good revert
Go to bed bro, she's not thinking about you.

User avatar
D&B
 
Joined: Mon Jun 13, 2016 2:23 am
Location: *teleports behind you*
Byond Username: Repukan

Re: Stock Market Removal

Postby D&B » Tue Apr 24, 2018 3:57 pm #402641

Stocks are spooks
Spoiler:
[20:26:02]ADMIN: PM: [censored admin]->[censored]: Welp. It was just a prank bro isn't a very good excuse when it comes to unprovoked nonantag murder, but since this is your first time doing it and you seem to understand the problem instead of a bannu I'm just going to leave you with a warning. Please PLEASE don't do this again in the future, as funny as crackhead broken bottle memes can be. Alrighty? Do you have any input on this?
[20:26:39]ADMIN: PM: [censored]->[censored admin]: Alright, no problem. I have some input. Fuck my boy pussy.
[20:27:06]ADMIN: PM: [censored admin]->[censored]: Okay then. Have fun.
[20:31:29]ADMIN: PM: [censored admin]->[censored]: Excuse me?

J_Madison wrote:that's a stupid fucking stat
you don't play, you've never played
lying little shit with your bullshit stat
fuck you

ColonicAcid wrote:and with enough practise i too could blow my own dick so well that only the gods know how it feels.

somerandomguy
 
Joined: Sun Nov 05, 2017 7:41 pm
Byond Username: Astatineguy12

Re: Stock Market Removal

Postby somerandomguy » Tue Apr 24, 2018 4:00 pm #402644

>removes it now
>"don't worry there's a replacement but don't expect it soon"

User avatar
ohnopigeons
 
Joined: Thu Oct 16, 2014 11:22 pm
Byond Username: Ohnopigeons
Github Username: ohnopigeons

Re: Stock Market Removal

Postby ohnopigeons » Tue Apr 24, 2018 4:08 pm #402656

I'm not telling you to not worry, but it's true that the existence of the cargo stock market is impeding new (and probably better) cargo features, from either me or anyone else.
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: Stock Market Removal

Postby iamgoofball » Tue Apr 24, 2018 5:07 pm #402740

ohnopigeons wrote:I'm not telling you to not worry, but it's true that the existence of the cargo stock market is impeding new (and probably better) cargo features, from either me or anyone else.

Stop lying lmao

A proper fix got made

User avatar
ohnopigeons
 
Joined: Thu Oct 16, 2014 11:22 pm
Byond Username: Ohnopigeons
Github Username: ohnopigeons

Re: Stock Market Removal

Postby ohnopigeons » Tue Apr 24, 2018 5:12 pm #402751

If it does what I think it does I'll enjoy seeing the results. If it actually fixes the problem, well, you get to tell me you told me so and that would feel pretty good for you.
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: Stock Market Removal

Postby iamgoofball » Tue Apr 24, 2018 5:38 pm #402784

honestly as long as null crate spam gets killed I'm happy

Going to totally kill that plasma shit though

User avatar
SpaceInaba
 
Joined: Wed Sep 21, 2016 1:03 pm
Location: everyone's favorite sjw
Byond Username: SpaceInaba

Re: Stock Market Removal

Postby SpaceInaba » Tue Apr 24, 2018 6:17 pm #402858

and he huffed and he puffed and he spammed prs based on false stats
Spoiler:
ImageImageImage
fuck,

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: Stock Market Removal

Postby ShadowDimentio » Tue Apr 24, 2018 6:24 pm #402874

Stocks are gay, they barely make you any money except when they bug out. I'd have rather had just the point regen, at least then you don't have to worry about leaving cargo for five minutes and finding out you lost all the money you would have made because the company you invested in crashed when you come back.
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

"I prefer my coffees to run dry too *snorts a line of maxwell house*"
-Super Aggro Crag

"You don't have an evil bone in your body, unless togopal comes for a sleepover"
-Bluespace

">Paying over a $1000 for a lump of silicon and plastic
Lol"
-Anonmare

"Then why did you get that boob job?"
-DrPillzRedux

"You take that back you colonial mongrel"
-Docprofsmith

"I don't care whether or not someone with an IQ 3 standard deviations below my own thinks they enjoy Wizard rounds."
-Malkraz

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: Stock Market Removal

Postby iamgoofball » Tue Apr 24, 2018 6:30 pm #402884

That's your fault for not keeping tabs on your investments.

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: Stock Market Removal

Postby ShadowDimentio » Tue Apr 24, 2018 7:05 pm #402954

I do, but when you get delimbed by a traitor or something and have to go to medbay you can't bring the computer with you.
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

"I prefer my coffees to run dry too *snorts a line of maxwell house*"
-Super Aggro Crag

"You don't have an evil bone in your body, unless togopal comes for a sleepover"
-Bluespace

">Paying over a $1000 for a lump of silicon and plastic
Lol"
-Anonmare

"Then why did you get that boob job?"
-DrPillzRedux

"You take that back you colonial mongrel"
-Docprofsmith

"I don't care whether or not someone with an IQ 3 standard deviations below my own thinks they enjoy Wizard rounds."
-Malkraz

User avatar
Aloraydrel
 
Joined: Thu Mar 19, 2015 4:14 pm
Byond Username: Aloraydrel
Github Username: Aloraydrel

Re: Stock Market Removal

Postby Aloraydrel » Tue Apr 24, 2018 7:57 pm #403034

Don't die then lol

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: Stock Market Removal

Postby iamgoofball » Tue Apr 24, 2018 8:17 pm #403051

Aloraydrel wrote:Don't die then lol

Dr_bee
 
Joined: Fri Dec 23, 2016 6:31 pm
Byond Username: DrBee

Re: Stock Market Removal

Postby Dr_bee » Tue Apr 24, 2018 8:20 pm #403058

Goofballs hate-boner for probably the only thing marginally interesting about an entire department is troubling to say the least.

Seriously, someone check up on him, is he doing ok? I dont like null crates very much either but this goes beyond normal. There are much more important shit that is unbalanced that could be worked on. That and cargo needs stuff to actually DO besides wait for mining and ordering the rare crate for another department.

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: Stock Market Removal

Postby ShadowDimentio » Tue Apr 24, 2018 11:29 pm #403241

Aloraydrel wrote:Don't die then lol


I said delimbed not killed stupid dumb wizard
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

"I prefer my coffees to run dry too *snorts a line of maxwell house*"
-Super Aggro Crag

"You don't have an evil bone in your body, unless togopal comes for a sleepover"
-Bluespace

">Paying over a $1000 for a lump of silicon and plastic
Lol"
-Anonmare

"Then why did you get that boob job?"
-DrPillzRedux

"You take that back you colonial mongrel"
-Docprofsmith

"I don't care whether or not someone with an IQ 3 standard deviations below my own thinks they enjoy Wizard rounds."
-Malkraz

User avatar
Aloraydrel
 
Joined: Thu Mar 19, 2015 4:14 pm
Byond Username: Aloraydrel
Github Username: Aloraydrel

Re: Stock Market Removal

Postby Aloraydrel » Wed Apr 25, 2018 12:12 pm #403409

Then you shouldn't have a problem running back to check your stocks nerd

User avatar
ohnopigeons
 
Joined: Thu Oct 16, 2014 11:22 pm
Byond Username: Ohnopigeons
Github Username: ohnopigeons

Re: Stock Market Removal

Postby ohnopigeons » Mon Apr 30, 2018 12:54 am #405313

And we're back.
Image

User avatar
Luke Cox
 
Joined: Sat Dec 06, 2014 8:52 am
Location: Prisoner Transfer Room
Byond Username: NocturnalQuill

Re: Stock Market Removal

Postby Luke Cox » Mon Apr 30, 2018 1:21 am #405320

If stocks are so awful, have you considered not doing them?
Image

User avatar
Iatots
 
Joined: Thu Oct 13, 2016 3:17 pm
Byond Username: Iatots
Github Username: Iatots

Re: Stock Market Removal

Postby Iatots » Mon Apr 30, 2018 12:20 pm #405393

We need a Moneyland where cargo techs can slay piggie banks and run Fat Bull's gambling gauntlet for that sweet native casino money.


Return to Coding Feedback

Who is online

Users browsing this forum: No registered users