Repeat github prs annoy me to no end.

[Shadowflame909]

I don't even know where to post this but, I want a conversation on this. So on the github I'm noticing that as soon as a pr gets denied
Not even a day later another pr gets made that effectively does something similar to what the original pr got denied for but re-worded or in a different way. Why is this allowed? If this isn't the right place for this forum mods please move it!

[ohnopigeons]

You seem to be talking about my PR so let's talk. Fox's mistake was bundling two distinct and separate changes into one PR. Arguments were made indicating that some people supported one change but not the other. So I made a PR about that one particular change, with a minor tweak of my own that I believe to be an improvement.

[Shadowflame909]

I'm talking in general since a day before Fox's pr goof was doing the same with cargo. If the verdict of the denial pr applied to all of it. What makes it alright to remove one thing from a denied pr and try to get that merged. I feel like if a pr gets denied and a day later another pr does something similar to the pr that got denied, it shouldn't even be given the light of day for trying to continue controversy from the previous PR. It's like if someone made a pr removing watermelon from the game because it offended them. It got denied, so they make another pr removing watermelon seeds from botany, make you forced to buy it from cargo and make the price 30k credits. "It's a different enough pr" shouldn't be an argument because it's accomplishing the same goal. That's wrong to me. If you do this that's wrong.

[XDTM]

On the other hand, just because a change was bundled in a PR with a bad change it does not mean it was itself bad. Plus you can try to half-remove things as you described as a middle way, which works in some cases (e.g. cherry bombs not being growable from cherries but available in xenobio if you're dedicated enough).

[onleavedontatme]

Different people are trying different solutions to a problem they perceive.

[Shadowflame909]

It seems like people are trying to keep PRing things until they get what they want merged in some form. That sounds completely against denying a pr. For it to be made over and over until they get what they want...

[Armhulen]

Denying the pr doesn't deny the idea of something, it's denying the way someone is doing it. It's understandable for other people who liked something from that denied pr to take a crack at the idea with a different angle and multiple people trying the idea leads to the best one picked for the maintainer, so it's actually pretty good.

[Shadowflame909]

I never thought about it like that, I'm still salty about a new nerf pr everytime I have hope that something won't get nerfed. Sad!

[oranges]

rest assured that we're not so silly as to fall for obvious examples