Page 1 of 1

Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 8:29 am
by Lumbermancer
It's fucking shit. Either remove this, give me option to disable it, or limit it to OOC.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 1:02 pm
by BeeSting12
If youre talkinf about admins doing it make a complaint if it's disruptive.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 2:08 pm
by Ayy Lemoh
BeeSting12 wrote:If youre talkinf about admins doing it make a complaint if it's disruptive.
Even if an admin has done it only once, it would still be nice to disable it. I don't even care when it happens, as it's kinda rare anyways, yet I can see why people want this.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 2:19 pm
by Lumbermancer
Correct. I don't want to be playing, and have anime pictures popping up in my chat box. I already have admin midis disabled. Muh immersions and shit.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 3:29 pm
by Shadowflame909
>Admins post that image of that duck vomiting into the chat.

CUT MY IMMERSION INTO PIECES THIS IS MY LAST RESORT

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 5:17 pm
by Dax Dupont
There's no way to disable it without filtering for specific html tags which would be annoying.

I don't even think it's actually easily done, stripping of html elements in general is done when the input is given, not when its sent to clients.

Also html elements have other uses like spans and what not to format text.

Ideally admins shouldn't send pictures. Especially NOT when the game is going on.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 7:40 pm
by kevinz000
admin issue not code issue tbh

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 7:43 pm
by Shadowflame909
how do i ban admins for this admin issue. THAT CURRENTLY HAS NO SOLUTION REEE

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 8:39 pm
by Atlanta-Ned
Give us round IDs and we can look it up.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 8:52 pm
by Lumbermancer
kevinz000 wrote:admin issue not code issue tbh
Atlanta-Ned wrote:Give us round IDs and we can look it up.
Not admin feedback, code feedback about bad feature (?).
Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.
What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 9:03 pm
by somerandomguy
Lumbermancer wrote:
kevinz000 wrote:admin issue not code issue tbh
Atlanta-Ned wrote:Give us round IDs and we can look it up.
Not admin feedback, code feedback about bad feature (?).
Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.
What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?
It is an admin issue, global narrate (I *think* that's the verb they're using) isn't sanitized (intentionally, even though there really aren't many legitimate non-debug uses) and they're using it to send pictures in chat during the round.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 9:17 pm
by Lumbermancer
Well my complaint is not about them posting pictures into chat, but rather that such thing is even possible.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Thu Jul 12, 2018 10:20 pm
by Cobby
I’m posting pictures into your chat next time

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 1:48 am
by oranges
Admin issue, and also funny :^)

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 2:12 am
by bandit
Someone should definitely post the code for this so all admins can study it to know what to look for.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 2:13 am
by kevinz000
if an admin is being obnoxious/spammy complaint it
don't get it taken from all of us
narrating unsanitized html is a nifty thing, and should be possible.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 7:38 am
by Lumbermancer
kevinz000 wrote:narrating unsanitized html is a nifty thing, and should be possible.
Answer my question then. If we agree that doing so during round is bad, then what is the point, if admins can already post pictures into the game screen between rounds. They can also rotate them, put game sprites in, and do other stuff. Unless you want unsanitized html to be used for other purpose than posting images, like malware, bitcoin miners etc. I don't see the point. But I digress.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 11:36 am
by Grazyn
I read this thread this morning, logged in and guess what, not even 5 minutes later BAM, puking duck pic

wtf end this please, it's not rare at all

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 11:41 am
by Shadowflame909
we gotta ban puking duck pics once and for all and also that weeb junk. you may invade my midis but not my chat ok

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 12:54 pm
by Ayy Lemoh
Grazyn wrote:I read this thread this morning, logged in and guess what, not even 5 minutes later BAM, puking duck pic

wtf end this please, it's not rare at all
it's probably less rare because of this thread now tbh.

Not saying that to be rude to admins, though.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 1:31 pm
by Shadowflame909
if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Fri Jul 13, 2018 2:42 pm
by Bluespace
can't wait for an angrey admeen to give me a bitcoin miner and burn down my house

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 11:41 am
by Dax Dupont
Lumbermancer wrote:
Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.
What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?
It's been a thing forever it's just not often used.

Global narrate has never "stripped" the input of admins.

The whole concept of global narrate requires html tags to remain. It's how you manipulate text or other elements.

img is just another html tag

In theory yes admins can inject bad code like a bitcoin miner that will stick till you close the window.

They can't really give you drive by viruses or anything though.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 3:26 pm
by Shadowflame909
Bluespace wrote:can't wait for an angrey admeen to give me a bitcoin miner and burn down my house
tfw admins wanna mine that bitcoin and discreetly make playing ss13 give them money. At the cost of ruining all of there players gpus, thus killing the server because no one will have a computer.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 5:00 pm
by MrStonedOne
The way the engine is designed, admins can do anything, they can call internal functions, edit the variables on objects, and send messages directly to clients, even if we took the latter away, they can still directly call the internal function that sends messages to clients, even if we took that away, they can call functions that call functions that send messages to clients, and if we took the whole chain away, and made it so no admin initiated call to an internal function could result in a message going out to clients then even internal game messages don't go out from such calls. and admins can still edit variables on objects that those objects use to send messages to clients, so again, the problem isn't solved. Hell even now, admins can bypass the admin sound preference by directly calling the internal function that handles sending sounds to clients.

And the reality is the primary reason admins can create some of the unique events they create is because the code is designed to give them such an open ended control to fuck with the world and the world state. In fact that applies to this game in general, the most magical moments in this game is when players combine features in new ways that were never directly planned for or designed for by the programmers, the same applies to admin tools and events.

That being said, images can be hidden by css selectors and we could easily conditionally load one into the style sheet and put a span around global narrate so we can be selective with it. Admins could still bypass it, but it would handle the common way they do that and we can handle intentionally bypassing it the way we do with the sound preference.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 5:04 pm
by ShadowDimentio
>The most magical events are when players combine features

Yeah until it's removed the next round by a buttmad coder. NO FUN ALLOWED

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 5:05 pm
by MrStonedOne
I thought the balance rat race was part of the fun?

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 6:05 pm
by ShadowDimentio
It would be if the coders didn't consider fun a bug that needed to be fixed

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sat Jul 14, 2018 8:01 pm
by Cobby
bandit wrote:Someone should definitely post the code for this so all admins can study it to know what to look for.
You global narrate <img src="url"> (it might be single quotes i forget, try both :^] )

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sun Jul 15, 2018 4:28 am
by MrStonedOne
the fun one is <img src="https://tgstation13.org/gamebanner.php?server=terry"> only because everybody will see a different name on the banner

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sun Jul 15, 2018 5:31 am
by subject217
Shadowflame909 wrote:if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS
Excuse me sir, it's called goose vomit. And it's a time honored tradition.

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sun Jul 15, 2018 5:46 am
by Shadowflame909
subject217 wrote:
Shadowflame909 wrote:if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS
Excuse me sir, it's called goose vomit. And it's a time honored tradition.
dON'T DO IT

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sun Jul 15, 2018 8:57 am
by oranges
Image

Re: Pasting images and gifs and other nonsense into the chat.

Posted: Sun Jul 15, 2018 9:16 am
by Grazyn
DUCK YOU