combat mode feedback

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.

Moderators: MisterPerson, Code Maintainers

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sat Feb 06, 2021 3:47 am #589622

BrianBackslide wrote:You have to shift+right click to open additional options for your inventory. (Turning on suit sensors and using the seed extractor, for example)


These should be bound to right click, full stop, if they're so important.

I asked someone to make right clicking on a jumpsuit open the suit sensors menu without having to traverse through any menus. If they don't do it soon I will. Feel free to do this with the seed extractor too if it has some verb I'm not aware of.
Mothblocks on Bagil - Say nice things about me



User avatar
Capsandi
 
Joined: Sat Jan 26, 2019 10:59 pm
Byond Username: Capsandi

Re: combat mode feedback

Postby Capsandi » Sat Feb 06, 2021 3:37 pm #589642

Lovin this, I'm sure I'll get used to the new examine controls, great job, my ONLY ISSUE is that 'combat mode' sounds so fucking stupid, can we just change it back to harm intent? I know nobody is forcing anyone to say combat mode, but when trying to move around in a cramped space, and someone says "Get out of combat mode, god dammit!" all I can think of are robotic crewmen turning their hands into knives and guns. If 'intent' is a term we are trying to move away from, perhaps "Harm inclination" could be a possible replacement?

User avatar
Qustinnus
TGMC Maintainer
 
Joined: Tue Nov 07, 2017 12:30 am
Byond Username: Qustinnus

Re: combat mode feedback

Postby Qustinnus » Sat Feb 06, 2021 4:03 pm #589643

the main reasons is that citadel already had a ton of icons for combat mode which I could use (we have a lot of UI styles)

User avatar
Boris
In-Game Admin
 
Joined: Wed Mar 14, 2018 10:21 pm
Location: Soon to be Atlantis
Byond Username: Borisvanmemes

Re: combat mode feedback

Postby Boris » Sat Feb 06, 2021 4:46 pm #589646

Getting used to this is going to be hell, I fully believe that it'll be good long term though.
The nerd that plays Tam and Amanda Lin

Call me a bad admin here.

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Sat Feb 06, 2021 5:20 pm #589652

Just add a normal right-click menu instead of disarm when combat mode is off and see the problems people are having with it disappear
technokek wrote:Cannot prove this so just belive me if when say this

User avatar
Yenwodyah
 
Joined: Mon Jan 15, 2018 10:47 pm
Byond Username: Yenwodyah
Github Username: Yenwodyah

Re: combat mode feedback

Postby Yenwodyah » Sat Feb 06, 2021 7:39 pm #589659

Probably not any worse than intents, but not any better, either.

Edit: Except for batons, those need to be switched back to normal ASAP
Image

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sat Feb 06, 2021 9:06 pm #589670

cacogen wrote:Just add a normal right-click menu instead of disarm when combat mode is off and see the problems people are having with it disappear


no. we're already binding things to right click when combat mode is off. this is non negotiable.
Mothblocks on Bagil - Say nice things about me

PostThis post was deleted by Armhulen on Sat Feb 06, 2021 9:33 pm.
Reason: user was banned for this post

User avatar
hiynastrike
 
Joined: Tue Jul 09, 2019 2:21 am
Location: Post-Void War New York
Byond Username: Hiynastrike

Re: combat mode feedback

Postby hiynastrike » Sat Feb 06, 2021 10:12 pm #589675

What if.... Examine mode? Like you have a litte magnifying glass button next to the combat toggle. Turn it on to get examine right clicks, turn it off to beat people or whatever people do with right click without the intention of examining it

Edit: What if you could have little buttons that set what your right click does? Like sure you could still use Crtl-Click or Shift-Click to grab and examine, but like toggle buttons that set right click to do a specific action

MOCKUP:
Image
I've come up with 4 actions you can specify Right click to:

EXAMINE: Opens the drop down menu for additional options
GRAB: Grab and pull what you click
ROB: When done to other players, opens their inventory
THROW: Hurls whatever is in the player's hand at where you click
Spoiler:
Image


I do pixel drawings of crewmembers. You can see them all to date here: viewtopic.php?f=2&t=27326

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sat Feb 06, 2021 10:46 pm #589684

hiynastrike wrote:What if.... Examine mode? Like you have a litte magnifying glass button next to the combat toggle. Turn it on to get examine right clicks, turn it off to beat people or whatever people do with right click without the intention of examining it

Edit: What if you could have little buttons that set what your right click does? Like sure you could still use Crtl-Click or Shift-Click to grab and examine, but like toggle buttons that set right click to do a specific action

MOCKUP:
Image
I've come up with 4 actions you can specify Right click to:

EXAMINE: Opens the drop down menu for additional options
GRAB: Grab and pull what you click
ROB: When done to other players, opens their inventory
THROW: Hurls whatever is in the player's hand at where you click


cute picture and you know i like you but this is problematic for ux, like i said a big part of combat mode is that we can finally bind right click to things now. we're using this not just for combat related stuff, but we're rolling it out to much more just "alternate actions" for things that used to be on alt click or just nowhere because theyre tile based for instance. by adding any extra difficulty to this, we lose massively because now our right click functionality is not as intuitive as it could be, and we end up going back to the modal-like system that we wanted to avoid with combat mode
Mothblocks on Bagil - Say nice things about me

User avatar
Horza
 
Joined: Fri Jan 11, 2019 9:43 pm
Byond Username: HorzBor

Re: combat mode feedback

Postby Horza » Sat Feb 06, 2021 10:48 pm #589685

hiynastrike wrote:whatever the fuck

This is either excellent satire or an absolutely flat-faced rebranding of the help-shove-grab-hurt system and I love it.
Spürdo spädre sbrölölö :DDDDD

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Sat Feb 06, 2021 10:53 pm #589687

Jaredfogle wrote:
cacogen wrote:Just add a normal right-click menu instead of disarm when combat mode is off and see the problems people are having with it disappear


no. we're already binding things to right click when combat mode is off. this is non negotiable.

Can't it just open the context menu if there's no right-click function though?
technokek wrote:Cannot prove this so just belive me if when say this

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sat Feb 06, 2021 11:37 pm #589695

cacogen wrote:
Jaredfogle wrote:
cacogen wrote:Just add a normal right-click menu instead of disarm when combat mode is off and see the problems people are having with it disappear


no. we're already binding things to right click when combat mode is off. this is non negotiable.

Can't it just open the context menu if there's no right-click function though?


I'm not sacrificing consistency for the sake of some people who can't get used to shift+right-click.
Mothblocks on Bagil - Say nice things about me

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sat Feb 06, 2021 11:38 pm #589696

The answer is no on a technical level too, anyway. BYOND gives us extremely little control over the right click menu. We won't know if an item should show the context menu until it's too late.
Mothblocks on Bagil - Say nice things about me

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Sun Feb 07, 2021 3:34 am #589727

It's not sacrificing consistency if both are possible it's maintaining the old method for people who don't know about the new one or haven't gotten used to it yet and accidentally do the old one from time to time but good to know it's impossible anyway now I can stop arguing about it thank you
technokek wrote:Cannot prove this so just belive me if when say this

BadSS13Player
 
Joined: Fri Nov 15, 2019 5:03 pm
Byond Username: BadSS13Player

Re: combat mode feedback

Postby BadSS13Player » Sun Feb 07, 2021 11:26 am #589754

Jaredfogle wrote:and we end up going back to the modal-like system that we wanted to avoid with combat mode


Combat mode is already a modal system, just worse because it only has 2 modes.

Jaredfogle wrote:I'm not sacrificing consistency for the sake of some people who can't get used to shift+right-click.


It's not about getting used to it, it's permanently worse than just right click. You use the context menu a lot more than you use shove, except when you're in combat, where you use shove a lot more than you use the context menu. Having it modal is just better UI.

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sun Feb 07, 2021 11:38 am #589755

BadSS13Player wrote:Combat mode is already a modal system, just worse because it only has 2 modes.


In case you weren't aware, four is a bigger number than two. There were four intents (help, harm, disarm, grab).

Jaredfogle wrote:It's not about getting used to it, it's permanently worse than just right click. You use the context menu a lot more than you use shove, except when you're in combat, where you use shove a lot more than you use the context menu. Having it modal is just better UI.


You are under the assumption right click will only be shoving. You will come to realize very shortly this is not the case, as we roll out more and more to right click.
Mothblocks on Bagil - Say nice things about me

BadSS13Player
 
Joined: Fri Nov 15, 2019 5:03 pm
Byond Username: BadSS13Player

Re: combat mode feedback

Postby BadSS13Player » Sun Feb 07, 2021 1:39 pm #589760

Jaredfogle wrote:In case you weren't aware, four is a bigger number than two. There were four intents (help, harm, disarm, grab).


Yes, that's why I said two is worse.

Jaredfogle wrote:You are under the assumption right click will only be shoving. You will come to realize very shortly this is not the case, as we roll out more and more to right click.


The uses of right click so far all seem to be niche usages like wrenching tables or related to combat like the proposed gun secondary fires. The earlier

User avatar
NecromancerAnne
 
Joined: Mon Sep 03, 2018 6:55 pm
Location: Don't touch me, motherfucker...
Byond Username: NecromancerAnne

Re: combat mode feedback

Postby NecromancerAnne » Mon Feb 08, 2021 3:22 am #589812

Is there supposed to be a sound when combat mode is acrivated, by the by? Since it's borrowing from previous iterations, I know those used a sound. Helps with working out if you toggled or not.

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Feb 08, 2021 3:29 am #589814

NecromancerAnne wrote:Is there supposed to be a sound when combat mode is acrivated, by the by? Since it's borrowing from previous iterations, I know those used a sound. Helps with working out if you toggled or not.


theres an option for it but floyd fucked up and so its only on by default for new players. go in your ooc preferences
Mothblocks on Bagil - Say nice things about me

User avatar
NecromancerAnne
 
Joined: Mon Sep 03, 2018 6:55 pm
Location: Don't touch me, motherfucker...
Byond Username: NecromancerAnne

Re: combat mode feedback

Postby NecromancerAnne » Mon Feb 08, 2021 3:46 am #589816

Ah cool beans.

User avatar
Sniffs-The-Glue
 
Joined: Fri Feb 05, 2021 4:39 pm
Byond Username: Cuttlefish

Re: combat mode feedback

Postby Sniffs-The-Glue » Mon Feb 08, 2021 3:45 pm #589862

Since combat mode is staying around, can the icon be a bit more obvious as to which state its in? Currently there's only the little border that shows if you are in or out of combat mode vs the bright green/red that help and harm would be. Basically it would look similar to what the borgs have if anything/placeholder.
I'll be black

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Feb 08, 2021 4:15 pm #589864

i agree, i wanted a subtle vignette around your screen.
Mothblocks on Bagil - Say nice things about me

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Mon Feb 08, 2021 4:52 pm #589870

add depth of field and camera shake to simulate adrenaline
technokek wrote:Cannot prove this so just belive me if when say this

Papastink
 
Joined: Thu Sep 17, 2020 12:52 pm
Byond Username: Thebiggestidiot

Re: combat mode feedback

Postby Papastink » Sat Feb 13, 2021 1:22 am #590395

It's going to take a while for me to get used to and has some bug but otherwise, it not great but not bad either. My only major problems are the weird flipping the sprites do in combat and the fact that the commands for when you bring up the list of items in a stack don't work.

User avatar
TheFinalPotato
Code Maintainer
 
Joined: Sun Oct 13, 2019 7:58 am
Byond Username: LemonInTheDark

Re: combat mode feedback

Postby TheFinalPotato » Sat Feb 13, 2021 2:51 am #590402

Papastink wrote:It's going to take a while for me to get used to and has some bug but otherwise, it not great but not bad either. My only major problems are the weird flipping the sprites do in combat and the fact that the commands for when you bring up the list of items in a stack don't work.

Not sure what you mean by weird flipping, but that second issue with the right click context menu should be fixed, if it comes up again shoot an issue report up onto the github so we can deal with it
Image

Papastink
 
Joined: Thu Sep 17, 2020 12:52 pm
Byond Username: Thebiggestidiot

Re: combat mode feedback

Postby Papastink » Sat Feb 13, 2021 2:36 pm #590445

TheFinalPotato wrote: Not sure what you mean by weird flipping, but that second issue with the right click context menu should be fixed, if it comes up again shoot an issue report up onto the github so we can deal with it


Whenever I hit someone or something in combat mode or use a melee weapon my sprite appears five tiles away upsidedown but my hitbox is in the same place. The same thing happens whenever a monkey or player hits me.

User avatar
wesoda25
In-Game Admin
 
Joined: Thu Aug 10, 2017 9:32 pm
Byond Username: Wesoda25

Re: combat mode feedback

Postby wesoda25 » Sat Feb 13, 2021 5:02 pm #590454

That’s a known bug and existed before combat mode. https://github.com/tgstation/tgstation/issues/55842

PostThis post was deleted by Papastink on Sat Feb 13, 2021 5:31 pm.
Reason: I didn't see the other message

User avatar
Qbmax32
In-Game Admin
 
Joined: Sun Feb 19, 2017 4:05 am
Location: somewhere
Byond Username: Qbmax32
Github Username: qbmax32

Re: combat mode feedback

Postby Qbmax32 » Sat Feb 13, 2021 7:55 pm #590469

why does it make the lifeweb noise when you press 4
my admin feedback thread


quotes
Spoiler:
Malkraz wrote:YES
DRINK THE PISS QB


angelstarri wrote:qbmax is a retard


imsxz wrote:mythic please stop you’ve hit rock bottom and you KEEP DIGGING


deedubya wrote:I'll defend to the death your right to scream "NIGGER NIGGER NIGGER" on a constant basis, but I'll also equally defend the right of people to call you a fuckin' pillock for doing it.

datorangebottle wrote:what, not having to act like customer service in a volunteer customer service position?

Here's a rebuttal: you're literally in a customer service slash celebrity position. Volunteer or not.

Malkraz wrote:can you stop posting this shit

Nalzul wrote:Fuck Blob (can you imagine how hot it would be to be gangbanged by a bunch of blobbernauts, the blob, and spores)

Wyzack wrote:qbmax your pathetic display of abhorrent burgercraft has brought shame onto the omnivores

Plapatin wrote:i AM the senate

BONERMASTER wrote:I am a big thinker, and it would only be logical if my character had a big head as well. And glasses. Because only people that think, wear glasses.

feem wrote:i tried to send canisters of urine to the station but ended up turning all oxygen into urine and breaking lavaland and also breathing

Anonmare wrote:Each post in this thread can't settle on what it wants to be, but yet, each one is more cursed than the last.

Beesting12 wrote:please write an apology to this forums, this community, the host, and the internet as a whole for the data storage space you wasted with this complaint.

Vile Beggar wrote:i don't like this thread

imsxz wrote:nervore

FantasticFwoosh wrote:I will whisper sweet nothings that will confuse and perhaps scare you a little, but enhance the experience no-less.

afelinidisfinetoo wrote:By the way, the person who posted that catgirl porn on the github page was me. If anyone wants my private stash just PM me

Nervere wrote:Anything for a femoid.....

Qbopper wrote:I'm a dumb poopy butthead

CitrusGender wrote:god i love it when people feed me my own fried legs

User avatar
Qustinnus
TGMC Maintainer
 
Joined: Tue Nov 07, 2017 12:30 am
Byond Username: Qustinnus

Re: combat mode feedback

Postby Qustinnus » Sun Feb 14, 2021 11:14 pm #590637

i stole it from citadel who credited interbay not realizing lifeweb also uses it, and when I asked them they said lifeweb also got it from another source so dunno.

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Sun Feb 14, 2021 11:33 pm #590639

its a sound i did with my mouth in a call with randy, and i expect royalties
Mothblocks on Bagil - Say nice things about me

User avatar
Mickyan
Github User
 
Joined: Tue Oct 14, 2014 11:59 pm
Byond Username: Mickyan
Github Username: Mickyan

Re: combat mode feedback

Postby Mickyan » Mon Feb 15, 2021 2:52 am #590658

It's super inconsistent between HUD themes but for several of them the buttons to toggle combat mode on/off look nearly identical at a glance and it's hard to tell whether it's enabled or not
ImageI play on Manuel as Swanni, the brain-damaged moth.
Be nice to each other.

User avatar
Qustinnus
TGMC Maintainer
 
Joined: Tue Nov 07, 2017 12:30 am
Byond Username: Qustinnus

Re: combat mode feedback

Postby Qustinnus » Mon Feb 15, 2021 10:26 am #590728

whoever thought of the idea of adding 9 different UI styles can go fck himself tbf. it's made any UI improvements ass to do

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Mon Feb 15, 2021 7:35 pm #590767

You could just remove all but like 2 or 3 either based on a poll or just whichever you think look best
technokek wrote:Cannot prove this so just belive me if when say this

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Feb 15, 2021 8:34 pm #590781

im still confused on why we can't make those dynamic
Mothblocks on Bagil - Say nice things about me

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: combat mode feedback

Postby cacogen » Mon Feb 15, 2021 9:34 pm #590792

I know I'm not particularly attached to the amount of choice because the option is in Preferences amidst a tonne of other things and you can't preview them so I picked one based on the name and completely forgot about it. If it was a dropdown at the top and you could change them on the fly (maybe this is already possible) then maybe I'd care more about the prospect of losing some of them. I seem to remember they're all ugly and it's filled with retro ones that look worse though.
technokek wrote:Cannot prove this so just belive me if when say this

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Feb 15, 2021 10:52 pm #590801

iirc our ui settings are:

- the default, and color variations on the default. internally, these are all separate sprite sheets which is a massive headache. ideally, this should be dynamic.
- glass, which IS dynamic. excellent work. if possible i'd like to see glass and the default merged in terms of effort needed to add a new ui element. i'm not sure how hard this is to do, as i haven't taken an extensive look at the dmi's myself, but ideally ui icons would be on their own, and uis distribute different frames
- retro, which i'd like to run an extensive analysis on to see how many people have. ideally i'd like to get rid of it, since it adds unnecessary work to ui designers, and our ui sucks so bad that i don't want anything to come in the way between an artist and the implementation
Mothblocks on Bagil - Say nice things about me

User avatar
Mitometeta
 
Joined: Mon Mar 01, 2021 12:01 am
Byond Username: GreenishBeanish

Re: combat mode feedback

Postby Mitometeta » Mon Mar 01, 2021 12:13 am #593948

encountered a bug on a tg based server where switching between hotkey and classic mode sometimes made right click bring up verbs instead like it used to and sometimes do its intended functions post-intent removal, dunno if this happened elsewhere to anyone else though

also could we please add a toggleable "legacy right click" function or something please? i know it sounds weird but i play classic all the time rather than hotkeys and it's really awkward having to reach over to shift from arrow keys every time i want to right click and look at some stacked stuff on a tile

thanks for the read and the updates x

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Mar 01, 2021 1:06 am #593952

encountered a bug on a tg based server where switching between hotkey and classic mode sometimes made right click bring up verbs instead like it used to and sometimes do its intended functions post-intent removal, dunno if this happened elsewhere to anyone else though


that server probably didn't update their skin.dmf, where the shift behavior is managed

also could we please add a toggleable "legacy right click" function or something please? i know it sounds weird but i play classic all the time rather than hotkeys and it's really awkward having to reach over to shift from arrow keys every time i want to right click and look at some stacked stuff on a tile


no, because we're binding a lot to right-click and don't want anything limiting that
Mothblocks on Bagil - Say nice things about me

User avatar
MisterPerson
Board Moderator
 
Joined: Tue Apr 15, 2014 4:26 pm
Byond Username: MisterPerson

Re: combat mode feedback

Postby MisterPerson » Mon Mar 01, 2021 6:34 am #593984

There might be room for letting people choose a different key than shift. Don't hold your breath on it happening though since the way the right click menu toggle works is quite a pain.
I code for the code project and moderate the code sections of the forums.

Feedback is dumb and it doesn't matter

User avatar
Jaredfogle
Code Maintainer
 
Joined: Fri Jul 27, 2018 9:33 am
Byond Username: Jaredfogle

Re: combat mode feedback

Postby Jaredfogle » Mon Mar 01, 2021 1:12 pm #594050

to clarify, it's impossible to bind context menu to anything other than right click + some kind of modifier
Mothblocks on Bagil - Say nice things about me

User avatar
Farquaar
 
Joined: Sat Apr 07, 2018 7:20 am
Location: Somewhere north of Hogtown
Byond Username: Farquaar

Re: combat mode feedback

Postby Farquaar » Thu Mar 04, 2021 7:32 pm #594510

After having some time to get used to it, I find it to be a lot more intuitive than the previous system. It feels like a natural progression that builds off of the stun and shoving reworks that were implemented last year. Overall, great stuff.

User avatar
SardarKreuz
 
Joined: Fri Mar 12, 2021 6:58 pm
Byond Username: SP_TA_009

Re: combat mode feedback

Postby SardarKreuz » Sun Mar 14, 2021 7:48 pm #595474

Can you believe I cane here just to comment on this feature?
Well, know it's BRILLIANT!

Made the very old martial arts actually useable without much effort.
And I can picture it doing interesting things, like making a spear a melee weapon with one click and throwable with other, creating alt-fire with weapons, alternative uses for objects by hand or turf, different behavior for vehicles based on clicks (imagine a flying bike with guns and missiles or a cart with accelerate and brake,... and this is the killer-app n feture form for those things to happen.)

And since intents aren't used here for passive defense of any sort, I don't think anything is going wrong with this gameplay-wise.

Now what I noticed in gameplay?

- StunBaton is looking WEIRD. You can't kil l mice in maint with it whatever combat mode is On or Not. Still going to try again with other keys and I noticed the comment above. (Why not turnig it into a close contact stun-gun thingy or whatever, if it isn't to behave like a baton/club?)

- I can't drag pets, small bots (medibot, beepsky,...) or lavaland fauna corpses. (If it's a feature and not a bug of this implementation or if there's a whole new way to drag those, please someone tell-me.)

- People are randomly pushing me around and some are excusing themselves.
A small problem with players from other servers not getting accostumed I think. (Can you place a warning for them by startscreen, character login message or something?)

Now going to the code wich I dived into out of curiosity. :)

Whatever you chage this:
if(T != target || shooter.a_intent == INTENT_DISARM || shooter.a_intent == INTENT_GRAB)
For this:
if(T != target || (modifiers && modifiers["right"]))

You are risking eventual coders from other bases to come here and not understand the context.

(I would place a handler or something to change this "right" into a "rightclick" if I were you.)

Also?

Looks like now the monkey will be pissed by getting disarmed as if they were being harmed. (Unless I didn't paid enough attention. I may be wrong on this one.)
But if I am right, is it to be like that?

(Nah, don't change it at all if it was intended. :) A monkey in real life is quick to go aggro if someone annoys them. :twisted: )
.-..-. -.-. .... --- --- ... . / .- / .--- --- -... / -.-- --- ..- / .-.. --- ...- . --..-- / .- -. -.. / -.-- --- ..- / .-- .. .-.. .-.. / -. . ...- . .-. / .... .- ...- . / - --- / .-- --- .-. -.- / .- / -.. .- -.-- / .. -. / -.-- --- ..- .-. / .-.. .. ..-. . --..-- .-..-. / -.-. --- -. ..-. ..- -.-. .. ..- ... / --- -. -.-. . / ... .- .. -.. .-.-.-
UHJvZml0ISEhIF4sXg0KDQpCYXNlNjQgaXMgbG92ZWx5Lg0KRm9yIHJlYWRpbmcgdGhpcyB0ZXh0LCBjb25zaWRlciB5b3Vyc2VsZiB0cnVseSBCQVNFRC4NCg0KIkFMTCBZT1VSIEJBU0UgQVJFIEJFTE9ORyBUTyBVUy4iDQogICAgICAgICAgICAgICAgICAgICAgICAgIC0gQ2F0cywgWmVybyBXaW5nDQo=

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: combat mode feedback

Postby oranges » Mon Mar 15, 2021 1:11 am #595497

the rare positive feedback

User avatar
Farquaar
 
Joined: Sat Apr 07, 2018 7:20 am
Location: Somewhere north of Hogtown
Byond Username: Farquaar

Re: combat mode feedback

Postby Farquaar » Mon Mar 15, 2021 1:39 am #595499

SardarKreuz wrote: - I can't drag pets, small bots (medibot, beepsky,...) or lavaland fauna corpses. (If it's a feature and not a bug of this implementation or if there's a whole new way to drag those, please someone tell-me.)

CTRL-click for small mob dragging is broken, but you can still pull them by shift-right clicking and selecting pull from the drop down menu.

User avatar
SardarKreuz
 
Joined: Fri Mar 12, 2021 6:58 pm
Byond Username: SP_TA_009

Re: combat mode feedback

Postby SardarKreuz » Tue Mar 16, 2021 12:13 am #595612

Farquaar wrote:...
CTRL-click for small mob dragging is broken, but you can still pull them by shift-right clicking and selecting pull from the drop down menu.


Oh my, I would entirelly miss this. Or have to code-dive.

Thx a lot Farquaar. :D

(Whatever this issue have something to do with combat mode or not, it's needing a fix certainly.)

oranges wrote:the rare positive feedback


Thz too, Orange.

I didn't played vanilla TG for a long time and this feature really caught my attention.

Looked intuitive because I was already accostumed to middle click alt-firing in TGMC. (It's the grenade launcher in rifles there, and xenomorph special attacks.)

Having a middle click (with "shift-click" as alternative command) as an action command was already good, but having the right click useable now is even better.

To tell a personal story?

Long time ago, I did some tests with a SS13 combat system that had emphasis on martial arts.

Had nothing to do with replacing intents. (It even used the grab, disarm and harm intent like they were a sort of "paper, rock and scissors" modifier over RNG results.)

But as you may had already guessed, we heavily implemented the same "combo" method of SS13 martial arts (Plasma Fist, Flying Carp, CQC, etc).
Only we had this on weapons too.
And needing to switch intents with 1234 keys in middle of combat for combos and special moves was totally lame.

With some playtesters noticing the handicap imposed on gameplay by the keyboard command style.
(And also how unfair of an advantage someone using a macro capable gamer mouse had over people playing with a regular one. )

On that, I can't even remember how many times I pressed Q, E or R myself, instead of a number key and it totally ruined the intended result with tragicomic consequences.

Gun dropped in middle of firefight. (Our alt-fire was intent based.)
Expensive sword being tossed, embedding on giant monster and being lost for the entire fight.
Etc...
GAAAAAAAH!!!!!! :x

So?
What got implemented here in combaat mode is an amazing feature.
A total killer-feature for action themed gameplay in SS13! ;)
.-..-. -.-. .... --- --- ... . / .- / .--- --- -... / -.-- --- ..- / .-.. --- ...- . --..-- / .- -. -.. / -.-- --- ..- / .-- .. .-.. .-.. / -. . ...- . .-. / .... .- ...- . / - --- / .-- --- .-. -.- / .- / -.. .- -.-- / .. -. / -.-- --- ..- .-. / .-.. .. ..-. . --..-- .-..-. / -.-. --- -. ..-. ..- -.-. .. ..- ... / --- -. -.-. . / ... .- .. -.. .-.-.-
UHJvZml0ISEhIF4sXg0KDQpCYXNlNjQgaXMgbG92ZWx5Lg0KRm9yIHJlYWRpbmcgdGhpcyB0ZXh0LCBjb25zaWRlciB5b3Vyc2VsZiB0cnVseSBCQVNFRC4NCg0KIkFMTCBZT1VSIEJBU0UgQVJFIEJFTE9ORyBUTyBVUy4iDQogICAgICAgICAgICAgICAgICAgICAgICAgIC0gQ2F0cywgWmVybyBXaW5nDQo=

Previous

Return to Coding Feedback

Who is online

Users browsing this forum: No registered users