Song Request Feature Feedback

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.
Post Reply
User avatar
Timberpoes
In-Game Game Master
Joined: Wed Feb 12, 2020 4:54 pm
Byond Username: Timberpoes

Song Request Feature Feedback

Post by Timberpoes » #687596

https://github.com/tgstation/tgstation/pull/74170

Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.

Problems with other URLs: Config issue. Maybe we'll enable more sites at some future point in time but we'll stick with the Big Three (Soundcloud/Bandcamp/YT) for now.

Assorted admin team feedback so far:
"When you accept it just autofills the URL into play-internet-sound and doesn't tell people who requested it"
"It would also be alot more usable if playing a song removed it from the request manager - or could be filtered to do so"

My suggestions: Three-state config flag.
On: Enabled. On by default, can be toggled off via an admin verb.
Toggle: Enabled. Off by default, can be toggled on via an admin verb.
Disabled: Disabled. Cannot be toggled on or off.

I think having the toggle verb would be very useful in general, and would probably be what the final config would end up being (enabled, off by default, toggleable to on). Similar to toggling OOC on and off, it would do a little announcement to let players know.
/tg/station Codebase Maintainer
/tg/station Game Master/Discord Jannie: Feed me back in my thread.
/tg/station Admin Trainer: Service guarantees citizenship. Would you like to know more?
Feb 2022-Sep 2022 Host Vote Headmin
Mar 2023-Sep 2023 Admin Vote Headmin
User avatar
WineAllWine
In-Game Admin Trainer
Joined: Thu Jun 27, 2019 8:17 pm
Byond Username: Wineallwine
Location: LANDAN

Re: Song Request Feature Feedback

Post by WineAllWine » #687820

Timberpoes wrote: Sat May 27, 2023 8:52 pm Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.
Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)
User avatar
Timberpoes
In-Game Game Master
Joined: Wed Feb 12, 2020 4:54 pm
Byond Username: Timberpoes

Re: Song Request Feature Feedback

Post by Timberpoes » #687821

WineAllWine wrote: Sun May 28, 2023 11:37 pm
Timberpoes wrote: Sat May 27, 2023 8:52 pm Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.
Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)
I meant that it rejected valid URLs as invalid before even making the request, because the filter was fucked and wouldn't accept youtube.com/watch?v= URLs.
/tg/station Codebase Maintainer
/tg/station Game Master/Discord Jannie: Feed me back in my thread.
/tg/station Admin Trainer: Service guarantees citizenship. Would you like to know more?
Feb 2022-Sep 2022 Host Vote Headmin
Mar 2023-Sep 2023 Admin Vote Headmin
User avatar
WineAllWine
In-Game Admin Trainer
Joined: Thu Jun 27, 2019 8:17 pm
Byond Username: Wineallwine
Location: LANDAN

Re: Song Request Feature Feedback

Post by WineAllWine » #687822

Timberpoes wrote: Sun May 28, 2023 11:39 pm
WineAllWine wrote: Sun May 28, 2023 11:37 pm
Timberpoes wrote: Sat May 27, 2023 8:52 pm Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.
Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)
I meant that it rejected valid URLs as invalid before even making the request, because the filter was fucked and wouldn't accept youtube.com/watch?v= URLs.
Oh, my bad
Post Reply

Who is online

Users browsing this forum: Bing [Bot]