manual crafting removal

[PKPenguin321]

Stealth changes from coderbus are removing wired rods and all associated crafting, such as making spears. You will have to use the crafting menu.

This is way less fun, ruins my immersion, and has absolutely no good reason for happening. Worst of all it's a stealth change during a freeze.

https://github.com/tgstation/-tg-station/pull/17876

[Super Aggro Crag]

codesteins should have to follow their own fucking rules of not changing shit during a freeze.

[firecage]

codesteins should have to follow their own fucking rules of not changing shit during a freeze.

Well...to be fair though, technically its not adding a new feature.

[Wyzack]

I fucking hate tablecrafting, it is clunky as shit. Why are we so obsessed with using it?

[MMMiracles]

Remember that tablecrafting is no longer a thing as there is a button on your gui that shows all recipes and pulls items from a 3x3 area around you.

Besides, as 'innovative' and ''''immersive'''' it is, handcrafting requires attackby checks and cosmetic items for partly-constructed item (stuff like wired rod existing solely for crafting) that clutters up.

Crafting menu could use an overhaul on how it displays recipes currently but seriously the only real reason I could see for you hating it that much is 'b-but change is bad!'

stop it.

[Wyzack]

Can we make the system better and then port everything over to it rather than the other way around? Especially during a god damn freeze

[Anonmare]

Stealthchanges are always bad to be honest.

[WarbossLincoln]

Crafting Menu Needs:

--Buttons or a DDL of categories instead of the two arrows.
--Textbox to search that will also search regardless of category selected.
--Button or a Checkbox that will filter down to all recipes you currently have the resources to make, regardless of category.
--Refresh button that will clear the aforementioned DDL and search box and go back to the default view.
--A Box(bottom maybe) that will list all the items included in that crafting session.
-------Box would have a scrollbar to limit size. Perhaps a hard limit on how many items will be loaded into it for huge stacks of items.
-------Preferably in the fashion of: "Metal Rod x10", so you don't have to count how many of a specific item you have.
--Recipe Display: It already displays what items are needed. Have it display what you are missing. Have it display how many of a given item you can make

[Remie Richards]

Crafting Menu Needs:

--Buttons or a DDL of categories instead of the two arrows.
--Textbox to search that will also search regardless of category selected.
--Button or a Checkbox that will filter down to all recipes you currently have the resources to make, regardless of category.
--Refresh button that will clear the aforementioned DDL and search box and go back to the default view.
--A Box(bottom maybe) that will list all the items included in that crafting session.
-------Box would have a scrollbar to limit size. Perhaps a hard limit on how many items will be loaded into it for huge stacks of items.
-------Preferably in the fashion of: "Metal Rod x10", so you don't have to count how many of a specific item you have.
--Recipe Display: It already displays what items are needed. Have it display what you are missing. Have it display how many of a given item you can make

I'm working my way down this list, some things I don't like and wont do and some things were already planned before reading it,
Here's an EARLY (literally first compile of DM side+tgui templates) prototype:

Spoiler:

Second prototype - sections only displaying when necessary, automatic commas

Spoiler:

Third prototype - search bar (the input is checked for in the name of the recipe AND the ingredients, so "pi" will find me "Pin removal" the recipe and recipes that need "Pipe")

Spoiler:

[WarbossLincoln]

Nice. I don't know how BYOND code works or how the existing code is set up, but in .NET those would be pretty trivial. I imagine with the sheer volume of items, stuff moving, potential slowdowns(being that it's a menu it's load time wouldn't be as critical as something active)there would be lots of testing and edge cases. Like how would the interface handle an item being removed from the area, would it auto update immediately or just fail to build and tell you why, etc.


I like #3 where you've got the search bar looking for ingredients too. That's a good idea.

[Remie Richards]

Prototype #4!

Showing all recipes:

Spoiler:

Showing craftable recipes:

Spoiler:

[PKPenguin321]

I fucking hate tablecrafting, it is clunky as shit. Why are we so obsessed with using it?

For the same reason as getting rid of verbs?

I don't know, the only reason given is it's easier to write new recipes; there's less code to write.

Yes. When I say there is literally no reason to remove slapcrafting I am not exaggerating. It is being removed for the sake of being removed, despite working perfectly well alongside UI crafting.

[Saegrimr]

Please reduce all that wasted fucking space between entries so I don't have to scroll down 3 miles of bullshit when crafting lists inevitably get that long

[Remie Richards]

Please reduce all that wasted fucking space between entries so I don't have to scroll down 3 miles of bullshit when crafting lists inevitably get that long

1. This is constant with all other TGUIs.
2. use the filter dummy.

[WarbossLincoln]

Please reduce all that wasted fucking space between entries so I don't have to scroll down 3 miles of bullshit when crafting lists inevitably get that long

1. This is constant with all other TGUIs.
2. use the filter dummy.

The perfect developer response. It's like all day at my job.

[Remie Richards]

Please reduce all that wasted fucking space between entries so I don't have to scroll down 3 miles of bullshit when crafting lists inevitably get that long

1. This is constant with all other TGUIs.
2. use the filter dummy.

The perfect developer response. It's like all day at my job.

<3

[Saegrimr]

92 pixels per fucking entry on a 513x645 window. 8 entries visible.

>b-but resize the win--

Doesn't even fucking remember your size settings, unless this is fixed in your "new" build, the fuck do you expect people to constantly resize this window every time they bring this shit up?

>j-just search

Great fucking idea lets hammer in random bullshit to see whats all on this list, have you SEEN the fucking food list? I sure hope you fucking have.



Yeah sure you could type "burger" and get a fucking list of 25 different "burgers"

What the fuck is a "Bearger"? That wont show up in the filters.
The fuck is a "Space Freezy"? Unless you actively know the name of the thing you want that shit will be a mystery buried under 189 entries, 17,388 pixels of bullshit.

>m-more tabs?...

REDUCE WHITESPACE

[The Ultimate Chimera]

Removing manual crafting? Ew...

[Remie Richards]

-snip-

No.

[iamgoofball]

-snip-

No.

Can you at least add a compact version

[Wyzack]

Baw closed the pull and mrperson opened a new one, which somehow managed to fail checks despite it being (i think) just Baw's code

[Armhulen]

Can we just have a meme where we try to remove manual crafting every single time stealthcode style?

[Saegrimr]

-snip-

No.

I fucking love pretentious """"artists""""

[PKPenguin321]

okay remie's thing aside:
manual crafting is getting stealth removed and cheridan is backing it for no reason?

https://github.com/tgstation/tgstation/pull/17901

please poop on cheridan at that link via downthumbs

[Remie Richards]

-snip-

No.

I fucking love pretentious """"artists""""

extensive use of quotation marks aside, thanks for calling me an artist.

[Screemonster]

Is the gigantic list of every item ever necessary, can't it be pruned to just list the things that are possible to make with whatever's surrounding the player or would that be too much overhead?

[Remie Richards]

Is the gigantic list of every item ever necessary, can't it be pruned to just list the things that are possible to make with whatever's surrounding the player or would that be too much overhead?

1. it used to only show possible recipes, like, half a year ago when I first added categories, I added the ability to see all recipes because people requested it.
2. It's the lock button on the new tgui that says "Showing All Recipes" clicking it swaps it to "Showing Craftable Recipes"

[PKPenguin321]

remie with all due respect make your own thread

slapcrafting must live

[Screemonster]

Is the gigantic list of every item ever necessary, can't it be pruned to just list the things that are possible to make with whatever's surrounding the player or would that be too much overhead?

1. it used to only show possible recipes, like, half a year ago when I first added categories, I added the ability to see all recipes because people requested it.
2. It's the lock button on the new tgui that says "Showing All Recipes" clicking it swaps it to "Showing Craftable Recipes"

Oh neat

I'm still gonna miss carrying half a beepsky in my pack and slapping that final part in though

[paprika]

I hate to break it to you but this is a clear example of 'ree change'

PK, this is gonna happen whether you like it or not, just from reading the PRs that have been leading up to this one (like Raz' crafting button and stuff) it's extremely obvious this attackby system is not gonna last long.

You can try and delay it by a week, a month, as long as your complaining can take you, but Goofball's do_after() progress bars were merged despite complaining and this feature's gonna get axed too.

If not now, it'll be soon. This is an almost unilaterally agreed upon choice by not only most of the maintainers and the person who technically OWNS the code project, but tons of coders working on the project. Seriously, let it go.

[Super Aggro Crag]

-snip-

No.

I fucking love pretentious """"artists""""

extensive use of quotation marks aside, thanks for calling me an artist.

i think he typod, he meant to imply you're on the autistic spectrum.

[Steelpoint]

As Paprika said there are some fights worth fighting, but this is not one of them. Its a inevitability.

[Wyzack]

I do not object to the change, just the way it is being done. It is pretty well agreed upon that the current interface is kinda shit. Why not fucking fix the interface before porting everything over rather than after? To make people suffer? Why?

[Takeguru]

Yeah, things like this haven't gone over well in the past

"Oh yeah, we're going to remove this thing and put in a half finished feature now, it can be finished LATER"

And then it never does

[Cheridan]

the crafting system is finished and fully functional though

[Wyzack]

Yes but it is a pain to navigate and a few coders keep saying they are going to fix it

[Zilenan91]

People say they're going to improve menu crafting but they never will. It's not going to happen, if you want to improve it do it now before anything else.

[iamgoofball]

there's literally a PR open right now
that you commented on and argued with me on before all our comments got nuked

[Zilenan91]

You mean the pr where MrPerson removes slap crafting and doesn't actually fix or do anything but enforce """"""""""""""""""""""""""""""code""""""""""""""""""""' """"""""""""""""""""""""'standards"""""""""""""""""""""""""""""""

Or are you talking about another one that I can't remember

[iamgoofball]

You mean the pr where MrPerson removes slap crafting and doesn't actually fix or do anything but enforce """"""""""""""""""""""""""""""code""""""""""""""""""""' """"""""""""""""""""""""'standards"""""""""""""""""""""""""""""""

Or are you talking about another one that I can't remember

the remie crafting menu overhaul PR that fixes all the issues

[allura]

You mean the pr where MrPerson removes slap crafting and doesn't actually fix or do anything but enforce """"""""""""""""""""""""""""""code""""""""""""""""""""' """"""""""""""""""""""""'standards"""""""""""""""""""""""""""""""

Or are you talking about another one that I can't remember

the remie crafting menu overhaul PR that fixes all the issues

that pr just makes the crafting menu even more user unfriendly and ugly and Richards refuses to fix it because they suck

[iamgoofball]

You mean the pr where MrPerson removes slap crafting and doesn't actually fix or do anything but enforce """"""""""""""""""""""""""""""code""""""""""""""""""""' """"""""""""""""""""""""'standards"""""""""""""""""""""""""""""""

Or are you talking about another one that I can't remember

the remie crafting menu overhaul PR that fixes all the issues

that pr just makes the crafting menu even more user unfriendly and ugly and Richards refuses to fix it because they suck

how are search bars and filters user unfriendly

[PKPenguin321]

I hate to break it to you but this is a clear example of 'ree change'

PK, this is gonna happen whether you like it or not, just from reading the PRs that have been leading up to this one (like Raz' crafting button and stuff) it's extremely obvious this attackby system is not gonna last long.

You can try and delay it by a week, a month, as long as your complaining can take you, but Goofball's do_after() progress bars were merged despite complaining and this feature's gonna get axed too.

If not now, it'll be soon. This is an almost unilaterally agreed upon choice by not only most of the maintainers and the person who technically OWNS the code project, but tons of coders working on the project. Seriously, let it go.

it's a Change is Always Good episode!

[paprika]

It's a change is always bad episode

[Incomptinence]

Praise crafting menu!

DEATH TO IMMERSOID SCUM THEY DIE IN THE GAME THEY DIE IN REAL LIFE!

[yackemflam]

Needs subsections.

Give this man the highest IQ award in the server.

[MisterPerson]

Just a heads up to everyone, the code wound up getting merged.

[Saegrimr]

92 pixels per fucking entry on a 513x645 window. 8 entries visible.

189 entries, 17,388 pixels of bullshit.

REDUCE WHITESPACE

[paprika]

Dude it's html

You cannot expect coders who are used to the abomination that is dreammaker to know how to make html objects look nice

Seriously if anyone knows html you can probably program the tgui shit to look nicer

[lzimann]

well, the shit change got merged.