Crafting food with TGUI

[deputi]

It's been nearly two months since the crafting menu was made to use TGUI yet the long loading time for the foods list hasn't been fixed. Trying to play as a chef is suffering because I have to wait for the list to load every time I open the menu to do my job. It never took this long to load the list before TGUI was implemented. If it hasn't been fixed after nearly two months, I think it would be easier to revert the crafting menu to what it was using before TGUI. Then, TGUI could be added back to crafting whenever someone feels like optimizing it.

[Wyzack]

I wholeheartedly agree, was talking to some other admins about it the other day. It is thoroughly broken and needs to be fixed

[John_Oxford]

I dont know if this is the same menu, but the traitor uplink, syndicate uplink, and crew monitoring console all have the same effect (either dont open, take 30 minutes to open, or crash the client when they get opened)
Pls revert

[Lumbermancer]

Too many strings. Remove the popup tooltips.

[Saegrimr]

REMEMBER HOW I WAS RIGHT?

https://tgstation13.org/phpBB/viewtopic ... 19#p179417

THANKS REMIE

[Remie Richards]

...

[John_Oxford]

-snip-

Why we even have a crafting menu as opposed to having everything just made step by step with items laying on the ground, and have ways to make them all on the wiki.

Oh wait, i forgot, the """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""ABSOLUTE"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" seperation of the code base from the player base.

You can't have one without the other, 50 coders (whom of which will probally never be online at the same time) can't support and run a server.
And without the code base, the playerbase has no where to go.

Your holding a bomb that's slowly ticking down, only to assure our mutually guaranteed destruction, and the more you kick and shit on the player base, the quicker that clock is going to go.

Soon.

[Okand37]

Honestly, the main reason I don't play some jobs is because the guis freeze or even crash my game. It'd be nice to be able to use them without that "feature."

[Remie Richards]

...

[Saegrimr]

>I'm intentionally going to severely inconvenience every downstream server and piss off every chef player and everybody that doesn't play chef but has to scroll past that huge window of fuck just to get back at someone I disagree with.

I can't :^) hard enough.

[Wyzack]

When this was launched people said it could be improved after it was implemented. I said why not make it good first and then implement it. Never really got an answer beyond "the code is good quality" and here we still are months later, it is hard to navigate, laggy as fuck and causes all kinds of crashes. I don't fucking care how good the code is if it causes crashes for so many people.

Not only do I lag and sometimes crash when opening the menu the first time, it also lags/crashes any time I make a food item as the entire giant menu for whatever reason closes and reopens again

[Shadowlight213]

>compact mode
Compact mode doesn't do shit to help since the huge ass delay is when you TRY TO OPEN THE TGUI WINDOW.
Adding a tgui button doesn't do shit for that lag.

This is NOT about the whitespace or whatever. This is about the LAG when using tgui.
This isn't any sort of visual aesthetic or anything. This is a functionality issue that people have a real problem with.
The whitespace argument is irrelevant to the issue at hand. I will start deleting posts if it continues.

Also I recall someone asking in another thread why we keep porting things to tgui before fixing the issues present in tgui that people are aware of.

[Remie Richards]

...

I didn't actually see "I will start deleting posts if it continues." from Shadow's post, but I'll just make it clear I've retracted my comments myself, after talking with Saeg in private.

[Lumbermancer]

Compact mode doesn't do shit to help since the huge ass delay is when you TRY TO OPEN THE TGUI WINDOW.

Now I'm not a coder, but isn't the delay caused by lots of shit being read at once? Like when you right click on a huge pile of items?

I will start deleting posts if it continues.

lmao.

[Zilenan91]

Could just split the crafting menu into generic terms, then for all those generic terms there's sub-terms so that you load less at one time.


So like, one generic term is weapons, one is ammo, one is Food, etc

And then below weapons is throwing, ranged, melee, unconventional

Below ammo is makeshift, etc.

Below Food is whatever the food items are made out of, so bread items would be under Wheat, meat would be under Meat, veggies/fruits would be under Veggies/Fruits menu

[Amelius]

Can we just like, remove TGUI?

I swear, I feel like you guys are trying to make chef as frustrating and awful as possible, between the TGUI changes and the testmerge of a wholly negatively received PR (muh rotting food) that wasn't even tested (even fucking salt and pepper melt).

Besides, what the fuck were you guys thinking when you merged TGUI when it's a downgrade in every sense from what we had?

Fuck you people are dumb sometimes.

[Archie700]

It's not just food crafting.

The fucking SUIT SENSORS window causes clients to lagcrash sometimes. (Yes, some people actually use suit sensors to find dead bodies or location of alive people.)

[Amelius]

It's not just food crafting.

The fucking SUIT SENSORS window causes clients to lagcrash sometimes. (Yes, some people actually use suit sensors to find dead bodies or location of alive people.)

Don't worry, it'll be fixed!

Spoiler:

by 2020

.

[Gamarr]

I like the attempt but this change has made certain things broken and lagstatic.
-Never had issues with the previous uplink, and while did not care for the upgrade, dealt with it. Then more 'upgrades,' and now for the last two weeks, my traitor uplink window likes to crash/bug out and force me to restart/relog.
-Foodcrafting with the new thing is awful and I've not played chef in a couple months because its impossible to use.
-When playing doctor, cannot use the crew locator handheld or console because it locks up half the time and kills the client/just doesn't work.
If its been 2 months of sitting with this, why haven't we undone this shit to menus that work?

These are basic menus, functional over form is the name of the game. This should not be so difficult to grasp.

[Archie700]

When you get to the point that TRAITOR UPLINKS can't be loaded properly sometimes, you have to ask why people said it was "good code". Did it just look pretty to you guys, that's why it's "good"?

[oranges]

fuck you nerds, get a real computer you little shits

[Wyzack]

I have a pretty beefy computer, there is no excuse for this shit

[Screemonster]

Unless they're literally rendering it in IE4 you can't blame the client's computer for being unable to display fucking text.

oooooh but the code looks pretty when you open it in a text editor

[onleavedontatme]

I highly doubt anyone is going to put forth the time and energy to revert tens of thousands of lines of tgui.

And the guy who made it left so it's probably not going to be fixed for a long time either.

But yeah my computer can happily run a VR headset and not the fucking chef menu

[Wyzack]

Never before have i been so fucking pissed about being right

"We can fix the problems after we implement it"

"But the code is good"

Fuck off, if it crashes everyone the code is objectively bad, and now the guy who made it fucked off so we are stuck with it. Amazing

[Screemonster]

I've had a few client lag issues in byond related to things sending a fuckload of text at once (a large mass of text coming in when I'm trying to highlight something for copypasta is a common culprit, especially if it's something that makes a noise like an adminpm) and the whole thing stalls until it's finished updating. Oddly enough my win7 laptop didnt have this problem.

I'm wondering what the odds are that the coders who love this shit aren't experiencing the crippling lag 'cause their test server is being run on the same machine as their client with no other players doing anything so of course it works perfectly for them.

[iamgoofball]

guys look

i fixed the lag

https://github.com/tgstation/tgstation/pull/19325

[Bolien]

Vote IAMGOOFBALL for Headmin 2016

Yes.