Page 1 of 1

Fixing map conflicts?

PostPosted: Thu Mar 08, 2018 6:07 am
by Denton
Is there a proper way to fix map conflicts when another PR that modifies a map file gets merged before mine?

So far I've been doing it the caveman way where I copy+paste my changes onto the version found on master. There has got to be a more efficient way.

Re: Fixing map conflicts?

PostPosted: Thu Mar 08, 2018 7:32 am
by SpaceManiac
If you're careful you can edit the .dmm file in a text editor and solve the conflict there, but it's kind of tricky. Your current method is not so bad. In your experience, do the conflicts appear spurious or are you editing the same locations as others are?

I'm working on automatic conflict resolver scripts for DMM and DMI files, but it'll be some time until I'm confident in their success rate.

Re: Fixing map conflicts?

PostPosted: Thu Mar 08, 2018 9:36 am
by Denton
SpaceManiac wrote:In your experience, do the conflicts appear spurious or are you editing the same locations as others are?


So far, I mostly have issues with conflicts when I make changes that can't easily be copypasted. For example, adding 20 light switches that are spread all over Pubbystation.

Re: Fixing map conflicts?

PostPosted: Thu Mar 08, 2018 1:43 pm
by Selea
Update your master branch. Rebase changes onto master. Git reset to point of master update. Save maps in mapmerge.git reset to last commit. Mapmerge.
This way all your changes will be properly merged on new version of map.

Re: Fixing map conflicts?

PostPosted: Thu Mar 08, 2018 3:58 pm
by Denton
Selea wrote:Update your master branch. Rebase changes onto master. Git reset to point of master update. Save maps in mapmerge.git reset to last commit. Mapmerge.
This way all your changes will be properly merged on new version of map.

Thank you for that, I'll test it on my branch tomorrow.

Re: Fixing map conflicts?

PostPosted: Sat Jun 23, 2018 11:52 pm
by Scott
SpaceManiac wrote:If you're careful you can edit the .dmm file in a text editor and solve the conflict there, but it's kind of tricky. Your current method is not so bad. In your experience, do the conflicts appear spurious or are you editing the same locations as others are?

I'm working on automatic conflict resolver scripts for DMM and DMI files, but it'll be some time until I'm confident in their success rate.


When the old python merger was removed, the script for resolving map conflicts was also removed (although the improved merger didn't include a script like it). You can look at it, the results are as good as they can be, provided there are no bugs.