/tg/Station 13

Bottom post of the previous page:

You could argue it's a feature. But I will rebuff that until he can turn OOC off and on at will.

Somehow I'm pretty sure one of our coders actually switched the feature on and broke it because they don't know it's a config option secretly or a long time ago. I distinctly remember it being talked about pre-update that introduced it, so.

Wouldn't be surprised, honestly.

Edit: Likely suspect is the /tg/ merge miggles did. There's some changes with the gameticker.dm file in there that handles OOC automuting. Someone fix it.



Has anyone like, looked at this yet?

Goofball, fuck off. It's a bug, and it's bad, and admins always have to fix it every round.

I wonder why the creator decided to have it default to on...

Q U A L I T Y

B Y O N D

C O D I N G

https://github.com/tgstation/-tg-statio ... 5455c515e9

Someone look at this or something.

I added the "auto disable OOC during rounds" for /tg/station, as a convenient option for servers who want it.

It defaults to off in the config but in the code I left it as the default, since the config option would overwrite it and I wouldn't have to use double negatives when coding, which are confusing to read. Anyway, you guys are missing this option in game_options.txt.

https://github.com/tgstation/-tg-statio ... ns.txt#L26

Add that and it'll be fixed. You can see it defaults to "leave OOC on during the round" in the link.

Yeah I see, during the merge of the option you added the part in the .txt was never added. Th-thanks giacom, I'll fix this now.

I hadn't realized that config options had been changed in the merge and the configs used in the repo, I believe, are the same ones used on the server. I didn't want to fuck up the config changes we had so I assumed that the config file shouldn't be changed. So it was my fault that it was an issue in the first place.

Well if it's still happening after a week I shouldn't have to be the one to hunt an issue like this down, I hunted down who initially made this a thing in under five fucking minutes and it's a crime to our codebase that nobody else fixed it a week ago. I guess it's something to keep in mind for the next time we do a mass-merge of /tg/ features and fixes, I'll help with testing when the time comes.

Also, If I may stick my head in here one more time. The broken traitor objective (where a traitor has no objectives) may be related to the secret documents. I have no idea how the secret documents work, but I got an adminhelp about the bug from a player who was a traitor and had that problem, and he said it was something to do with secret documents. Don't know if that is credible/actually the cause but it would make sense because it is the most recent change to traitor objectives.

we already know