Loyalty Pinned Wizard staffs are possible!

[Bombadil]

That's a staff of chaos.
An artefact that spits bolts of chaotic magic that can potentially do anything.
It is a huge item.
It has a the electronic firing pin installed.

I see the firing pin was implemented in a intelligent way

[Konork]

Code: Select all

obj/item/weapon/gun/magic/staff/chaos
	name = "staff of chaos"
	desc = "An artefact that spits bolts of chaotic magic that can potentially do anything."
	ammo_type = /obj/item/ammo_casing/magic/chaos
	icon_state = "staffofchaos"
	item_state = "staffofchaos"
	max_charges = 10
	recharge_rate = 2
	no_den_usage = 1

It's not a problem with the pins, it's a problem with the staves

[Drynwyn]

Code: Select all

obj/item/weapon/gun/magic/staff/chaos
	name = "staff of chaos"
	desc = "An artefact that spits bolts of chaotic magic that can potentially do anything."
	ammo_type = /obj/item/ammo_casing/magic/chaos
	icon_state = "staffofchaos"
	item_state = "staffofchaos"
	max_charges = 10
	recharge_rate = 2
	no_den_usage = 1

It's not a problem with the pins, it's a problem with the staves

Staves have been a child of gun for a LONG time- making staves NOT a gun would require duplicating a lot of code, which is a much bigger issue than the occasional coder not realizing that they are guns and need to be excluded from changes that shouldn't affect them.

[Fayrik]

Am I the only one who sees this as a good thing?

• Make "Magic" pin.
• Only Wizards can use that pin.

Heck, if you wanted to go absolutely nuts with this, you could give the wizard a whole box of magic pins, then he could pin every gun on the station so that only he can use them.

Yes, this isn't the way it would work, but imho, this is the way it should work.

[drovidi]

The proper Giacom-approved polymorphic thing to do would be to make staves and guns a child of an abstract projectile-spitting superclass.

[iRazgriz]

Change their name to something like magic crystals or whatever.

But I think that regular human shouldn't be able to use magic at all, be it wands or staves.

Or better, give them a chance to backfire horribly.

[callanrockslol]

Am I the only one who sees this as a good thing?

• Make "Magic" pin.
• Only Wizards can use that pin.

Heck, if you wanted to go absolutely nuts with this, you could give the wizard a whole box of magic pins, then he could pin every gun on the station so that only he can use them.

Yes, this isn't the way it would work, but imho, this is the way it should work.

Summon magic wouldn't work then would it.

Also please remove pins and never bring them back, its just helping idiots that keep their guns out at all times and wonder why they get dunked.

[Steelpoint]

As of right now every single gun in the game uses a standard firing pin, the only guns that start without a firing pin are those produced from RnD or the guns that Cargo can print.

[iRazgriz]

How do firing pins exactly work?

[420goslingboy69]

Do not stop people from using magic weapons, please. That's stupid and unthought out.

[Steelpoint]

You know.

If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.

[Incoming]

You know.

If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.

This basically already exists in the instant summons spell

[Bombadil]

You know.

If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.

This basically already exists in the instant summons spell

It has a 10 second cd too

[Balut]

Do not stop people from using magic weapons, please.

[Cheridan]

Change their name to something like magic crystals or whatever.

I had already done that the day before.
https://github.com/tgstation/-tg-station/pull/7240

Note that the topic is a false statement, loyalty pins aren't even available to be crafted. I 'commented' them out by making them require combat 10, due to people raising concerns that they would become the new standard. Pins also are not even replaceable, but I plan on adding that ability.

[Bombadil]

Change their name to something like magic crystals or whatever.

I had already done that the day before.
https://github.com/tgstation/-tg-station/pull/7240

Note that the topic is a false statement, loyalty pins aren't even available to be crafted. I 'commented' them out by making them require combat 10, due to people raising concerns that they would become the new standard. Pins also are not even replaceable, but I plan on adding that ability.

So if you put a test pin in you cant put in a standard pin after?

[Miauw]

The proper Giacom-approved polymorphic thing to do would be to make staves and guns a child of an abstract projectile-spitting superclass.

they basically are, right now. split into three big subareas: energy, projectile and magic. pins were added in the superclass because energy and projectile both use pins.

[Ricotez]

you can just include the ability to distinguish between items that take pins and items that don't in the superclass, add a boolean needs_pin and the necessary checks in the pin code

you could even go one step further and also add an enum pin_type that determines which type of pins the device accepts, electronic pins or magic gems