Page 1 of 1
Loyalty Pinned Wizard staffs are possible!
Posted: Tue Jan 20, 2015 2:06 am
by Bombadil
That's a staff of chaos.
An artefact that spits bolts of chaotic magic that can potentially do anything.
It is a huge item.
It has a the electronic firing pin installed.
I see the firing pin was implemented in a intelligent way
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Tue Jan 20, 2015 2:13 am
by Konork
Code: Select all
obj/item/weapon/gun/magic/staff/chaos
name = "staff of chaos"
desc = "An artefact that spits bolts of chaotic magic that can potentially do anything."
ammo_type = /obj/item/ammo_casing/magic/chaos
icon_state = "staffofchaos"
item_state = "staffofchaos"
max_charges = 10
recharge_rate = 2
no_den_usage = 1
It's not a problem with the pins, it's a problem with the staves
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Wed Jan 21, 2015 12:35 pm
by Drynwyn
Konork wrote:Code: Select all
obj/item/weapon/gun/magic/staff/chaos
name = "staff of chaos"
desc = "An artefact that spits bolts of chaotic magic that can potentially do anything."
ammo_type = /obj/item/ammo_casing/magic/chaos
icon_state = "staffofchaos"
item_state = "staffofchaos"
max_charges = 10
recharge_rate = 2
no_den_usage = 1
It's not a problem with the pins, it's a problem with the staves
Staves have been a child of gun for a LONG time- making staves NOT a gun would require duplicating a lot of code, which is a much bigger issue than the occasional coder not realizing that they are guns and need to be excluded from changes that shouldn't affect them.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Wed Jan 21, 2015 12:42 pm
by Fayrik
Am I the only one who sees this as a good thing?
- Make "Magic" pin.
- Only Wizards can use that pin.
Heck, if you wanted to go absolutely nuts with this, you could give the wizard a whole box of magic pins, then he could pin every gun on the station so that only he can use them.
Yes, this isn't the way it would work, but imho, this is the way it should work.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Wed Jan 21, 2015 3:18 pm
by drovidi
The proper Giacom-approved polymorphic thing to do would be to make staves and guns a child of an abstract projectile-spitting superclass.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Wed Jan 21, 2015 4:16 pm
by iRazgriz
Violaceus wrote:Change their name to something like magic crystals or whatever.
But I think that regular human shouldn't be able to use magic at all, be it wands or staves.
Or better, give them a chance to backfire horribly.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 11:09 am
by callanrockslol
Fayrik wrote:Am I the only one who sees this as a good thing?
- Make "Magic" pin.
- Only Wizards can use that pin.
Heck, if you wanted to go absolutely nuts with this, you could give the wizard a whole box of magic pins, then he could pin every gun on the station so that only he can use them.
Yes, this isn't the way it would work, but imho, this is the way it should work.
Summon magic wouldn't work then would it.
Also please remove pins and never bring them back, its just helping idiots that keep their guns out at all times and wonder why they get dunked.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 11:10 am
by Steelpoint
As of right now every single gun in the game uses a standard firing pin, the only guns that start without a firing pin are those produced from RnD or the guns that Cargo can print.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 12:44 pm
by iRazgriz
How do firing pins exactly work?
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 5:56 pm
by 420goslingboy69
Do not stop people from using magic weapons, please. That's stupid and unthought out.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 5:59 pm
by Steelpoint
You know.
If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Thu Jan 22, 2015 10:36 pm
by Incoming
Steelpoint wrote:You know.
If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.
This basically already exists in the instant summons spell
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Fri Jan 23, 2015 5:29 am
by Bombadil
Incoming wrote:Steelpoint wrote:You know.
If someone ever coded out a more robust spell cost system, where different abilities/powers/items costed varying amounts of spell points, it might be interesting to allow a Wizard to buy a "wizard loyalty gem" to insert into one of their staffs. So they can buy the guarantee that no one will be able to steal their staff and turn it on them.
This basically already exists in the instant summons spell
It has a 10 second cd too
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Fri Jan 23, 2015 5:59 am
by Balut
420goslingboy69 wrote:Do not stop people from using magic weapons, please.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Sat Jan 24, 2015 1:24 am
by Cheridan
Violaceus wrote:Change their name to something like magic crystals or whatever.
I had already done that the day before.
https://github.com/tgstation/-tg-station/pull/7240
Note that the topic is a false statement, loyalty pins aren't even available to be crafted. I 'commented' them out by making them require combat 10, due to people raising concerns that they would become the new standard. Pins also are not even replaceable, but I plan on adding that ability.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Sat Jan 24, 2015 2:56 am
by Bombadil
Cheridan wrote:Violaceus wrote:Change their name to something like magic crystals or whatever.
I had already done that the day before.
https://github.com/tgstation/-tg-station/pull/7240
Note that the topic is a false statement, loyalty pins aren't even available to be crafted. I 'commented' them out by making them require combat 10, due to people raising concerns that they would become the new standard. Pins also are not even replaceable, but I plan on adding that ability.
So if you put a test pin in you cant put in a standard pin after?
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Sat Jan 24, 2015 3:05 pm
by Miauw
drovidi wrote:The proper Giacom-approved polymorphic thing to do would be to make staves and guns a child of an abstract projectile-spitting superclass.
they basically are, right now. split into three big subareas: energy, projectile and magic. pins were added in the superclass because energy and projectile both use pins.
Re: Loyalty Pinned Wizard staffs are possible!
Posted: Sat Jan 24, 2015 3:08 pm
by Ricotez
you can just include the ability to distinguish between items that take pins and items that don't in the superclass, add a boolean needs_pin and the necessary checks in the pin code
you could even go one step further and also add an enum pin_type that determines which type of pins the device accepts, electronic pins or magic gems