Bottom post of the previous page:
If you visited the Github or chose not to cherry pick your statements here you'd know that the ACTUAL Major changes don't get merged in one day, they tend to stay up for atleast 5+ days.Tunder wrote:I DO go on Github, and thus realize that it is a poor medium for feedback. There is no polling option, and there is no ability to directly reply to posts. It is a poor man's imageboard, and completely dysfunctional when it comes to discussing code before it is merged.Remie Richards wrote:The people who bother to make the MINIMUM amount of effort to go to the Github and see the PRs, are listened to, and take part in the discussions.Tunder wrote:I have a Github.Remie Richards wrote:You're aware Pull Requests exist right? their entire functionality is to discuss the change before it's merge or closing.Tunder wrote: It is an open source game. Stop avoiding discussion on changes that you want to make.
We don't push straight to master, even for hotfixes, meaning a PR always exists, it's a rule + the 24hrs rule, you have a window to discuss.
So as far as I can see it the only one avoiding anything is YOU.
Github is shit.
We shouldn't have to come to you to discuss changes you want to make to the game. This forum is the base of operations for the community, not Github.
Everyone posts here. Discuss the changes here. it's that simple. You can make polls and get feedback much simpler in a normal forum than on Github, which has limited scrolling comment functionality.
You hide on Github to avoid having to explain and defend your changes, and your kickin' rad place to be is producing poor results because so few of you regularly play the game anymore and you don't get feedback from normal players, you hide on Github and refuse to use the forums, where all of the noncoders are.
It is not our fault if you refuse to take part.
If you are merging code in the game that we play, we shouldn't have to climb Mt. Olympus to appease the pantheon every time we want to discuss changes.
If you want to affect this community, you need to come to where the community is, we should not have to come to you. Otherwise you will continue to commit shit code that breaks the game/was poorly designed/lowers the server quality of life/the playerbase doesn't want and eventually we'll get fed up.
One day before a merge is simply not enough time, major changes should be put on the forum for a week to discuss and poll.
Github is used as it's where all the discussion of code happens outside of Coderbus, it's the literal closest place to the codebase, and it's tools for commenting on code changes are much better than the forum However yes, polling is arse, Gitlab has a system to automatically count the number of thumbs up (+1) and thumbs down (-1) a PR has for a rough scale of reaction, It's the only feature of Gitlab I wished we had with Github.
On the forums, we don't have control over posts, and so can't stop OBVIOUSLY knee-jerk reactions to things from spiralling into week long threads that circle around and end up nowhere, with control over the Issue reports we can filter down redundancy (Duplicate issues) and such.
As for "Climbing to mount Olympus" it's one URL, you obviously have one link/bookmark/shortcut/URL to get to these forums, so why is the Github one INFINITELY hard to reach according to your claims of it being the distance from earth and the palace of the gods?
Github allows us to get -good- feedback, where would you rather us go? Singulo? No, OOC? God No, the Forums? Some of us do! but it's no surprise people tend to stick to what they're most familiar with, people have invested in Github because it's required to push their changes to the game, so they're obviously more willing to stick around and interact there.
