Upcoming Pseudo Freeze

onleavedontatme · Tue May 30, 2017 7:49 pm

This freeze will start in ~2 weeks. Things that will be accepted during this freeze

-Bug Fixes

-Refactors

-Improvements to civilian systems or gameplay or new features that you can use while not an antagonist without getting banned

Things that won't be accepted

-Balance changes (there can be incidental balance changes from otherwise acceptable PRs, but no "I buffed tasers" or "I nerfed eswords")

-New antagonist toys/types/etc

-New civilian stuff that can't realistically be used without being an antagonist or using it on an antagonist.

The freeze will last 1-2 months.

Hoping for input from other project members on finalizing the details in this.

Bawhoppennn · Post by **Bawhoppennn** » Tue May 30, 2017 7:53 pm #301114

Please be active so you can force through PRs that rework systems that people will get upset about changing

Remie Richards · Tue May 30, 2017 7:53 pm

tl;dr it's an antag content freeze.

Post by **Armhulen** » Tue May 30, 2017 7:56 pm #301116

XHIUS READD SLINGS ALREADY YOU DON'T EVEN NEED CONVERSION REEEEEEEEEEEEEE

bandit · Post by **bandit** » Tue May 30, 2017 8:28 pm #301131

tbh this should be indefinite

Post by **oranges** » Tue May 30, 2017 9:23 pm #301150

bandit wrote:tbh this should be indefinite

The reason we are at the top of the ss13 community is because we change

BeeSting12 · Post by **BeeSting12** » Tue May 30, 2017 10:01 pm #301171

oranges wrote:
bandit wrote:tbh this should be indefinite
The reason we are at the top of the ss13 community is because we change

NO CHANGE REEEEE

danno · Post by **danno** » Tue May 30, 2017 11:04 pm #301206

oranges wrote: we are at the top of the ss13 community

Post by **oranges** » Tue May 30, 2017 11:09 pm #301209

you know we are danno, we're the top and everyone is our bottom

Bawhoppennn · Wed May 31, 2017 12:37 am

oranges wrote:
bandit wrote:tbh this should be indefinite
The reason we are at the top of the ss13 community is because we change

That's like calling China the top country

Post by **oranges** » Wed May 31, 2017 2:45 am #301265

Bawhoppennn wrote:
oranges wrote:
bandit wrote:tbh this should be indefinite
The reason we are at the top of the ss13 community is because we change
That's like calling China the top country

We're the number one innovator

Oldman Robustin · Wed May 31, 2017 4:29 am

Only thing I don't understand is how "No balance" is supposed to coherently relate to "Non-antag features".

A lot of the drastic balance shit has been """"indirect"""" results of features being added/removed/changed.

If I started work on the Engineering ship and beacon to summon it, or the repair vehicles and the factory to create them, would those be closed due to their balance implications?

Bawhoppennn wrote: That's like calling China the top country

Except we're not usually on the hub trying to attract the largest mass of players possible. People come here for a reason.

Bawhoppennn · Post by **Bawhoppennn** » Wed May 31, 2017 5:49 am #301307

Oldman Robustin wrote:
Except we're not usually on the hub trying to attract the largest mass of players possible. People come here for a reason.

Okay that's not what I meant but that's not even really true either

CPTANT · Post by **CPTANT** » Wed May 31, 2017 11:23 am #301366

Not really sure why balance changes are excluded.

There are a lot of simple tweaks in numbers that could improve the game.

IMO the problem is that balance changes are way less rewarding due to the fact that there is an above 50% chance of everyone shitting on your PR, while new antag toys are basically always accepted.

Not-Dorsidarf · Sun Jul 30, 2023 1:33 am

Can we please have a freeze which also freezes refactors? As far as I can tell the main reason we didnt really lose any issues overall last freeze was because of dozens of poorly-implemented refactors that left more bugs in the game because >what is a test

CPTANT · Post by **CPTANT** » Wed May 31, 2017 11:32 am #301369

Not-Dorsidarf wrote:Can we please have a freeze which also freezes refactors? As far as I can tell the main reason we didnt really lose any issues overall last freeze was because of dozens of poorly-implemented refactors that left more bugs in the game because >what is a test

But refactors (when done right) while be extremely worth it in the long run.

D&B · Post by **D&B** » Wed May 31, 2017 1:34 pm #301384

They're hardly done right

Remie Richards · Wed May 31, 2017 2:43 pm

How would you know? You don't contribute, you don't see or interact with the fruits of the refactors.

Remie Richards · Wed May 31, 2017 3:05 pm

Changes nothing.
In a perfect world you, an end user, wouldn't notice anything, that's actually in the definition of the word refactor (atleast with it's meaning within programming circles)
However this is not a perfect world, so all we have are the functional improvements, which again, you can't comment on as you never come into contact with them.

D&B · Post by **D&B** » Wed May 31, 2017 3:39 pm #301414

Like that time shuttles broke.

Or the time window breaking broke

Or the time pointing was persistent

Sure were swell improvements

Post by **Rockdtben** » Wed May 31, 2017 3:57 pm #301422

Kor wrote:This freeze will start in ~2 weeks. Things that will be accepted during this freeze

-Bug Fixes

-Refactors

-Improvements to civilian systems or gameplay or new features that you can use while not an antagonist without getting banned

Things that won't be accepted

-Balance changes (there can be incidental balance changes from otherwise acceptable PRs, but no "I buffed tasers" or "I nerfed eswords")

-New antagonist toys/types/etc

-New civilian stuff that can't realistically be used without being an antagonist or using it on an antagonist.

The freeze will last 1-2 months.

Hoping for input from other project members on finalizing the details in this.

So I can keep working on this yes? https://tgstation13.org/phpBB/viewtopic.php?f=5&t=10967

CPTANT · Post by **CPTANT** » Wed May 31, 2017 5:18 pm #301446

D&B wrote:Like that time shuttles broke.

Or the time window breaking broke

Or the time pointing was persistent

Sure were swell improvements

Or that time all snowflake damage code was rewritten into one global system meaning it was no longer unmaintanable

Or that continuing effort to replace the garbage gamemode code with antag datums so we can actually mix antags and stuff.

danno · Post by **danno** » Wed May 31, 2017 5:44 pm #301451

goofball is actually in the right this time

captain sawrge · Wed May 31, 2017 6:28 pm

He stole my posting gimmick from four years ago

Qbopper · Post by **Qbopper** » Wed May 31, 2017 7:05 pm #301483

Remie Richards wrote:Changes nothing.
In a perfect world you, an end user, wouldn't notice anything, that's actually in the definition of the word refactor (atleast with it's meaning within programming circles)
However this is not a perfect world, so all we have are the functional improvements, which again, you can't comment on as you never come into contact with them.

bugs are unintentional, you can complain about testing/etc. but I don't see why that has to cause a freeze on refactoring

bandit · Post by **bandit** » Wed May 31, 2017 7:22 pm #301492

Remie Richards wrote:Changes nothing.
In a perfect world you, an end user, wouldn't notice anything, that's actually in the definition of the word refactor (atleast with it's meaning within programming circles)
However this is not a perfect world, so all we have are the functional improvements, which again, you can't comment on as you never come into contact with them.

This goes both ways. Speaking as an admin who constantly has to answer ahelps with "it's a known bug," coders who never come into contact with the end result of the "improvements" in-game should not comment.

Remie Richards · Wed May 31, 2017 7:25 pm

bandit · Post by **bandit** » Wed May 31, 2017 8:14 pm #301517

OK but the click code refactor, to take one example, has resulted in a lot of ahelps along the lines of "I can't interact with _______" resulting in actual round issues. One issue recently was wanted posters being unable to be removed, causing a lot of unnecessary shit with security due to a bug

Remie Richards · Wed May 31, 2017 8:16 pm

Actually most interaction bugs are the fault of Cyberboss' Initialize() stuff, not the clickcode rewrite, which was minor in scope.
I figured you'd know that since you fixed one yourself? (Ian)

onleavedontatme · Wed May 31, 2017 8:18 pm

Rockdtben wrote: So I can keep working on this yes? https://tgstation13.org/phpBB/viewtopic.php?f=5&t=10967

Yeah

bandit · Post by **bandit** » Wed May 31, 2017 8:21 pm #301524

Remie Richards wrote:Actually most interaction bugs are the fault of Cyberboss' Initialize() stuff, not the clickcode rewrite, which was minor in scope.
I figured you'd know that since you fixed one yourself? (Ian)

yeah initialize(), is what I meant

Grazyn · Post by **Grazyn** » Thu Jun 01, 2017 10:06 am #301751

Will removals/reverts be allowed? They were allowed during the regular freeze. I don't want to see clockcult stay for 2 more months because the poll ran for 2 weeks and the freeze kicked in before it could be removed.

XDTM · Post by **XDTM** » Thu Jun 01, 2017 11:58 am #301771

I'd rather allow reverts but prevent removals, last freeze we saw balance changes pass due to being technically code removals, like removing telescience.

Grazyn · Post by **Grazyn** » Thu Jun 01, 2017 12:06 pm #301776

I just realized that clockcult removal will be grandfathered in regardless because it was opened before the freeze, duh

Bawhoppennn · Post by **Bawhoppennn** » Fri Jun 02, 2017 2:54 am #302138

Oldman Robustin wrote:Only thing I don't understand is how "No balance" is supposed to coherently relate to "Non-antag features".

A lot of the drastic balance shit has been """"indirect"""" results of features being added/removed/changed.

If I started work on the Engineering ship and beacon to summon it, or the repair vehicles and the factory to create them, would those be closed due to their balance implications?

Also I'm pretty sure it can alter balance massively, it just needs to be in the spirit of actually improving the game, hence why he said no "buff eswords & nerf tasers" type of balance changes.

Post by **AnturK** » Fri Jun 02, 2017 9:56 am #302208

Sounds good, about as far as we can realistically go in defining development direction.

Remie Richards · Fri Jun 02, 2017 10:15 am

God antur why are you the chinese hive man from alpha centauri you just spooked me so hard.

Post by **AnturK** » Fri Jun 02, 2017 10:47 am #302220

I'm preparing mentally for moving the code into recycling vats. (Also played it recently)

Steelpoint · Post by **Steelpoint** » Fri Jun 02, 2017 10:57 am #302222

AnturK is looking to the future of coderbus, a hive mind under one person's whim.

Remie Richards · Fri Jun 02, 2017 11:14 am

my whim.

Alipheese · Post by **Alipheese** » Fri Jun 02, 2017 1:26 pm #302294

Remie Richards wrote:my whim.

Oranges whim

kevinz000 · Post by **kevinz000** » Mon Jun 05, 2017 5:48 pm #303474

Juiced

Remie Richards · Mon Jun 05, 2017 5:48 pm

Now have you seen what happens to people who cross me?

Remie Richards · Mon Jun 05, 2017 5:48 pm

Now have you seen what happens to people who cross me?

Xhuis · Post by **Xhuis** » Mon Jun 05, 2017 5:59 pm #303485

Now have you seen what happens to people who post the same thing twice?

Remie Richards · Mon Jun 05, 2017 6:25 pm

Xhuis wrote:Now have you seen what happens to people who post the same thing twice?

Yes, the people who point it out get juiced
it's my mouse, it manages to hit the button twice really quickly (check out the vidya threads, I just did it thrice!) and I guess phpBB doesn't delay clicks.

kevinz000 · Post by **kevinz000** » Mon Jun 05, 2017 6:50 pm #303520

Remie Richards wrote:Now have you seen what happens to people who cross me?

Oldman Robustin · Fri Jun 09, 2017 1:02 am

>No warning about the specific start time for the freeze
>Both this thread and IRC had misleading times for the freeze start

I'm pretty fucking salty about this, why do it like this when our last freeze was specific down to the minute about when it would start.

Qbopper · Post by **Qbopper** » Fri Jun 09, 2017 3:29 am #305641

Oldman Robustin wrote:>No warning about the specific start time for the freeze
>Both this thread and IRC had misleading times for the freeze start

I'm pretty fucking salty about this, why do it like this when our last freeze was specific down to the minute about when it would start.

>literally one of the few exceptions to the freeze
>is complaining about the freeze starting despite being exempt

Spoiler:

Grazyn · Post by **Grazyn** » Fri Jun 09, 2017 6:24 am #305684

Oldman Robustin wrote:>No warning about the specific start time for the freeze
>Both this thread and IRC had misleading times for the freeze start

I'm pretty fucking salty about this, why do it like this when our last freeze was specific down to the minute about when it would start.

Specific date means that people would rush to PR their unfinished stuff to bypass grandfather clause. It's better this way. See: Trump's travel ban.