Page 1 of 2

Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 8:12 pm
by Cyberboss
https://atlantaned.space/coderbus (raw data)

Concept is simple the more, issues you fix/improvements to the codebase you make, the bigger your epeen. Features, balances, and tweaks degrade your score. Going below zero is grounds for not getting your PR merged (no one has gotten even close yet and it's really easy to increase your score so don't complain about it)

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 8:39 pm
by Qbopper
the point system gimmick is back but this time it's not even in the game

memes aside I do think this is cool though

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 8:40 pm
by factoryman942
page looks beautiful 10/10

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 8:43 pm
by BeeSting12
How are people added to the page?

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 8:46 pm
by oranges
automatically

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 10:39 pm
by Cyberboss
factoryman942 wrote:page looks beautiful 10/10
Get a browser that formats json for you Image

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:03 pm
by CPTANT
Cyberboss wrote:https://tools.tgstation13.org/pr_balances.json

Concept is simple the more, issues you fix/improvements to the codebase you make, the bigger your epeen. Features, balances, and tweaks degrade your score. Going below zero is grounds for not getting your PR merged (no one has gotten even close yet and it's really easy to increase your score so don't complain about it)
That is some serious fucking bullshit there and yes I will complain about it.

Also balances and tweaks don't generate issues, so why do I get punished for addressing balance issues and other tweaks? Balance is already the shitty area nobody wants to touch.

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:10 pm
by oranges
you don't even code

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:17 pm
by Slignerd
Cyberboss wrote:the more improvements to the codebase you make, the bigger your epeen.
Cyberboss wrote:Features, balances, and tweaks degrade your score.
So which one is it?

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:21 pm
by iamgoofball
Cyberboss wrote:Going below zero is grounds for not getting your PR merged (no one has gotten even close yet and it's really easy to increase your score so don't complain about it)
hold my beer

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:25 pm
by Incomptinence
Doesn't go far enough.

Need gbp purchasable balance pr force merges.

Re: Introducing #coderbus goodboy points

Posted: Fri Sep 15, 2017 11:27 pm
by oranges
kek good idea

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 12:17 am
by lzimann
Here, I got bored and did this until(if) mso/someone does a permanent page.

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 12:19 am
by Cyberboss
CPTANT wrote:
Cyberboss wrote:https://tools.tgstation13.org/pr_balances.json

Concept is simple the more, issues you fix/improvements to the codebase you make, the bigger your epeen. Features, balances, and tweaks degrade your score. Going below zero is grounds for not getting your PR merged (no one has gotten even close yet and it's really easy to increase your score so don't complain about it)
That is some serious fucking bullshit there and yes I will complain about it.
I literally opened a random file and found 3 different ways to get 5 points, it's not hard.
Also balances and tweaks don't generate issues, so why do I get punished for addressing balance issues and other tweaks? Balance is already the shitty area nobody wants to touch.
Oh sweet summer child...

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 1:48 am
by kevinz000
someone who broke everything two times has more good boy points than me now i want to fix issues wtf

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 5:43 am
by Qbopper
kevinz000 wrote:someone who broke everything two times has more good boy points than me now i want to fix issues wtf
the system works

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 10:06 am
by InsaneHyena
What if I'm a complete shithead who doesn't know how to code? How do I get GBP then?

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 10:39 am
by CPTANT
kevinz000 wrote:someone who broke everything two times has more good boy points than me now i want to fix issues wtf
Guide to getting goodboy points:

1. Break shit
2. Fix your own shit

Tadaaaa,

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 11:00 am
by CPTANT
Cyberboss wrote:
Also balances and tweaks don't generate issues, so why do I get punished for addressing balance issues and other tweaks? Balance is already the shitty area nobody wants to touch.
Oh sweet summer child...
Cyberboss wrote:I don't trust myself to review this PR and I wouldn't merge it anyway because I generally don't touch balance,

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 4:00 pm
by firecage
I propose an amendment to this. If someone either creates a meme PR, or they have more closed PR's than merged PR's, it can have a bad effect on their points. For example, let's say they have 61 PR's. 30 was merged, and 31 was closed, it would decrease their points by one.

Not like someone is so horrible they will end up at like -480 points or something.

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 9:09 pm
by Cobby
firecage wrote:I propose an amendment to this. If someone either creates a meme PR, or they have more closed PR's than merged PR's, it can have a bad effect on their points. For example, let's say they have 61 PR's. 30 was merged, and 31 was closed, it would decrease their points by one.

Not like someone is so horrible they will end up at like -480 points or something.
I have a lot of closed prs that are due to simply not being the direction that people would prefer to go in, along with prs that I close myself because there's a better way to handle the problem after some discussion.

It would be quite unfair to have those negatively impact me because we don't know how to ban goof.

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 9:17 pm
by CPTANT
It also dissuades touching anything that might be even remotely considered controversial.

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 16, 2017 9:19 pm
by Cyberboss
CPTANT wrote:
Cyberboss wrote:
Also balances and tweaks don't generate issues, so why do I get punished for addressing balance issues and other tweaks? Balance is already the shitty area nobody wants to touch.
Oh sweet summer child...
Cyberboss wrote:I don't trust myself to review this PR and I wouldn't merge it anyway because I generally don't touch balance,
I was rolling my eyes at the "balances and tweaks don't generate issues," they do, all the time.

Re: Introducing #coderbus goodboy points

Posted: Sun Sep 17, 2017 3:43 pm
by Atlanta-Ned
lzimann wrote:Here, I got bored and did this until(if) mso/someone does a permanent page.
I gotchu fam https://atlantaned.space/newSS13tools/coderbus/gbp.php

Re: Introducing #coderbus goodboy points

Posted: Mon Sep 18, 2017 2:06 am
by Doctor Pork
CPTANT wrote:It also dissuades touching anything that might be even remotely considered controversial.
example please?

Re: Introducing #coderbus goodboy points

Posted: Mon Sep 18, 2017 10:43 pm
by Qbopper
Doctor Pork wrote:
CPTANT wrote:It also dissuades touching anything that might be even remotely considered controversial.
example please?
yeah I thought it was literally just "fixes up your points but features lower it" or something along those lines

Re: Introducing #coderbus goodboy points

Posted: Mon Sep 18, 2017 10:57 pm
by Jordie0608
These are the values

Code: Select all

'Fix' => 2,
'Refactor' => 2,
'Code Improvement' => 1,
'Priority: High' => 4,
'Priority: CRITICAL' => 5,
'Atmospherics' => 4,
'Logging' => 1,
'Feedback' => 1,
'Performance' => 3,
'Feature' => -1,
'Balance/Rebalance' => -1,
'Tweak' => -1,

Re: Introducing #coderbus goodboy points

Posted: Mon Sep 18, 2017 11:15 pm
by Qbopper
why's the atmos tag so high?

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 12:13 am
by Doctor Pork
Qbopper wrote:why's the atmos tag so high?
literally an atmos simulator

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 12:22 am
by Qbopper
Doctor Pork wrote:
Qbopper wrote:why's the atmos tag so high?
literally an atmos simulator
yeah I just thought it was odd, is there usually a lack of/so many atmos PRs that make it necessary or something

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 4:41 am
by oranges
because it's hard

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 6:29 am
by iamgoofball
Atmos math requires a degree to understand

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 1:37 pm
by CPTANT
iamgoofball wrote:Atmos math requires a degree to understand
I wanted to say lolno, but then I remembered I have a technical degree.

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 3:32 pm
by Atlanta-Ned
Added labels from the repo (yay APIs!) and their values: https://atlantaned.space/newSS13tools/coderbus/gbp.php

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 3:41 pm
by Arianya
Could probably stand to have "Grammar/Formatting" on the list at 1, since I believe pulls solely correcting those tend not to get "Fix".

I believe "Easy Fix" is a issues only tag, but if not then worth putting it at 1, since any fix is a good fix, even if its easy.

"Map Edit"... I feel like it should have some value, maybe -1? Not terribly sure tbh.

In terms of the issues side of things, maybe a new "Reproduced" or "Confirmed" tag that gives the reporter of the issue 1 point, for use where the reporter has given information/reproduction steps for their bug that has helped lead to a reproduction?

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 4:48 pm
by Cyberboss
The vast majority of map edits are fixes

Re: Introducing #coderbus goodboy points

Posted: Tue Sep 19, 2017 11:30 pm
by Oldman Robustin
>Someone makes a sloppy balance PR that addresses an issue, but does so in the worst way possible

>Spend hours coding up the proper approach

>Getting the improved PR merged costs me points

Hmmm

Re: Introducing #coderbus goodboy points

Posted: Wed Sep 20, 2017 1:18 pm
by Nabski
Ned, the tags of values linking to github doesn't work for the two word labels. Toss some "" in there or something.

This was more amusing when I just thought nothing had ever been tagged "Code Improvement"

Re: Introducing #coderbus goodboy points

Posted: Wed Sep 20, 2017 2:35 pm
by Atlanta-Ned
Nabski wrote:Ned, the tags of values linking to github doesn't work for the two word labels. Toss some "" in there or something.

This was more amusing when I just thought nothing had ever been tagged "Code Improvement"
goddammit this should be fixed now and i hate uris

Re: Introducing #coderbus goodboy points

Posted: Thu Sep 21, 2017 9:12 pm
by Bawhoppennn
>sound and sprites don't give anything

Cmon man, they're the two things we need the most

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 23, 2017 2:17 am
by Slignerd
At first I thought this idea was a joke.

Re: Introducing #coderbus goodboy points

Posted: Sat Sep 23, 2017 11:51 pm
by bandit
I don't see how a tweak costs points, it's as neutral as you can possibly get

Re: Introducing #coderbus goodboy points

Posted: Mon Sep 25, 2017 11:43 pm
by Cyberboss
bandit wrote:I don't see how a tweak costs points, it's as neutral as you can possibly get

Re: Introducing #coderbus goodboy points

Posted: Wed Oct 11, 2017 9:53 pm
by J_Madison
this can only end well.

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 2:23 am
by Cyberboss
Issue count has actually started decreasing, albiet slowly. A massive improvement from the endless inflation

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 6:44 am
by onleavedontatme
Feature might need to cost a little more since right now you gain points by submitting bugged stuff and fixing it afterwards instead of testing, but it's been a surprisingly successful system in general

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 6:46 am
by iamgoofball
Kor wrote:Feature might need to cost a little more since right now you gain points by submitting bugged stuff and fixing it afterwards instead of testing, but it's been a surprisingly successful system in general
That won't fix it

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 3:35 pm
by firecage
iamgoofball wrote:
Kor wrote:Feature might need to cost a little more since right now you gain points by submitting bugged stuff and fixing it afterwards instead of testing, but it's been a surprisingly successful system in general
That won't fix it
Well, you might make less PR's. That's fixing one of the problems.

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 4:06 pm
by Bawhoppennn
This has been a surprising success.

Re: Introducing #coderbus goodboy points

Posted: Thu Oct 12, 2017 10:05 pm
by factoryman942
>frog is on -2 points