/tg/Station 13

Bottom post of the previous page:

oranges wrote:

Code: Select all

/datum/reagent/toxin/mutagen/reaction_mob(mob/living/carbon/M, method=TOUCH, reac_volume)
	if(!..())
		return
	if(!M.has_dna())
		return  //No robots, AIs, aliens, Ians or other mobs should be affected by this.
	if((method==VAPOR && prob(min(33, reac_volume))) || method==INGEST || method==PATCH || method==INJECT)
		M.randmuti()
		if(prob(98))
			M.randmutb()
		else
			M.randmutg()
		M.updateappearance()
		M.domutcheck()
..()

PKPenguin321 wrote:

oranges wrote:

Code: Select all

/datum/reagent/toxin/mutagen/reaction_mob(mob/living/carbon/M, method=TOUCH, reac_volume)
   if(!..())
      return
   ...
   ..()

What's so bad about this? I usually get these but this one's readable and not awful

lzimann wrote:So, I am currently refactoring all gamemode code, and for that I set the ticker.mode to always be null. With that, I discovered that doors/airlocks are dependent on ticker.mode existing.

This one is the open() proc for doors. The code is not pretty overall, but notice the if(!ticker || !ticker.mode) there. It also happens in airlocks.

Code: Select all

/obj/machinery/door/proc/open()
	if(!density)
		return 1
	if(operating)
		return
	if(!ticker || !ticker.mode)
		return 0
	operating = 1
	do_animate("opening")
	SetOpacity(0)
	sleep(5)
	density = 0
	sleep(5)
	layer = OPEN_DOOR_LAYER
	update_icon()
	SetOpacity(0)
	operating = 0
	air_update_turf(1)
	update_freelook_sight()
	if(autoclose)
		spawn(autoclose)
			close()
	return 1

Remie Richards wrote:snip

lzimann wrote:

Remie Richards wrote:snip

I imagined it was something like that, but still... it hurts

XDTM wrote:So basically you inject double the mutagen if you use vapor

4dplanner wrote:

XDTM wrote:So basically you inject double the mutagen if you use vapor

I still don't get it - why?

E: I mean, I see it calls ..() twice but that doesn't seem to be vapor specific, so I'm still confused.

/datum/reagent/proc/reaction_mob(mob/living/M, method=TOUCH, reac_volume, show_message = 1, touch_protection = 0)
	if(!istype(M))
		return 0
	if(method == VAPOR) //smoke, foam, spray
		if(M.reagents)
			var/modifier = Clamp((1 - touch_protection), 0, 1)
			var/amount = round(reac_volume*modifier, 0.1)
			if(amount >= 0.5)
				M.reagents.add_reagent(id, amount)
   return 1

Remie Richards wrote:the spawn room thing is terrible aswell as there used to be area-checks inside attack code that just said "stop hitting people in spawn jackass" or something to that effect.

/mob/living/attack_alien(mob/living/carbon/alien/humanoid/M)
	if(isturf(loc) && istype(loc.loc, /area/start))
		to_chat(M, "No attacking people at spawn, you jackass.")
                return 0

XDTM wrote:Looks like standard saycode to me

FrozenGuy5 wrote:

XDTM wrote:Looks like standard saycode to me

good joke

SpaceManiac wrote:Discovered on yogstation:

Code: Select all

// in machines.dm
#define OPEN    1
#define IDSCAN  2
#define BOLTS   4
#define SHOCK   8

// in firedoor.dm
/var/const/OPEN = 1
/var/const/CLOSED = 2

That's right,

Code: Select all

/var/const/1 = 1

compiles.

SpaceManiac wrote:Discovered on yogstation:

Code: Select all

// in machines.dm
#define OPEN    1
#define IDSCAN  2
#define BOLTS   4
#define SHOCK   8

// in firedoor.dm
/var/const/OPEN = 1
/var/const/CLOSED = 2

That's right,

Code: Select all

/var/const/1 = 1

compiles.

Dax Dupont wrote:

Code: Select all

	var/fucking_stock_spikes = current_value + 500
	var/piece_of_shit_fuck = current_value - 500
	var/i_hate_this_code = (speculation / rand(25000, 50000) + performance / rand(100, 800)) * current_value
	if(i_hate_this_code < fucking_stock_spikes || i_hate_this_code > piece_of_shit_fuck)
		current_value += i_hate_this_code

https://github.com/tgstation/tgstation/ ... #L142-L146

Dax Dupont wrote:

Code: Select all

	var/fucking_stock_spikes = current_value + 500
	var/piece_of_shit_fuck = current_value - 500
	var/i_hate_this_code = (speculation / rand(25000, 50000) + performance / rand(100, 800)) * current_value
	if(i_hate_this_code < fucking_stock_spikes || i_hate_this_code > piece_of_shit_fuck)
		current_value += i_hate_this_code

https://github.com/tgstation/tgstation/ ... #L142-L146

LifeReign wrote:Let's be honest, Goof could be entirely forumbanned and repobanned, and he'd still try to run for headmin. Also, Goof for headmin is becoming a stale meme, we need a fresh meme headmin candidate.