Testmerging seems to be a PITA for everyone

How, what and why to code in BYOND.

Moderators: MisterPerson, Code Maintainers

User avatar
Oldman Robustin
 
Joined: Tue May 13, 2014 2:18 pm
Byond Username: ForcefulCJS

Testmerging seems to be a PITA for everyone

Postby Oldman Robustin » Tue Mar 06, 2018 6:11 pm #387921

Testmerging is an extremely valuable tool but the way its utilized right now is awful.

On the maintainer/headmin side its the source of a relentless stream of begging/nagging. Then if something goes wrong it's another flurry of messaging to get someone to take it down.

From the coder side its horribly underutilized. The coder has almost no idea when or where its been testmerged unless they're there personally lobbying for it (and even then they might miss it if they don't hear back immediately). Its incredibly disruptive to workflow when you're sitting around with nothing to do but can't progress until testing, then when testing is finally done you're working on something else and have to drop everything to address issues while they're still fresh and witnesses are around to describe what went wrong. More commonly, stuff just gets merged with little to no testing, the coder can never predict when the merge is going to happen, then you get a litany of bugs that would've been caught during testing and now the coder either has to drop everything and fix them or buggy code just sits around because reality called and the coder has shit to do.

I think everyone agrees that more feedback is likely to yield a better final product, coders are much more incentivized to polish up their work if theres reported bugs/complaints sitting in an unmerged PR rather than sitting in an 1,100 item issue list with a vague title. What can we do to improve this process? Could it be automated based on "test merge candidate" tagging and limited + scheduled test windows? Can we give ordinary admins the ability to remove test merges so that testmergers don't feel like they have to babysit a test merge if something goes wrong - or alternatively, if they don't babysit the test, so that we can remove broken test PRs?
Image



User avatar
D&B
 
Joined: Mon Jun 13, 2016 2:23 am
Location: *teleports behind you*
Byond Username: Repukan

Re: Testmerging seems to be a PITA for everyone

Postby D&B » Tue Mar 06, 2018 6:47 pm #387932

Can't you host your own server for 15 minutes to test it
Spoiler:
[20:26:02]ADMIN: PM: [censored admin]->[censored]: Welp. It was just a prank bro isn't a very good excuse when it comes to unprovoked nonantag murder, but since this is your first time doing it and you seem to understand the problem instead of a bannu I'm just going to leave you with a warning. Please PLEASE don't do this again in the future, as funny as crackhead broken bottle memes can be. Alrighty? Do you have any input on this?
[20:26:39]ADMIN: PM: [censored]->[censored admin]: Alright, no problem. I have some input. Fuck my boy pussy.
[20:27:06]ADMIN: PM: [censored admin]->[censored]: Okay then. Have fun.
[20:31:29]ADMIN: PM: [censored admin]->[censored]: Excuse me?

J_Madison wrote:that's a stupid fucking stat
you don't play, you've never played
lying little shit with your bullshit stat
fuck you

ColonicAcid wrote:and with enough practise i too could blow my own dick so well that only the gods know how it feels.

Selea
 
Joined: Sat Nov 11, 2017 11:11 am
Byond Username: Serpentarium

Re: Testmerging seems to be a PITA for everyone

Postby Selea » Tue Mar 06, 2018 7:09 pm #387948

sometimes you can't find all the bugs yourself.Some will occur only on server with many people.
But test merge shedule will be a thing.
Image

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: Testmerging seems to be a PITA for everyone

Postby PKPenguin321 » Tue Mar 06, 2018 7:49 pm #387981

D&B wrote:Can't you host your own server for 15 minutes to test it

obviously but many bugs or balance changes can't be found or fully tested by yourself
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
Image

User avatar
Atlanta-Ned
In-Game Admin
 
Joined: Fri Apr 18, 2014 2:11 pm
Byond Username: Atlanta-ned

Re: Testmerging seems to be a PITA for everyone

Postby Atlanta-Ned » Tue Mar 06, 2018 8:17 pm #388008

I wish admins had more guidance on testmerged PRs so we can specifically skew the round to test whatever needs to be tested.
Feedback pls (Don't bother though, because I am perfect)
### ListVarEdit by Atlanta-ned: /datum/reagents reagent_list: Water=/obj/item/weapon/gun/energy/alien
IcePacks wrote:>all you have is a taser and the cold realization that you're a haphazard bandaid over a problem that may or may not exist, applied by someone who doesn't know or care enough about their job to do it properly

OOC: Pizzatiger: God damn Atlanta, how are you so fucking smart and charming. It fucking pisses me off how perfect you are

User avatar
Oldman Robustin
 
Joined: Tue May 13, 2014 2:18 pm
Byond Username: ForcefulCJS

Re: Testmerging seems to be a PITA for everyone

Postby Oldman Robustin » Tue Mar 06, 2018 10:18 pm #388060

D&B wrote:Can't you host your own server for 15 minutes to test it


I test extremely thoroughly but there's shit that you just won't catch alone.

Like my Box Update shit itself last Friday over canvases. I added persistent art, during local testing I had made several pieces and they saved/loaded just fine.

Then it went live and after the mime found out he could immortalize his work he went and did some complex canvas art and suddenly nobody could even look near the art gallery without their client going into permacrash.

I rushed some fixes (mostly removing canvases from the box update) but its been 5 days and I still haven't been able to test it further.

Its also other shit like "the shutters you put in to secure something can be broken with a mere fireaxe" that testing helps reveal. Often its a lot of general feedback too, UI stuff, little things that work as intended but people have impressions/suggestions that let you refine them. Like I said coder motivation to make their code as appealing as possible is at its PEAK during the inaugural PR, you're much likely to see minor improvements then than waiting for a merge and then hoping someone cares enough to open a feedback thread/PR/issue explaining where your code falls short.

After the Box update I want to work on Techwebs, which is still missing basic features,but im already giving me PTSD flashbacks to waiting around IRC for weeks trying to find someone to testmerge. Even during the test that revealed CRITICAL issues with canvases, I had to repeatedly beg Cyberboss who finally gave in with "I'm going to regret this".

That's basically where things stand. I'm going to lose another week of coding at this rate just waiting for another testmerge.
Image

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Testmerging seems to be a PITA for everyone

Postby oranges » Tue Mar 06, 2018 11:23 pm #388086

150 hours of testing lol

onleavedontatme
 
Joined: Fri Mar 13, 2015 10:26 pm
Byond Username: KorPhaeron

Re: Testmerging seems to be a PITA for everyone

Postby onleavedontatme » Tue Mar 06, 2018 11:27 pm #388087

This should get better next term, current headmins are all busy or burned out. We lost a key holder when Shadowlight got deadminned as well.

MSO is also slowly trialing giving remote to all maintainers.

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Testmerging seems to be a PITA for everyone

Postby oranges » Tue Mar 06, 2018 11:28 pm #388088

Kor wrote:This should get better next term, current headmins are all busy or burned out. We lost a key holder when Shadowlight got deadminned as well.

MSO is also slowly trialing giving remote to all maintainers.

WHEN

User avatar
Bawhoppennn
Github User
 
Joined: Wed Jan 14, 2015 11:42 pm
Byond Username: Bawhoppennn
Github Username: Bawhoppen

Re: Testmerging seems to be a PITA for everyone

Postby Bawhoppennn » Tue Mar 06, 2018 11:37 pm #388093

oranges wrote:WHEN


Can't you stay satisfied being heir apparent for both headcoder AND host, should either Kor or MSO leave for whatever reason?
Image
<KorMobile> you're a hero

[21:20:53] <%oranges> Baw "has cute legs" hoppen

DEAD: ADMIN(Owegno) says, "Nothing lewd happens in adminbus sadly."

[07:13:57] <Rockdtben> Keep in mind that I'm an extremely successful and wealthy male in his late twenties.

(F) DEAD: Professor DonkPocket says, "Admins preventchaos with good messages"

OOC: Pogoman122: Fun fact if someone trespasses on your kitchen just turn them into a nugget

<+KorPhaeron> russians have no souls so magic enrages them
<+KorPhaeron> people who don't like rng are not from /tg/ and are likely redditors
ausops wrote:apart from this there is literally nothing more to say other than that this is the first thread in five years to have achieved something.

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: Testmerging seems to be a PITA for everyone

Postby PKPenguin321 » Wed Mar 07, 2018 1:49 am #388126

Kor wrote:This should get better next term, current headmins are all busy or burned out. We lost a key holder when Shadowlight got deadminned as well.

MSO is also slowly trialing giving remote to all maintainers.

>maintainers
>not gamemasters
grumble
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
Image

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Testmerging seems to be a PITA for everyone

Postby oranges » Wed Mar 07, 2018 3:00 am #388142

PKPenguin321 wrote:
Kor wrote:This should get better next term, current headmins are all busy or burned out. We lost a key holder when Shadowlight got deadminned as well.

MSO is also slowly trialing giving remote to all maintainers.

>maintainers
>not gamemasters
grumble

we actually know what we're doing

User avatar
Not-Dorsidarf
In-Game Admin
 
Joined: Fri Apr 18, 2014 4:14 pm
Location: Space outside the Brig
Byond Username: Dorsidwarf

Re: Testmerging seems to be a PITA for everyone

Postby Not-Dorsidarf » Wed Mar 07, 2018 11:23 am #388198

I like the idea of a schedule for test merge slots instead of just "whenever someone feels like it for however long they feel like it". At the very least ping the coder to tell them their testmerge is up or something
Image
Image

CPTANT
 
Joined: Mon May 04, 2015 1:31 pm
Byond Username: CPTANT

Re: Testmerging seems to be a PITA for everyone

Postby CPTANT » Wed Mar 07, 2018 5:35 pm #388268

D&B wrote:Can't you host your own server for 15 minutes to test it


Not really feasible for anything that depends on the interaction of multiple people.
Screemonster wrote:how the fuck are you supposed to RP with a grille

User avatar
kevinz000
In-Game Admin
 
Joined: Fri Nov 14, 2014 8:41 am
Location: Dorm Room 3
Byond Username: Kevinz000
Github Username: kevinz000

Re: Testmerging seems to be a PITA for everyone

Postby kevinz000 » Wed Mar 07, 2018 10:42 pm #388307

oranges wrote:
PKPenguin321 wrote:
Kor wrote:This should get better next term, current headmins are all busy or burned out. We lost a key holder when Shadowlight got deadminned as well.

MSO is also slowly trialing giving remote to all maintainers.

>maintainers
>not gamemasters
grumble

we actually know what we're doing

Oh shit

User avatar
Oldman Robustin
 
Joined: Tue May 13, 2014 2:18 pm
Byond Username: ForcefulCJS

Re: Testmerging seems to be a PITA for everyone

Postby Oldman Robustin » Thu Mar 08, 2018 1:35 am #388333

Don't see why Gamemasters couldn't as long as a maintainer threw up the test merge candidate tag (and assuming we use that tag appropriately).
Image

User avatar
kevinz000
In-Game Admin
 
Joined: Fri Nov 14, 2014 8:41 am
Location: Dorm Room 3
Byond Username: Kevinz000
Github Username: kevinz000

Re: Testmerging seems to be a PITA for everyone

Postby kevinz000 » Thu Mar 08, 2018 10:20 am #388540

automated would have to use a snapshot of a pr, rather than directly, otherwise >get scheduled for testmerge >put in code that makes you god emperor headmin and disables the ban system before the system actually testmerges but after it's marked for testmerging >wreak havoc with your evading friends
see why only certain people can testmerge and only manually now?

User avatar
BeeSting12
In-Game Admin
 
Joined: Sat Apr 16, 2016 1:11 am
Location: 'Murica
Byond Username: BeeSting12
Github Username: BeeSting12

Re: Testmerging seems to be a PITA for everyone

Postby BeeSting12 » Thu Mar 08, 2018 3:52 pm #388605

Cant you just make tags auto remove if another commit is made
Edward Sloan, THE LAW
Melanie Flowers, Catgirl
Borgasm, Cyborg
Spoiler:
OOC: Hunterh98: to be fair sloan is one of the, if not the, most robust folks on tg

DEAD: Schlomo Gaskin says, "sloan may be a faggot but he gets the job done"

DEAD: Rei Ayanami says, "YOU'RE EVERYWHERE WHERE BAD SHIT IS HAPPENING"
DEAD: Rei Ayanami says, "IT'S ALWAYS FUCKING EDWARD SLOAN"
oranges wrote:Bee sting is honestly the nicest admin, I look forward to seeing him as a headmin one day


[2020-05-21 01:21:48.923] SAY: Crippo/(Impala Chainee) "Shaggy Voice - She like... wants to get Eiffel Towered bro!!" (Brig (125, 166, 2))

hows my driving?

User avatar
MrStonedOne
Host
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: Testmerging seems to be a PITA for everyone

Postby MrStonedOne » Thu Mar 08, 2018 11:21 pm #388688

Test merge candidate tag is nice, but it merely states that a maintainer thinks the thing needs to be test merged, it doesn't speak to rather or not anybody has actually reviewed the code to confirm its worthy of test merge. This is why it hasn't been too helpful at getting something test merged.

Maintainers have to be the ones who sign off on test merges, there isn't any other way, and unless maintainers stop slapping that tag on prs until they review them, the tag can't be a way of signing off on a test merge.

So until i bring all the maintainers in on test merges, I'd like to see coders stop going to headmins/key holders with test merge requests and instead go to maintainers with them, maintainers can then handle going to key holders with prs to test merge after they've reviewed the code.
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[10:55 AM] spookydonut: stonedmc is the work of a criminally insane mad genius

Selea
 
Joined: Sat Nov 11, 2017 11:11 am
Byond Username: Serpentarium

Re: Testmerging seems to be a PITA for everyone

Postby Selea » Thu Mar 08, 2018 11:22 pm #388690

why not just testmerge up to last marked commit commit?git allows very advanced code version juggling.
Image

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Testmerging seems to be a PITA for everyone

Postby oranges » Fri Mar 09, 2018 2:37 am #388718

They're going straight to the keyholders because we're ignoring 99% of peoples requests anyway, the fact that the keyholders aren't telling them to get lost is their problem, way to many people are treating the test merge system like it's there to help them find bugs, instead of being there to get feedback and balance issues.

User avatar
ninjanomnom
Code Maintainer
 
Joined: Wed May 31, 2017 3:35 am
Byond Username: Ninjanomnom
Github Username: ninjanomnom

Re: Testmerging seems to be a PITA for everyone

Postby ninjanomnom » Thu Apr 12, 2018 12:23 pm #399471

As of a couple weeks ago most if not all maintainers have testmerge access now
Narcissistic stuff others said/made for me
Spoiler:
Image
Image

User avatar
Cyberboss
Code Maintainer
 
Joined: Mon Sep 26, 2016 7:58 pm
Location: Ontario, CA
Byond Username: Cyberboss
Github Username: Cyberboss

Re: Testmerging seems to be a PITA for everyone

Postby Cyberboss » Fri Apr 20, 2018 3:10 pm #401716

This is a lot of future crafting BUT

TGSv4 is currently in the works. The primary draw of it is a complete rewrite of the API to make it much more similar to GitHub's json.

Unlike where only the specialized C# library communicate with the servers, the new web API gives us to the ability to create tools to automate interactions while keeping the layers of approval. For example, the repo bot already automatically removes test merge candidate if a coder changes their PR. It wouldn't be a far stretch to allow the bot to take the maintainer approval and allow the coder to initiate and remove the test merge when it is convenient for them. Something else planned for v4 is a comment attribute to test merges which can communicate intentions to admins while it's on.

This is all a lot of theory crafting though and, given the strict parameters I'm developing V4 with, I don't know when it'll ready for production use.
ImageImage


Return to Coding

Who is online

Users browsing this forum: No registered users