Page 1 of 1

Pipes update

PostPosted: Fri Apr 25, 2014 11:29 pm
by Donkie
Plumbers and atmosians reunite!

This update is ment to fix up any visual shit found within atmos and their gas pipes. Visually both ingame but also the code, and also clean up the metric shitton of icons atmos has.
A lot of these errors are things people have always seen as features, so you might not have even realised it's broken.
So far I've done the following:


  • General code cleanup, absolute paths errywhere
  • Pipes are now colored using the color var instead of specific icons for each color. This means: 1. Less icons, 2. Unlimited amount of color possibilities
  • Broken pipes (not connected in one of the ends) now display properly using the T-ray scanner
  • Pipemanifold is also colorable using color var
  • Pipemanifold icon have been lowered to 3 iconstates from roughly 12 or something. This means: 1. Cleaner code, 2. Less codertears
  • Pipemanifold now displays properly using T-ray, even when any of the ends are not attached:
    Image
  • All pipe's colors are now displayed properly using T-ray
  • Removed the "dirt" which is found at the end of all pipe pieces, lines of pipes look a lot better now IMO
  • Fixed up the shading of pipes, the dark side is always to the WEST or SOUTH, this was pretty inconsistent before


  • Pumps now support colored pipes
  • Updated pump icon slightly, replacing the red direction ribbon with an arrowthingy:
    Image
  • Filters now have broken ends for where pipes are not attached
  • Filterpipes now share color of the pipe it's connected to:
    Image
  • Binary (two ends) and trinary (three ends) devices now update their icons properly


  • All devices, both binary and triary, now set their pipe colors depending on the attached pipe, example:
    Image
  • Vents, scrubbers and injectors now show the pipe connected properly.
    Image

Github branch for those interested: https://github.com/Donkie/-tg-station/commits/pipes

Re: Pipes update

PostPosted: Fri Apr 25, 2014 11:39 pm
by Bluespace
This is perfect.

Re: Pipes update

PostPosted: Fri Apr 25, 2014 11:41 pm
by Psyentific
I'd like it if the pump direction arrow was more prominent, otherwise A+ 10/10

Re: Pipes update

PostPosted: Fri Apr 25, 2014 11:42 pm
by Donkie
Psyentific wrote:I'd like it if the pump direction arrow was more prominent, otherwise A+ 10/10

Yeah I'm no spriter, but I had to throw up something because the red ribbon looked shit with a red pipe underneith. Anyone is free to help.

Re: Pipes update

PostPosted: Sat Apr 26, 2014 12:09 pm
by vista
Perhaps you could make that ribbon use the negative of the current colour. It won't look as good, but it will certainly be visible on all colors.

Re: Pipes update

PostPosted: Sat Apr 26, 2014 12:11 pm
by Donkie
That'll probably look worse than what it is currently. Surely it would work, but IMO a better sprite is the better alternative.

Re: Pipes update

PostPosted: Sat Apr 26, 2014 7:34 pm
by MisterPerson
I forgot to say this when I first saw this thread, but this is great stuff. Seriously, excellent work here.

Re: Pipes update

PostPosted: Mon Apr 28, 2014 12:34 pm
by AseaHeru
Have you found a use for tubing as well?

Because if you have, and if it is as a makeshift pipe, then you are a god.

Re: Pipes update

PostPosted: Mon Apr 28, 2014 7:12 pm
by Donkie
Tubing?

Re: Pipes update

PostPosted: Tue Apr 29, 2014 10:33 am
by flazeo25
Think aseaheru means the transport tubes/transport station, making them buildable/deconstructable for atmos.

Re: Pipes update

PostPosted: Tue Apr 29, 2014 3:16 pm
by Remie Richards
I think Asheaheru means the tubes in tubing.dmi.

Image

Re: Pipes update

PostPosted: Wed Apr 30, 2014 12:52 pm
by AseaHeru
That is what I mean, thank you Richards.
Although, building transport tubes sounds fun, but that would be in a different topic.

Re: Pipes update

PostPosted: Wed Apr 30, 2014 1:47 pm
by peoplearestrange
Nice job. Maybe the direction arrow could be colour though? or at least more prominent. Though its 1000x better than the red stripe with always confused me (In my mind the red strip should have been the blocking end not the direction of flow)