radiation_pulse called with negative intensity.

How, what and why to code in BYOND.

Moderators: MisterPerson, Code Maintainers

Booktower
In-Game Admin
 
Joined: Mon Apr 23, 2018 4:44 pm
Byond Username: Booktower

radiation_pulse called with negative intensity.

Postby Booktower » Sat Jan 05, 2019 1:29 am #467026

The SM may call radiation_pulse with huge negative values under some circumstances.
Does calling radiation_pulse with negative values cause issues? I was thinking of adding logging for this.
Related issue: https://github.com/tgstation/tgstation/issues/42141



Swindly
 
Joined: Wed Jul 27, 2016 5:21 pm
Byond Username: Swindly

Re: radiation_pulse called with negative intensity.

Postby Swindly » Sat Jan 05, 2019 2:11 am #467031

Code: Select all
/obj/item/clothing/head/helmet/space/hardsuit/rad_act(severity)
   . = ..()
   rad_count += severity


This seems like a problem.

User avatar
Gun Hog
 
Joined: Sat Apr 19, 2014 5:19 am
Byond Username: Gun Hog

Re: radiation_pulse called with negative intensity.

Postby Gun Hog » Sun Jan 06, 2019 3:28 am #467268

Swindly wrote:
Code: Select all
/obj/item/clothing/head/helmet/space/hardsuit/rad_act(severity)
   . = ..()
   rad_count += severity


This seems like a problem.


"rad_count" is for the Geiger counter noise.

User avatar
Cobby
Code Maintainer
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: radiation_pulse called with negative intensity.

Postby Cobby » Sun Jan 06, 2019 9:51 pm #467393

we should make it absolute value so it just deletes the station lol
Voted best trap in /tg/ 2014-current


Return to Coding

Who is online

Users browsing this forum: No registered users