Page 1 of 1

radiation_pulse called with negative intensity.

PostPosted: Sat Jan 05, 2019 1:29 am
by Booktower
The SM may call radiation_pulse with huge negative values under some circumstances.
Does calling radiation_pulse with negative values cause issues? I was thinking of adding logging for this.
Related issue: https://github.com/tgstation/tgstation/issues/42141

Re: radiation_pulse called with negative intensity.

PostPosted: Sat Jan 05, 2019 2:11 am
by Swindly
Code: Select all
/obj/item/clothing/head/helmet/space/hardsuit/rad_act(severity)
   . = ..()
   rad_count += severity


This seems like a problem.

Re: radiation_pulse called with negative intensity.

PostPosted: Sun Jan 06, 2019 3:28 am
by Gun Hog
Swindly wrote:
Code: Select all
/obj/item/clothing/head/helmet/space/hardsuit/rad_act(severity)
   . = ..()
   rad_count += severity


This seems like a problem.


"rad_count" is for the Geiger counter noise.

Re: radiation_pulse called with negative intensity.

PostPosted: Sun Jan 06, 2019 9:51 pm
by Cobby
we should make it absolute value so it just deletes the station lol