Page 1 of 1

Techweb Related Code Bounties

Posted: Mon Jun 17, 2019 11:17 pm
by Yakumo_Chen
I will pay 5usd for each list following list point. they may be in separate PRs or grouped if you feel you can push multiple points in one PR. If you feel a point requires more work then 5usd can justify, I can negotiate.

-Move Bag of Holding to its own node after Tier 4 parts (Advanced BS I think?). 5000 tech points.
-Ability to halt research point generation of Research servers through the console in the server room.
-Logging on RnD console of the last tech researched, who did it, and GPS coordinates of console used. Downstream servers should have this code if a port would be easier.

-Ability for Research Director access to set tech nodes to high priority (moves to top of list and makes it stand out some way)
-Ability for Research Director access to block (and unblock) tech individual tech nodes from being researched. Emagged consoles can bypass.
-Less related but I still want it: bags of holding and body bags of holding make a very small explosion and qdel when placed inside each other (to prevent boh bomb cheese)


Pre tech webs, the RD was able to more easily actually direct research (Primarially through the server console). I hope to bring some of this back through these, so the title "Research Director" means something again, and allows some means of sabotage that is more subtle (by halting point gen) and also to make it harder for people to build consoles to steal all the points without science being able to find out and know who to lynch.

Re: Techweb Related Code Bounties

Posted: Mon Jun 17, 2019 11:31 pm
by knacker48
Is that halting of research points just for antags to sabotage RnD or is there some non-harmful reason you see for doing it?

Re: Techweb Related Code Bounties

Posted: Mon Jun 17, 2019 11:35 pm
by Yakumo_Chen
Gives the server consoles a use again since all they do is list the servers that are two tiles away regardless. You used to be able to delete research from it before tech webs.

Gives the RD a bit more sway over research, they can threaten to turn off servers if security or something is building research insoles and stealing all the points without needing to physically destroy them.

Similar to the fact that the CE can turn off gravity or halt power if he feels slighted in some way. You mainly will see antag doing it but sometimes there will be valid reason to.

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 1:09 am
by dapocalypse
Can i give this a thicc claim

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 12:15 pm
by FloranOtten
Can I dibs on

-Move Bag of Holding to its own node after Tier 4 parts (Advanced BS I think?). 5000 tech points.

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 9:02 pm
by dapocalypse
FloranOtten wrote:Can I dibs on

-Move Bag of Holding to its own node after Tier 4 parts (Advanced BS I think?). 5000 tech points.
Bruh

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 10:58 pm
by Yakumo_Chen
I don't intend to reserve these for anyone, I figure whoever wants to code them can civilly sort it out amongst each other.

Just let me know in thread I guess when you pr and PM me a payment method when it's up to snuff.

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 11:16 pm
by Qustinnus

Re: Techweb Related Code Bounties

Posted: Tue Jun 18, 2019 11:26 pm
by Yakumo_Chen
As for the reasoning behind the bag changes, I've never liked the fact you unlock then wither tier 4 parts. The parts are always useful, but the bags tend to be more trouble then they're worth, and a pretty powerful item in their own right.

Also being able to boh bomb by hiding one in a body bag of holding in your pocket is cheesy and gay because you can't detect it.

Re: Techweb Related Code Bounties

Posted: Sat Jun 22, 2019 11:54 pm
by zxaber
Why not place the logging onto the console in the server room? You could totally have a full list of all tech researched, ore silo style, instead of only the most recent.

Re: Techweb Related Code Bounties

Posted: Sun Jun 23, 2019 2:44 am
by Yakumo_Chen
That's an option as well. However, I know for a fact that downstreams have the last tech research listed on the RnD console, along with who did it, and where. Coders will probably find it less work to port then to write a whole new thing.

Re: Techweb Related Code Bounties

Posted: Sun Jun 23, 2019 5:53 am
by zxaber
The other question is what to do if someone just removes their ID before getting the tech? Sure, we can find what console they used, but it'll show up as "Unknown" for the user. Is that fine and dandy?

Also, on an unrelated note; how do we feel about golems getting to research things? I suppose you could block their console, but they'd just be able to print more boards from the circuit imprinter and keep going. The other option would be making all consoles unable to research by default, and then manually setting the two in science, and the first board that golems get to be unlocked at round-start. That way the golems only get locked if they're being a pain in the ass, and it also stops engineering from becoming Science Bravo. I might try doing this one too, after the history one.

Re: Techweb Related Code Bounties

Posted: Sun Jun 23, 2019 6:51 am
by Tlaltecuhtli
doesnt the golem ship havea static tele beacon? just maxcap them if they are griefing with rnd points

Re: Techweb Related Code Bounties

Posted: Sun Jun 23, 2019 10:43 am
by zxaber
True, but we could just as easily add functionality to shut off their research tech while we're already here. It wouldn't really be too much extra work, and I like the idea of restricting Engineering's ability to just convert their RD console from production mode to research mod.

Anyway, while looking through and setting up code for the logs and console disabling, I ended up getting most of the halting points thing done.
Spoiler:
This screenshot is like way bigger than it should have been.
servercontroller.png
servercontroller.png (9.36 KiB) Viewed 5146 times
I figure the console locking and logs could either come after, or else be on tabs selected from the top. It makes the most sense to me that they would be on the server controller console. Turns out there's already logging done for researching nodes, it just doesn't display anywhere (that I know of) yet.
serverlogs.png
serverlogs.png (7.21 KiB) Viewed 5146 times
Is area location good, or do you want exact coordinates too?

Re: Techweb Related Code Bounties

Posted: Sun Jun 23, 2019 10:11 pm
by Yakumo_Chen
Exact coordinates would be preferred, science already works with GPS units and it's similarly in line with AI upload (that shows straight up on GPS however).

The console reading ID is fine, I want to allow for some amount of deception. For the same reason I'm actually against the wholesale disabling of consoles. Science should have some control over research (by prioritizing and disabling specific nodes or halting points) but I don't want them to be able to easily completely monopolize the system.

Re: Techweb Related Code Bounties

Posted: Mon Jun 24, 2019 7:50 am
by zxaber
Disabling point regen and research log.
https://github.com/tgstation/tgstation/pull/44783

Re: Techweb Related Code Bounties

Posted: Wed Jun 26, 2019 5:00 am
by Yakumo_Chen
Quick update: The bag of holding PR has been merged. Someone who hasn't posted in this thread has also offered to do the block and priority points as well. I have also been asked via PM about the final point.

Re: Techweb Related Code Bounties

Posted: Sun Jul 14, 2019 1:35 am
by Yakumo_Chen
The person coding the last two major points has been unresponsive, in case anyone wanted to beat them to it.

I believe Questinus also asked me about the last point, the body bag of holding nerf, but I don't believe they made a PR, so it's probably up for grabs as well.

Re: Techweb Related Code Bounties

Posted: Thu Jul 18, 2019 11:45 pm
by nicbn
They aren't body bags of holding, they are bluespace body bags. They can only contain 15 mobs and 30 total items, and currently cannot contain another bluespace body bag. They are thematically different from bags of holding, it doesn't make much sense to make them explode because bags of holding will do too.
Do you still want this change?

Re: Techweb Related Code Bounties

Posted: Sat Jul 20, 2019 2:45 am
by Yakumo_Chen
nicbn wrote:They aren't body bags of holding, they are bluespace body bags. They can only contain 15 mobs and 30 total items, and currently cannot contain another bluespace body bag. They are thematically different from bags of holding, it doesn't make much sense to make them explode because bags of holding will do too.
Do you still want this change?
The change I want is to prevent people from carrying the BoH inside a bluespace body bag, so they be unable to to BoH bomb with a pocket-sized item instead of a huge one.
The other way around should also work because being able to carry BoH-storage tier items inside BoHs isn't cool and it should make sense to have it work one way if it works the other way around.
I don't want the explosion to be large, or deadly, just big enough to teach people that you shouldn't be able to do it, not big enough to be used offensively. Something like a 0,0,0 from a PDA bomb or fireball.