Page 1 of 2

Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 9:48 am
by Stickymayhem
Alright fuckers

this change is so fucking bad and stupid that it's literally making me never want to admin again. this was possibly intentional and if so well played

I dont know who did this, I'm not going to go back and check because if I ever find out who did I will grudge them for years

here's my explanation of why it's shit.

https://streamable.com/vm1upr

I don't care what you do, you can fucking revert it for all I care, if it gets done, you get money. I don't care who I just want it to stop make it fucking stop MAKE IT STOP

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 9:56 am
by Not-Dorsidarf
In the inverse to most ss13 changes, I liked this one at first and grew steadily more annoyed with it as I used it more and more.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:14 am
by Thunder11
If I don’t know which category the verb I want is in, I have to search through then all whether they’re on different tabs or one long tab. If I do know, I now have to search for that category in the Tower of Babel Admin. This is in no way beneficial and serves only make it harder to find verbs.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:15 am
by Armhulen
You know I've barely noticed because I've entirely grown into using the command line

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:21 am
by terranaut
lol I immediately noticed this and complained about it when I was testing my code for the monkey sechailers for the toolbox tournament
its really awful (cant believe im agreeing with sticky on something)

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:22 am
by Thunder11
https://github.com/tgstation/tgstation/pull/53947

When you don’t post screenshots of the big change because people will hate it if you do.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:30 am
by Boris
Always used the command line, can't relate sorry!

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:33 am
by oranges
I'm not changing it, now fuck off

if you know what verb you want you can use the command line, if you don't know, having them all in one tab makes them discoverable.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:41 am
by Stickymayhem
oranges wrote:I'm not changing it, now fuck off

if you know what verb you want you can use the command line, if you don't know, having them all in one tab makes them discoverable.
muscle memory clicking on a verb is far quicker than typing into the command line and you know it

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:42 am
by oranges
I've heard a lot of things, but never have I ever heard as much bullshit as I have just heard right now

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:50 am
by Stickymayhem
oranges wrote:I've heard a lot of things, but never have I ever heard as much bullshit as I have just heard right now
why do you even care about this

Is this wasted whitespace in the default widescreen configuration here to "improve discoverability"?

Image

I actually just did the maths. Of 680 pixels in this screen, 190 are wasted useless whitespace as a direct result of this change. 28% of the fucking menu is literally by any possible metric, completely fucking useless

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 1:22 pm
by Nabski
Sticky please don't kill yourself over a video game change.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 1:38 pm
by bobbahbrown
do you have a weird screen resolution? on master i don't have an issue with the fourth column being absent at 1920x1080

Image

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 1:43 pm
by bobbahbrown
Thunder11 wrote:https://github.com/tgstation/tgstation/pull/53947

When you don’t post screenshots of the big change because people will hate it if you do.
If you click on the 'You can see video samples of both light and dark mode here on imgur.' directly below the screenshots you can see I very explicitly show the new Admin tab styling. I even make a point to scroll on it!

It's not very nice to imply I made this PR to hide anything, and I'd rather you don't imply that.

Best wishes,
bobbah "bee" brown

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 1:57 pm
by bobbahbrown
cobby tells me that he gets the 3 column thing too so i suspect it might be a bug. my other suspicion as to where it may come from is that if changing the window size is somehow persistent then you may have manually changed it at some point, and then that bad sizing is for some reason saved, could you try using the Fit-Viewport verb? just type fit in your verb bar, hit space, and then enter

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 2:51 pm
by bobbahbrown
update: i got sticky to try fit-viewport and it didnt help! i think it might be based on the browser that BYOND uses to render the panel maybe? there's something weird goin on there

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 7:21 pm
by Stickymayhem
bobbahbrown wrote:update: i got sticky to try fit-viewport and it didnt help! i think it might be based on the browser that BYOND uses to render the panel maybe? there's something weird goin on there
no worries our head coder has already declared this a feature and it will not be changed because he gitpushed his ego to the repo

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 7:44 pm
by Armhulen
Stickymayhem wrote:
oranges wrote:I'm not changing it, now fuck off

if you know what verb you want you can use the command line, if you don't know, having them all in one tab makes them discoverable.
muscle memory clicking on a verb is far quicker than typing into the command line and you know it
Image

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 7:51 pm
by Misdoubtful
I do prefer just using the command bar. Auto fill (very fast) and some command bar functions that buttons can't meet (like for vv) are just easier than learning a new layout, again. Since it never changes.

It's like the difference between doing things individually or doing them all at once through sdql.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 9:11 pm
by Cobby
I set fit-viewport to manual, set it to 4 columns, leave, rejoin, and I can literally see the menu force itself back to 3 column width.

I think it is something related to widescreen because when i set widescreen off (fit-viewport auto on) then set it back to on it's at the same position aka 3 columns it forced it to when I join.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Oct 26, 2020 10:41 pm
by skoglol
Cobby wrote:I set fit-viewport to manual, set it to 4 columns, leave, rejoin, and I can literally see the menu force itself back to 3 column width.

I think it is something related to widescreen because when i set widescreen off (fit-viewport auto on) then set it back to on it's at the same position aka 3 columns it forced it to when I join.
I dont play fullscreen and I've had window size reset on me to the same state for literal years, this is not new.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 12:19 am
by Cobby
i only had to set it once when i was on my older computers though to 4 columns, I know i didnt have to do it every round so it cant be that old.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 12:26 am
by zxaber
Am I the only admin that enjoys not flipping through three tabs to find the verb I need?

The only thing that bugs me is Tickets being the last tab.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 12:55 am
by PKPenguin321
Stickymayhem wrote:
oranges wrote:I'm not changing it, now fuck off

if you know what verb you want you can use the command line, if you don't know, having them all in one tab makes them discoverable.
muscle memory clicking on a verb is far quicker than typing into the command line and you know it
:roll:

that said i agree that the whitespace thing/important verbs being below meme buttons are pretty stupid changes but it sounds like one's a bug and the other would take ten seconds to fix so...

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 3:30 am
by cacogen
oranges wrote:I'm not changing it, now fuck off.
Who asked you to? Looking at the PR Thunder linked, it was made by bobbahbrown and merged by Rohesie. You didn't even comment on it. How is wanting it changed back a slight against you? You've done this with other things as well.
Stickymayhem wrote:
bobbahbrown wrote:update: i got sticky to try fit-viewport and it didnt help! i think it might be based on the browser that BYOND uses to render the panel maybe? there's something weird goin on there
no worries our head coder has already declared this a feature and it will not be changed because he gitpushed his ego to the repo
You have to just try to slip the fix past him and hope he forgets blocking it is interwoven with his ego now. My post will not help. I don't care, though.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 3:43 am
by bobbahbrown
cacogen wrote:
oranges wrote:I'm not changing it, now fuck off.
Who asked you to? Looking at the PR Thunder linked, it was made by bobbahbrown and merged by Rohesie. You didn't even comment on it. How is wanting it changed back a slight against you? You've done this with other things as well.
to give context on this oranges was the one who asked in adminbus if the PR was okay in the firstplace, so he did have a role in its development in that manner

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 3:45 am
by cacogen
I see. Is it so hard to take feedback on board and update it as a result of that though?

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 7:43 am
by Flatulent
dont do it, we dont want stickymayhem to admin ever again

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Tue Oct 27, 2020 6:41 pm
by Cobby
the scrolling is fine tho

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 2:27 am
by Naloac
its fine tbh, just make it an option if you have to change it AGAIN

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 5:43 am
by Nalzul
just type the commands lol, its way faster than using the menu unless you dont know what the name of what youre doing is

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 7:57 am
by oranges
cacogen wrote:
oranges wrote:I'm not changing it, now fuck off.
Who asked you to? Looking at the PR Thunder linked, it was made by bobbahbrown and merged by Rohesie. You didn't even comment on it. How is wanting it changed back a slight against you? You've done this with other things as well.
Stickymayhem wrote:
bobbahbrown wrote:update: i got sticky to try fit-viewport and it didnt help! i think it might be based on the browser that BYOND uses to render the panel maybe? there's something weird goin on there
no worries our head coder has already declared this a feature and it will not be changed because he gitpushed his ego to the repo
You have to just try to slip the fix past him and hope he forgets blocking it is interwoven with his ego now. My post will not help. I don't care, though.
Image

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 10:48 am
by Stickymayhem
oranges wrote:
cacogen wrote:
oranges wrote:I'm not changing it, now fuck off.
Who asked you to? Looking at the PR Thunder linked, it was made by bobbahbrown and merged by Rohesie. You didn't even comment on it. How is wanting it changed back a slight against you? You've done this with other things as well.
Stickymayhem wrote:
bobbahbrown wrote:update: i got sticky to try fit-viewport and it didnt help! i think it might be based on the browser that BYOND uses to render the panel maybe? there's something weird goin on there
no worries our head coder has already declared this a feature and it will not be changed because he gitpushed his ego to the repo
You have to just try to slip the fix past him and hope he forgets blocking it is interwoven with his ego now. My post will not help. I don't care, though.
Image
love you

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 5:59 pm
by Vekter
How much is the bounty

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Wed Oct 28, 2020 6:08 pm
by trollbreeder
Vekter wrote:How much is the bounty
Sixty bananas. Sixty bucks. Sixty one dollar bills. Sixty pencils to shove up your nose. Sixty. Six times ten. Two times three times ten. Sixty balloons. 60$

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 10:46 am
by Stickymayhem
Vekter wrote:How much is the bounty
S I X T Y D O L L A R Y D O O S

but you have to best oranges in the github arena as well

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 2:38 pm
by terranaut
Stickymayhem wrote: but you have to best oranges in the github arena as well
that's not how code bounties are handled because its out of the hands of the guy fulfilling the code bounty.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 5:44 pm
by Stickymayhem
terranaut wrote:
Stickymayhem wrote: but you have to best oranges in the github arena as well
that's not how code bounties are handled because its out of the hands of the guy fulfilling the code bounty.
ITS HOW THIS CODE BOUNTY WORKS AND THE PRICE REFLECTS THE EFFORT

I THOUGHT YOU LIKED CAPITALISM

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 5:47 pm
by bobbahbrown
Stickymayhem wrote:
terranaut wrote:
Stickymayhem wrote: but you have to best oranges in the github arena as well
that's not how code bounties are handled because its out of the hands of the guy fulfilling the code bounty.
ITS HOW THIS CODE BOUNTY WORKS AND THE PRICE REFLECTS THE EFFORT

I THOUGHT YOU LIKED CAPITALISM
code bounty is for code not for pr merge

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 8:34 pm
by cacogen
Yeah you work on the code and get paid for that work regardless of whether a maintainer immediately closes it you yuppie

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 11:08 pm
by BONERMASTER
Ok, how about 120$ to leave the admin menu as it is?

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Thu Oct 29, 2020 11:20 pm
by PKPenguin321
BONERMASTER wrote:Ok, how about 120$ to leave the admin menu as it is?
I'll take it, now pay up

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Fri Oct 30, 2020 2:49 am
by capn_monkeypaw
I'll do it for $115.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Fri Oct 30, 2020 10:13 am
by Stickymayhem
i'll do it for $100 they never took my remote away

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Sat Oct 31, 2020 2:17 am
by cacogen
Image
Stickymayhem manually reverts pull request #53947 (2010)

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Nov 02, 2020 12:23 am
by JusticeGoat
For the love of god please give me back my separated tabs like before 100% agree with sticky the new admin tab is terrible.

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Nov 02, 2020 2:32 am
by Whoneedspacee
yeah honestly this is gay as fuck for debugging whenever i want to spawn a megafauna i have to scroll to the bottom whereas it was easy as fuck beforehand

also if your screen margins change the tiniest bit you have to re-find the fucking button since it changes position massively whenever the column moves

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Nov 02, 2020 11:45 am
by trollbreeder
honestly for debugging i prefer having everything in one place because then i can look around to find what i want to use without becoming lost in the categories like the spawn reagent verb

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Nov 02, 2020 3:37 pm
by bobbahbrown
for those of you who are displeased with my change: sorry

Re: Code Bounty:FIX THE FUCKING ADMIN MENU $60

Posted: Mon Nov 02, 2020 4:12 pm
by Stickymayhem
bobbahbrown wrote:for those of you who are displeased with my change: sorry
help pls