Page 1 of 1

Code bounty: Printable Portraits

Posted: Fri Apr 16, 2021 8:36 am
by carshalash
Basically, I want there to be a way for portraits to be printable/orderable in some method. Traz did something somewhat similar with AIs being able to change their core sprites to portraits, as shown here
https://github.com/tgstation/tgstation/pull/53994

Preferably it would be something tied in with the library book ordering system, if there is a better method you can think of then go ahead.

Payment will be $20 probably, I don't know if this is reasonable or not so if you want to discuss it go ahead.

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 4:35 am
by carshalash
Alright, it's been a month. Bumping this up to $30 to hopefully entice people.

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 9:00 am
by Armhulen
Fine, i'll do it tomorrow if nobody does it first. I was meaning to awhile back but I just kinda forgot

but please be a tiny bit more specific on what you want the portraits to be and how you want to obtain them
carshalash wrote:Preferably it would be something tied in with the library book ordering system, if there is a better method you can think of then go ahead.
The better method I suggest is literally any other method (hell, even a new machine for it), the library book ordering system is REALLY bad. Like, I'm pretty sure that code is 100% off limits unless you're fixing up the endless code issues or removing it entirely for a better system

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 10:16 am
by carshalash
Honestly, printing them from anywhere is fine. I just want a system of sort where you can print premade portraits that can be hung up in places.

I thought of cargo order for a bit but then I realized it would probably be too difficult, so some sort of computer or machine that can look through the servers portrait database and print/manifest things people have made would be neat.

Thank you arm <3

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 10:18 am
by Armhulen
Ok... I was pretty bored so its up minus the mapping and some js https://github.com/tgstation/tgstation/pull/59146. I went with modular console in the hopes that at some point in the future we move more of the curator's billion machines into programs on the console, though book management has comments wailing about its power level since 2012 so I'm not sure who is gonna go for that.

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 10:22 am
by carshalash
Sweet, Rave pointed out that there is a chance that portraits may get duplicated when put in the library portrait area if they're already in the database. Think this will be an issue?

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 10:25 am
by Armhulen
I may have to plan around this but my first thought is not letting printed canvases count as something that should be added to the database. All the icons get converted into md5s which should mean the same icon will always make the same md5 so maybe I should be checking for dupe portraits in persistent saving instead

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 9:00 pm
by Mickyan
For what it's worth there's already issues with portraits getting duped, as you can see on statbus. I know it can be done by moving a persistent painting to a different category but occasionally it seems like some paintings also get saved in the same category more than once, I do not know why.

It would probably be for the best if any portrait loaded from persistence was automatically ignored during saving

Re: Code bounty: Printable Portraits

Posted: Sun May 16, 2021 9:34 pm
by Armhulen
Mickyan wrote:For what it's worth there's already issues with portraits getting duped, as you can see on statbus. I know it can be done by moving a persistent painting to a different category but occasionally it seems like some paintings also get saved in the same category more than once, I do not know why.

It would probably be for the best if any portrait loaded from persistence was automatically ignored during saving
Not a bad idea at all, but this is all bandaid for what I should really be doing which is making a list of md5s in the sspersistence and only allowing the first instance of md5 to exist

Re: Code bounty: Printable Portraits

Posted: Mon May 17, 2021 3:50 am
by Farquaar
Just for clarification: We're talking about paintings, right?

Re: Code bounty: Printable Portraits

Posted: Mon May 17, 2021 4:06 am
by Armhulen
Farquaar wrote:Just for clarification: We're talking about paintings, right?
Yeah.

Re: Code bounty: Printable Portraits

Posted: Tue May 18, 2021 8:05 pm
by cacogen
I love public art!