/tg/Station 13

no tl;dr

i was accused of making "half-assed PRs" earlier

i bust my ass every day for this shitty fucking community of caustic volatile 5 year olds just for them to take huge heaping clown-filled shits all over the work I made over multiple days, weeks, sometimes months, just for them to enjoy and experience

and here's why I make the changes I make:

part 1: the cause
so, there's usually 3 different types of causes

let's start with the 1st:
I played X feature, found it lacking

for example:
i play CE a lot
i noticed that my engineers below me are pretty much on the same level as me when it comes to shit
engineers have all access by default
engineers can take down any wall and build any structure
chief engineer has some fancy blueprints and a custom paintjob on their hardsuit

meanwhile, all the other heads have tools that make them better at their job than the people below them

the RD starts with teleport armor and shit he can use/decon from higher tech levels
the CMO starts with the hypospray and belt defib
the HoS starts with a dual stun/laser gun
the captain has all access and an auto-recharging laser gun
the HoP can disappear into thin air during a rev. round without ever being caught and can upgrade the access of others/himself

so, I coded a set of faster tools for the CE with golden sprites as a joke about how a lot of games have golden items being better stronger and faster despite being the weakest material IRL, and to let the CE have a one up on his subordinates when it comes to actually doing his job

cause 2:
people complained about X on the forums
for example:

people have recently been complaining that the prison break random event is shit due to only targeting the brig, doing it badly, and then not actually opening everything in the brig
i posted in the thread "yeah ill just make it apply to a random department or 2"
only 1 person acknowledges the post and says "id be fine with that" or some shit

so I coded a severity system for it and made it pick a random few departments with the amount based on the severity

cause 3:
i was bored and wanted a project

for example:
i was bored one day

i was recently digging through the gooncode

saw the wrasslin belt

felt like coding

so i ported it to tg

part 2: the aftermath

after the PR gets opened, I get the following comment types:

"goofball PR "
dont have much to say here, its the same old story every PR

"this doesn't fit the aesthetic"
everyone has their own opinion on what the aesthetic is, i just agree to disagree

"the code is bad" from someone who doesn't make PRs or code at all
learn to code and then come back

"the code is bad" from someone who does code but didn't specify what was wrong
great, specify whats wrong so I can fix it please

"the code is bad and here's why"
ok i can fix it

"this feature breaks the metagame"
why should the metagame never change, they never give a reason why it shouldn't

"it was fine the way it was"
i disagree with you on this one, you can have your opinions if you like

"i literally cannot play the game if this is merged"
yes you can
statistically speaking, you're full of complete and utter bullshit
unless it somehow makes it not run on a potato okay you can claim it then
but 999 times out of 1000 its not about that, its about muh balance

"go back to goon"
they aren't hiring

part 3: the post merge
shit either goes well or people kneejerk revert it because they cant handle the change, maybe it was even a bad change

i'm going to get shit if I close the PR before it gets merged because:
"ugh goofball you make too many PRs and then close them/never finish them stop halfassing it
or the PR gets merged and then:
"ugh goofball your PRs are shit stop making them so shit and getting them merged ugh"
damned if you do damned if you dont

anyways that concludes my ramblings

Goofball.. Code me a borg that can be made with human arms and legs... so it can pick things up

Most people who play this game will never contribute to it, so why should they complain about the people who do?

goof is really mad about people not liking his things

You don't have to code to say that stuff like disablers or Goofchem were shit. Your argument is invalid.

But seriously for how much I hate you sometimes for being a cuck Goof you do a lot of work and that's commendable.

Consider taking requests on stuff to code and people would probably change their tune on hating you/coders

robustin should make a thread about this too, but yes I totally agree people just -1 goof's prs because others do

I'm pretty sure most people disliked the PR because of the bad sprites.

Steelpoint wrote:I'm pretty sure most people disliked the PR because of the bad sprites.

what, the golden tools? I liked them! if that is goof's work that's a hell of a lot better than other coders do with spriting in general.

iamgoofball wrote:i play CE a lot
i noticed that my engineers below me are pretty much on the same level as me when it comes to shit
engineers have all access by default
engineers can take down any wall and build any structure
chief engineer has some fancy blueprints and a custom paintjob on their hardsuit

meanwhile, all the other heads have tools that make them better at their job than the people below them

so the hardsuit that is 90% rad immune and 100% fire immune is just a paintjob?
and the magboots that have no slowdown?
CE already has neat things already that make him better than engineers/atmos...

> goofchem is bad

Will you people fuck off with this already? Yes it was super easy to heal people with our old Chem. It was also fucking BORING. Now we have crazy shit like phlogiston, black powder, bath salts, meth, so much variety for shenanigans. The implementation was a little shitty but i can not imagine going back to our old chemistry system

it is true though there is a stigma with goofball that automatically gets his PRs hit with negative feedback

did you know krav maga was mostly coded by goofball, i just salvaged the code after his PR was closed, made it use action buttons, and rebalanced it a tiny bit? yet his PR was closed and mine was merged.

it really sucks too because goofball is actually one of our better coders. he really does make a lot of features for us which is more than most of the players here can say.

he can make controversial shit at times (goofchem REMOVE) but most of the time he's not as bad as people make him out to be.

Christ goof, chill out, you should know by now that the best way to code is to do it in silence and not give a shit about what other people think because otherwise you'll just get banned by lynchmobs

If people don't or can't provide reasoning for their criticism, just ignore them.
For people saying that 'if you don't contribute to the code you shouldn't critise people that do' - fuck you. This is genuinely one of the most retarded things ever, and only contributes to a hostile and insular environment that helps nothing but your thin skinned ego. While it doesn't mean they can just be massive shitters for no reason, providing that the noncoder plebs provide criticism that is well reasoned/backed up with proof etc, then it's just as valid as coming from someone who DOES contribute.

With goofchem, hilariously broken mechanics/bugs aside, basically no one ever had a problem with the non healing chems - what rustled people's jimmies was the fact that your argument for replacing trek (healing) chems literally made no sense.
Trekchems are far more versatile in terms of application methods, and yes shit like DD is comparatively strong/easy to get. So you replaced it arguing that trekchem was too strong/easy, yet you replaced it with chems that were even simpler, massively more potent, and lacked all the versatility of trekchems. And when people called you out on it, you backpeddled and argued to KEEP goofchems because THEY were more potent then trekchems???

Also, how are normal engineers anywhere near as good as the CE?
His hardsuit is the clear best on station, he has boots of notslow, and has motherfucking poly - slayer of spiders, stealer of revolvers, and spouter of memes.

>poly

literally useless

>hardsuit with rad + fire protection

you can get that from a firesuit and the right drugs mix

rad protection literally never comes up

>magboots of noslow

Okay, here's why magboots of noslow dont matter:
You only use magboots in zero-grav enviroments. Such as space. Where your hardsuit has a jetpack and stabilizer built in.

iamgoofball wrote:>poly

literally useless

>hardsuit with rad + fire protection

you can get that from a firesuit and the right drugs mix

rad protection literally never comes up

>magboots of noslow

Okay, here's why magboots of noslow dont matter:
You only use magboots in zero-grav enviroments. Such as space. Where your hardsuit has a jetpack and stabilizer built in.

A firesuit doesn't make you space proof or provide reasonable armour. Common firesuits don't even make you completely fire immune, unless that's been reverted recently.
Not everyone has access to giant stockpiles of drugs, and having to constantly pop a limited supply of pills vs just putting on a suit is a pretty clear disadvantage.

Also the CE also used to be one of the very few guys with round start access to the RCD - which was really his equivilent telearmour/hypospray (it was even a steal objective like the blueprints) but repeated memebuffs means those are fucking everywhere so eh...

You're right about the inbuilt jetpack, but inbuilt jetpacks are inherently unbalanced as fuck, and it looks like they'll soon get replaced with toggleable jetpacks instead, if not outright removed.
Also you dont need to wear the boots and hardsuit at the same time yo.

plenty of people use the magboots without the hardsuit on do you even play

Lets unleash the fury on this one. I'm still pretty pissed.

Your reasons for goonchem are paper thin, not to mention you're so very protective any attempt to change, nerf, revert any part of it results in a response from you far greater than the responses we offer to your PRs. Hell you screamed at me in caps lock for a good five minutes demanding that I don't touch it.

Your content makes me question why it's even needed. I think less things from goon would be nice. You don't take criticism in this way. It's your way or the highway.

The hissy fits if a maintainer refuses to merge your PR. You went about for more than 3 hours harassing maintainers in coderbus and the use of timers to harass them twice in 30 minutes until someone spoke up and told you they didn't like this attitude. They didn't want to merge it. You nailed your own coffin this time.

Oh but you won't take that. You got mad, defiantly reopened it, tried everything but you don't get it.

Nobody wants this content. Not anymore they don't.
You call yourself the code gypsy, maybe it's because you get thrown out of so many communities you force yourself to take a vacation and hope they forget about you.



That's your constructive feedback.

ShadowDimentio wrote:You don't have to code to say that stuff like disablers or Goofchem were shit. Your argument is invalid.

But seriously for how much I hate you sometimes for being a cuck Goof you do a lot of work and that's commendable.

Consider taking requests on stuff to code and people would probably change their tune on hating you/coders

PKPenguin321 wrote:it really sucks too because goofball is actually one of our better coders

Stop this. There are several coders that put in a lot more effort than goof to fix bugs or to create well thought out features that aren't "golden tools that are faster". This takes no effort whatsoever, except maybe from the spriter.

Stop commending goof for meme PRs so he can progress past that shit.

Goof you didn't listen to what phil said. Drop the ego and put in some effort. Take a vacation from features and start fixing PRs, but not like the bug fixes you did this week.

Nobody hates you. Except maybe that person that thumbs down your PRs automatically.

ShadowDimentio wrote:You don't have to code to say that stuff like disablers or Goofchem were shit. Your argument is invalid.

But seriously for how much I hate you sometimes for being a cuck Goof you do a lot of work and that's commendable.

Consider taking requests on stuff to code and people would probably change their tune on hating you/coders

You can think something is shitty, that's fine. But you better be able to back it up. It's your job to change the mind of the coder. It's not my or any other coder's job to make you or any player happy just because you complain.

It's also not goofball's job to rant endlessly about being unpopular, but he does it anyway.

goofhate is a meme

btw the golden tools were just too silly

the idea isn't terrible though

thx

SpinnerMaster wrote:Most people who play this game will never contribute to it, so why should they complain about the people who do?

There is such a thing as spamming PRs. Goof made ~320 PRs in the last 1.5 years and only ~130 got merged, that's a 40% merge rate, one of the lowest of all coders who ever coded for tgstation. In the last 1.5 years, maintainers had to review and discuss ~190 PRs from goof alone that ended up not getting merged, that's roughly 1 every 2.5 days. We complain about bad coders because they make maintainers lose time, time that could be used reviewing better PRs or coding more bugfixes and features.

The arguement that "he does it for free" doesn't work either.

As I've always said to both admins and coders going "WELL DUHH WHY DONT YOU TRY IT??!!!?!?!":
It's a volunteer position, you volunteered to do your job, I on the other hand, did not volunteer to eat shit daily for free, so perhaps maybe instead of trying to justify your bad decisions by the fact that you took this voluntary job how about you actually do your job?

iamgoofball wrote: >magboots of noslow

Okay, here's why magboots of noslow dont matter:
You only use magboots in zero-grav enviroments. Such as space. Where your hardsuit has a jetpack and stabilizer built in.

did you know active magboots work just like non-slip shoes

lzimann wrote:

iamgoofball wrote: >magboots of noslow

Okay, here's why magboots of noslow dont matter:
You only use magboots in zero-grav enviroments. Such as space. Where your hardsuit has a jetpack and stabilizer built in.

did you know active magboots work just like non-slip shoes

They're actually better since no-slips don't counteract no-grav or lube but the CE's boots do.

MisterPerson wrote:You can think something is shitty, that's fine. But you better be able to back it up. It's your job to change the mind of the coder. It's not my or any other coder's job to make you or any player happy just because you complain.

I try to give good arguments to why stuff is shit. I'm rarely listened to though.

That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

J_Madison wrote:Your reasons for goonchem are paper thin, not to mention you're so very protective any attempt to change, nerf, revert any part of it results in a response from you far greater than the responses we offer to your PRs. Hell you screamed at me in caps lock for a good five minutes demanding that I don't touch it.

you acted the same about virology a few weeks back when a goofmed bug occured during the test merge that was set up to catch oversights like this made stimulants have a few weird effects

i'll admit i get a bit annoyed when people touch goofchem but its because it's usually "remove goofchem bring back trekchem" and I don't want my work to go down the trash bin

J_Madison wrote:Your content makes me question why it's even needed. I think less things from goon would be nice. You don't take criticism in this way. It's your way or the highway.

i have the right to code
i also have the right to defend my positions on the code

J_Madison wrote:The hissy fits if a maintainer refuses to merge your PR. You went about for more than 3 hours harassing maintainers in coderbus and the use of timers to harass them twice in 30 minutes until someone spoke up and told you they didn't like this attitude. They didn't want to merge it. You nailed your own coffin this time.

when the only way to get a PR merged is to nag maintainers, I nag maintainers. I tried asking nicely and the only person who listened was raz who gave me the "its too much effort to press the green button" excuse.

J_Madison wrote:Oh but you won't take that. You got mad, defiantly reopened it, tried everything but you don't get it.

yup

J_Madison wrote:Nobody wants this content. Not anymore they don't.

going by the fact that the 3rd iteration of the PR https://github.com/tgstation/tgstation/pull/18262
has 4 upvotes and 0 downvotes, i think people do want it

J_Madison wrote:You call yourself the code gypsy, maybe it's because you get thrown out of so many communities you force yourself to take a vacation and hope they forget about you.

yup

Scott wrote:Stop this. There are several coders that put in a lot more effort than goof to fix bugs or to create well thought out features that aren't "golden tools that are faster". This takes no effort whatsoever, except maybe from the spriter.

Why does every PR have to be this highly detailed new system designed from the ground up? Why can't I propose a 8 line change as a buff to the CE instead of recoding a bunch of stupid shit just to buff the CE? You guys complained about massive sweeping redesigns and new shit, why are you bitching now that I'm trying to do simple shit?

when redesigning the wheel it doesn't need 15 sporks, neon lights, and a built in mini-fridge

Scott wrote:Goof you didn't listen to what phil said. Drop the ego and put in some effort. Take a vacation from features and start fixing PRs, but not like the bug fixes you did this week.

i do put in effort

i spend most of my time not spent working coding for SS13

i'm constantly thinking up ideas on how to do shit and methods to improve the game experience

i put a very large amount of effort into PRs, and I find it really fucking offensive to say that I don't put in effort

the PRs I drop and stop supporting that phil was so kindly giving us statistics for?

90% of them aren't going to be merged regardless of code quality

also another thing I dont have magical foresight that says whether something will be merged or not so dont tell me I should "know" if it'll get merged
because shit like golden tools aren't out of place compared to clowns, mimes, genetic catgirls, and fucking lizards with wings

phil235 wrote:There is such a thing as spamming PRs.

spamming PRs is "flooding the issue tracker with shittons of empty PRs with no line changes"
spamming PRs is not "coding stuff and submitting it"

phil235 wrote:Goof made ~320 PRs in the last 1.5 years and only ~130 got merged, that's a 40% merge rate, one of the lowest of all coders who ever coded for tgstation.

Yes. I code a lot of stuff. Not all of it is good in your eyes. I have the right to make a PR, I don't have the right to get it merged.

phil235 wrote:In the last 1.5 years, maintainers had to review and discuss ~190 PRs from goof alone that ended up not getting merged, that's roughly 1 every 2.5 days.

Okay. I code a lot of stuff for this game and some of it gets rejected. Do you expect me to magically know whether a PR is going to be merged or not?

phil235 wrote:We complain about bad coders because they make maintainers lose time, time that could be used reviewing better PRs or coding more bugfixes and features.

Quite frankly, it takes very little time at all to review a PR. The only time shit actually takes discussion is balance memes, and even then that's best shut up by telling Kor to make a decision.

ColonicAcid wrote:It's a volunteer position, you volunteered to do your job, I on the other hand, did not volunteer to eat shit daily for free, so perhaps maybe instead of trying to justify your bad decisions by the fact that you took this voluntary job how about you actually do your job?

I do my job though, look at phil's statistics up there. I code a lot more than most coders and submit a lot more PRs.

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

I made that post because that guy was talking about "why are there so many deleted posts??"
it was a funny meme

Golden tools were boss, fuck you guys.

I was talking to shadowdimentio, not you.

NikNakFlak wrote:I was talking to shadowdimentio, not you.

you can never tell these days

That's because you both shitpost wayy to hard so you can't tell who shitposting is referring to.
Also, stop typing half in meme lowercase and half in proper uppercase grammar, it's painful to read and makes you look stupid.

i code this way because im a victim
I code this way because I'm a victim.

Jesus, #Triggered

NikNakFlak wrote:That's because you both shitpost wayy to hard so you can't tell who shitposting is referring to.
Also, stop typing half in meme lowercase and half in proper uppercase grammar, it's painful to read and makes you look stupid.

i code this way because im a victim
I code this way because I'm a victim.

Jesus, #Triggered

i dont know What You're Talking about

I really liked the golden tools, yeah

Goof, well, because you do tend to completely churn out a bugridden mess with zero sense of game balance at all and then scream at the top of your lungs like a 2 year old when anyone mentions something bad about it. Like Goofchem was for the first few weeks, which took a fuckload of PR's afterwards to fix. Or like Goofmed was which I swear you didn't test anything on.

firecage wrote:Goof, well, because you do tend to completely churn out a bugridden mess with zero sense of game balance at all and then scream at the top of your lungs like a 2 year old when anyone mentions something bad about it. Like Goofchem was for the first few weeks, which took a fuckload of PR's afterwards to fix. Or like Goofmed was which I swear you didn't test anything on.

Read fhe thread

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

HEY GUYS REMEMBER WHEN GOOFMED WAS TEST MERGED?

I REMEMBER

AND THAT WAS ENOUGH OF GOOF CODE FOR ME

Please stay away from the github

Guys, wow, here's an idea...

Maybe find the maintainers merging goofball's shit and criticize them for not using their brains??? (hint hint razharas)

They're the ones with the authority here, you can't make goof stop coding things you don't like, but you CAN get maintainers' titles removed if you think they're actually not doing their job and letting the codebase burn. Sure, it's goofball's fault if he submits something that's buggy and unfinished, but ultimately the responsibility is on the !!!MAINTAINER!!! to make sure the code is good. I know maintainers can't physically test every PR that comes down the pipeline but if there's a trend of some guys merging goof's shit without taking the code or design further into consideration (HINT HINT WE HAVE A DESIGN LEAD NOW, MAYBE FUCKING USE HIM?) then they should have their titles removed.

And this is the last kind of thread I expected from goofball considering he's the one who told me in IRC PMs a long time ago to 'not let people get to you' or something, maybe take your own advice goof none of this shit matters in the end we are all dust and ash trying to fill our life with something that removes the boredom if only for a moment. I know I'm not the best one to be giving advice here but maybe let it go if people don't want your PR and learn to distinguish/ignore blind hate bias from legit criticisms, something I am totally awful at

make our station great again

goofstation 2020

ShadowDimentio wrote:

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

I'd like to think that most people agree with me. There's a reason you were put into the cuck shed and your complaint made into a joke.

NikNakFlak wrote:

ShadowDimentio wrote:

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

I'd like to think that most people agree with me. There's a reason you were put into the cuck shed and your complaint made into a joke.

Seconded

IrishWristWatch0 wrote:

NikNakFlak wrote:

ShadowDimentio wrote:

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

I'd like to think that most people agree with me. There's a reason you were put into the cuck shed and your complaint made into a joke.

Seconded

o f f t o p i c

IrishWristWatch0 wrote:

NikNakFlak wrote:

ShadowDimentio wrote:

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

I'd like to think that most people agree with me. There's a reason you were put into the cuck shed and your complaint made into a joke.

Seconded

Thirded

NikNakFlak wrote:

ShadowDimentio wrote:

NikNakFlak wrote:That's because most shit out of your mouth is retarded shitposting. See: Your most recent post in admin feedback

Well I mean if you had reading skills beyond a elementary schooler you could probably differentiate the two

I'd like to think that most people agree with me. There's a reason you were put into the cuck shed and your complaint made into a joke.

Because Goof shitposted the thread into oblivion

AND WE COME FULL CIRCLE, DUN DUNNNN

To be honest, I never could take goofball seriously, but not because of his features or because of his code - I actually find some features that I hear are made by him interesting. It's more about the general impression he gives. Like, just look at the typing style, the profile icon and some of the dumb comments now and then, and an impression is made.

If you don't really conduct yourself at least somewhat seriously, you can't expect people to take you seriously. It's an image thing, not a code thing, imo.

I agree. Goofball, stop making text LARGE AND BOLD TO TRY AND MAKE A POINT it's so fucking condescending and shitty, I'm sure a lot of people will immediately see you in a better light if you stop that, I used to do it (to be intentionally a dickhead) but you seem to think it's helping your message get across

i used large text here as it should be, to highlight important parts to read or to act as dividers between sections

you're going to divide my heart into sections if you keep using big text to condescend