Vendors - Product Ads?

[Cuboos]

Code: Select all

/obj/machinery/vending/dinnerware
	name = "\improper Plasteel Chef's Dinnerware Vendor"
	desc = "A kitchen and restaurant equipment vendor"
	product_ads = "Mm, food stuffs!;Food and food accessories.;Get your plates!;You like forks?;I like forks.;Woo, utensils.;You don't really need these..."
	icon_state = "dinnerware"
	products = list(/obj/item/weapon/storage/bag/tray = 8,/obj/item/weapon/kitchen/fork = 6,/obj/item/weapon/kitchen/knife = 6,/obj/item/weapon/kitchen/rollingpin = 2,/obj/item/weapon/reagent_containers/food/drinks/drinkingglass = 8,/obj/item/clothing/suit/apron/chef = 2,/obj/item/weapon/reagent_containers/food/condiment/pack/ketchup = 5,/obj/item/weapon/reagent_containers/food/condiment/pack/hotsauce = 5,/obj/item/weapon/reagent_containers/food/condiment/saltshaker = 5,/obj/item/weapon/reagent_containers/food/condiment/peppermill = 5,/obj/item/weapon/reagent_containers/glass/bowl = 20)
	contraband = list(/obj/item/weapon/kitchen/rollingpin = 2, /obj/item/weapon/kitchen/knife/butcher = 2)
/obj/machinery/vending/sovietsoda
	name = "\improper BODA"
	desc = "Old sweet water vending machine"
	icon_state = "sovietsoda"
	product_ads = "For Tsar and Country.;Have you fulfilled your nutrition quota today?;Very nice!;We are simple people, for this is all we eat.;If there is a person, there is a problem. If there is no person, then there is no problem."
	products = list(/obj/item/weapon/reagent_containers/food/drinks/drinkingglass/filled/soda = 30)
	contraband = list(/obj/item/weapon/reagent_containers/food/drinks/drinkingglass/filled/cola = 20)

Coderbus was too busy talking about other stuff to answer these question. Vendors contain a list called produc_ads that don't do anything. I've checked through the whole code and nothing calls them. I noticed this when i was working on some sounds for them. They aren't the phrases they say in world, those are under "produc_slogans". I'm not sure what to do with them, they seem to do nothing but bloat the code. Should i figure out a way to implement them? comment them out? delete them entirely? They seem redundant.

[Remie Richards]

supposed to appear in the UI.

[Cuboos]

supposed to appear in the UI.

I checked, it doesn't.

[Remie Richards]

supposed to appear in the UI.

I checked, it doesn't.

Read what I said.
I never said it appears in the UI, just that it's supposed to, that's clear enough from the comment on the definition.
all you need to do is split it into a list like how slogans is split, and then pick one each time the UI opens and style it nicely.
it's a black browser UI so it's just HTML.

[oranges]

You like forks?;I like forks.

No way we can't have this in our code, absolutely disgusting

[iamgoofball]

You like forks?;I like forks.

No way we can't have this in our code, absolutely disgusting

It already is

[Cuboos]

supposed to appear in the UI.

I checked, it doesn't.

Read what I said.
I never said it appears in the UI, just that it's supposed to, that's clear enough from the comment on the definition.
all you need to do is split it into a list like how slogans is split, and then pick one each time the UI opens and style it nicely.
it's a black browser UI so it's just HTML.

Oh. I guess i'll add them then, must have been removed when they were updated to TGUI.

[MisterPerson]

You like forks?;I like forks.

No way we can't have this in our code, absolutely disgusting

Just because some of the existing forks are bad doesn't mean all forks are bad. You're a hateful forkist, but that doesn't mean we all are. Some of my best codebases happen to be forks. What do you have to say about that? #notallforks

[ShadowDimentio]

#Forkwarnow

[The Ultimate Chimera]

I was hoping this was going to be poster ads for the vending machines. Rip my dreams.