/tg/Station 13

So I've been starting to code for /tg/, and have gotten a few things merged. My biggest commit was helping pubby with his mapping. A lot of PRs I've made have been criticized, and I usually make tweak PRs to see how the community would react to rebalances. A lot of my PRs were small buffs or debuffs, and oranges and others criticized me for making low-effort PRs. Really though I just wanted to see if people wanted something rebalanced, then gone ahead to polish it up. I don't want to spend a ton of time on a PR that will be dismissed over balance concerns in two seconds. An example of that being my navajo hatchets PR.

This brings me to my current situation. Right now if i try to interact at all with the github repo, I just get a notification saying that my action could not be completed at this time. I've let it go assuming it to be a bug, but after research it seems likely I was blocked from the repo. Not only am I blocked from making PRs, but I also cannot open issues, or comment on PRs or issues. I feel this is really not at all fair, considering I have made contributions, have bugs to report, feedback to give, and PRs to open. This was totally uncalled for. After all, the PR system is democratic. If you think my PR is stupid, don't merge it. Don't go and block me because i make PRs you don't like, especially considering I now have code merged on the server, and code to maintain.

You should probably take this to coderbus, but I do recall hearing oranges warning you that it you made another meme pr you would be banned.

I warned you if you kept making poorly constructed pr's that are designed to incite reactions rather than genuine attempts to improve the code that you would get shitcanned.

You kept doing it so you got shitcanned.

We don't have time to bother reviewing pr's from people who don't make a good faith effort to improve the code.

the stupid gun with your name on it that you snuck into the game is probably what killed you tbh

PKPenguin321 wrote:the stupid gun with your name on it that you snuck into the game is probably what killed you tbh

>your name on it
Player references are not allowed.

What gun was it?

> without warning
> got several warnings

???

@oranges

I warned you if you kept making poorly constructed pr's that are designed to incite reactions rather than genuine attempts to improve the code that you would get shitcanned.

The last comment you made on my last PR was this:

Low effort pr again, with poor implementation on a bad idea.

Please try to listen to the last piece of advice I gave you.

And then I was banned without even being told, or given a chance to "listen to your advice". My PRs aren't created for the sole purpose of inciting reactions, almost all of my prs are just small tweaks to existing things. The PRs which create reactions are the ones where I go and either A: modify weaponry or B: add features.


https://github.com/tgstation/tgstation/pull/21348
For example, in this PR i fixed an issue that made it only possible to craft lizard skin hats through the crafting menu. It was closed because it had a reference to smells the feet. Now I'm banned and lizard skin will probably never be fixed.

You only seem to complain about low effort on my tweak PRs that get closed

For example when I made some adjustments to the ATV crate I had added, the only comment you had was

TUNNEL SNAKES

That was a pr that was nothing except adding a few lines to a list of the gear in the ATV crate. Not even coding. yet because it's popular, you had no complaints about low effort.

In fact I even had this PR: https://github.com/tgstation/tgstation/pull/21358 that was a work in progress. I had finished the code on my computer locally, and was going to upload when I noticed that I had been banned. And on the PR that I hadn't finished you wrote:

Could you please
A) put more effort into your pr's on their first presentation
B) stop touching things you know will attract peoples attention in the wrong way

You're soaking up valuable maintainer time that could be better spent elsewhere.

I guess I'm not allowed to do work in progress PRs, and by the time I had it finished you had already banned me and commented this.

New coders are welcomed

New coders who have a merge rate lower than goofball and who touch a bunch of balance things that cause a lot of backlash as their first pr?
https://github.com/tgstation/tgstation/ ... s%3Aclosed

Earning the right to balance the game requires you to show up and prove your competence first.

No, we don't need more paprika's thank you.

I believe the PR where you were warned was something about the Pope, after a round occurred where a certain admin made sentient, evil popes?

...ah yes, found it
https://github.com/tgstation/tgstation/pull/21250

@oranges

oh look its someone who has an even lower merge rate than me and isnt gitbanned

https://github.com/tgstation/tgstation/ ... hor%3Ama44

also goofball is an experienced coder who adds large things a lot of people like, and while his PRs are hit or miss he's not a low bar.

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

tacolizard wrote:@oranges

oh look its someone who has an even lower merge rate than me and isnt gitbanned

https://github.com/tgstation/tgstation/ ... hor%3Ama44

ma44 was banned, though. on a couple occasions, i think.

also

meh my mergerate is relatively low but then again i fucked up a bunch of times and gave up on my own prs or had to remake them because i didn't know how to deal with conflicts wew

but uh, serious tip. Code things that add fun to the game without being a major balance discussion at first, and make bugfixes, expecially to your own code.

tacolizard wrote:

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

what is this meme where whenever someone doesn't get what they want they complain that whatever thing kicked them out isn't a democracy when it clearly never was one in the first place

is this the official last ditch argument?

My merge rate isn't a good comparison because my system wouldn't work if PRs weren't closed

looks like you were shot with your own .45, engraved on the side was "tacolizard forever [banned on github]"

tacolizard wrote:

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

It's not a democracy, it's a meritocracy. The last thing coderbus needs is memecoders, one goof is enough.

like what kevinz said, a lot of my closed prs i closed myself.

honestly the ban kinda came out of nowhere. The only time I had been warned about getting banned was with the praise the pope pr. Other than that a gitban was never threatened. the last comments you made on my prs just told me to listen you your advice. I had no real idea that i was close to being banned.

Scott wrote:

tacolizard wrote:

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

It's not a democracy, it's a meritocracy. The last thing coderbus needs is memecoders, one goof is enough.

One Goof is more than enough, but they still ain't throwing him out.

DemonFiren wrote:

Scott wrote:

tacolizard wrote:

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

It's not a democracy, it's a meritocracy. The last thing coderbus needs is memecoders, one goof is enough.

One Goof is more than enough, but they still ain't throwing him out.

Probbably because, as much as I dislike his stuff, he's still a net + to the coderbase

Not-Dorsidarf wrote:

DemonFiren wrote:

Scott wrote:

tacolizard wrote:

Earning the right to balance the game requires you to show up and prove your competence first.

A democratic system is broken if you can be thrown out for having a dissenting opinion

It's not a democracy, it's a meritocracy. The last thing coderbus needs is memecoders, one goof is enough.

One Goof is more than enough, but they still ain't throwing him out.

Probbably because, as much as I dislike his stuff, he's still a net + to the coderbase

Meh he codes good stuff sometimes even if he is a meme.
He doesn't spew memes 24/7.

But he does meltdown in coderbus sometimes

When goof has his meltdowns he's by far one of the most abrasive and toxic individuals I've ever met online and I think all of you are doing both him and the community a disservice by just shrugging and going "well that's just how he is"

Don't get jealous

Shaps wrote:When goof has his meltdowns he's by far one of the most abrasive and toxic individuals I've ever met online and I think all of you are doing both him and the community a disservice by just shrugging and going "well that's just how he is"

Were you not around for bloopers?

Shaps wrote:When goof has his meltdowns he's by far one of the most abrasive and toxic individuals I've ever met online and I think all of you are doing both him and the community a disservice by just shrugging and going "well that's just how he is"

This community has a bad problem with people who don't realize that their behavior is unacceptable and has to change.

oranges wrote:We don't have time to bother reviewing pr's from people who don't make a good faith effort to improve the code.

thanks for highlighting my most important improvement to the codebase

lol how do you get banned from an open source code project?

First kek of the day goes to bloopers.

paprika wrote:lol how do you get banned from an open source code project?

open source does not mean "i do whatever the fuck i want", you still need to comply with the project manager's goals/directives...

lzimann wrote:

paprika wrote:lol how do you get banned from an open source code project?

open source does not mean "i do whatever the fuck i want", you still need to comply with the project manager's goals/directives...

Lzimann. I suspect Paprika was actually being sarcastic/joking. Considering he kinda was banned from the Repo...