TGUI GPS

[Gun Hog]

Simply put, I would like to convert GPS units to TGUI! GPS units currently do not update on their own, making them a bit annoying to use. TGUI is built for handling auto-updating UI, for which the GPS is a perfect candidate! I have already spent a few hours learning how to handle the dark and mysterious magic that is the TGUI code to build a simple interface.

What do you players think? Would you like to see GPS put into TGUI? Why or why not?

Mechanics: Turning tracking off disables your view of the list and the ability of other GPS to see you. Click the tag to change your GPS tag.

EDIT: PR here: https://github.com/tgstation/tgstation/pull/26561

[kevinz000]

tbh nothing to be discussed here this is strictly making it better , don't see why there would be anyone who doesn't want this to be auto-updating as you can do it via hotkey already.

[BeeSting12]

Looks cool, can't wait to see this in the game

[Gun Hog]

There is a feature freeze on, so I will save this for the thaw

[christ110]

When doing telescience, I sometimes like to open the GPS window, and leave it open as a "snapshot" of positions. Maybe give me the option to turn auto-update off?

[oranges]

tbh nothing to be discussed here this is strictly making it better , don't see why there would be anyone who doesn't want this to be auto-updating as you can do it via hotkey already.

That would be true if ractive.js wasn't a hot mess.

[Cobby]

Gun hog discussed removing the window if you backpacked it though so I'd personally rather have that+nonauto than auto but the window is removed if I backpack it.

[ShadowDimentio]

I want this, the GPS as it stands is a huge pain to use.

[Gun Hog]

I have yet to figure out how to freeze the UI without completely breaking it. But, I will try to work something out. The key is to not lose any functionality. See Kev, you do not know what kind of feedback you will get until you ask!

[Remie Richards]

I have yet to figure out how to freeze the UI without completely breaking it. But, I will try to work something out. The key is to not lose any functionality. See Kev, you do not know what kind of feedback you will get until you ask!

really? couldn't figure it out?

Code: Select all

/datum/tgui/proc/set_autoupdate(state = 1)
    autoupdate = state

[Gun Hog]

I actually did, tyvm! Shortly after posting. You do not need to be so condescending, you know. Anyway, I can cancel the auto-updating now, and I will see about the window opening/closing next. I do not think any UI behaves that way though.

[lzimann]

I actually did, tyvm! Shortly after posting. You do not need to be so condescending, you know. Anyway, I can cancel the auto-updating now, and I will see about the window opening/closing next. I do not think any UI behaves that way though.

You probably missed my message in coderbus, but the tgui subsystem has a proc called close_uis, which let's you pass an atom as argument, and it will close every open UI linked to that atom.

[Gun Hog]

Added interface 'snapshotting':

Spoiler:

I set the interface to use the same vision checks as tablets. You can drop them on the ground and walk away a bit (if you are not adjacent, you cannot press buttons but still see it until you go a few steps away), you can hold them in your pocket or belt, but if you put it away, you can no longer physically see the GPS, thus the interface closes. I used the force-close tip from Izimann to disable the interface when the GPS is EMP'ed. If you simply turn it off, you still have the interface and controls, but not your location or the other GPS signals.

I am sorry, ExcessiveCobblestone, but I cannot implement your suggestion. But, auto-updating GPS with a manual updating option, distance and direction to target, as well as being able to tell your own location without having to find your tag in the list is a substantial improvement in my opinion. I am hoping that you find this one drawback acceptable.

I am also going to work on changing how I feed the GPS data to the UI, so I can format it a little better, such as adding a °(degrees) symbol to the direction reading so players more easily realize what it is.

[Remie Richards]

a degrees symbol should not be in the data.
the degrees symbol should be in the .ract file only.

[Gun Hog]

a degrees symbol should not be in the data.
the degrees symbol should be in the .ract file only.

I know, I tried it both ways and found that I could only do it in the .ract. That is why I need to redo how I send data, I have too much data grouped in the same string, preventing such customizations.

[Gun Hog]

I have added a z-level filter for the interface such that irrelevant signals can be ignored. Explorers and telesci operators are interested in off-z-level signals, but miners only care about chasing down megafauna and finding their way back home. This is useful for rescue teams as well.

Spoiler:

[Gun Hog]

It is happening! https://github.com/tgstation/tgstation/pull/26561