/tg/Station 13

Code: Select all

<Remie|BlueRevolver> I also hate the PR
<Remie|BlueRevolver> as evidenced by my -1 and my lack of helping
<PKPenguin321> ok but
<PKPenguin321> why
<PKPenguin321> reeeeeeeee
* Cyberboss has quit (Quit: http://www.kiwiirc.com/ - A hand crafted IRC client)
<Remie|BlueRevolver> literal meme
<Joan> I know HOW to fix your issue... but I'm not going to, since I think the feature it's supporting is dicks.
<Jalleo> memes end up causing bugs and getting removed
<LeoZ> examine reaction is really far from ideal tbh
<PKPenguin321> yeah but mob examine is supremely fucky
<Joan> it could technically be useful but as it is there it is not useful
<Remie|BlueRevolver> also
<Remie|BlueRevolver> that's a fair point
<Remie|BlueRevolver> I hate the code you've put up
<PKPenguin321> i was thinking of using special examine messages for a lot of abstracts
<Remie|BlueRevolver> just
<Remie|BlueRevolver> you know
<PKPenguin321> like chainsaw arms could throw a message like "Their arm has been replaced by a chainsaw" instead of just nothing
<Joan> you should have fucking started with that then
<Remie|BlueRevolver> override examine()?
<Remie|BlueRevolver> you mean mob shit
<Remie|BlueRevolver> well
<Remie|BlueRevolver> we just cram that into mob examine
<Remie|BlueRevolver> it's shit
<PKPenguin321> that is what i did
* atlanta_ned has quit (Read error: Connection reset by peer)
<PKPenguin321> i put it in mob examine
<Remie|BlueRevolver> but it's better than your weird mini-framework
<Joan> if you want a framework for something like that you should use it for the things that are the issues first and memes later
<PKPenguin321> eh i guess
<PKPenguin321> i can just undo the last two commits and cut out the examine functionality for now
<PKPenguin321> if youre all so adamant about it
* Jalleo has quit (Quit: see ya)
<octa91> see my comments. circlegame/examine_reaction shouldn't do identical things to examiner and owner
<Remie|BlueRevolver> I'm platinum about it
<Joan> also the meme is... not getting in
<Joan> it's just not happening.
<PKPenguin321> i dont get why
<PKPenguin321> players want it
<PKPenguin321> i did it with emotes instead of like slapping and shit
<PKPenguin321> which was terrible
<octa91> maybe the part where it brings a half-implemented system?
<PKPenguin321> yeah i already said i can revert that
<Remie|BlueRevolver> slapping isn't a meme
<PKPenguin321> it was implemented terribly is what im saying remie
<PKPenguin321> which is supposedly why it was nixed
* octa91 has quit (Quit: Leaving)
* NikNakFlak (~NikNakFla@Nik.Nak.Flak) has joined
<LeoZ> i dislike people using "people want this" as an excuse to add something
* Cyberboss (Cyberboss@Rizon-AE01C82C.static.comm.cgocable.net) has joined
* ChanServ gives channel half-operator status to Cyberboss
<NikNakFlak> is it because nobody likes you what you add
<NikNakFlak> like those two PRs
* Miauw has quit (Read error: Connection reset by peer)
<JainsMadison> LeoZ what is the criteria for lobby music?
<LeoZ> idk
<Ergovisavi> "Players want this" != "This is good for the game"
<PKPenguin321> why is it bad for the game
<PKPenguin321> literally what harm
<LeoZ> popular doesnt mean good, impopular doesnt mean bad
<JainsMadison> I wanted to put the miami vice crockett's theme into the game
<JainsMadison> because it's such a warm, bright theme.
<LeoZ> not necessarily bad for the gam
<PKPenguin321> ok stop throwing generalizations
<PKPenguin321> explain to this specific feature
<PKPenguin321> why
<LeoZ> but the code is kinda bad/bad way to implement such thing
<Ergovisavi> Because every single feature, large or small, must be maintained
<PKPenguin321> i am undoing the bad implementation
<Ergovisavi> Or it has to spend maintainer time being axed
<Ergovisavi> And then that's just a whole new plate of drama
<Ergovisavi> Because no matter how insignificant or shit something is
<Ergovisavi> If it goes, someone whines and whines
<PKPenguin321> better close every open PR
<Mrs_Sybil> GAME: New round starting on Delta Station!
<NikNakFlak> speaking of lobby music one sec
<PKPenguin321> if youre saying this thing that im adding is too much work to maintain or something equally retarded then you must be the laziest fucker in the IRC
<PKPenguin321> literally 1 emote as part of the easy to use emote datums we have
<Joan> we're saying what you're trying to add will get axed later since it's not good enough
<PKPenguin321> again, youve said something that goes in general and have avoided arguing against this actual feature
<TheGhostOfWhibyl1> [tgstation] Niknakflak opened pull request #29041: Revert "Removes title4.ogg" (master...revert-28882-Cyberboss-patch-2) https://github.com/tgstation/tgstation/pull/29041
<PKPenguin321> joan, who will care enough to axe it
no more responses at this point