Config Change: Antag Rep Edition

Locked
subject217
Github User
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Config Change: Antag Rep Edition

Post by subject217 » #437453

Okay, basically what I'm suggesting is one part config change, and one part code change (although it could be handled via config, it'd be more work.)

This functionally configures the antag rep system to work like Pseudo-RNG from Dota 2.

Here are the changes:
ANTAG_REP_MAXIMUM 350 -> 100
MAX_TICKETS_PER_ROLL 150 -> 100

But what does this mean?

Basically, the current way antag rep works is that the roll is calculated based on an "initial" value of 100 for each player, with a certain amount of tickets being added onto that based on how many the player has. If they succeed in the roll, they will lose those tickets that they had stored, but if they fail the roll, they will keep them. And every time you play a role, you get 10 more tickets (or 7 for assistant).

The problem with the system as it currently stands (aside from the "it should be purely RNG" claim) is that players who play a lot will keep more of their antag rep around, and new players or people who just don't play a lot since it was added have to play for a long time to build up this rep.

My suggested changes basically make it so that you can only double your chance of rolling for antag compared to the base chance anyone gets, and when you win your chances are reset entirely instead of just being dropped down a bit. The latter part is the particularly important bit.

The code change/config with work change would be setting Assistant to earn 5 rep per round instead of 7. The rationale for this is that with a lower max antag rep the impact of Assistant earning less rep is reduced. The dev of antag rep included a config option for custom job reps that differ from what the code itself says, which is currently not used by the server, but it'd be very easy to set up. Or I could open a PR on GitHub and change it, but since these two systems are tied (config and non config) it'd make more sense to do it all as a config change.
User avatar
BeeSting12
Joined: Sat Apr 16, 2016 1:11 am
Byond Username: BeeSting12
Github Username: BeeSting12
Location: 'Murica

Re: Config Change: Antag Rep Edition

Post by BeeSting12 » #437457

How about we remove antag rep instead?
Edward Sloan, THE LAW
Melanie Flowers, Catgirl
Borgasm, Cyborg
Spoiler:
OOC: Hunterh98: to be fair sloan is one of the, if not the, most robust folks on tg

DEAD: Schlomo Gaskin says, "sloan may be a faggot but he gets the job done"

DEAD: Rei Ayanami says, "YOU'RE EVERYWHERE WHERE BAD SHIT IS HAPPENING"
DEAD: Rei Ayanami says, "IT'S ALWAYS FUCKING EDWARD SLOAN"
oranges wrote:Bee sting is honestly the nicest admin, I look forward to seeing him as a headmin one day
[2020-05-21 01:21:48.923] SAY: Crippo/(Impala Chainee) "Shaggy Voice - She like... wants to get Eiffel Towered bro!!" (Brig (125, 166, 2))
hows my driving?
subject217
Github User
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: Config Change: Antag Rep Edition

Post by subject217 » #437459

BeeSting12 wrote:How about we remove antag rep instead?
Not what this thread is about. Many, many, many different people have discussed removing or disabling antag rep many different times, and it is still a discussion that is worth having, just not here.
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: Config Change: Antag Rep Edition

Post by oranges » #437460

this useless deadweight of code has produce no obvious change in player behaviour and therefore should be removed completely
subject217
Github User
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: Config Change: Antag Rep Edition

Post by subject217 » #437463

oranges wrote:this useless deadweight of code has produce no obvious change in player behaviour and therefore should be removed completely
The objective of this config change isn't to induce change in player behavior, it is to make antag rolls more fair by increasing the odds for people who get unlucky, and that's it. You are a head coder, you could remove it if you wanted to.
User avatar
Arianya
In-Game Game Master
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: Config Change: Antag Rep Edition

Post by Arianya » #437544

oranges wrote:this useless deadweight of code has produce no obvious change in player behaviour and therefore should be removed completely
Also its disingenuous to say that it didn't produce change in player behaviour when the system was never widely explained to players, and on top of that was implemented in such a way that the player-choice element of it was minimized so much it was practically non-existent.
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
User avatar
Lumbermancer
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Config Change: Antag Rep Edition

Post by Lumbermancer » #437572

subject217 wrote:and when you win your chances are reset entirely instead of just being dropped down a bit..
I thought it was the case already, because it seems logical. No idea why wasn't this a thing in the first place.
aka Schlomo Gaskin aka Guru Meditation aka Copyright Alright aka Topkek McHonk aka Le Rouge
Image
segundoblz
Joined: Sun Jul 01, 2018 4:57 pm
Byond Username: Segundoblz

Re: Config Change: Antag Rep Edition

Post by segundoblz » #437583

It also discredits admins as they can increase their own rep or for a "friend". I don't know. It's not logged. What should playerbase believe?
User avatar
WarbossLincoln
Joined: Wed Feb 10, 2016 11:14 pm
Byond Username: WarbossLincoln

Re: Config Change: Antag Rep Edition

Post by WarbossLincoln » #437589

It also greatly favors people who play all the time. Someone who plays for a couple hours twice a week might not get antag in a month because their rep stays low. People who play every day get both more rolls(which they should cause they're playing a ton) and more rep making those rolls more likely(which is what may or may not be a good thing). When the people who play like 10 hours a day get tons of rep they get antag way more often and take a slot. When someone who doesn't play as much starts building up rep they might get a higher chance of rolling antag but they're still competing with a big base of people who always have high rep so that further dilutes their chances.

You can see this in game too. There are a couple regulars I notice get antag almost every night that I'm playing, not uncommonly multiple times a night. These are regulars who are on basically every night, all night. I play like 6-8 hours a week or so, give or take, and I average antag about once a week.

This is all not necessarily a bad thing, if you want to favor people who play tons of hours on the server. But that should be taken into consideration with this system.
--Crocodillo

Image
User avatar
Arianya
In-Game Game Master
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: Config Change: Antag Rep Edition

Post by Arianya » #437592

segundoblz wrote:It also discredits admins as they can increase their own rep or for a "friend". I don't know. It's not logged. What should playerbase believe?
In as much as my saying it matters, I can tell you 100% that it's never been done while I've been around (it sends a message to admins whenever anyone touches antag rep) and that in general administrators were reluctant to touch it for any reason whatsoever, even when it might have been justified.
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
subject217
Github User
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: Config Change: Antag Rep Edition

Post by subject217 » #437601

segundoblz wrote:It also discredits admins as they can increase their own rep or for a "friend". I don't know. It's not logged. What should playerbase believe?
Admin logging for it is public, and nobody is allowed to just increase theirs for the hell of it. I wholly encourage you to find any examples of admins changing antag rep for personal gain or the gain of their friends. It should show up in the game log under the ADMIN prefix.
WarbossLincoln wrote:Snip
This is primarily what I'm seeking to change. That's also why I lowered the max antag rep, so people who roll more can't get it as high before it resets.
User avatar
CitrusGender
In-Game Game Master
Joined: Tue Jul 25, 2017 8:34 pm
Byond Username: CitrusGender
Github Username: CitrusGender

Re: Config Change: Antag Rep Edition

Post by CitrusGender » #438196

I don't particularly have a problem with this but I fail to understand why we shouldn't reward our players who play more with one of the only benefits in the game we can offer.

There's literally nothing else we can control as a benefit of playing the game other than antag rolls and we're going to remove the incentive to players to play more.
Again, I don't have a problem with this but I'm just confused as to why this is considered an overall bad thing. I can understand how it does maker the roll less likely to favor new players, but there's never going to be an upside without a downside.
I will do this but if you dislike it that much, I suggest you do a revert codeside.
Image
User avatar
Hathkar
Joined: Sat Jul 08, 2017 12:41 am
Byond Username: Hathkar

Re: Config Change: Antag Rep Edition

Post by Hathkar » #438230

CitrusGender wrote:I don't particularly have a problem with this but I fail to understand why we shouldn't reward our players who play more with one of the only benefits in the game we can offer.

There's literally nothing else we can control as a benefit of playing the game other than antag rolls and we're going to remove the incentive to players to play more.
I don't think there needs to be an incentive or benefit to playing more. If you're playing the game more often, your reward is that you get to play the game more often because you clearly enjoy playing.
And if you can't have fun without being an antagonist, maybe you should take a break?
User avatar
CitrusGender
In-Game Game Master
Joined: Tue Jul 25, 2017 8:34 pm
Byond Username: CitrusGender
Github Username: CitrusGender

Re: Config Change: Antag Rep Edition

Post by CitrusGender » #438237

Hathkar wrote:
CitrusGender wrote:I don't particularly have a problem with this but I fail to understand why we shouldn't reward our players who play more with one of the only benefits in the game we can offer.

There's literally nothing else we can control as a benefit of playing the game other than antag rolls and we're going to remove the incentive to players to play more.
I don't think there needs to be an incentive or benefit to playing more. If you're playing the game more often, your reward is that you get to play the game more often because you clearly enjoy playing.
And if you can't have fun without being an antagonist, maybe you should take a break?
Well, that may be a misrepresentation of the people we're dealing with. If that's the case, then yeah, it would not be feasible. However, if people are willing to play and get that extra enjoyment out of being antag more often and thus are encouraged to play more with that extra boost, then those are the types of people we'd want to encourage. It's a trade off between whether or not we want to cater to our returning players or our new players.

A similar thing can be said about newer players, if they stop playing because they don't get early antag rolls, perhaps they shouldn't be playing either?

Ultimately, I don't think there is an easy answer to this question.
I do like to encourage new players though so I'm kinda leaning towards turning it off.
Image
EagleWiz
Joined: Sun Aug 06, 2017 5:23 am
Byond Username: EagleWiz

Re: Config Change: Antag Rep Edition

Post by EagleWiz » #438281

CitrusGender wrote:

It's a trade off between whether or not we want to cater to our returning players or our new players.

A similar thing can be said about newer players, if they stop playing because they don't get early antag rolls, perhaps they shouldn't be playing either?

Ultimately, I don't think there is an easy answer to this question.
I do like to encourage new players though so I'm kinda leaning towards turning it off.
Doesn't this actually help newer players? When you are new you can't even get most types of antag until a certain amount of playtime (or is it just a certain number of days), but presumably you can still get antag rep while not eligible to roll antag. I agree that 350 is a bit much (thats 35 rounds!), but at 100 this should make it so that when new players start being able to roll for antag they have a high chance of actually getting antag.
User avatar
Mickyan
Github User
Joined: Tue Oct 14, 2014 11:59 pm
Byond Username: Mickyan
Github Username: Mickyan

Re: Config Change: Antag Rep Edition

Post by Mickyan » #438316

CitrusGender wrote:I fail to understand why we shouldn't reward our players who play more with one of the only benefits in the game we can offer.
I don't really think that's the case any more than playing more rounds naturally gives you more chances to roll antag

What this system does is skew the RNG in favor of the unlucky- if you have an unlucky streak where you're not getting selected for antag in a while, your chances go up. You're less likely to have situations where one person gets constantly selected out of sheer luck while someone else never does, out of the same number of rounds

I agree that the changes described in the OP would be beneficial to make this system more efficient and into a sort of "soft queue" where as soon as you roll antag you go to the back of the line, so to speak.
ImageI play on Manuel as Swanni, the brain-damaged moth.
Be nice to each other.
Image
Image
Image
Image
Image
subject217
Github User
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: Config Change: Antag Rep Edition

Post by subject217 » #438424

EagleWiz wrote:Doesn't this actually help newer players? When you are new you can't even get most types of antag until a certain amount of playtime (or is it just a certain number of days), but presumably you can still get antag rep while not eligible to roll antag. I agree that 350 is a bit much (thats 35 rounds!), but at 100 this should make it so that when new players start being able to roll for antag they have a high chance of actually getting antag.
This is not the current case IIRC, there are no time restrictions on antags.
User avatar
WarbossLincoln
Joined: Wed Feb 10, 2016 11:14 pm
Byond Username: WarbossLincoln

Re: Config Change: Antag Rep Edition

Post by WarbossLincoln » #438826

Mickyan wrote:What this system does is skew the RNG in favor of the unlucky- if you have an unlucky streak where you're not getting selected for antag in a while, your chances go up. You're less likely to have situations where one person gets constantly selected out of sheer luck while someone else never does, out of the same number of rounds

This is kind of not what happens though. You see situations where one person gets selected repeatedly. There are several players I can think of that I see getting antag a couple times a night pretty consistently when I'm on. That's anecdotal of course but I don't think antag rep really does what it's intended in practical effect. There might should be a level where your antag rep is high enough to kick into a new bracket with 100% chance next game or something.

I dunno what the current odds are but I think I get antag about once every 15-20 rounds or so.
--Crocodillo

Image
User avatar
Lumbermancer
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Config Change: Antag Rep Edition

Post by Lumbermancer » #438829

Like Sticky always being traitor when HoP.
aka Schlomo Gaskin aka Guru Meditation aka Copyright Alright aka Topkek McHonk aka Le Rouge
Image
User avatar
CreationPro
Joined: Sat Apr 19, 2014 11:11 am
Byond Username: Solar Marine
Location: Commiefornia

Re: Config Change: Antag Rep Edition

Post by CreationPro » #438916

WarbossLincoln wrote:
Mickyan wrote:What this system does is skew the RNG in favor of the unlucky- if you have an unlucky streak where you're not getting selected for antag in a while, your chances go up. You're less likely to have situations where one person gets constantly selected out of sheer luck while someone else never does, out of the same number of rounds

This is kind of not what happens though. You see situations where one person gets selected repeatedly. There are several players I can think of that I see getting antag a couple times a night pretty consistently when I'm on. That's anecdotal of course but I don't think antag rep really does what it's intended in practical effect. There might should be a level where your antag rep is high enough to kick into a new bracket with 100% chance next game or something.

I dunno what the current odds are but I think I get antag about once every 15-20 rounds or so.
byond rng works in mysterious ways.
I'd seen Blessed Heretic roll wizard 5 times in a row on highpop (60-ish people) in 2013. I'm still amazed.
terranaut wrote:Scared? My stand 「CLOWN WORLD」 and it's 「FUNNY COMPANY」will defeat your weak stand in moments.
Terry the Moth, Melody Jean the roboticist and S.O.L. the cyborg.
I will not change my avatar but if I did I'd have this good KVADRATNIY boy.
Spoiler:
Image
IkeTG wrote:love is okay
CreationPro wrote: i love you
IkeTG wrote:love is no longer okay
Old quotes and stuff
Spoiler:
obscolene wrote:I super glued my PC case shut please don't ask why.
<Pretendo> well Ia ksed in banbus
<AurxSS13> IA KSED! IA KSED! THE BLACK TYPO WITH A THOUSAND ERRORS!

<scaredofshadows> I randomly take buttons away from people
<scaredofshadows> because I am now rogue
<hornygranny> host is rouge
<Ikarrus> blow the admins
trytryagain66 wrote: I accidently axed a guy said I was sorry to him, then he punched me so I axed his head off.
Hibbles wrote:Man, I love CP. I wish we had more CP on the server.
Antonkr wrote:<antonkr> tfw you will never lick hg|works delicious sexy mustache
<antonkr> ;_;
User avatar
Arianya
In-Game Game Master
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: Config Change: Antag Rep Edition

Post by Arianya » #440224

It's been disabled so...
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
Locked

Who is online

Users browsing this forum: No registered users