[Deleted] wordless removal of the party button

Resolved.

Moderator: Board Moderators

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

wordless removal of the party button

Unread postby NikNakFlak » Wed Jul 11, 2018 4:54 am #425353




SpaceManiac
Code Maintainer
 
Joined: Fri Sep 22, 2017 4:06 am
Byond Username: SpaceManiac
Github Username: SpaceManiac

Re: wordless removal of the party button

Unread postby SpaceManiac » Wed Jul 11, 2018 5:13 am #425355

It died when fire alarms were changed and I removed the code because it was in the way, messy, and seemed like it didn't get much use. I shan't complain if someone wants to re-add the feature.

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Wed Jul 11, 2018 5:16 am #425356

why did you not list it in the changes in your PR, it's barely searchable in the code

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: wordless removal of the party button

Unread postby iamgoofball » Wed Jul 11, 2018 6:05 am #425360

NikNakFlak wrote:why did you not list it in the changes in your PR, it's barely searchable in the code

Not his problem.

User avatar
Stickymayhem
In-Game Admin
 
Joined: Mon Apr 28, 2014 6:13 pm
Byond Username: Stickymayhem

Re: wordless removal of the party button

Unread postby Stickymayhem » Wed Jul 11, 2018 6:53 am #425369

niknak the fact that this is an issue for you really makes me like you
Image

Omni Tears

Spoiler:
Image
Image
Image

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Wed Jul 11, 2018 7:26 am #425373

iamgoofball wrote:
NikNakFlak wrote:why did you not list it in the changes in your PR, it's barely searchable in the code

Not his problem.

Image
It's what he's supposed to do, there's no need to be a needless cunt goof, but I guess we all figured out you have a hard time doing this.
Now it has to be re-added again

cacogen
 
Joined: Sat Jun 02, 2018 10:27 am
Byond Username: Cacogen

Re: wordless removal of the party button

Unread postby cacogen » Wed Jul 11, 2018 7:38 am #425375

Mr. Flak why's your cat avatar got its face on its bod?

User avatar
ninjanomnom
Code Maintainer
 
Joined: Wed May 31, 2017 3:35 am
Byond Username: Ninjanomnom
Github Username: ninjanomnom

Re: wordless removal of the party button

Unread postby ninjanomnom » Wed Jul 11, 2018 4:52 pm #425424

NikNakFlak wrote:
iamgoofball wrote:
NikNakFlak wrote:why did you not list it in the changes in your PR, it's barely searchable in the code

Not his problem.

Image
It's what he's supposed to do, there's no need to be a needless cunt goof, but I guess we all figured out you have a hard time doing this.
Now it has to be re-added again


If you want to go with technicalities, that's a part of the guidelines saying how to make it easier to merge the pull request, not a requirement of pull requests.

PRs go through all the time without changes documented in the pr body because often associated changes are necessitated by the rest of the changes. They probably *should* have kept all the old functionality but it's up to the maintainer to agree with those changes and often times the bother of updating a barely used feature outweighs the benefits from a code improvement.
Narcissistic stuff others said/made for me
Spoiler:
Image
Image

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: wordless removal of the party button

Unread postby MrStonedOne » Thu Jul 12, 2018 1:13 am #425511

If I had known about the silent removal when that pr was made or merged I would have closed it or started a revert war over it.

Changes should be getting documented in the pr, even related changes like removing not implimenting an existing feature in a new system because it didn't seem worth it to support it.

I implore coderbus to enshrine this as a hard on policy if they seem to think its only a guideline and welcome any reports to my pm inbox of this happening in current prs for me to start a revert war over.

Maintainers following such policies has always been a sore subject but I will always enforce such best practices on them in whatever ways I can, petty or not.
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[10:55 AM] spookydonut: stonedmc is the work of a criminally insane mad genius

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: wordless removal of the party button

Unread postby oranges » Thu Jul 12, 2018 1:20 am #425515

yall arguing about an admin button that was probably never pressed until niknak logged in once a year to find it missing
as she says in pain

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: wordless removal of the party button

Unread postby iamgoofball » Thu Jul 12, 2018 2:43 am #425539

Image

Considering this is how long it took before someone noticed it was gone, we don't need it.

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Thu Jul 12, 2018 3:34 am #425561

that PR was June 8th of this year
It's been barely a month, are you actually this dumb

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: wordless removal of the party button

Unread postby iamgoofball » Thu Jul 12, 2018 3:45 am #425569

whoops, checked the wrong PR

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: wordless removal of the party button

Unread postby MrStonedOne » Thu Jul 12, 2018 5:15 am #425660

If you are really arguing that stealth changes are ok as long as nobody notices for a long enough time you're even dumber than I thought goofball.

Even if your post was true its still an invalid point because it fails to address anything.
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[10:55 AM] spookydonut: stonedmc is the work of a criminally insane mad genius

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Thu Jul 12, 2018 10:32 am #425731

I attempted to re-add this but the refactor has changed the code so it's no longer just copy and paste and I am too lazy to figure out weather and lighting, someone plz help

User avatar
Stickymayhem
In-Game Admin
 
Joined: Mon Apr 28, 2014 6:13 pm
Byond Username: Stickymayhem

Re: wordless removal of the party button

Unread postby Stickymayhem » Thu Jul 12, 2018 11:22 am #425738

I would like to say I tried to use the party button a couple weeks ago and went "Oh man it got removed that sucks" and then didn't follow through because niknak cares more about the game than I do and he's a hero
Image

Omni Tears

Spoiler:
Image
Image
Image

User avatar
Ayy Lemoh
 
Joined: Mon Jun 05, 2017 5:58 pm
Byond Username: Jerry Derpington

Re: wordless removal of the party button

Unread postby Ayy Lemoh » Thu Jul 12, 2018 2:29 pm #425768

Stickymayhem wrote:I would like to say I tried to use the party button a couple weeks ago and went "Oh man it got removed that sucks" and then didn't follow through because niknak cares more about the game than I do and he's a hero

i think i remember seeing it as an admin candidate or trial admin once but I never used it.

I honestly thought we didnt have one and that it was just me misremembering a time i went on a different codebase that did have it.

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Sun Jul 15, 2018 5:56 am #426412

bump

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: wordless removal of the party button

Unread postby oranges » Sun Jul 15, 2018 8:07 am #426446

Aint nobody gonna do it for you spud
as she says in pain

User avatar
NikNakFlak
In-Game Admin
 
Joined: Thu Apr 17, 2014 5:08 pm
Byond Username: NikNakflak

Re: wordless removal of the party button

Unread postby NikNakFlak » Sun Jul 15, 2018 10:12 am #426466

bump

User avatar
Aloraydrel
 
Joined: Thu Mar 19, 2015 4:14 pm
Byond Username: Aloraydrel
Github Username: Aloraydrel

Re: wordless removal of the party button

Unread postby Aloraydrel » Sun Jul 15, 2018 1:54 pm #426494

Bump
I'm having the same problem

User avatar
FrozenGuy5
Github User
 
Joined: Thu Jun 01, 2017 9:56 pm
Byond Username: FrozenGuy5
Github Username: praisenarsie

Re: wordless removal of the party button

Unread postby FrozenGuy5 » Sun Jul 15, 2018 2:30 pm #426496

imagine bumping the thread twice on the same day when someone already posted on it
ййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййййй shitty fucking signatures

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: wordless removal of the party button

Unread postby MrStonedOne » Sun Jul 15, 2018 7:55 pm #426566

Bump
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[10:55 AM] spookydonut: stonedmc is the work of a criminally insane mad genius

User avatar
Shezza
 
Joined: Sat May 27, 2017 6:54 pm
Byond Username: Wilchen

Re: wordless removal of the party button

Unread postby Shezza » Sun Jul 15, 2018 9:51 pm #426594

bump
Image
Image
Image
Image
Image
Image

User avatar
Rustledjimm
In-Game Admin
 
Joined: Tue Feb 14, 2017 9:07 pm
Byond Username: Rustledjimm

Re: wordless removal of the party button

Unread postby Rustledjimm » Mon Jul 16, 2018 12:42 am #426646

BUMP
So uhh, I'm an admin. Please leave feedback!

Will Baker
Suzu Suzaku
TBC
Spoiler:
Image

Personal Ban Length Record: 2.1024e+006 minutes

User avatar
Luke Cox
 
Joined: Sat Dec 06, 2014 8:52 am
Location: Prisoner Transfer Room
Byond Username: NocturnalQuill

Re: wordless removal of the party button

Unread postby Luke Cox » Mon Jul 16, 2018 12:46 am #426648



I had to
Image


Return to Archived/Deleted

Who is online

Users browsing this forum: No registered users and 1 guest