Pasting images and gifs and other nonsense into the chat.

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.

Moderators: MisterPerson, Giacom, Nienhaus, Code Maintainers

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Pasting images and gifs and other nonsense into the chat.

Unread postby Lumbermancer » Thu Jul 12, 2018 8:29 am #425721

It's fucking shit. Either remove this, give me option to disable it, or limit it to OOC.
aka Schlomo Gaskin aka Guru Meditation aka Tachikoma aka Magical Trevor aka Topkek McHonk aka Le Rouge

Image



User avatar
BeeSting12
In-Game Admin
 
Joined: Sat Apr 16, 2016 1:11 am
Location: 'Murica
Byond Username: BeeSting12
Github Username: BeeSting12

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby BeeSting12 » Thu Jul 12, 2018 1:02 pm #425750

If youre talkinf about admins doing it make a complaint if it's disruptive.
Edward Sloan, THE LAW
Melanie Flowers, Catgirl
Borgasm, Cyborg
Spoiler:
OOC: Hunterh98: to be fair sloan is one of the, if not the, most robust folks on tg

DEAD: Schlomo Gaskin says, "sloan may be a faggot but he gets the job done"

DEAD: Rei Ayanami says, "YOU'RE EVERYWHERE WHERE BAD SHIT IS HAPPENING"
DEAD: Rei Ayanami says, "IT'S ALWAYS FUCKING EDWARD SLOAN"
oranges wrote:Bee sting is honestly the nicest admin, I look forward to seeing him as a headmin one day

Click here to make incoherent rants about my badminning.

Ayy Lemoh
 
Joined: Mon Jun 05, 2017 5:58 pm
Byond Username: Jerry Derpington

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Ayy Lemoh » Thu Jul 12, 2018 2:08 pm #425764

BeeSting12 wrote:If youre talkinf about admins doing it make a complaint if it's disruptive.

Even if an admin has done it only once, it would still be nice to disable it. I don't even care when it happens, as it's kinda rare anyways, yet I can see why people want this.

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Lumbermancer » Thu Jul 12, 2018 2:19 pm #425767

Correct. I don't want to be playing, and have anime pictures popping up in my chat box. I already have admin midis disabled. Muh immersions and shit.
aka Schlomo Gaskin aka Guru Meditation aka Tachikoma aka Magical Trevor aka Topkek McHonk aka Le Rouge

Image

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Thu Jul 12, 2018 3:29 pm #425784

>Admins post that image of that duck vomiting into the chat.

CUT MY IMMERSION INTO PIECES THIS IS MY LAST RESORT

User avatar
Dax Dupont
In-Game Admin
 
Joined: Sun Apr 20, 2014 9:07 pm
Location: Belgium
Byond Username: DaxYeen
Github Username: DaxDupont

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Dax Dupont » Thu Jul 12, 2018 5:17 pm #425812

There's no way to disable it without filtering for specific html tags which would be annoying.

I don't even think it's actually easily done, stripping of html elements in general is done when the input is given, not when its sent to clients.

Also html elements have other uses like spans and what not to format text.

Ideally admins shouldn't send pictures. Especially NOT when the game is going on.

User avatar
kevinz000
In-Game Admin
 
Joined: Fri Nov 14, 2014 8:41 am
Location: Dorm Room 3
Byond Username: Kevinz000
Github Username: kevinz000

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby kevinz000 » Thu Jul 12, 2018 7:40 pm #425849

admin issue not code issue tbh

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Thu Jul 12, 2018 7:43 pm #425851

how do i ban admins for this admin issue. THAT CURRENTLY HAS NO SOLUTION REEE

User avatar
Atlanta-Ned
In-Game Admin
 
Joined: Fri Apr 18, 2014 2:11 pm
Byond Username: Atlanta-ned

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Atlanta-Ned » Thu Jul 12, 2018 8:39 pm #425854

Give us round IDs and we can look it up.
Feedback pls (Don't bother though, because I am perfect)
### ListVarEdit by Atlanta-ned: /datum/reagents reagent_list: Water=/obj/item/weapon/gun/energy/alien
IcePacks wrote:>all you have is a taser and the cold realization that you're a haphazard bandaid over a problem that may or may not exist, applied by someone who doesn't know or care enough about their job to do it properly

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Lumbermancer » Thu Jul 12, 2018 8:52 pm #425858

kevinz000 wrote:admin issue not code issue tbh


Atlanta-Ned wrote:Give us round IDs and we can look it up.


Not admin feedback, code feedback about bad feature (?).

Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.


What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?
aka Schlomo Gaskin aka Guru Meditation aka Tachikoma aka Magical Trevor aka Topkek McHonk aka Le Rouge

Image

somerandomguy
 
Joined: Sun Nov 05, 2017 7:41 pm
Byond Username: Astatineguy12

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby somerandomguy » Thu Jul 12, 2018 9:03 pm #425861

Lumbermancer wrote:
kevinz000 wrote:admin issue not code issue tbh


Atlanta-Ned wrote:Give us round IDs and we can look it up.


Not admin feedback, code feedback about bad feature (?).

Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.


What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?

It is an admin issue, global narrate (I *think* that's the verb they're using) isn't sanitized (intentionally, even though there really aren't many legitimate non-debug uses) and they're using it to send pictures in chat during the round.

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Lumbermancer » Thu Jul 12, 2018 9:17 pm #425871

Well my complaint is not about them posting pictures into chat, but rather that such thing is even possible.
aka Schlomo Gaskin aka Guru Meditation aka Tachikoma aka Magical Trevor aka Topkek McHonk aka Le Rouge

Image

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Cobby » Thu Jul 12, 2018 10:20 pm #425906

I’m posting pictures into your chat next time
Image

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby oranges » Fri Jul 13, 2018 1:48 am #425939

Admin issue, and also funny :^)
Image

User avatar
bandit
In-Game Admin
 
Joined: Thu Apr 17, 2014 7:35 pm
Byond Username: Bgobandit

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby bandit » Fri Jul 13, 2018 2:12 am #425943

Someone should definitely post the code for this so all admins can study it to know what to look for.
"I don't see any difference between ERP and rape." -- erro

admin feedback pls

User avatar
kevinz000
In-Game Admin
 
Joined: Fri Nov 14, 2014 8:41 am
Location: Dorm Room 3
Byond Username: Kevinz000
Github Username: kevinz000

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby kevinz000 » Fri Jul 13, 2018 2:13 am #425946

if an admin is being obnoxious/spammy complaint it
don't get it taken from all of us
narrating unsanitized html is a nifty thing, and should be possible.

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Lumbermancer » Fri Jul 13, 2018 7:38 am #425978

kevinz000 wrote:narrating unsanitized html is a nifty thing, and should be possible.


Answer my question then. If we agree that doing so during round is bad, then what is the point, if admins can already post pictures into the game screen between rounds. They can also rotate them, put game sprites in, and do other stuff. Unless you want unsanitized html to be used for other purpose than posting images, like malware, bitcoin miners etc. I don't see the point. But I digress.
aka Schlomo Gaskin aka Guru Meditation aka Tachikoma aka Magical Trevor aka Topkek McHonk aka Le Rouge

Image

User avatar
Grazyn
 
Joined: Tue Nov 04, 2014 11:01 am
Byond Username: Grazyn

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Grazyn » Fri Jul 13, 2018 11:36 am #425996

I read this thread this morning, logged in and guess what, not even 5 minutes later BAM, puking duck pic

wtf end this please, it's not rare at all

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Fri Jul 13, 2018 11:41 am #425998

we gotta ban puking duck pics once and for all and also that weeb junk. you may invade my midis but not my chat ok

Ayy Lemoh
 
Joined: Mon Jun 05, 2017 5:58 pm
Byond Username: Jerry Derpington

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Ayy Lemoh » Fri Jul 13, 2018 12:54 pm #426006

Grazyn wrote:I read this thread this morning, logged in and guess what, not even 5 minutes later BAM, puking duck pic

wtf end this please, it's not rare at all

it's probably less rare because of this thread now tbh.

Not saying that to be rude to admins, though.

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Fri Jul 13, 2018 1:31 pm #426007

if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS

User avatar
Bluespace
 
Joined: Fri Apr 18, 2014 1:04 pm
Location: UK
Byond Username: Bluespace

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Bluespace » Fri Jul 13, 2018 2:42 pm #426016

can't wait for an angrey admeen to give me a bitcoin miner and burn down my house
Image

User avatar
Dax Dupont
In-Game Admin
 
Joined: Sun Apr 20, 2014 9:07 pm
Location: Belgium
Byond Username: DaxYeen
Github Username: DaxDupont

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Dax Dupont » Sat Jul 14, 2018 11:41 am #426256

Lumbermancer wrote:
Dax Dupont wrote:Ideally admins shouldn't send pictures. Especially NOT when the game is going on.


What "shouldn't send pictures" mean? Are you saying, pasting pictures into the chat (which I've never seen happening before) is not a new feature? And "not when game is going on"? Then what is the point at all, since admins already send pictures onto the game screen between rounds?


It's been a thing forever it's just not often used.

Global narrate has never "stripped" the input of admins.

The whole concept of global narrate requires html tags to remain. It's how you manipulate text or other elements.

img is just another html tag

In theory yes admins can inject bad code like a bitcoin miner that will stick till you close the window.

They can't really give you drive by viruses or anything though.

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Sat Jul 14, 2018 3:26 pm #426272

Bluespace wrote:can't wait for an angrey admeen to give me a bitcoin miner and burn down my house


tfw admins wanna mine that bitcoin and discreetly make playing ss13 give them money. At the cost of ruining all of there players gpus, thus killing the server because no one will have a computer.

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby MrStonedOne » Sat Jul 14, 2018 5:00 pm #426289

The way the engine is designed, admins can do anything, they can call internal functions, edit the variables on objects, and send messages directly to clients, even if we took the latter away, they can still directly call the internal function that sends messages to clients, even if we took that away, they can call functions that call functions that send messages to clients, and if we took the whole chain away, and made it so no admin initiated call to an internal function could result in a message going out to clients then even internal game messages don't go out from such calls. and admins can still edit variables on objects that those objects use to send messages to clients, so again, the problem isn't solved. Hell even now, admins can bypass the admin sound preference by directly calling the internal function that handles sending sounds to clients.

And the reality is the primary reason admins can create some of the unique events they create is because the code is designed to give them such an open ended control to fuck with the world and the world state. In fact that applies to this game in general, the most magical moments in this game is when players combine features in new ways that were never directly planned for or designed for by the programmers, the same applies to admin tools and events.

That being said, images can be hidden by css selectors and we could easily conditionally load one into the style sheet and put a span around global narrate so we can be selective with it. Admins could still bypass it, but it would handle the common way they do that and we can handle intentionally bypassing it the way we do with the sound preference.
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[1:17 AM] oranges: technically I've committed a crime in my own country
[1:17 AM] oranges: by wiring money to mso
[1:17 AM] oranges: knowing that he will use it for drugs

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby ShadowDimentio » Sat Jul 14, 2018 5:04 pm #426290

>The most magical events are when players combine features

Yeah until it's removed the next round by a buttmad coder. NO FUN ALLOWED
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"I have seen the face of God and his name is SALT"
-Super Aggro Crag

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby MrStonedOne » Sat Jul 14, 2018 5:05 pm #426291

I thought the balance rat race was part of the fun?
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[1:17 AM] oranges: technically I've committed a crime in my own country
[1:17 AM] oranges: by wiring money to mso
[1:17 AM] oranges: knowing that he will use it for drugs

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby ShadowDimentio » Sat Jul 14, 2018 6:05 pm #426297

It would be if the coders didn't consider fun a bug that needed to be fixed
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"I have seen the face of God and his name is SALT"
-Super Aggro Crag

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Cobby » Sat Jul 14, 2018 8:01 pm #426314

bandit wrote:Someone should definitely post the code for this so all admins can study it to know what to look for.


You global narrate <img src="url"> (it might be single quotes i forget, try both :^] )
Image

User avatar
MrStonedOne
Site Admin
 
Joined: Mon Apr 14, 2014 10:56 pm
Byond Username: MrStonedOne
Github Username: MrStonedOne

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby MrStonedOne » Sun Jul 15, 2018 4:28 am #426397

the fun one is <img src="https://tgstation13.org/gamebanner.php?server=terry"> only because everybody will see a different name on the banner
Forum/Wiki Administrator, Server host, Database King, Master Coder


MrStonedOne on Reddit(banned), Steam, IRC, Skype Discord.

[1:17 AM] oranges: technically I've committed a crime in my own country
[1:17 AM] oranges: by wiring money to mso
[1:17 AM] oranges: knowing that he will use it for drugs

User avatar
subject217
In-Game Admin
 
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby subject217 » Sun Jul 15, 2018 5:31 am #426404

Shadowflame909 wrote:if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS

Excuse me sir, it's called goose vomit. And it's a time honored tradition.

User avatar
Shadowflame909
 
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Shadowflame909 » Sun Jul 15, 2018 5:46 am #426408

subject217 wrote:
Shadowflame909 wrote:if i see that puking duck pic one more time in my chat im gonna start playing the "you can feel your tongue in your mouth" game with the admins private DMS

Excuse me sir, it's called goose vomit. And it's a time honored tradition.


dON'T DO IT

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby oranges » Sun Jul 15, 2018 8:57 am #426452

Image
Image

User avatar
Grazyn
 
Joined: Tue Nov 04, 2014 11:01 am
Byond Username: Grazyn

Re: Pasting images and gifs and other nonsense into the chat.

Unread postby Grazyn » Sun Jul 15, 2018 9:16 am #426456

DUCK YOU


Return to Coding Feedback

Who is online

Users browsing this forum: No registered users and 2 guests