TGMC Hotkeys Port Feedback

bobbahbrown · Post by **bobbahbrown** » Fri Nov 08, 2019 7:26 pm #523034

I've chatted with a few people and there didn't really seem to be a good place to leave feedback on this new feature, so I made this thread.

Original PR here: https://github.com/tgstation/tgstation/pull/47003
Revert PR here: https://github.com/tgstation/tgstation/pull/47571

kopoba · Post by **kopoba** » Fri Nov 08, 2019 8:55 pm #523048

Revert please this is unplayble

Dr_bee · Post by **Dr_bee** » Fri Nov 08, 2019 9:43 pm #523064

The inability to keep the chat bar focused so you can easily chat is a problem for me. It makes quickly speaking difficult and speaking while moving impossible.

carshalash · Post by **carshalash** » Sat Nov 09, 2019 2:19 am #523087

Absolutely fucking cancerous for AI, i'd take back the telepad meme if it meant this would go away. having to hit tab whenever I do literally anything and having the camera hotkeys memed away is ass.

Removed the ability to turn with ctrl + arrows. Surely there has to be a better method for customizing hotkeys than this.

gameaddict07 · Sat Nov 09, 2019 7:34 pm

It SUCKS FAT ASS please remove.
I want to be able to use arrow keys AND WASD.

deedubya · Post by **deedubya** » Sat Nov 09, 2019 8:33 pm #523184

Tarchonvaagh · Sun Nov 10, 2019 7:37 pm

After the fixes... I still don't use it but its not unplayable so yeah, this only fucked over the command bar people

bobbahbrown · Post by **bobbahbrown** » Sun Nov 10, 2019 8:19 pm #523292

Tarchonvaagh wrote:After the fixes... I still don't use it but its not unplayable so yeah, this only fucked over the command bar people

fuck jannies

Tlaltecuhtli · Sun Nov 10, 2019 8:36 pm

this is like society we are lowering everyones life quality to accept a few weirdos with not qwerty keyboards

skoglol · Post by **skoglol** » Sun Nov 10, 2019 8:56 pm #523301

My life quality has been increased, and I am on a qwerty keyboard.

actioninja · Post by **actioninja** » Mon Nov 11, 2019 2:49 am #523370

deedubya wrote:<snip>

I laughed but you left part of the screencap out:

And I was completely right, the revert has still been causing issues with save files.

confused rock · Mon Nov 11, 2019 5:16 am

I used to use the arrow keys to talk while moving while using wasd normally. the only people the new hotkeys benefit are powergamers. Meanwhile, arrow key mode makes talking easier than fighting. I wonder which you think I prefer.

deedubya · Post by **deedubya** » Mon Nov 11, 2019 5:52 am #523385

actioninja wrote:wew

Aside from the comedic effect, my point there was also the fact that merging something with at least partial knowledge that it would cause issues isn't exactly good maintenance practice.

Surely if this was a near-irreversible change as you predicted, it deserved to have more time being tested on localhosts to ensure we wouldn't lose functionality once it went live?

actioninja · Post by **actioninja** » Mon Nov 11, 2019 6:50 am #523391

It was tested on local. The issues that came up in production weren't issues that were seen in local testing. I said it was probably going to break things because large changes to controls like this frequently do. If I didn't expect it to be fixed I wouldn't have merged it.

Tarchonvaagh · Mon Nov 11, 2019 2:04 pm

im using a qwertz keyboard you jannies

Post by **oranges** » Mon Nov 11, 2019 8:47 pm #523464

deedubya wrote:
actioninja wrote:wew
Aside from the comedic effect, my point there was also the fact that merging something with at least partial knowledge that it would cause issues isn't exactly good maintenance practice.

Surely if this was a near-irreversible change as you predicted, it deserved to have more time being tested on localhosts to ensure we wouldn't lose functionality once it went live?

you obviously have no idea about the way we run things here

Mon Nov 11, 2019 10:19 pm

There's a big difference between knowing that there will be issues and knowing what those issues actually are. Obviously yeah if there were any outstanding issues they would have been fixed.

peoplearestrange · Tue Nov 12, 2019 1:30 am

Let me ask a question. What does this have thats objectively a massive improvement in the game?

If its custom bindable keys, let me further that by asking WHY do we need it?

Sure you can't use hotkeys if you use your DOVAK or non qwerty keyboard, but then use arrows like every other person who managed to play the game. Hell maybe you'll even find it means you talk more and spend less time wordlessly running around trying to min/max, probably not.

Seriously though, what was actually useful about this merge? Did we even get a say? From what I can see this wasn't a overall code change pushed by the headcoder, this was a loosely implemented use of someone elses (broken) code.
Are we really heading back to the googlecode days of jamming stuff in and testing later...? Kinda seems like that.

peoplearestrange · Tue Nov 12, 2019 1:38 am

Fuck sake just let me die in piece before you all destroy the game I can play...

Post by **oranges** » Tue Nov 12, 2019 2:17 am #523522

we're not going to delay technical improvements because of a bunch of boomers

carshalash · Post by **carshalash** » Tue Nov 12, 2019 6:48 am #523570

People like having easy access to the chat bar in a roleplaying game.

cdru · Post by **cdru** » Tue Nov 12, 2019 9:55 am #523592

I like being able to run AND type at the same time

peoplearestrange · Tue Nov 12, 2019 7:40 pm

oranges wrote:we're not going to delay technical improvements because of a bunch of boomers

This is my point though, its not improved my experience. If anything its made it much much worse. I'm waiting for the work around merge to go through and I hope that allows me to at least keep the damn bar focused...
And its not just the old accounts complaining either... 2017/2018 acounts, hell I had a (fairly) new player ask why they could no longer move and why they couldn't get the bar to stay focused.

carshalash wrote:People like having easy access to the chat bar in a roleplaying game.

This ^ In the same way as half the screen is dedicated to text, for a roleplaying game

skoglol · Post by **skoglol** » Tue Nov 12, 2019 8:00 pm #523687

peoplearestrange wrote:hell I had a (fairly) new player ask why they could no longer move and why they couldn't get the bar to stay focused.

Better get rid of it now then, before more people adopt the input style.

Anonmare · Post by **Anonmare** » Tue Nov 12, 2019 8:19 pm #523688

Why are you even trying to have a conversation with oranges when you know he won't give a fuck outside of the coderbus circlejerk? You know coderbus are insular as fuck, why waste the energy? Just move to a different codebase, I'm only here cause Eris isn't open outside of weekends.

Post by **oranges** » Tue Nov 12, 2019 9:18 pm #523706

you've been "leaving" tg for fucking years, maybe if you actually sacked up and did it, people wouldn't think you're so much of a joke

reality is there's an open pr to fix the issues, so there's nothing really to discuss, other than the lack of patience people have

Anonmare · Post by **Anonmare** » Tue Nov 12, 2019 10:05 pm #523715

oranges wrote:you've been "leaving" tg for fucking years, maybe if you actually sacked up and did it, people wouldn't think you're so much of a joke

reality is there's an open pr to fix the issues, so there's nothing really to discuss, other than the lack of patience people have

What the actual fuck kind of methyleated spirits are you on oranges, I've been "leaving" for the past several months. Have you really retreated so far up your ass you're no longer able to tell people apart? And your fix don't fix shit, that "fix", or another like it, went live on TGMC and didn't fix my problems with the control scheme and that it doesn't respect the division between hotkey and chat modes.

You're completely impossible to talk to in any kind of serious capacity and it's only through being dismissed do you actually respond with something other than memes. It's infuriating.

Post by **oranges** » Wed Nov 13, 2019 1:43 am #523747

for years anonmare, for years

carshalash · Post by **carshalash** » Wed Nov 13, 2019 2:33 am #523751

The fact that the removal of default mode was completely undocumented is probably the worst thing about this.

Post by **oranges** » Wed Nov 13, 2019 8:58 pm #523854

it was discussed, I just dont' think anyone gives a shit about it other than the four or five people who bothered to comment

peoplearestrange · Wed Nov 13, 2019 10:11 pm

oranges wrote:it was discussed, I just dont' think anyone gives a shit about it other than the four or five people who bothered to comment

based on what? Your assumption that everyone who effected knows the forums exist, then takes the time to find the right thread and then comments on it?

As much as I'm fairly certain that fixes will help it return to how I played, there was very little evidence, even the change log was fairly unclear to what was being changed and the fact that the change included REMOVING something in the process.

I think thats what urks me more, is that when I asked why I couldn't get out of hotkey mode people acted like I was dumb or some idiot on the backbenches... Which is just a weird angle to play for actually quite a large change.

Post by **oranges** » Thu Nov 14, 2019 2:45 am #523912

based on the assumption that very few people actually use classic mode, because it hasn't been the default or recommended for years

peoplearestrange · Thu Nov 14, 2019 1:48 pm

Still not data and only assumptions. Not a great way to make a change as such.
Don't go all Firefall on us...

carshalash · Post by **carshalash** » Fri Nov 15, 2019 2:39 am #524091

The default click and chat is... very very finnicky. I've found my command bar being over written by letters while clicking and talking quickly.

Post by **oranges** » Fri Nov 15, 2019 3:31 am #524103

type slower then

peoplearestrange · Fri Nov 15, 2019 1:15 pm

oranges wrote:type slower then

N.A.S.

bandit · Post by **bandit** » Sun Nov 17, 2019 11:43 pm #524497

very much looking forward to the day I can actually play this game again

(edit: wait, it seems I can, hallelujah)

teepeepee · Post by **teepeepee** » Mon Nov 18, 2019 12:51 am #524507

had a fun round due to the ability to bind scream to a key, we had a space court determine that spamming scream and deafening all around you is free speech

carshalash · Post by **carshalash** » Mon Nov 18, 2019 2:17 am #524514

For the love of god please kill bindable emotes.

Sandshark808 · Mon Nov 18, 2019 3:12 am

carshalash wrote:For the love of god please kill bindable emotes.

Please make *flip deal slight damage to people around you, so we can be human ninja stars.

teepeepee · Post by **teepeepee** » Mon Nov 18, 2019 3:23 am #524518

carshalash wrote:For the love of god please kill bindable emotes.

*scream

ATHATH · Post by **ATHATH** » Mon Nov 18, 2019 4:39 am #524521

Maybe add a sort of sechailer-like system to hotkeyed emotes? Like, say, if you use hotkeys to use the same emote 5 times in 5 seconds, your hotkey for it gets disabled for a minute?

carshalash · Post by **carshalash** » Tue Nov 19, 2019 3:06 am #524668

Seems that default mode is unable to press tab to use lettered hotkeys anymore.