Song Request Feature Feedback

[Timberpoes]

https://github.com/tgstation/tgstation/pull/74170

Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.

Problems with other URLs: Config issue. Maybe we'll enable more sites at some future point in time but we'll stick with the Big Three (Soundcloud/Bandcamp/YT) for now.

Assorted admin team feedback so far:
"When you accept it just autofills the URL into play-internet-sound and doesn't tell people who requested it"
"It would also be alot more usable if playing a song removed it from the request manager - or could be filtered to do so"

My suggestions: Three-state config flag.
On: Enabled. On by default, can be toggled off via an admin verb.
Toggle: Enabled. Off by default, can be toggled on via an admin verb.
Disabled: Disabled. Cannot be toggled on or off.

I think having the toggle verb would be very useful in general, and would probably be what the final config would end up being (enabled, off by default, toggleable to on). Similar to toggling OOC on and off, it would do a little announcement to let players know.

[WineAllWine]

Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.

Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)

[Timberpoes]

Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.

Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)

I meant that it rejected valid URLs as invalid before even making the request, because the filter was fucked and wouldn't accept youtube.com/watch?v= URLs.

[WineAllWine]

Problems with it not accepting valid YouTube URLs: Config issue, hopefully should be fixed.

Isn't our whole thing just rubbish at youtube. I know the Play-Internet-Sound verb as maybe like a 70% success rate as an admin if I'm using youtube. (Soundcloud never fails)

I meant that it rejected valid URLs as invalid before even making the request, because the filter was fucked and wouldn't accept youtube.com/watch?v= URLs.

Oh, my bad