Revert Whoneedspacee's Mob Abilities PR

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.
Post Reply
User avatar
Indie-ana Jones
Joined: Mon Aug 26, 2019 6:15 pm
Byond Username: Indie-ana Jones

Revert Whoneedspacee's Mob Abilities PR

Post by Indie-ana Jones » #646269

It's been 6 months and ever since https://github.com/tgstation/tgstation/pull/63520 has been merged, there have been consequences impacting the megafaunas. This PR borked over almost every megafauna in some way or another. The ability-adding capability also doesn't even work, and Space isn't capable of keeping his PRs to fix it maintained in order to get them merged. I say just remove the damn thing and if he really wants it, make him submit a version with the fixes already implemented as to not make Mining complete ass for another 6 months.
Last edited by Indie-ana Jones on Wed Jul 13, 2022 7:49 am, edited 3 times in total.
Imitates-The-Lizards
Joined: Mon Oct 11, 2021 2:28 am
Byond Username: Typhnox

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Imitates-The-Lizards » #646287

Can you be more specific about what exactly is broken or has issues in regards to megafauna?
Image
Image
User avatar
Shadowflame909
Joined: Mon Jun 05, 2017 10:18 pm
Byond Username: Shadowflame909
Location: Think about something witty and pretend I put it here

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Shadowflame909 » #646288

Imitates-The-Lizards wrote: Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
bubblegum keeps breaking
► Show Spoiler
Time-Green
Code Maintainer
Joined: Thu Jun 30, 2016 6:09 pm
Byond Username: Time-Green

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Time-Green » #646289

Shadowflame909 wrote: Fri Jul 08, 2022 8:03 am
Imitates-The-Lizards wrote: Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
bubblegum keeps breaking
Can you be more specific about what exactly is broken or has issues in regards to megafauna?
User avatar
Indie-ana Jones
Joined: Mon Aug 26, 2019 6:15 pm
Byond Username: Indie-ana Jones

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Indie-ana Jones » #646292

Imitates-The-Lizards wrote: Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
- Megafauna can melee attack during their abilities when using an ability used to reset their melee cooldown. Bubblegum and Ash Drake are extremely notable examples of this, though all megafaunas exhibit this equally. Very noticeable with a crusher.
- Some attacks can be chained immediately into another attack whilst the first attack is still active. Bubblegum Phase 2 with hallucinations and hierophant seem to exhibit this the most, though once again they all do it.
- Megafauna will sometimes execute their actions much slower than intended or much faster than intended. The faster variation might just be whatever is happening in issue 2.
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: Revert Whoneedspacee's Mob Abilities PR

Post by oranges » #646418

You know we have an issue tracker right?
User avatar
Stickymayhem
Joined: Mon Apr 28, 2014 6:13 pm
Byond Username: Stickymayhem

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Stickymayhem » #646428

a PR that gave admins way more tools to make super fun mobs (it does work very well) AND made miners mad?

another W for whoneedspace
Image
Image
Boris wrote:Sticky is a jackass who has worms where his brain should be, but he also gets exactly what SS13 should be
Super Aggro Crag wrote: Wed Oct 13, 2021 6:17 pm Dont engage with sticky he's a subhuman
User avatar
Indie-ana Jones
Joined: Mon Aug 26, 2019 6:15 pm
Byond Username: Indie-ana Jones

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Indie-ana Jones » #646466

oranges wrote: Sun Jul 10, 2022 9:44 pm You know we have an issue tracker right?
This issue has been open since January: https://github.com/tgstation/tgstation/issues/63886

As for what Sticky said, according to dragomagol on that same issue report, the add mob ability button doesn't even work.
User avatar
Fikou
In-Game Game Master
Joined: Sun Jun 10, 2018 8:38 am
Byond Username: Fikou
Github Username: Fikou
Location: Dreamland

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Fikou » #646556

it does work
User avatar
Indie-ana Jones
Joined: Mon Aug 26, 2019 6:15 pm
Byond Username: Indie-ana Jones

Re: Revert Whoneedspacee's Mob Abilities PR

Post by Indie-ana Jones » #646573

OK then, good. That just leaves the issues with the abilities themselves. Space has re-opened his PR, hopefully this time it gets merged and this won't be an issue anymore.
Post Reply

Who is online

Users browsing this forum: No registered users