Revert Whoneedspacee's Mob Abilities PR
- Indie-ana Jones
- Joined: Mon Aug 26, 2019 6:15 pm
- Byond Username: Indie-ana Jones
Revert Whoneedspacee's Mob Abilities PR
It's been 6 months and ever since https://github.com/tgstation/tgstation/pull/63520 has been merged, there have been consequences impacting the megafaunas. This PR borked over almost every megafauna in some way or another. The ability-adding capability also doesn't even work, and Space isn't capable of keeping his PRs to fix it maintained in order to get them merged. I say just remove the damn thing and if he really wants it, make him submit a version with the fixes already implemented as to not make Mining complete ass for another 6 months.
Last edited by Indie-ana Jones on Wed Jul 13, 2022 7:49 am, edited 3 times in total.
-
- Joined: Mon Oct 11, 2021 2:28 am
- Byond Username: Typhnox
Re: Revert Whoneedspacee's Mob Abilities PR
Can you be more specific about what exactly is broken or has issues in regards to megafauna?
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Revert Whoneedspacee's Mob Abilities PR
bubblegum keeps breakingImitates-The-Lizards wrote: ↑Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
► Show Spoiler
-
- Code Maintainer
- Joined: Thu Jun 30, 2016 6:09 pm
- Byond Username: Time-Green
Re: Revert Whoneedspacee's Mob Abilities PR
Can you be more specific about what exactly is broken or has issues in regards to megafauna?Shadowflame909 wrote: ↑Fri Jul 08, 2022 8:03 ambubblegum keeps breakingImitates-The-Lizards wrote: ↑Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
- Indie-ana Jones
- Joined: Mon Aug 26, 2019 6:15 pm
- Byond Username: Indie-ana Jones
Re: Revert Whoneedspacee's Mob Abilities PR
- Megafauna can melee attack during their abilities when using an ability used to reset their melee cooldown. Bubblegum and Ash Drake are extremely notable examples of this, though all megafaunas exhibit this equally. Very noticeable with a crusher.Imitates-The-Lizards wrote: ↑Fri Jul 08, 2022 7:17 am Can you be more specific about what exactly is broken or has issues in regards to megafauna?
- Some attacks can be chained immediately into another attack whilst the first attack is still active. Bubblegum Phase 2 with hallucinations and hierophant seem to exhibit this the most, though once again they all do it.
- Megafauna will sometimes execute their actions much slower than intended or much faster than intended. The faster variation might just be whatever is happening in issue 2.
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Revert Whoneedspacee's Mob Abilities PR
You know we have an issue tracker right?
- Stickymayhem
- Joined: Mon Apr 28, 2014 6:13 pm
- Byond Username: Stickymayhem
Re: Revert Whoneedspacee's Mob Abilities PR
a PR that gave admins way more tools to make super fun mobs (it does work very well) AND made miners mad?
another W for whoneedspace
another W for whoneedspace
Boris wrote:Sticky is a jackass who has worms where his brain should be, but he also gets exactly what SS13 should be
- Indie-ana Jones
- Joined: Mon Aug 26, 2019 6:15 pm
- Byond Username: Indie-ana Jones
Re: Revert Whoneedspacee's Mob Abilities PR
This issue has been open since January: https://github.com/tgstation/tgstation/issues/63886
As for what Sticky said, according to dragomagol on that same issue report, the add mob ability button doesn't even work.
- Fikou
- In-Game Game Master
- Joined: Sun Jun 10, 2018 8:38 am
- Byond Username: Fikou
- Github Username: Fikou
- Location: Dreamland
- Indie-ana Jones
- Joined: Mon Aug 26, 2019 6:15 pm
- Byond Username: Indie-ana Jones
Re: Revert Whoneedspacee's Mob Abilities PR
OK then, good. That just leaves the issues with the abilities themselves. Space has re-opened his PR, hopefully this time it gets merged and this won't be an issue anymore.
Who is online
Users browsing this forum: Bing [Bot]