Toggle internals button into an action button
-
- Joined: Tue Apr 22, 2014 2:59 pm
- Byond Username: Kingofkosmos
Toggle internals button into an action button
https://github.com/tgstation/-tg-station/pull/10629
I haven't gotten much feedback on Github for this so I thought I'd ask here since this is a big-ish change, it's used by most players at least once or twice during every round.
So what do you think?
I haven't gotten much feedback on Github for this so I thought I'd ask here since this is a big-ish change, it's used by most players at least once or twice during every round.
So what do you think?
-
- Github User
- Joined: Fri Apr 18, 2014 1:50 pm
- Byond Username: Xxnoob
- Github Username: xxalpha
Re: Toggle internals button into an action button
I think its bad.
- Braincake
- Joined: Fri Apr 18, 2014 2:48 pm
- Byond Username: Braincake
Re: Toggle internals button into an action button
Does this add a button for each available tank? Couldn't really get this from the PR.
If yes, is there some distinction between, for instance, two emergency tanks in your pockets?
If yes, is there some distinction between, for instance, two emergency tanks in your pockets?
-
- Joined: Tue Apr 22, 2014 2:59 pm
- Byond Username: Kingofkosmos
Re: Toggle internals button into an action button
Please elaborate.Scott wrote:I think its bad.
Yes, each tank gets an action button. If they are the same type of tank, there will be no knowing which one is which unless you remember the order you took them out, the first one being is the leftmost.Braincake wrote:Does this add a button for each available tank? Couldn't really get this from the PR.
If yes, is there some distinction between, for instance, two emergency tanks in your pockets?
The current system does it so that you have no direct control over using a particular tank if you have multiple ones. It just uses the first thing which it finds checking through hands --> suit storage --> belt --> pocket.
-
- Github User
- Joined: Fri Apr 18, 2014 1:50 pm
- Byond Username: Xxnoob
- Github Username: xxalpha
Re: Toggle internals button into an action button
We have a button for internals already, it's been there since forever. Changing that is bad. Moving that button to the already crowded action button "bar" is bad.
- Braincake
- Joined: Fri Apr 18, 2014 2:48 pm
- Byond Username: Braincake
Re: Toggle internals button into an action button
I know about the current system; it's why I asked. This would be an improvement in that regard.kosmos wrote:Yes, each tank gets an action button. If they are the same type of tank, there will be no knowing which one is which unless you remember the order you took them out, the first one being is the leftmost.
The current system does it so that you have no direct control over using a particular tank if you have multiple ones. It just uses the first thing which it finds checking through hands --> suit storage --> belt --> pocket.
However, where is the on-screen indicator that you're running on internals? This is pretty vital information, and confining it to the status tab would be awfully restrictive. Unless I'm blind and missing something from the webm, there is no indicator at all.
-
- Joined: Tue Apr 22, 2014 2:59 pm
- Byond Username: Kingofkosmos
Re: Toggle internals button into an action button
Excellent point, in the PR the only way know you're running from internals is from the status tab like seen from the video - not ideal, I know, but it does the job. I was hoping someone more competent would later on make some kind of a internals-running-icon for every tank...Braincake wrote:However, where is the on-screen indicator that you're running on internals? This is pretty vital information, and confining it to the status tab would be awfully restrictive. Unless I'm blind and missing something from the webm, there is no indicator at all.
- Braincake
- Joined: Fri Apr 18, 2014 2:48 pm
- Byond Username: Braincake
Re: Toggle internals button into an action button
Have you considered leaving the current on-screen indicator, until the feature is complete? The status tab is not a viable substitute; if it was, there wouldn't have been need for an on-screen indicator in the first place.kosmos wrote:I was hoping someone more competent would later on make some kind of a internals-running-icon for every tank...
-
- Joined: Tue Apr 22, 2014 2:59 pm
- Byond Username: Kingofkosmos
Re: Toggle internals button into an action button
I'll try and see if I can make all tanks have same kind of a small flashing overlay light like jetpacks do.
Who is online
Users browsing this forum: No registered users