Live-Server Testmerges Should Require 'Testmerge Candidate' Label

[bobbahbrown]

I have determined that according to Skoglol there is no formal procedure for when a testmerge should be allowed. As live-server testing of PRs is not a codebase issue (its a decision made by keyholders) I am requesting that policy be formalized to better control what can and cannot be testmerged.

Specifically, I am proposing that we only allow PRs with a specific label, the obvious option being the 'testmerge candidate' label, to be testmerged. From what I understand, the purpose of this label should be to require that a PR has a maintainer vouch for the code that is contained in the PR prior to being testmerged onto a live server.

This prevents an obvious attack vector from being abused, as it really only takes one slip-up to sour the experience for everyone involved. It'll also promote better code review, I think.

Best,
bobbah "bee" brown

[Vekter]

I think this is fair, though if we're doing this we should also change to require that flag for anything that would realistically impact the server enough to require a testmerge. Assuming that's not the current policy, of course.

[oranges]

the keyholders reject your request.

[Coconutwarrior97]

This isn't really up to headmins.

Headmin votes:
Coconutwarrior97: Not up to us.
Phuzzylodgik: Not up to us.
TWATICUS: Not up to us.