WORST CHANGE EVER

How, what and why to code in BYOND.
Post Reply
User avatar
Cheridan
Joined: Tue Apr 15, 2014 6:04 am
Byond Username: Cheridan

WORST CHANGE EVER

Post by Cheridan » #43219

After careful review of the tgstation project SVN code hosted on http://code.google.com/p/tgstation13/, I've determined that the offical WORST COMMIT EVER, as determined through total amount of negative votes, is...

*drumroll*

http://code.google.com/p/tgstation13/so ... ail?r=3045

Posted Feb 6 2012 by our very own Errorage~

Unfortunately, no equivalent metric exists to judge Github pull requests. :(
Image
/tg/station spriter, admin, and headcoder. Feel free to contact me via PM with questions, concerns, or requests.
User avatar
paprika
Rarely plays
Joined: Fri Apr 18, 2014 10:20 pm
Byond Username: Paprka
Location: in down bad

Re: WORST CHANGE EVER

Post by paprika » #43225

There is no way someone thought this would be a good idea
Oldman Robustin wrote:It's an established meme that coders don't play this game.
User avatar
MisterPerson
Board Moderator
Joined: Tue Apr 15, 2014 4:26 pm
Byond Username: MisterPerson

Re: WORST CHANGE EVER

Post by MisterPerson » #43227

2 commits later is a revert that basically goes "Come on guys can't you take a joke?"
I code for the code project and moderate the code sections of the forums.

Feedback is dumb and it doesn't matter
User avatar
ExplosiveCrate
Joined: Fri Apr 18, 2014 8:04 pm
Byond Username: ExplosiveCrate

Re: WORST CHANGE EVER

Post by ExplosiveCrate » #43281

classic erro :^)

Who was it that brought that whole random name thing that one april's fools?
i dont even know what the context for my signature was
Kavaloosh
Joined: Fri Apr 18, 2014 7:17 pm

Re: WORST CHANGE EVER

Post by Kavaloosh » #43283

not as bad as things that fag ergo has done
Confront them with annihilation, and they will then survive; plunge them into a deadly situation, and they will then live. When people fall into danger, they are then able to strive for victory.
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: WORST CHANGE EVER

Post by oranges » #43305

You can talk kavalava, you shitter
Incomptinence
Joined: Fri May 02, 2014 3:01 am
Byond Username: Incomptinence

Re: WORST CHANGE EVER

Post by Incomptinence » #43394

The ITS A JOKE bit sounds like ass covering.

I mean do you put jokes on your resume?
Kavaloosh
Joined: Fri Apr 18, 2014 7:17 pm

Re: WORST CHANGE EVER

Post by Kavaloosh » #43398

oranges wrote:You can talk kavalava, you shitter
are you hitting on me
Spoiler:
im hitting on you
Confront them with annihilation, and they will then survive; plunge them into a deadly situation, and they will then live. When people fall into danger, they are then able to strive for victory.
User avatar
srifenbyxp
Joined: Tue May 20, 2014 4:49 am
Byond Username: Srifenbyxp
Location: UK

Re: WORST CHANGE EVER

Post by srifenbyxp » #43486

This is the same as goon's electrician IIRC, annoying but nothing surgery or SEs cant fix. Might as well not limit it to engis and share the failure with ever one else with the same 10%.
To be robust is not about combat prowess, it is the state of readiness for the situation at hand.
Erbbu
Joined: Tue Oct 28, 2014 4:56 am
Byond Username: Erbbu

Re: WORST CHANGE EVER

Post by Erbbu » #43504

That change was the pinnacle of autism. No actually what was worse was the commit that we can't eat through masks anymore.
User avatar
Steelpoint
Github User
Joined: Thu Apr 17, 2014 6:37 pm
Byond Username: Steelpoint
Github Username: Steelpoint
Location: The Armoury

Re: WORST CHANGE EVER

Post by Steelpoint » #43505

There should be a option to allow your character to start with near-sightedness and with prescription glasses. Just cause why not.
Image
User avatar
Cheridan
Joined: Tue Apr 15, 2014 6:04 am
Byond Username: Cheridan

Re: WORST CHANGE EVER

Post by Cheridan » #43547

I was actually corrected somewhat; the OP change is tied with 'Dangercon 2011' (a.k.a. engineer glove 'removal') at -20 downvotes each.

http://code.google.com/p/tgstation13/so ... ail?r=1490

Though Dangercon has many more positive votes, so the net amount of negative votes is offset.

Honorable mentions:
http://code.google.com/p/tgstation13/so ... ail?r=3506 -- The time Poly made it so you shoot yourself every time you tried to put your gun into a box.
Image
/tg/station spriter, admin, and headcoder. Feel free to contact me via PM with questions, concerns, or requests.
User avatar
Cheridan
Joined: Tue Apr 15, 2014 6:04 am
Byond Username: Cheridan

Re: WORST CHANGE EVER

Post by Cheridan » #43552

I think we sometimes focus too much on the negative.

The undisputed BEST CHANGES EVER on the SVN are:

http://code.google.com/p/tgstation13/so ... ail?r=3234 -- Cloaker removal
http://code.google.com/p/tgstation13/so ... ail?r=2110 -- RIP GHOSTS
Next up, removing ghosts rotating chairs because that can be used for communication zomg!!!!!11111
eheheheheheehehehheehhheee

Honorable Mentions:

http://code.google.com/p/tgstation13/so ... ail?r=3574 -- The revert of our Baymed port
http://code.google.com/p/tgstation13/so ... ail?r=3361 -- That one time Doohl snuck in poo
http://code.google.com/p/tgstation13/so ... ail?r=4205 -- Fixing most of the FEA atmos simulation lag with 1 line
Image
/tg/station spriter, admin, and headcoder. Feel free to contact me via PM with questions, concerns, or requests.
User avatar
paprika
Rarely plays
Joined: Fri Apr 18, 2014 10:20 pm
Byond Username: Paprka
Location: in down bad

Re: WORST CHANGE EVER

Post by paprika » #43568

Cheridan wrote: http://code.google.com/p/tgstation13/so ... ail?r=3574 -- The revert of our Baymed port
Reverted Tarajans
muh sides
Oldman Robustin wrote:It's an established meme that coders don't play this game.
User avatar
Jordie0608
Site Admin
Joined: Tue Apr 15, 2014 1:33 pm
Byond Username: Jordie0608
Github Username: Jordie0608
Location: Spiderland, Australia

Re: WORST CHANGE EVER

Post by Jordie0608 » #43667

Cheridan wrote:I was actually corrected somewhat; the OP change is tied with 'Dangercon 2011' (a.k.a. engineer glove 'removal') at -20 downvotes each.

http://code.google.com/p/tgstation13/so ... ail?r=1490

Though Dangercon has many more positive votes, so the net amount of negative votes is offset.
Most of those changes are still present in the game even today.
Forum Admin
Send me a PM if you have any issues, concerns or praise of fishfood to express about the forums.
User avatar
CocaneStyle
Joined: Fri Apr 25, 2014 4:34 am
Byond Username: CocaneStyle

Re: WORST CHANGE EVER

Post by CocaneStyle » #44137

Anyone remember when they added ERP?
miggles
Joined: Fri Apr 18, 2014 9:02 am
Byond Username: Miggles
Contact:

Re: WORST CHANGE EVER

Post by miggles » #44176

CocaneStyle wrote:Anyone remember when they added ERP?
april fools
dezzmont wrote:I am one of sawrge's alt accounts
dezzmont wrote:sawrge has it right.
Connor wrote:miggles is correct though
Post Reply

Who is online

Users browsing this forum: Lilah