dirk_mcblade wrote: ↑Fri Aug 18, 2023 1:28 pmDo you think any discussion would've resulted in the mosin reskin not getting merged? I don't think it was avoidable regardless of its popularity.
I mean, yes. Discussion would have not had it merged as much as discussion did have it merged. The person who made the pr and did the sprites was open to discussion, was discussing matters with people, responding to feedback, and discussing the matter with spritetainers and was very good about it. They made compelling arguments to a spritemaint and they agreed on that. It wasn't going to be merged without at least talking to someone and making a good pitch to the people that matter in whether or not it is merged.
Hell, here is one spritemaint who disagreed. That suggests there is room for further discussion, and not the unanimous decision to allow it that people claim. It's just that the team largely trusts one another if someone believes strongly enough that something should be merged. And if nobody agrees, this pr goes stale and nothing happens.
The conversations are taking place in a public format, there were disagreements, and there was criticism. As I said, someone is already redoing them again. That's form of criticism in of itself, and a healthy one.
Just telling someone 'no this sucks' and repeating to them the reasons they feel it should be changed ultimately isn't going to necessarily persuade someone to not do something. They see that as the reason to make those changes. In addition, since there is disagreement from spritemaints about the matter, it could be altered given time and discussion.