the annual look back at tgstations github fuckups of the year

[nianjiilical]

edit: vekter made a poll https://strawpoll.com/XmZRxEBkwnd


for those not in the know, the tgstation github has milestone categories for fuckup of the year, showcasing the best and brightest of our collective coderbase and the unmitigated power of being an open source game with ten thousand contributors

seeing as december is here i think we should have a look back at 2023 in terms of amazing code moments

my personal favorites:

-having your species datum deleted by your mom

-the day of all the comms breaking

-infinite explosion man

-the object specifically designed to kill mice instead causing mice to become very healthy

for more cool moments check out prior years: 2022 2021 2020 2019 2018 2017

[iansdoor]

For fuck sakes. I cannot find the PR. you will just have to take my word as I had to ask riggle for help to delete the bastards. Slimes were changed to more unique mob and were 100% immune to everything. Figure that out while doing xenobio.

Then there isn't the clear PR, but the golem change with it's innate armor being 55%, while eating plasteel gained another 35% and lastly being augmented with robotic parts made a double e-sword deal .4 damage a swing.

That was all this year

[CPTANT]

I think few things will ever beat infinite explosion man.

[Fikou]

my mother made me nonhuman too

[conrad]

Ah yes the day I was yelled at by the notes are punishment crowd for noting a fellow admin.

[Constellado]

I think few things will ever beat infinite explosion man.

Indeed. I remember laughing my ass off when I first saw the video.

I think one person got a note/ban for being the one to discover the bug too xD I don't have it with me though.

[DATAxPUNGED]

I think few things will ever beat infinite explosion man.

Indeed. I remember laughing my ass off when I first saw the video.

I think one person got a note/ban for being the one to discover the bug too xD I don't have it with me though.

Where is the video? Can you share a link?

[CPTANT]

I think few things will ever beat infinite explosion man.

Indeed. I remember laughing my ass off when I first saw the video.

I think one person got a note/ban for being the one to discover the bug too xD I don't have it with me though.

Where is the video? Can you share a link?

https://www.youtube.com/watch?v=KqZ4uipUPdM

[conrad]

I think one person got a note/ban for being the one to discover the bug too xD I don't have it with me though.

I noted Trexter for doing it, then removed it when he appealed with the bug report. No regrets 10/10 would note again.

[Vekter]

I got to curate the list this year, that was fun.

I'm a big fan of the "Riding the tram causes you to be linked in superposition to it so when it moves, you also move" and Bubblegum can get stuck inside a pAI in very specific circumstances" bugs.

I think infinite explosions takes it for sheer impact, though.

Some of my friends ask me why I keep playing this game. Where else am I going to get shit like "my mother called me a disappointment so my race changed"?

E: I made a poll, it's in the OP. idk what the winner gets. Maybe we get the person who caused it a trophy?

[Timonk]

Look Ma, i made the list! please dont remove my species datum

[Not-Dorsidarf]

Im also die hard for TRAM RIDER

[NecromancerAnne]

Infinite explosion man is honestly so good I want to see it returned as a feature in some fashion.

[oranges]

the foxkin and canid pr does not belong on the list because it was simply a wasted get and didn't actually implement anything.

[iansdoor]

Oh my god.
How did we forget that abomination of rabbit people.
Jumping through whatever and just randomly dying as they broke 8 single panel windows. Also a real reason to call death squad every round.

https://github.com/tgstation/tgstation/pull/79698

[gameaddict07]

Don't forget the infinite growth serum.

[Constellado]

I saw that tram bug the other week.
https://youtu.be/eaUA8w1Jn0o?si=PEn0EzhmOfBCXEWL

[Dax Dupont]

Reminds me of rhumba beat virus before we nerfed it to not keep firing on death.

[Jacquerel]

Honourable mentions:
- Organ refactor testmerge causes gulag teleporter to remove all organs and limbs from your body prior to teleportation.
- Standing next to a table on a moving tram causes your sprite to repeatedly offset vertically until you ascend or descend off the screen completely.

[CMDR_Gungnir]

Infinite explosions man is fantastic, but "Your mother calls you a disappointment so hard that it deletes your species" is a sentence you can only get from SS13.

[vect0r]

I saw that tram bug the other week.
https://youtu.be/eaUA8w1Jn0o?si=PEn0EzhmOfBCXEWL

The same thing happened to me at hilberts, but it lagged for JUST the right amount that the tram impacted me and knocked me into crit.

[RedBaronFlyer]

Not sure if this counts but one of the first rounds of birdshot had this horrible issue where everything kept imploding. It was latenight and killed nearly everyone on the station, when the shuttle arrived it too imploded. IIRC me (the guy in the firesuit) and the captain were some of the only survivors

https://imgur.com/nblmhxN

[Constellado]

Not sure if this counts but one of the first rounds of birdshot had this horrible issue where everything kept imploding. It was latenight and killed nearly everyone on the station, when the shuttle arrived it too imploded. IIRC me (the guy in the firesuit) and the captain were some of the only survivors

https://imgur.com/nblmhxN

Oh my god what.

That is beautiful.

[MooCow12]

Remember when tram station was first tested and it had no floor so when the round started everyone without immediate access to a hardsuit died and if we had modsuits just a year earlier at that point i wouldnt be suprised if everyone that did have immediate access to a modsuit would have also died due to the delay to put it on.

If we were in a timeline where modsuits were just a year sooner we would have had rounds where literally the entire server pop died.

[Timonk]

Remember when tram station was first tested and it had no floor so when the round started everyone without immediate access to a hardsuit died and if we had modsuits just a year earlier at that point i wouldnt be suprised if everyone that did have immediate access to a modsuit would have also died due to the delay to put it on.

If we were in a timeline where modsuits were just a year sooner we would have had rounds where literally the entire server pop died.

you underestimate the power of epinephrine and coffee rushing

[vect0r]

Not sure if this counts but one of the first rounds of birdshot had this horrible issue where everything kept imploding. It was latenight and killed nearly everyone on the station, when the shuttle arrived it too imploded. IIRC me (the guy in the firesuit) and the captain were some of the only survivors

https://imgur.com/nblmhxN

I remember this shift, I was AI if I am not mistaken. What a hellish shift.

[Bepis]

I vaguely remember cooking just not working for a while, thought it had the fuckup of the year tag on it

[Justice12354]

Wasn't there a bug that fucked up the whole game and made people burst into flames out of nowhere or was that last year?

[Indie-ana Jones]

Nobody's fixed donut monkeys yet.

[Vekter]

Honourable mentions:
- Organ refactor testmerge causes gulag teleporter to remove all organs and limbs from your body prior to teleportation.

This never got added to the milestone but 1) it was a testmerge so IMO it's not eligible and 2) the guy who made it got banned from our github for being a transphobe so I would disqualify them anyway.

[Jacquerel]

Honourable mentions:
- Organ refactor testmerge causes gulag teleporter to remove all organs and limbs from your body prior to teleportation.

This never got added to the milestone but 1) it was a testmerge so IMO it's not eligible and 2) the guy who made it got banned from our github for being a transphobe so I would disqualify them anyway.

no this is for a more recent testmerge made by one of our maintainers

[Vekter]

Honourable mentions:
- Organ refactor testmerge causes gulag teleporter to remove all organs and limbs from your body prior to teleportation.

This never got added to the milestone but 1) it was a testmerge so IMO it's not eligible and 2) the guy who made it got banned from our github for being a transphobe so I would disqualify them anyway.

no this is for a more recent testmerge made by one of our maintainers

Something something nickel something every time something two

[GPeckman]

The organ stuff isn't even unique to TG. Goonstation also had issues caused by organs being stored in the body. I mean, just look at the title of this issue report: Foodtech dispenser dispensing my vital orans when I request plates

[Longestarmlonglaw]

This PR killed tgstation

https://github.com/tgstation/tgstation/pull/54041

[Armhulen]

I'll hear you out if you expand on your thesis. Why?

[NecromancerAnne]

I'll hear you out if you expand on your thesis. Why?

Lol this dude hadn't even started playing until after it was merged.

[Longestarmlonglaw]

I'll hear you out if you expand on your thesis. Why?

I dont like increasing the size of weapons. It discourages using the station resources, making you more dependent on your abilities/uplink. I dont like being dependent on my antag abilities all the time, this is a sandbox game, usually problems have multiple solutions, because after this PR, i will be more limited in how i can obtain weapons (and conceal them).

I can see what you mean by "preventing one man armying" but i want to ask who would win? 3 guys with 1 laser each, or 1 guy with 3 laser guns? the trio will most likely win because they can output more damage than the solo guy dual wielding his lasers, assuming he can hit anything since dual wielding has accuracy penalties.

Bulky weapons also make the armory a less enticing target for antags since they cant conceal their ill-gotten gains. Today, if you try and disarm security by spacing their guns, they can easily obtain more from cargo at the cost of a little money and time, guns were also made cheaper in that same pr. You are just wasting their time. (Unless you're trying to steal the reflector trenchcoat). Not to mention since a traitor busted their armory, they'll be on high alert and likely consider arming the entire crew to gun you down at first opportunity.

And for "bypassing ammo restrictions" I think we can have a compromise of a "large" class item, its as big as 2 normal items. You can still store guns in your bag, albeit less so.

Emps are also an energy weapon's weakness, even though you made an emp chemical reaction harder to create, it does not require a large reaction to drain an entire energy arsenal. Antags have their own options for doing EMPs, assuming they dont use the crew's emp chem bomb method. Emps are practically ubiquitous.

That is all i have to say.

[Longestarmlonglaw]

I'll hear you out if you expand on your thesis. Why?

Lol this dude hadn't even started playing until after it was merged.

I've played on yogstation before, most of their guns can fit in bags

[Timonk]

I don't like it so it killed tgstation

[dendydoom]

I'll hear you out if you expand on your thesis. Why?

thesis

i like it for 2 things:
firstly, spacing/looting the armoury is not some genius high level tactic. as a warden there was more of less an 80% chance of someone trying this every single round. i'm glad it's rarer now because it's the same high risk for less tangible reward. people still do it, but it's not as often and not as bad when they get away with it.

secondly, it restricts the crew too: a single secoff also can't loot 5 laser guns and then wipe out the entire rogue's gallery without the need for a recharger. those little red shirted shits are encouraged to work together.

[kinnebian]

those little red shirted shits are encouraged to work together.

hey arent you a warden main
youre a red shirted shit too!

[TheLoLSwat]

I'll hear you out if you expand on your thesis. Why?

Bulky weapons also make the armory a less enticing target for antags since they cant conceal their ill-gotten gains. Today, if you try and disarm security by spacing their guns, they can easily obtain more from cargo at the cost of a little money and time, guns were also made cheaper in that same pr. You are just wasting their time. (Unless you're trying to steal the reflector trenchcoat). Not to mention since a traitor busted their armory, they'll be on high alert and likely consider arming the entire crew to gun you down at first opportunity.

I don’t know about it being easy when your options of restocking the armory are slowly ordering a crate every 10-15 minutes or strongarming cargo and then having to share with them. Concealment issues is also kinda a skill issue because you can still put guns in a crate and run off.

Armory is high risk high reward for a reason, cleaning it out is relatively difficult but there’s still plenty of reasoning to raid it especially if you nab a hand tele or something similar that makes the job trivial

E: now that I think about it, you don’t even lose out in bulky weapons because dragnet, flashbang / teargas box, baton (on beepsky) and disabler are all normal sized still and you don’t need more than the dragnet and a disabler / baton

[Rageguy505]

I'll hear you out if you expand on your thesis. Why?

Bulky weapons also make the armory a less enticing target for antags since they cant conceal their ill-gotten gains. Today, if you try and disarm security by spacing their guns, they can easily obtain more from cargo at the cost of a little money and time, guns were also made cheaper in that same pr. You are just wasting their time. (Unless you're trying to steal the reflector trenchcoat). Not to mention since a traitor busted their armory, they'll be on high alert and likely consider arming the entire crew to gun you down at first opportunity.

I don’t know about it being easy when your options of restocking the armory are slowly ordering a crate every 10-15 minutes or strongarming cargo and then having to share with them. Concealment issues is also kinda a skill issue because you can still put guns in a crate and run off.

Armory is high risk high reward for a reason, cleaning it out is relatively difficult but there’s still plenty of reasoning to raid it especially if you nab a hand tele or something similar that makes the job trivial

E: now that I think about it, you don’t even lose out in bulky weapons because dragnet, flashbang / teargas box, baton (on beepsky) and disabler are all normal sized still and you don’t need more than the dragnet and a disabler / baton

The head of security has his own departmental budget to buy guns with

[RedBaronFlyer]

Plus, at least on Manuel, if you (security) ask cargo to order you guns they’ll actually order them and ship them to security 9/10. I don’t order and ship guns to security without cause unless I get asked to/there’s a threat like cult/spiders/blob/revs/xenos that requires a mass arming up.

Also yeah it feels like an overwhelming majority of heads of staff are completely unaware of department budgets. They also don’t know how to grant the janitor access to their department through the key system but that’s off topic.