Github Merging
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Github Merging
so, basically, why does oranges keep merging heavily disliked stuff? shouldnt there be something that prevents him from merging (policy wise) without considering what the community wants?
Examples:
https://github.com/tgstation/tgstation/pull/44324
https://github.com/tgstation/tgstation/pull/44530
https://github.com/tgstation/tgstation/pull/42386
all of these were heavily disliked, yet oranges still merged them.
dont get me wrong here, this isnt just oranges, but hes doing most of it.
also a gem i found in my pics, god bless his soul
Examples:
https://github.com/tgstation/tgstation/pull/44324
https://github.com/tgstation/tgstation/pull/44530
https://github.com/tgstation/tgstation/pull/42386
all of these were heavily disliked, yet oranges still merged them.
dont get me wrong here, this isnt just oranges, but hes doing most of it.
also a gem i found in my pics, god bless his soul
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Shaps-cloud
- Code Maintainer
- Joined: Thu Aug 14, 2014 4:25 am
- Byond Username: Shaps
Re: Github Merging
DIVISION BETWEEN THE SERVER AND THE CODEBASE IS-
- bobbahbrown
- Joined: Mon Nov 10, 2014 1:04 am
- Byond Username: Bobbahbrown
- Location: canada
- Contact:
Re: Github Merging
you answered your own post with a post inside your post.
The information contained in this post is intended only for the individual or entity to whom it is addressed. Its contents (including any attachments) may contain confidential and/or privileged information. If you are not an intended recipient, you may not use, disclose, disseminate, copy or print its contents. If you received this post in error, please notify the sender by reply post and delete and destroy the message.
L’information contenue dans ce message est destinée exclusivement aux personnes ou aux entités auxquelles le message est adressé. Le contenu de ce message (y compris toute pièce jointe) peut renfermer de l’information confidentielle et / ou privilégiée. Si ce message ne vous est pas destiné, vous ne pouvez utiliser, divulguer, diffuser, copier ou imprimer son contenu. Si vous avez reçu ce message par erreur, veuillez aviser l’expéditeur en lui faisant parvenir une réponse. De plus, veuillez supprimer et détruire le message.
- wesoda25
- Joined: Thu Aug 10, 2017 9:32 pm
- Byond Username: Wesoda25
Re: Github Merging
Probably the most intelligent deitus post I’ve ever seen. But to a degree I feel a “dictator” like codebase is necessary, because the masses really never do seem to know what they actually want. In some select cases its seemed almost antagonistic of the coders to keep certain features, especially when votes have proven they are in the minority. But I suppose thats the price we have to pay for the stability that figures such as oranges bring to SS13.
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
my point is it shouldn't be like thatbobbahbrown wrote:you answered your own post with a post inside your post.
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Screemonster
- Joined: Sat Jul 26, 2014 7:23 pm
- Byond Username: Scree
Re: Github Merging
just because a majority vote agrees on something doesn't make it a good idea
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
i mean, there is a player poll feature and when was the last time a testmerge got unmerged?wesoda25 wrote:because the masses really never do seem to know what they actually want
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
yea, some of this may not seem like a good idea, but that's what the players want, and not for it to be removed.Screemonster wrote:just because a majority vote agrees on something doesn't make it a good idea
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- wesoda25
- Joined: Thu Aug 10, 2017 9:32 pm
- Byond Username: Wesoda25
Re: Github Merging
It’s usually rare for a feature removal of testmerge stuff bc for it to be testmerged in the first place, coders are usually on board. By the test merge, any flaws coders see are ironed out and its deemed ready for the game. Theres been lots tho im sure, none I could list off the top of my head tho.Timonk wrote:i mean, there is a player poll feature and when was the last time a testmerge got unmerged?wesoda25 wrote:because the masses really never do seem to know what they actually want
- Arianya
- In-Game Game Master
- Joined: Tue Nov 08, 2016 10:27 am
- Byond Username: Arianya
Re: Github Merging
This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.
If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.
If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.
Frequently playing as Aria Bollet on Bagil & Scary Terry
Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Github Merging
Not sure why you locked this thread after this post. I believe the suggestion is to reform the current system into a policy that the server has some say over, which is a valid point of discussion in here, like it or not.Arianya wrote:This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.
If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.
A "democratic" pull request process is absolutely something that could hypothetically be put in place as a policy.
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
-
- Joined: Fri Sep 22, 2017 4:06 am
- Byond Username: SpaceManiac
- Github Username: SpaceManiac
Re: Github Merging
Game design is not and should not be a popularity contest
- Arianya
- In-Game Game Master
- Joined: Tue Nov 08, 2016 10:27 am
- Byond Username: Arianya
Re: Github Merging
That's incredibly wild hypothetical on your part - realistically one that could only be implemented by fork of the codebase or the codebase ceding to it. Regardless, this thread is in violation of the Policy Discussion rules:PKPenguin321 wrote:Not sure why you locked this thread after this post. I believe the suggestion is to reform the current system into a policy that the server has some say over, which is a valid point of discussion in here, like it or not.Arianya wrote:This isn't for Policy Discussions - the administration (including the headmins) have no greater say in what gets merged then the average player does.
If you're interested in asking oranges about his rationale I suggest posting in the coding subforum - Coding or Feedback, probably.
A "democratic" pull request process is absolutely something that could hypothetically be put in place as a policy.
4.) This board is for discussing in-game administrative policy and rules, including in-game server configuration; coding policies and rules is discussed in #coderbus viewtopic.php?f=2&t=150
Frequently playing as Aria Bollet on Bagil & Scary Terry
Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
Source of avatar is here: https://i.imgur.com/hEkADo6.jpg
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Github Merging
Strong agree. Its good that players are interested in the state of the game and its development direction. They should actively share how they feel about changes and make/suggest some. But many necessary changes would not currently exist if every change were subject to even more political games and hand wringing. Getting to vote about changes feels good for the randoms that cast votes, but merely playing the game does not grant special insight into how the game functions nor does it provide a stable field on which the game can be developed.SpaceManiac wrote:Game design is not and should not be a popularity contest
This also opens the door to code changes by coders people like for reasons other than their code gaining more support for their changes not because they are good changes, but because the coder is popular or charismatic and pulls more people to upvote their code.
Keep democratic memes out of the codebase
- Jimmius
- Joined: Wed Dec 19, 2018 11:00 pm
- Byond Username: Jimmius
Re: Github Merging
yeah let's do a global player poll on every server for every PR before it gets merged, even minor bugfixes, there are no downsides to this at all
unless you're saying a pr being merged or not should be decided by the upvotes and downvotes it gets on github, which is even funnier honestly
unless you're saying a pr being merged or not should be decided by the upvotes and downvotes it gets on github, which is even funnier honestly
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Github Merging
Going to say that this is superseded by the act of proposing new policy, which I explicitly allowed in the board guidlines (see https://tgstation13.org/phpBB/viewtopic ... 33&t=11057)Arianya wrote:4.) This board is for discussing in-game administrative policy and rules, including in-game server configuration; coding policies and rules is discussed in #coderbus viewtopic.php?f=2&t=150
Normally coding changes would be moved out, yes, but this thread is specifically about proposing a new server policy that handles how we interact with code.
Whether what's proposed in this thread is a good idea or not should be discussed, and whether it should be locked and resolved is up to headmins (or on rare occasion a moderator if the thread goes wildly out of hand), not you.
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- wesoda25
- Joined: Thu Aug 10, 2017 9:32 pm
- Byond Username: Wesoda25
Re: Github Merging
I think a system where if a feature is controversial enough, and its put to vote in game and say X% of active players vote X% majority, coders have to honor the polls decision. This way only truly horrific features which are universally hated can be put up for removal, a check of sorts.
The “teehee every bugfix vote” is idiotic and we know it. What I proposed obviously wouldn’t be a perfect system, nor should it be the finished product, but would giving the players some sort of insurance against the will of coders.
The “teehee every bugfix vote” is idiotic and we know it. What I proposed obviously wouldn’t be a perfect system, nor should it be the finished product, but would giving the players some sort of insurance against the will of coders.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
I would agree if maintainers actually gave a damn about quality control.cedarbridge wrote:Strong agree. Its good that players are interested in the state of the game and its development direction. They should actively share how they feel about changes and make/suggest some. But many necessary changes would not currently exist if every change were subject to even more political games and hand wringing. Getting to vote about changes feels good for the randoms that cast votes, but merely playing the game does not grant special insight into how the game functions nor does it provide a stable field on which the game can be developed.SpaceManiac wrote:Game design is not and should not be a popularity contest
This also opens the door to code changes by coders people like for reasons other than their code gaining more support for their changes not because they are good changes, but because the coder is popular or charismatic and pulls more people to upvote their code.
Keep democratic memes out of the codebase
So many controversial obviously bug filled Prs getting merged.
We need a little bit more than just the bare minimum that is instantly closing the obvious meme PRs.
Coders should be forced to fix the issues in their ideas if they want it merged. A half-baked idea only harms the people that actually play the game.
Tsk tsk tsk.
► Show Spoiler
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Github Merging
Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.
- wesoda25
- Joined: Thu Aug 10, 2017 9:32 pm
- Byond Username: Wesoda25
Re: Github Merging
Fans of the NBA don’t play the game.cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Github Merging
You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.wesoda25 wrote:Fans of the NBA don’t play the game.cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
Maybe a mix of that? Make a player poll for controversial PRs?Jimmius wrote:yeah let's do a global player poll on every server for every PR before it gets merged, even minor bugfixes, there are no downsides to this at all
unless you're saying a pr being merged or not should be decided by the upvotes and downvotes it gets on github, which is even funnier honestly
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
I mean the NBA viewers are basically the audience on YouTube, etc. and we are the basketball players?cedarbridge wrote:You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.wesoda25 wrote:Fans of the NBA don’t play the game.cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Github Merging
How on Earth did you come to such a terrible conclusion?Timonk wrote:I mean the NBA viewers are basically the audience on YouTube, etc. and we are the basketball players?cedarbridge wrote:You're right. They pay for the tickets and attend the game. You log onto a server running the codebase's code. They play the game you want a hand in: the code.wesoda25 wrote:Fans of the NBA don’t play the game.cedarbridge wrote:Exactly which part of "give a bunch of non-coders a vote on what counts for good code" suddenly makes the code better? You don't make the NBA better by having the fans in the bleachers write the rules.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
Because we play the game while the greedy team owners make terrible business decisions
► Show Spoiler
-
- Joined: Fri Sep 22, 2017 4:06 am
- Byond Username: SpaceManiac
- Github Username: SpaceManiac
Re: Github Merging
This basketball analogy is clearly too confusing, if it's so easy to equate "playing spacemans" with "playing pro basketball" just because they're both called "playing".
Coding involves work. The best way to influence the direction of the codebase is to put in that work.
Coding involves work. The best way to influence the direction of the codebase is to put in that work.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
I'm sick of all the work being half-assed and being accepted.
Because ultimately it harms the player.
The player is sick of being abused! aaaaa
Because ultimately it harms the player.
The player is sick of being abused! aaaaa
► Show Spoiler
- NoxVS
- In-Game Admin
- Joined: Sun Apr 22, 2018 7:43 pm
- Byond Username: NoxVS
Re: Github Merging
I can’t really think of a better system than what we have here. While there are some moments that I think democracy would be better, there are also moments where something is changed for the better despite all people wanting otherwise separated chemicals
The weak should fear the strong
thehogshotgun wrote:How does having jannies like you, who have more brain tumor than brain benefit the server
- Steelpoint
- Github User
- Joined: Thu Apr 17, 2014 6:37 pm
- Byond Username: Steelpoint
- Github Username: Steelpoint
- Location: The Armoury
Re: Github Merging
Outside the scope of this, but I always thought there was a 24 hour rule to merging new pull requests?
Realistically, and on topic, nothing will change.
Realistically, and on topic, nothing will change.
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Github Merging
I'm guessing that's the only way that metaphor got confused. "I consume the thing so I'm best suited to dictate how the thing is made" makes no sense in either of those cases.SpaceManiac wrote:This basketball analogy is clearly too confusing, if it's so easy to equate "playing spacemans" with "playing pro basketball" just because they're both called "playing".
Coding involves work. The best way to influence the direction of the codebase is to put in that work.
Entitlement without actual entitlement.Shadowflame909 wrote:Because we play the game while the greedy team owners make terrible business decisions
- Dax Dupont
- In-Game Admin
- Joined: Sun Apr 20, 2014 9:07 pm
- Byond Username: DaxYeen
- Github Username: DaxDupont
- Location: Belgium
- Qbmax32
- Joined: Sun Feb 19, 2017 4:05 am
- Byond Username: Qbmax32
- Github Username: qbmax32
- Location: in your walls
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
I actually agreed with pretty much of all of Kors design decisions but I'm still unsure if there was actually a point of time, even in Kor's time. That people actually had any convincing power over the maintainers.
Basically oligarchs now.
Which makes me quite the aggro'd gamer when broken half-baked PRs get merged instead of maintainers forcing lame shitters to fix their own PRs.
I know that even the current maintainers don't give a fuck about the current issue tracker (Some of them do. I guess, otherwise that whole code lock-down thing would have never happened.) But I don't think we should just allow code to break mechanics and gimmicks very noticeably and just wait for someone else to code a fix for it because you like the PR.
That's so lazy and WYCI is going to crash and burn /tg/station with no survivors because with minimal design direction other then "shake up the meta to keep power-gamers on their toes" and "nerf this old feature because players have gotten too reliant on it" you're going to end up in a state of entropy where the game literally is too convoluted to do anything enjoyable anymore.
So yeah, you're going to turn us into paradise maintainers!
Basically oligarchs now.
Which makes me quite the aggro'd gamer when broken half-baked PRs get merged instead of maintainers forcing lame shitters to fix their own PRs.
I know that even the current maintainers don't give a fuck about the current issue tracker (Some of them do. I guess, otherwise that whole code lock-down thing would have never happened.) But I don't think we should just allow code to break mechanics and gimmicks very noticeably and just wait for someone else to code a fix for it because you like the PR.
That's so lazy and WYCI is going to crash and burn /tg/station with no survivors because with minimal design direction other then "shake up the meta to keep power-gamers on their toes" and "nerf this old feature because players have gotten too reliant on it" you're going to end up in a state of entropy where the game literally is too convoluted to do anything enjoyable anymore.
So yeah, you're going to turn us into paradise maintainers!
► Show Spoiler
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
are you telling me you would merge something that literally nobody wants?SpaceManiac wrote:Game design is not and should not be a popularity contest
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Jimmius
- Joined: Wed Dec 19, 2018 11:00 pm
- Byond Username: Jimmius
Re: Github Merging
hello i wanted all three of the prs in the OP mergedTimonk wrote:are you telling me you would merge something that literally nobody wants?SpaceManiac wrote:Game design is not and should not be a popularity contest
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
So say this topic inspires new policy and the community gets a greater say in merges. Hypothetically, let's say something unpopular needs to get merged and, in hindsight, that thing will be good for the server. Do you think the community would be able to make the right choice and allow it to be merged?Timonk wrote:yea, some of this may not seem like a good idea, but that's what the players want, and not for it to be removed.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
If it needed to be merged then it wouldn't be unpopular.
Sorry gamer, but the maintaners and the players want a whole different game.
Sorry gamer, but the maintaners and the players want a whole different game.
► Show Spoiler
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
Do you really think the majority of players wanted seperated chems and null crates removed? Emagging the cargo console is basically useless now unless you want that static weak gamer gear for 5k or soIkeTG wrote:Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
That wasn't my question.Timonk wrote:Do you really think the majority of players wanted seperated chems and null crates removed?
- Timonk
- Joined: Thu Nov 15, 2018 6:27 pm
- Byond Username: Timonk
- Location: ur mum
Re: Github Merging
Kinda answered that first part though
joooks wrote:Quoting a legend, at least im not a faggot lolNaloac wrote:
In short, this appeal is denied. Suck my nuts retard.
See you in 12 months unless you blacklist me for this
Timberpoes wrote: ↑ I'm going to admin timonk [...]. Fuck it, he's also now my second host vote if goof rejects.
pikeyeskey13 wrote: ↑ ok don't forget to shove it up your ass lmao oops u can delete this one I just wanted to make sure it went through
Agux909 wrote:Woah bravo there sir, post of the month you saved the thread. I feel overwhelmed by the echo of unlimited wisdom and usefulness sprouting from you post. Every Manuel player now feels embarrased to exist because of your much NEEDED wise words, you sure teached'em all, you genius, IQ lord.Timonk wrote:This is why we make fun of Manuel
The hut has perished at my hands.
The pink arrow is always right.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
Because I have no reason not to.IkeTG wrote:Do you believe this will be the case every single time there's an unpopular PR? Why should we trust the community's foresight?Shadowflame909 wrote:If it needed to be merged then it wouldn't be unpopular.
► Show Spoiler
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
You're arguing that oranges doesn't give a good enough reason why something was merged, but here you are not giving a good enough reason why something shouldn't be merged. How would applying this topic's policy change anything except making a force in the codebase that's way harder to hold accountable?
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
No, I'm upset that so much broken code gets merged and the maintainers shove it onto other people to fix it. "eventually"
If the bug is obvious, then the coder should fix their own shit before it gets merged. We shouldn't accept the half-baked code.
That's all I'm saying. If the maintainers aren't willing to do so. Then maybe the players would have more interest in the quality of life of /tg/station. Since they're the ones actually dealing with it.
If the bug is obvious, then the coder should fix their own shit before it gets merged. We shouldn't accept the half-baked code.
That's all I'm saying. If the maintainers aren't willing to do so. Then maybe the players would have more interest in the quality of life of /tg/station. Since they're the ones actually dealing with it.
► Show Spoiler
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
You're trying to frame the issue of bugs as a matter of laziness or irresponsibility because it's easier to attack those two points. "If the bug is obvious..." If all the bugs are so obvious, why are all the players, who in your eyes are perfectly capable of vetting merges, not fixing them right now?
If you want meaningful change you need to make a good, solid case for the change. Otherwise, you're just beating around the bush and squabbling over what if's.
If you want meaningful change you need to make a good, solid case for the change. Otherwise, you're just beating around the bush and squabbling over what if's.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
That's the problem. We have over 1000 bugs that the maintainers seemingly don't care about because of how "wonky" the issue tracker is.
We don't need any PRs adding more of them.
It's a quality of life thing. And maintainers aren't living up to quality control.
The only real aspect of that I've seen is just instantly closing meme PRs as PK Penguin adds in a dildo PR. Or another counter-nerf PR's that happen out of outrage.
I just want more quality control.
Because of the current standard of accepting quirks and issues within a PR only makes the game worse.
Also Hint, if the ever-growing issue logger isn't a sign. Those issues don't get fixed.
We don't need any PRs adding more of them.
It's a quality of life thing. And maintainers aren't living up to quality control.
The only real aspect of that I've seen is just instantly closing meme PRs as PK Penguin adds in a dildo PR. Or another counter-nerf PR's that happen out of outrage.
I just want more quality control.
Because of the current standard of accepting quirks and issues within a PR only makes the game worse.
Also Hint, if the ever-growing issue logger isn't a sign. Those issues don't get fixed.
► Show Spoiler
- IkeTG
- Joined: Wed Feb 24, 2016 2:03 am
- Byond Username: LizardDreams
- Location: Here, Now
Re: Github Merging
You're saying quality control but you aren't making a visible case as to what you mean by quality control or how you think one could work towards achieving this quality control. This is a good example of why giving players a say in what gets merged would make things more confusing and less efficient, simply because a lot of players would say Thing Bad but couldn't feasibly elaborate on workable solutions or alternatives.
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Github Merging
itt people with no understanding of how to run a codebase
- wesoda25
- Joined: Thu Aug 10, 2017 9:32 pm
- Byond Username: Wesoda25
Re: Github Merging
Separated chems were cancer, good PR. Null crates were cancer, good PR. Autocloning was cancer, good PR.
If you’re gonna quote features for your argument at least address stuff like hygiene.
If you’re gonna quote features for your argument at least address stuff like hygiene.
- Shadowflame909
- Joined: Mon Jun 05, 2017 10:18 pm
- Byond Username: Shadowflame909
- Location: Think about something witty and pretend I put it here
Re: Github Merging
If you want some examples. When I look at the recent PRs. I get really annoyed at the disregard of simple mob functions and their antagonists. You nerfed dragging but gave people a feasible alternative. (Almost didn't exist until PKpenguin came up with the idea. But the execution ended up just being another roundabout minor movement speed nerf.) The problem with this was, is that simple mobs were not addressed and ultimately ignored. Because "They're not important enough for me to care" as oranges put it so eloquently.
On another example, stasis. It left some gaps to fill in medbay as it made doctors even more useless and forced people to rely on an unreliable role. It wasn't a 1:1 replacement as the maintainer who merged it put it, and hoped that it would inspire people either out of anger or frustration to fix medbay themselves.
It didn't, and the maintainer themselves had to add in a bit more to keep medical doctors busy.
These issues would both be addressed by some quality control that I'm looking for. A simple, "Your PR has issues like ___ and until they get fixed. This is simply not compatible with our code-base."
You cannot rely on people to care about things that do not affect them. You have to give them a reason to care. Maybe a coder would fix the botched PRs after a month passes and they realize "Hey. Why does this role suck so much? How come no one fixed this?" But I feel like this could ultimately be more easily addressed by just having the original person. Either fix it or not merge their half-baked idea at all.
To simply put it. I want it to be the original coder's problem. They only care whether their nerf PR gets merged or not. Why shouldn't the maintainers make them care about the issues their nerf PR brings up?
This is what confuses me.
On another example, stasis. It left some gaps to fill in medbay as it made doctors even more useless and forced people to rely on an unreliable role. It wasn't a 1:1 replacement as the maintainer who merged it put it, and hoped that it would inspire people either out of anger or frustration to fix medbay themselves.
It didn't, and the maintainer themselves had to add in a bit more to keep medical doctors busy.
These issues would both be addressed by some quality control that I'm looking for. A simple, "Your PR has issues like ___ and until they get fixed. This is simply not compatible with our code-base."
You cannot rely on people to care about things that do not affect them. You have to give them a reason to care. Maybe a coder would fix the botched PRs after a month passes and they realize "Hey. Why does this role suck so much? How come no one fixed this?" But I feel like this could ultimately be more easily addressed by just having the original person. Either fix it or not merge their half-baked idea at all.
To simply put it. I want it to be the original coder's problem. They only care whether their nerf PR gets merged or not. Why shouldn't the maintainers make them care about the issues their nerf PR brings up?
This is what confuses me.
► Show Spoiler
Who is online
Users browsing this forum: No registered users