rip toxins
- Rohen_Tahir
- Joined: Wed Jun 05, 2019 1:00 pm
- Byond Username: Rohen Tahir
- Location: Primary fool storage
- Contact:
- Jonathan Gupta
- Joined: Sun Feb 21, 2021 10:16 pm
- Byond Username: BallastMonsterGnarGnar
- Location: The Corner
Re: rip toxins
whats next engineering?Rohen_Tahir wrote:toxins is getting removed this week
- Nabski
- Joined: Thu Oct 20, 2016 5:42 pm
- Byond Username: Nabski
- Github Username: Nabski89
- Location: TN
Re: rip toxins
what?
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
- Rohen_Tahir
- Joined: Wed Jun 05, 2019 1:00 pm
- Byond Username: Rohen Tahir
- Location: Primary fool storage
- Contact:
Re: rip toxins
It's true. The removal PR was opened on Sunday.sinfulbliss wrote:Lies and falsehood.
- Omega_DarkPotato
- In-Game Admin Trainer
- Joined: Thu Jun 11, 2020 12:05 am
- Byond Username: Omega_DarkPotato
- Location: Former Hell, Gensokyo
Re: rip toxins
https://github.com/tgstation/tgstation/pull/60619
imo
ordnance is infinitely cooler and far more accurate
imo
ordnance is infinitely cooler and far more accurate
play opus: echo of starsongSuper Aggro Crag wrote:This is what u get when u let people into your community
I'm an admin, typically on /tg/station Sybil. If you've got anything you'd like to say about me, my adminning, or my decisions, please comment in my admin feedback thread!
- Armhulen
- Global Moderator
- Joined: Thu Apr 28, 2016 4:30 pm
- Byond Username: Armhulenn
- Github Username: bazelart
- Location: The Grand Tournament
Re: rip toxins
This mostly has some serious code improvement behind it, the front end is whatever
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
Spoiler:
- EOBGames
- Code Maintainer
- Joined: Tue Nov 12, 2019 1:10 am
- Byond Username: EOBGames
- Location: Unamerican Scottish Fuck in Scotland
- Contact:
Re: rip toxins
What will those crazy coders do next
Everyone's favourite internewt. Je maptiendrai.
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Fluff Images:
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Spoiler:
► Show Spoiler
- TheFinalPotato
- Code Maintainer
- Joined: Sun Oct 13, 2019 7:58 am
- Byond Username: LemonInTheDark
Re: rip toxins
what?sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
You heard me, green man.TheFinalPotato wrote:what?sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
Spoiler:
-
- Joined: Fri Nov 10, 2017 12:16 am
- Byond Username: Tlaltecuhtli
Re: rip toxins
orangedance? what a terrible name
- TheFinalPotato
- Code Maintainer
- Joined: Sun Oct 13, 2019 7:58 am
- Byond Username: LemonInTheDark
Re: rip toxins
excuse me?sinfulbliss wrote:You heard me, green man.TheFinalPotato wrote:what?sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
I said...TheFinalPotato wrote:excuse me?sinfulbliss wrote:You heard me, green man.TheFinalPotato wrote:what?sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.
What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
Spoiler:
- Agux909
- Joined: Mon Oct 07, 2019 11:26 pm
- Byond Username: Agux909
- Location: My own head
Re: rip toxins
Genetics= DeviationsEOBGames wrote:What will those crazy coders do next
Xenobiology= Bio-tampering
Robotics= Borg Assembly
- wet socks
- Joined: Mon Apr 22, 2019 10:26 pm
- Byond Username: AarontheIdiot
- Location: under a rock
-
- Forum Soft Banned
- Joined: Sat Jun 02, 2018 10:27 am
- Byond Username: Cacogen
Re: rip toxins
in a rare moment of self-restraint i opted not to say ordnance sounds off but now i will. i think it needs to refer to the relevant scientific field
technokek wrote:Cannot prove this so just belive me if when say this
NSFW:
- Rohen_Tahir
- Joined: Wed Jun 05, 2019 1:00 pm
- Byond Username: Rohen Tahir
- Location: Primary fool storage
- Contact:
Re: rip toxins
So physics?cacogen wrote:in a rare moment of self-restraint i opted not to say ordnance sounds off but now i will. i think it needs to refer to the relevant scientific field
-
- Forum Soft Banned
- Joined: Sat Jun 02, 2018 10:27 am
- Byond Username: Cacogen
Re: rip toxins
no, something more specific
technokek wrote:Cannot prove this so just belive me if when say this
NSFW:
- wubli
- Joined: Sat May 13, 2017 6:10 am
- Byond Username: Wubli
Re: rip toxins
Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
- Agux909
- Joined: Mon Oct 07, 2019 11:26 pm
- Byond Username: Agux909
- Location: My own head
Re: rip toxins
There there. But yeah, what it does is basically this:wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
All references for the science department are now labeled "Ordnance" instead of "Toxins"
All references for plasma as the gas are now labeled "Plasma" instead of "Toxins"
References for toxin damage are still labeled "Toxins"
So now the code is less of a spaghetti mess when having to rummage through it for toxin references.
- Rohen_Tahir
- Joined: Wed Jun 05, 2019 1:00 pm
- Byond Username: Rohen Tahir
- Location: Primary fool storage
- Contact:
Re: rip toxins
░░░░░▄▄▄▄▀▀▀▀▀▀▀▀▄▄▄▄▄▄░░░░░░░wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
░░░░░█░░░░▒▒▒▒▒▒▒▒▒▒▒▒░░▀▀▄░░░░
░░░░█░░░▒▒▒▒▒▒░░░░░░░░▒▒▒░░█░░░
░░░█░░░░░░▄██▀▄▄░░░░░▄▄▄░░░░█░░
░▄▀▒▄▄▄▒░█▀▀▀▀▄▄█░░░██▄▄█░░░░█░
█░▒█▒▄░▀▄▄▄▀░░░░░░░░█░░░▒▒▒▒▒░█
█░▒█░█▀▄▄░░░░░█▀░░░░▀▄░░▄▀▀▀▄▒█
░█░▀▄░█▄░█▀▄▄░▀░▀▀░▄▄▀░░░░█░░█░
░░█░░░▀▄▀█▄▄░█▀▀▀▄▄▄▄▀▀█▀██░█░░
░░░█░░░░██░░▀█▄▄▄█▄▄█▄████░█░░░
░░░░█░░░░▀▀▄░█░░░█░█▀██████░█░░
░░░░░▀▄░░░░░▀▀▄▄▄█▄█▄█▄█▄▀░░█░░
░░░░░░░▀▄▄░▒▒▒▒░░░░░░░░░░▒░░░█░
░░░░░░░░░░▀▀▄▄░▒▒▒▒▒▒▒▒▒▒░░░░█░
░░░░░░░░░░░░░░▀▄▄▄▄▄░░░░░░░░█░░
- EOBGames
- Code Maintainer
- Joined: Tue Nov 12, 2019 1:10 am
- Byond Username: EOBGames
- Location: Unamerican Scottish Fuck in Scotland
- Contact:
Re: rip toxins
Perhaps it could refer to the production of explosives- something like Ordnance, maybe?cacogen wrote:no, something more specific
Everyone's favourite internewt. Je maptiendrai.
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Fluff Images:
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Spoiler:
► Show Spoiler
- MMMiracles
- Code Maintainer
- Joined: Fri Aug 29, 2014 2:27 am
- Byond Username: MMMiracles
- Github Username: MMMiracles
-
- Forum Soft Banned
- Joined: Sat Jun 02, 2018 10:27 am
- Byond Username: Cacogen
Re: rip toxins
no, i was thinking something more in line with genetics or robotics or xenobiology or cytology
Last edited by cacogen on Mon Aug 02, 2021 5:37 pm, edited 1 time in total.
technokek wrote:Cannot prove this so just belive me if when say this
NSFW:
- Agux909
- Joined: Mon Oct 07, 2019 11:26 pm
- Byond Username: Agux909
- Location: My own head
Re: rip toxins
Well, what is artillery exactly?MMMiracles wrote:i thought ordnance meant like artillery
Last edited by Agux909 on Mon Aug 02, 2021 5:29 pm, edited 1 time in total.
- EOBGames
- Code Maintainer
- Joined: Tue Nov 12, 2019 1:10 am
- Byond Username: EOBGames
- Location: Unamerican Scottish Fuck in Scotland
- Contact:
Re: rip toxins
Technically it's a title for any military explosive, bombs and such would qualify too.MMMiracles wrote:i thought ordnance meant like artillery
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.
Everyone's favourite internewt. Je maptiendrai.
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Fluff Images:
In the rare event that I'm on the server, I'm either Inept-At-Job or Kayden Riker. Accept no substitutes.
If you've gotta contact me, hit me up on discord, as I don't really check forum DMs: @Emerald_or_Bust#1314
Spoiler:
► Show Spoiler
-
- Joined: Fri Nov 10, 2017 12:16 am
- Byond Username: Tlaltecuhtli
Re: rip toxins
well this isnt tg mc , so military explosives arent what they make, toxin should be changed to boomer department as they make shit go boomEOBGames wrote:Technically it's a title for any military explosive, bombs and such would qualify too.MMMiracles wrote:i thought ordnance meant like artillery
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
Personally ordnance is a kinda quirky word which doesn’t really roll off the tongue easily cause of the double “dn” consonants. Feels weird to say. Maybe for Brits...EOBGames wrote:Technically it's a title for any military explosive, bombs and such would qualify too.MMMiracles wrote:i thought ordnance meant like artillery
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.
Why not just “Explosives”? I doubt many people know what “ordnance” means offhand.
Spoiler:
- Pandarsenic
- Joined: Fri Apr 18, 2014 11:56 pm
- Byond Username: Pandarsenic
- Location: AI Upload
Re: rip toxins
I'm with the "Boomer Department" thing here
(2:53:35 AM) scaredofshadows: how about head of robutts
I once wrote a guide to fixing telecomms woohoo
I once wrote a guide to fixing telecomms woohoo
- EuSouAFazenda
- Joined: Sat Jul 17, 2021 1:34 pm
- Byond Username: EuSouAFazenda
- Location: Brazil
Re: rip toxins
Someone coded this.Agux909 wrote:There there. But yeah, what it does is basically this:wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
All references for the science department are now labeled "Ordnance" instead of "Toxins"
All references for plasma as the gas are now labeled "Plasma" instead of "Toxins"
References for toxin damage are still labeled "Toxins"
So now the code is less of a spaghetti mess when having to rummage through it for toxin references.
I remade the beach away mission
- cocothegogo
- Joined: Tue Nov 25, 2014 10:11 pm
- Byond Username: Cocothegog0
- Location: Brazil
Re: rip toxins
my uncle is oranges and he says there gonna remove fun from the game next
- Gigapuddi420
- Joined: Fri May 19, 2017 8:08 am
- Byond Username: Gigapuddi420
- Location: Dorms
- Capsandi
- Joined: Sat Jan 26, 2019 10:59 pm
- Byond Username: Capsandi
Re: rip toxins
I would be so pissed at the pr renaming the toxins department if 'ordnance' didn't sound 100x cooler
Lower your tone with me if your tracked play time doesn't look like this:Timonk wrote:You have clearly never seen his dickWesoda25 wrote:Genuinely think they should be blacklisted.
Flatulent wrote:of course you can change religion doing it while islamic however makes you lose your head from happiness
- XivilaiAnaxes
- Joined: Sat May 11, 2019 7:13 am
- Byond Username: XivilaiAnaxes
Re: rip toxins
This is a stupid complaint who gives a fuck what a niche part of science is labelled as.
It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
Stickymayhem wrote:Imagine the sheer narcisssim required to genuinely believe you are this intelligent.
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
You know what, you're right. Coders deserve a break. I therefore propose a new system.XivilaiAnaxes wrote:This is a stupid complaint who gives a fuck what a niche part of science is labelled as.
It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
For ease of use, I propose we get rid of the departmental names entirely. We replace them with something simple, so it's most efficient on the backend.
"Genetics" will be "G"
"Xenobiology" will be "X"
Toxins will be "T"
Sec will be "S"
And so forth. This should greatly simplify matters.
(Note: in cases where there are conflicts (i.e., science and sec both "S"), we can use more letters. So "SCI" and "SEC.")
Spoiler:
- Mothblocks
- Code Maintainer
- Joined: Fri Jul 27, 2018 9:33 am
- Byond Username: Jaredfogle
Re: rip toxins
Use descriptive and obvious names
Optimize for readability, not writability. While it is certainly easier to write M than victim, it will cause issues down the line for other developers to figure out what exactly your code is doing, even if you think the variable's purpose is obvious.
Don't use abbreviations
Avoid variables like C, M, and H. Prefer names like "user", "victim", "weapon", etc.
// What is M? The user? The target?
// What is A? The target? The item?
/proc/use_item(mob/M, atom/A)
// Much better!
/proc/use_item(mob/user, atom/target)
Unless it is otherwise obvious, try to avoid just extending variables like "C" to "carbon"--this is slightly more helpful, but does not describe the context of the use of the variable.
Optimize for readability, not writability. While it is certainly easier to write M than victim, it will cause issues down the line for other developers to figure out what exactly your code is doing, even if you think the variable's purpose is obvious.
Don't use abbreviations
Avoid variables like C, M, and H. Prefer names like "user", "victim", "weapon", etc.
// What is M? The user? The target?
// What is A? The target? The item?
/proc/use_item(mob/M, atom/A)
// Much better!
/proc/use_item(mob/user, atom/target)
Unless it is otherwise obvious, try to avoid just extending variables like "C" to "carbon"--this is slightly more helpful, but does not describe the context of the use of the variable.
Head Coder of /tg/station, hi!Shaps-cloud wrote: ↑Mon Dec 07, 2020 7:59 am May eventually become one of the illusive maintainer-headmins if they choose to pursue that path, having a coder in the senior admin leadership has usually been positive for both sides in the past.
Head Admin of /tg/station Feb 2022.
Mothblocks everywhere, >>> Say nice things about me <<<
- XivilaiAnaxes
- Joined: Sat May 11, 2019 7:13 am
- Byond Username: XivilaiAnaxes
Re: rip toxins
This is stupid and you should feel bad for posting it.sinfulbliss wrote:You know what, you're right. Coders deserve a break. I therefore propose a new system.XivilaiAnaxes wrote:This is a stupid complaint who gives a fuck what a niche part of science is labelled as.
It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
For ease of use, I propose we get rid of the departmental names entirely. We replace them with something simple, so it's most efficient on the backend.
"Genetics" will be "G"
"Xenobiology" will be "X"
Toxins will be "T"
Sec will be "S"
And so forth. This should greatly simplify matters.
(Note: in cases where there are conflicts (i.e., science and sec both "S"), we can use more letters. So "SCI" and "SEC.")
Stickymayhem wrote:Imagine the sheer narcisssim required to genuinely believe you are this intelligent.
- sinfulbliss
- Joined: Thu Apr 04, 2019 8:53 am
- Byond Username: SinfulBliss
- Location: prisoner re-education chamber
Re: rip toxins
That checks out.Jaredfogle wrote:Use descriptive and obvious names
Optimize for readability, not writability. While it is certainly easier to write M than victim, it will cause issues down the line for other developers to figure out what exactly your code is doing, even if you think the variable's purpose is obvious.
Don't use abbreviations
Avoid variables like C, M, and H. Prefer names like "user", "victim", "weapon", etc.
// What is M? The user? The target?
// What is A? The target? The item?
/proc/use_item(mob/M, atom/A)
// Much better!
/proc/use_item(mob/user, atom/target)
Unless it is otherwise obvious, try to avoid just extending variables like "C" to "carbon"--this is slightly more helpful, but does not describe the context of the use of the variable.
Spoiler:
- TheFinalPotato
- Code Maintainer
- Joined: Sun Oct 13, 2019 7:58 am
- Byond Username: LemonInTheDark
Re: rip toxins
Here's an ss13 alphabet that I not motblocks collected!
Aren't I clever?
Code: Select all
For your entertainment, here's some of the alphabet of SS13, the variable names of real code:
A - Atom, area, admins, augury, advanced disease, arrivals shuttle, asset, award
B - Blob, button, blue, area again (for some reason), blindfold, bomb
C - Carbon, client, simple_animal in create_random_spawn for some reason, count, corner, circuit, cinematic
D - Datum, design, bank account (yes, really), duct, drone
E - Radial entry, explosive, eye, ethereal, edible, emitter
F - Flat, frame, flasher, fire alarm, fire ball, filter, foam
G - Green, ghost, guardian, gloves, goal, high five (again, for seemingly no reason), gang
H - Human, holder, hunter, item (as both h and H in drag_drop.dm), holopad
I - Item, icon, interview, organ, implant, ID, image, immobilized
J - Icon again, job, jaunt, jetpack, cult spell (for seemingly no reason)
K - Keycard, knockdown, kinetic blast, knife
L - List, living, lighting, laws, limb, lungs, loot, turf
M - Mob, month, matrix, mode, machine, message, mobile
N - Nuke, new player, new, area for some reason in weather.dm, nozzle, node
O - Object, observer, objective, robot (for some reason), closet, outfit, body parts
P - Client, paper, node, pack, plumbing, point, player details, projectile
Q - Turf, carbon, query, quirk, reagents
R - Regex, ref, robot, mech, radio, role
S - Silicon, swarmer, shuttle, shelter, start, symptom
T - Turf, techweb, quirk, tackle, temperature, cyborg gun
U - Under, uplink, user, turf, upgrade
V - Vote, vomit, rods, mask, vampire
W - Weakref, weather, item, wound, particle, wall
X - Xenobio, extract, golem, paper
Y - We don't seem to have used Y as a variable name for anything other than y coordinates. Hooray!
Z - Plasma tank, drone, victim
- Yenwodyah
- Joined: Mon Jan 15, 2018 10:47 pm
- Byond Username: Yenwodyah
- Github Username: Yenwodyah
- Mothblocks
- Code Maintainer
- Joined: Fri Jul 27, 2018 9:33 am
- Byond Username: Jaredfogle
Re: rip toxins
what's next engineering?
Head Coder of /tg/station, hi!Shaps-cloud wrote: ↑Mon Dec 07, 2020 7:59 am May eventually become one of the illusive maintainer-headmins if they choose to pursue that path, having a coder in the senior admin leadership has usually been positive for both sides in the past.
Head Admin of /tg/station Feb 2022.
Mothblocks everywhere, >>> Say nice things about me <<<
- Super Aggro Crag
- In Game PermaBanned
- Joined: Sat Mar 21, 2015 9:47 pm
- Byond Username: Super Aggro Crag
Re: rip toxins
Fucking science boomers and their ancient spaghetty department that literally existed only to blow holes in the station
Who is online
Users browsing this forum: No registered users