The item pick-up animation

For feedback on the game code and design. Feedback on server rules and playstyle belong in Policy Discussion.

Moderators: MisterPerson, Code Maintainers

Do you like the item pickup animation?

Yes, it's fine as it is.
14
23%
No, it should be reverted.
37
60%
No, it should be modified. (please specify complaint)
11
18%
 
Total votes : 62

User avatar
subject217
Github User
 
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

The item pick-up animation

Postby subject217 » Sun Jul 22, 2018 9:33 pm #428397

This feature has garnered a lot of controversy in the short time it's been on the server. Rather than trying to argue across PRs like bee lore, I thought it would be worthwhile to discuss it on the forums. Please vote in the poll I've made, and explain your opinions in more detail in the thread.

Personally, I feel that the whole thing is just useless, and the little icon shaking animation that happens whenever an item is put into your hand (including when taking it out of backpacks and the like) is downright ugly. I don't think this feature has any merit to stand upon, and aesthetically it is extremely unappealing.

PRs linked for brevity:
https://github.com/tgstation/tgstation/pull/39231
https://github.com/tgstation/tgstation/pull/39261
thankfully former admin
viewtopic.php?f=27&t=20553



User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: The item pick-up animation

Postby Lumbermancer » Sun Jul 22, 2018 9:39 pm #428398

I like it. It gives you more visual feedback. What someone picked up (say from a big pile of items), what item someone pulled out (say a weapon). Something your character would be aware of, but it's not that obvious in game. It's great from AI perspective too.

But it introduces some pick up delay, which I didn't notice before, it could probably go. |edit| <- it doesn't
Last edited by Lumbermancer on Mon Jul 23, 2018 7:54 am, edited 1 time in total.
aka Schlomo Gaskin aka Guru Meditation aka Copyright Alright aka Topkek McHonk aka Le Rouge
Image

User avatar
Hathkar
 
Joined: Sat Jul 08, 2017 12:41 am
Byond Username: Hathkar

Re: The item pick-up animation

Postby Hathkar » Sun Jul 22, 2018 9:56 pm #428402

Some more visual feedback of who picked what up is nice.

My only complaints are:
The item showing up when you take something out of your bag/pockets. The text message is enough for those.
Not a fan of the pick up delay.
The shaking looks odd and doesn't really fit with the aesthetics.

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: The item pick-up animation

Postby oranges » Sun Jul 22, 2018 10:02 pm #428405

is this a copypaste of the yog forum post?
Image

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: The item pick-up animation

Postby Cobby » Sun Jul 22, 2018 10:02 pm #428406

Remove/Minimize Shaking and scale the speed of the animation with obj weight
Voted best trap in /tg/ 2014-current

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: The item pick-up animation

Postby oranges » Sun Jul 22, 2018 10:03 pm #428407

Lumbermancer wrote:I like it. It gives you more visual feedback. What someone picked up (say from a big pile of items), what item someone pulled out (say a weapon). Something your character would be aware of, but it's not that obvious in game. It's great from AI perspective too.

But it introduces some pick up delay, which I didn't notice before, it could probably go.

It is not supposed to introduce any pickup delay, you have the item in hand as soon as you click on it, the animation should be purely visual, are you sure the delay isn't just in your head?
Image

User avatar
kevinz000
In-Game Admin
 
Joined: Fri Nov 14, 2014 8:41 am
Location: Dorm Room 3
Byond Username: Kevinz000
Github Username: kevinz000

Re: The item pick-up animation

Postby kevinz000 » Sun Jul 22, 2018 10:05 pm #428409

while visual feedback is nice I feel like a simple "item shrinks as it glides 'into' your sprite" is better than the shaking.
overcomplication is not always good, even if it seems like it's more "fancy" than a simple one.

User avatar
Lumbermancer
 
Joined: Fri Jul 25, 2014 3:40 am
Byond Username: Lumbermancer

Re: The item pick-up animation

Postby Lumbermancer » Sun Jul 22, 2018 10:14 pm #428411

oranges wrote:
Lumbermancer wrote:I like it. It gives you more visual feedback. What someone picked up (say from a big pile of items), what item someone pulled out (say a weapon). Something your character would be aware of, but it's not that obvious in game. It's great from AI perspective too.

But it introduces some pick up delay, which I didn't notice before, it could probably go.

It is not supposed to introduce any pickup delay, you have the item in hand as soon as you click on it, the animation should be purely visual, are you sure the delay isn't just in your head?


Unless I'm going senile already, I was able to click-swap hands-click instantly before, there's some delay now, on second click to pick.

--edit

Well nevermind, I just tested and there's no delay. I don't know what happened before, was it in my head or lag induced.
Last edited by Lumbermancer on Sun Jul 22, 2018 10:20 pm, edited 1 time in total.
aka Schlomo Gaskin aka Guru Meditation aka Copyright Alright aka Topkek McHonk aka Le Rouge
Image

User avatar
subject217
Github User
 
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: The item pick-up animation

Postby subject217 » Sun Jul 22, 2018 10:20 pm #428415

oranges wrote:is this a copypaste of the yog forum post?

Is it? I don't browse the Yog forums, but I don't think what I've said or the way I've phrased it is an uncommon opinion in any respect.
thankfully former admin
viewtopic.php?f=27&t=20553

User avatar
Saegrimr
 
Joined: Thu Jul 24, 2014 4:39 pm
Byond Username: Saegrimr

Re: The item pick-up animation

Postby Saegrimr » Sun Jul 22, 2018 10:32 pm #428420

The overlays appear on alt-clicked tiles.
The shake animation looks dumb.
Can be spammed while running down a hall clicking your backpack with something big in your hand
Constant crashing ever since.
tedward1337 wrote:Sae is like the racist grandad who everyone laughs at for being racist, but deep down we all know he's right.

User avatar
subject217
Github User
 
Joined: Tue Jan 23, 2018 11:27 pm
Byond Username: Subject217
Github Username: subject217

Re: The item pick-up animation

Postby subject217 » Sun Jul 22, 2018 10:40 pm #428424

Saegrimr wrote:Constant crashing ever since.

Gonna point out that all the crashes I hear about on this issue are usually people using an old version of 512. I've not been able to replicate the pickup animation causing crashes issue on the latest 512 Beta builds.
thankfully former admin
viewtopic.php?f=27&t=20553

User avatar
Pizzatiger
 
Joined: Mon Jun 05, 2017 2:44 pm
Byond Username: Pizzatiger

Re: The item pick-up animation

Postby Pizzatiger » Mon Jul 23, 2018 12:48 am #428461

subject217 wrote:
Saegrimr wrote:Constant crashing ever since.

Gonna point out that all the crashes I hear about on this issue are usually people using an old version of 512. I've not been able to replicate the pickup animation causing crashes issue on the latest 512 Beta builds.

To be fair we shouldn't have a code that crashes people who don't use the potentially buggy Beta build. If something is going to be added to the game then it should work for the Current Non-beta build

User avatar
ShadowDimentio
 
Joined: Thu May 08, 2014 3:15 am
Byond Username: David273

Re: The item pick-up animation

Postby ShadowDimentio » Mon Jul 23, 2018 12:52 am #428465

Remove the delay, the little shake the items do before picking them up, and the icon appearing when you inventory.
Spoiler:
"Clowns are different you can't trust those shifty fucks you never know what they're doing or if they're willing to eat a dayban for some cheap yuks."
-Not-Dorsidarf

"The amount of people is the amount of times the sound is played... on top of itself. And with sybil populations on the shuttle..."
-Remie Richards

"I just spent all fucking day playing fallen london and sunless sea and obsessing over how creepy the fucking dawn machine is and only just clocked now that your avatar is the fucking dawn machine. Nobody vote for this disgusting new sequence blasphemer he wants to kill the gods"
-Stickymayhem

"Drank a cocktail of orange Gatorade and mint mouthwash on accident. Pretty sure I'm going to die, I am on the verge of vomit. It was nice knowing you guys"
-PKPenguin321

"You're too late, you will have to fetch them from the top of my tower, built by zombies, slaves, zombie slaves and garitho's will to live!"
-Armhulen

"This is like being cooked alive in a microwave oven which utilises the autistic end of the light spectrum to cook you."
-DarkFNC

"Penguins are the second race to realise 2D>3D"
-Anonmare

"Paul Blart mall cops if they all had ambitions of joining the Waffen-SS"
-Anonmare

"These logs could kill a dragon much less a man"
-Armhulenn

">7 8 6
WHAT MADNESS IS THIS? POETIC ANARCHY!"
-Wyzack

"We didn't kick one goofball out only to have another one come in like a fucking revolving door"
-Kraseo

"There's a difference between fucking faggots and being a fucking faggot."
-Anonmare

"You guys splitting the 20 bucks cost to hire your ex again?"
-lntigracy

"Wew. Congrats. It's been actual years since anyone tried to make fun of me for being divorced. You caught me, I'm tilted. Here is your trophy."
-Timbrewolf

"I prefer my coffees to run dry too *snorts a line of maxwell house*"
-Super Aggro Crag

"You don't have an evil bone in your body, unless togopal comes for a sleepover"
-Bluespace

">Paying over a $1000 for a lump of silicon and plastic
Lol"
-Anonmare

"Then why did you get that boob job?"
-DrPillzRedux

"You take that back you colonial mongrel"
-Docprofsmith

"I don't care whether or not someone with an IQ 3 standard deviations below my own thinks they enjoy Wizard rounds."
-Malkraz

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 12:57 am #428466

Inventory effect is a bug and there's literally no inventory delay it's all cosmetic.

The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"

User avatar
Saegrimr
 
Joined: Thu Jul 24, 2014 4:39 pm
Byond Username: Saegrimr

Re: The item pick-up animation

Postby Saegrimr » Mon Jul 23, 2018 1:03 am #428468

iamgoofball wrote:The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"


The only argument for remove it is "I don't like it"
The only argument for keeping it is "I like it"
tedward1337 wrote:Sae is like the racist grandad who everyone laughs at for being racist, but deep down we all know he's right.

User avatar
Lazengann
In-Game Admin
 
Joined: Sat Feb 25, 2017 2:26 pm
Byond Username: Lazengann

Re: The item pick-up animation

Postby Lazengann » Mon Jul 23, 2018 1:03 am #428469

The shake is ugly

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: The item pick-up animation

Postby Cobby » Mon Jul 23, 2018 1:09 am #428471

The shake is not because "I don't like it", it's because it

1) Doesn't convey any information. The item moving to the player conveys who picked up the item, the shaking does not.

2)makes stealing a pain when the object, to no control of your own, goes HEY LOOK IM BEING TAKEN.

The response to number 2 was "lol just don't steal when people are around" so I know i'm wasting my breath on the topic though.
Voted best trap in /tg/ 2014-current

User avatar
PKPenguin321
In-Game Game Master
 
Joined: Tue Jul 01, 2014 7:02 pm
Location: U S A, U S A, U S A
Byond Username: PKPenguin321
Github Username: PKPenguin321

Re: The item pick-up animation

Postby PKPenguin321 » Mon Jul 23, 2018 1:13 am #428473

Somebody suggested having it so that walking and picking something up wouldn't play the animation so you can still have stealth item grabbing and I think that sounds cool
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 1:28 am #428479

No

User avatar
DemonFiren
 
Joined: Sat Dec 13, 2014 9:15 pm
Byond Username: DemonFiren

Re: The item pick-up animation

Postby DemonFiren » Mon Jul 23, 2018 1:48 am #428485

lmao
Image
Image
Image
ImageImageImageImageImage

non-lizard things:
Spoiler:
Image

User avatar
Saegrimr
 
Joined: Thu Jul 24, 2014 4:39 pm
Byond Username: Saegrimr

Re: The item pick-up animation

Postby Saegrimr » Mon Jul 23, 2018 1:50 am #428486

I love how this happens every time with goofball
tedward1337 wrote:Sae is like the racist grandad who everyone laughs at for being racist, but deep down we all know he's right.

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 1:54 am #428487

Saegrimr wrote:I love how this happens every time with goofball

The only opinion that matters about a feature is maintainer opinions and headcoder opinions.

User avatar
DemonFiren
 
Joined: Sat Dec 13, 2014 9:15 pm
Byond Username: DemonFiren

Re: The item pick-up animation

Postby DemonFiren » Mon Jul 23, 2018 1:55 am #428488

iamgoofball wrote:
Saegrimr wrote:I love how this happens every time with goofball

The only opinion that matters about a feature is maintain opinions and headcoder opinions.

Well, which one are you?
Image
Image
Image
ImageImageImageImageImage

non-lizard things:
Spoiler:
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 1:55 am #428489

Neither, and the same goes for you. Have fun.

User avatar
DemonFiren
 
Joined: Sat Dec 13, 2014 9:15 pm
Byond Username: DemonFiren

Re: The item pick-up animation

Postby DemonFiren » Mon Jul 23, 2018 2:02 am #428495

iamgoofball wrote:and the same goes for you

How's that relevant?
Image
Image
Image
ImageImageImageImageImage

non-lizard things:
Spoiler:
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 2:12 am #428502

Try thinking really hard.

Also, the maintainers gave me the changes they want made.

User avatar
Cobby
 
Joined: Sat Apr 19, 2014 7:19 pm
Byond Username: ExcessiveUseOfCobby
Github Username: ExcessiveUseOfCobblestone

Re: The item pick-up animation

Postby Cobby » Mon Jul 23, 2018 2:16 am #428504

goof is basically the new pap without the cute girl profile picture and can sometimes make good prs
Voted best trap in /tg/ 2014-current

User avatar
DemonFiren
 
Joined: Sat Dec 13, 2014 9:15 pm
Byond Username: DemonFiren

Re: The item pick-up animation

Postby DemonFiren » Mon Jul 23, 2018 2:17 am #428505

iamgoofball wrote:Try thinking really hard.

Also, the maintainers gave me the changes they want made.

So that was a general "you filthy unwashed masses" you, not a "me specifically" you?
Image
Image
Image
ImageImageImageImageImage

non-lizard things:
Spoiler:
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 2:17 am #428506

Cobby wrote:goof is basically the new pap without the cute girl profile picture and can sometimes make good prs

Not only do I predate paprika but paprika also did literally nothing wrong.

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: The item pick-up animation

Postby oranges » Mon Jul 23, 2018 2:20 am #428508

Saegrimr wrote:
iamgoofball wrote:The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"


The only argument for remove it is "I don't like it"
The only argument for keeping it is "I like it"

well actually it's not that you like, it's that *I* like it
Image

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 2:21 am #428509

oranges wrote:
Saegrimr wrote:
iamgoofball wrote:The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"


The only argument for remove it is "I don't like it"
The only argument for keeping it is "I like it"

well actually it's not that you like, it's that *I* like it

Yeah that

User avatar
Mickyan
Github User
 
Joined: Tue Oct 14, 2014 11:59 pm
Byond Username: Mickyan
Github Username: Mickyan

Re: The item pick-up animation

Postby Mickyan » Mon Jul 23, 2018 2:22 am #428510

Even though I personally like the shake, it's bad for gameplay. As showcased in this thread, it gives players the impression that picking up items is delayed as the animation takes almost a full second to complete

That's not my opinion, it's plain bad visual feedback
ImageI play as Swanni, the brain-damaged moth.
Be nice to each other.

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 2:25 am #428511

Mickyan wrote:Even though I personally like the shake, it's bad for gameplay. As showcased in this thread, it gives players the impression that picking up items is delayed as the animation takes almost a full second to complete


hey see look at that, actually useful feedback

User avatar
DemonFiren
 
Joined: Sat Dec 13, 2014 9:15 pm
Byond Username: DemonFiren

Re: The item pick-up animation

Postby DemonFiren » Mon Jul 23, 2018 2:27 am #428512

which has been posted before but you elected to ignore it in favour of taking bait
Image
Image
Image
ImageImageImageImageImage

non-lizard things:
Spoiler:
Image

User avatar
Pizzatiger
 
Joined: Mon Jun 05, 2017 2:44 pm
Byond Username: Pizzatiger

Re: The item pick-up animation

Postby Pizzatiger » Mon Jul 23, 2018 3:27 am #428523

subject217 wrote:
Saegrimr wrote:Constant crashing ever since.

Gonna point out that all the crashes I hear about on this issue are usually people using an old version of 512. I've not been able to replicate the pickup animation causing crashes issue on the latest 512 Beta builds.

I have upgraded to the latest 512 Beta build and i keep crashing due to the shitty pick up animation.

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 3:27 am #428524

Pizzatiger wrote:
subject217 wrote:
Saegrimr wrote:Constant crashing ever since.

Gonna point out that all the crashes I hear about on this issue are usually people using an old version of 512. I've not been able to replicate the pickup animation causing crashes issue on the latest 512 Beta builds.

I have upgraded to the latest 512 Beta build and i keep crashing due to the shitty pick up animation.

I can't reproduce the crash, man. What are your specs? Also, which server is this?

User avatar
skoglol
Code Maintainer
 
Joined: Wed Jun 13, 2018 5:25 am
Byond Username: Skoglol
Github Username: kriskog

Re: The item pick-up animation

Postby skoglol » Mon Jul 23, 2018 3:35 am #428526

Fairly sure you cannot click through the animation, which makes picking up several items slower. Otherwise I like it, though it could possibly be toned down a bit.

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 3:36 am #428527

skoglol wrote:Fairly sure you cannot click through the animation, which makes picking up several items slower. Otherwise I like it, though it could possibly be toned down a bit.

The animation has no impact on speed of picking up items.

User avatar
BeeSting12
In-Game Admin
 
Joined: Sat Apr 16, 2016 1:11 am
Location: 'Murica
Byond Username: BeeSting12
Github Username: BeeSting12

Re: The item pick-up animation

Postby BeeSting12 » Mon Jul 23, 2018 4:09 am #428531

It should be disabled for tiny and small items so you can feasibly get away with taking small stuff. Obviously anyone could see you take a taser or baton, but something smaller such a an ebow or ID could go unnoticed.

The shaking isn't good for reasons already stated but I think it has potential if you make it have no effect on small/tiny items
Edward Sloan, THE LAW
Melanie Flowers, Catgirl
Borgasm, Cyborg
Spoiler:
OOC: Hunterh98: to be fair sloan is one of the, if not the, most robust folks on tg

DEAD: Schlomo Gaskin says, "sloan may be a faggot but he gets the job done"

DEAD: Rei Ayanami says, "YOU'RE EVERYWHERE WHERE BAD SHIT IS HAPPENING"
DEAD: Rei Ayanami says, "IT'S ALWAYS FUCKING EDWARD SLOAN"
oranges wrote:Bee sting is honestly the nicest admin, I look forward to seeing him as a headmin one day


[2020-05-21 01:21:48.923] SAY: Crippo/(Impala Chainee) "Shaggy Voice - She like... wants to get Eiffel Towered bro!!" (Brig (125, 166, 2))

hows my driving?

User avatar
Saegrimr
 
Joined: Thu Jul 24, 2014 4:39 pm
Byond Username: Saegrimr

Re: The item pick-up animation

Postby Saegrimr » Mon Jul 23, 2018 4:20 am #428535

iamgoofball wrote:
Saegrimr wrote:I love how this happens every time with goofball

The only opinion that matters about a feature is maintainer opinions and headcoder opinions.

subject217 wrote:I thought it would be worthwhile to discuss it on the forums. Please vote in the poll I've made, and explain your opinions in more detail in the thread.


Why even post here then you big manbaby lmao
tedward1337 wrote:Sae is like the racist grandad who everyone laughs at for being racist, but deep down we all know he's right.

User avatar
gum disease
In-Game Admin
 
Joined: Thu Dec 07, 2017 9:14 pm
Location: England
Byond Username: GUM DISEASE

Re: The item pick-up animation

Postby gum disease » Mon Jul 23, 2018 5:10 am #428543

Honestly, I like the idea of it. It makes it easier to see who's picked up what. I just think the wiggle is unnecessarily misleading because it makes you think there's a pick-up delay when there isn't.
Image no aim, smooth brain, i'm a borg main.

User avatar
Shezza
 
Joined: Sat May 27, 2017 6:54 pm
Byond Username: Wilchen

Re: The item pick-up animation

Postby Shezza » Mon Jul 23, 2018 6:33 am #428560

oranges wrote:
Saegrimr wrote:
iamgoofball wrote:The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"


The only argument for remove it is "I don't like it"
The only argument for keeping it is "I like it"

well actually it's not that you like, it's that *I* like it


Well you like to make people angry so why should we take your opinion as honest and serious as this point.

zaracka
 
Joined: Wed Apr 18, 2018 1:22 am
Byond Username: Zaracka

Re: The item pick-up animation

Postby zaracka » Mon Jul 23, 2018 7:44 am #428573

I heard it's causing crashes on 1416 and below

User avatar
Arianya
In-Game Game Master
 
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: The item pick-up animation

Postby Arianya » Mon Jul 23, 2018 8:14 am #428579

I don't like how it looks visually at the moment, the shake and the shrinking make the icons look even worse and on smaller icons is basically indecipherable as to which item it actually was.

There are also some noticeable bugs (the one I recall noticing offhand is that removing paper from a paperbin creates a pickup animation underneath the player, rather then from the paperbin to the player)

Fairly sure you cannot click through the animation, which makes picking up several items slower. Otherwise I like it, though it could possibly be toned down a bit.


If the animation/afterimage of the picked up item is covering items still on the ground then this has some pretty important balance implications.

The fact that it's caused substantial number of crashes and required updating BYOND (after a semi-long period of everyone being advised not to update beyond 1416) is the icing on the cake.
Last edited by Arianya on Mon Jul 23, 2018 9:46 am, edited 1 time in total.
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg

User avatar
oranges
Code Maintainer
 
Joined: Tue Apr 15, 2014 9:16 pm
Location: #CHATSHITGETBANGED
Byond Username: Optimumtact
Github Username: optimumtact

Re: The item pick-up animation

Postby oranges » Mon Jul 23, 2018 9:25 am #428593

Shezza wrote:
oranges wrote:
Saegrimr wrote:
iamgoofball wrote:The shake isn't getting removed since the only argument posed against it is "it's weird" and "ss13 is old"


The only argument for remove it is "I don't like it"
The only argument for keeping it is "I like it"

well actually it's not that you like, it's that *I* like it


Well you like to make people angry so why should we take your opinion as honest and serious as this point.

the point is it doesn't matter how you take my opinion
Image

User avatar
Lazengann
In-Game Admin
 
Joined: Sat Feb 25, 2017 2:26 pm
Byond Username: Lazengann

Re: The item pick-up animation

Postby Lazengann » Mon Jul 23, 2018 9:30 am #428596

quit crashing my game, CODERS,

User avatar
iamgoofball
Github User
 
Joined: Fri Apr 18, 2014 5:50 pm
Byond Username: Iamgoofball
Github Username: Iamgoofball

Re: The item pick-up animation

Postby iamgoofball » Mon Jul 23, 2018 5:30 pm #428672

Arianya wrote:I don't like how it looks visually at the moment, the shake and the shrinking make the icons look even worse and on smaller icons is basically indecipherable as to which item it actually was.

There are also some noticeable bugs (the one I recall noticing offhand is that removing paper from a paperbin creates a pickup animation underneath the player, rather then from the paperbin to the player)

Fairly sure you cannot click through the animation, which makes picking up several items slower. Otherwise I like it, though it could possibly be toned down a bit.


If the animation/afterimage of the picked up item is covering items still on the ground then this has some pretty important balance implications.

The fact that it's caused substantial number of crashes and required updating BYOND (after a semi-long period of everyone being advised not to update beyond 1416) is the icing on the cake.

>getting mad over having to do a free update

come on, grow up

User avatar
Lazengann
In-Game Admin
 
Joined: Sat Feb 25, 2017 2:26 pm
Byond Username: Lazengann

Re: The item pick-up animation

Postby Lazengann » Mon Jul 23, 2018 5:33 pm #428673

.1413 was a work of art goofball and now we had to part ways with it

User avatar
Arianya
In-Game Game Master
 
Joined: Tue Nov 08, 2016 10:27 am
Byond Username: Arianya

Re: The item pick-up animation

Postby Arianya » Mon Jul 23, 2018 5:38 pm #428674

iamgoofball wrote:
Arianya wrote:I don't like how it looks visually at the moment, the shake and the shrinking make the icons look even worse and on smaller icons is basically indecipherable as to which item it actually was.

There are also some noticeable bugs (the one I recall noticing offhand is that removing paper from a paperbin creates a pickup animation underneath the player, rather then from the paperbin to the player)

Fairly sure you cannot click through the animation, which makes picking up several items slower. Otherwise I like it, though it could possibly be toned down a bit.


If the animation/afterimage of the picked up item is covering items still on the ground then this has some pretty important balance implications.

The fact that it's caused substantial number of crashes and required updating BYOND (after a semi-long period of everyone being advised not to update beyond 1416) is the icing on the cake.

>getting mad over having to do a free update

come on, grow up


>ignoring all other feedback and gotcha-ing people being annoyed at their game crashing

come on, grow up
Frequently playing as Aria Bollet on Bagil & Scary Terry

Source of avatar is here: https://i.imgur.com/hEkADo6.jpg

User avatar
Saegrimr
 
Joined: Thu Jul 24, 2014 4:39 pm
Byond Username: Saegrimr

Re: The item pick-up animation

Postby Saegrimr » Mon Jul 23, 2018 6:23 pm #428680

Arianya wrote:>ignoring all other feedback and gotcha-ing people being annoyed at their game crashing

come on, grow up


Uh excuse me your opinion doesn't matter here, this thread is bait and should be closed.
tedward1337 wrote:Sae is like the racist grandad who everyone laughs at for being racist, but deep down we all know he's right.

Next

Return to Coding Feedback

Who is online

Users browsing this forum: Anna May