British English vs. American English

[Fayrik]

Bottom post of the previous page:

Told ya ya'd need me.

DemonFiren for /tg/ official variable namer.
All new variables must be named, signed and approved by DemonFiren.

Seriously though, how about not changing other people's variable names to reflect your own culture?
If Remie had done this, the entire PR would have been closed with comments like

Fuck England trying to invade again muh freedom guns woo fuck england

Well it works both ways.
Fuck America, fuck the illusion of freedom, fuck guns, you get the picture.
Color or colour, whatever. Just stop the fucking one-upmanship.

Talk about a storm in a teacup.

That's racist.

Spoiler:

I was going to continue my rant but then I saw this and fucking lol'd.

[NikNakFlak]

If it wasn't changed, it'd look like this
/var = colour thingys
/var = thingy color
and this triggers me even more

[oranges]

you don't even code

[NikNakFlak]

Excuse you, shaving corgis says otherwise

[oranges]

mm it's true

[asskek]

Told ya ya'd need me.

DemonFiren for /tg/ official variable namer.
All new variables must be named, signed and approved by DemonFiren.

Seriously though, how about not changing other people's variable names to reflect your own culture?
If Remie had done this, the entire PR would have been closed with comments like

Fuck England trying to invade again muh freedom guns woo fuck england

Well it works both ways.
Fuck America, fuck the illusion of freedom, fuck guns, you get the picture.
Color or colour, whatever. Just stop the fucking one-upmanship.

Talk about a storm in a teacup.

That's racist.

Spoiler:

I was going to continue my rant but then I saw this and fucking lol'd.

but american english is objectively better
as we pointed out

[oranges]

And America objectively lost a war against Vietnamese irregulars and Iraqi insurgents.

checkmate americans, checkmate.

[PKPenguin321]

i say we make a poll that says "what is your favorite color/colour" and whichever wins is the new var name
i vote for red

[Saegrimr]

i say we make a poll that says "what is your favorite color/colour" and whichever wins is the new var name
i vote for red

Green is my favorite red.

[Skorvold]

I don't think it really matters, and I wouldn't put "professional" in any sentence involving anything about tgstation13. We really shouldn't be getting pissed off about something as simple as the spelling of a word.

[THE MIGHTY GALVATRON]

Damn kids just get a thesaurus and look for a synonym for color! It ain't hard!

[DemonFiren]

Damn kids just get a thesaurus and look for a synonym for color! It ain't hard!

How about...

Spoiler:

hue

[Yoshmaster]

Just combine the two, duh!
Color + Colour = Colouor
Aluminum + Aluminium = Aluminuminium

[LiamLime]

I use British English in speech and strict American English in variable names, methods, etc. Heck, you might find something like this in my code:

Code: Select all

private Color Color; //The player's colour

Using a standard is much more important than some petty nationalistic argument. In my opinion, the variables written in British English (Most of which were made by Urist McDorf), should be refactored to American.

This same argument happens in databases: is the table called "wp_users" or "wp_user". Just choose one and stick to it. In this example "wp_" is the prefix that signifies wordpress.

[Ricotez]

Code: Select all

private Color Color; //The player's colour

>starting class names with a capital letter but then not using camelCase for variable names

for shame

[oranges]

camel case is literally the worst invention of all time

CapitalClassNames
methods_with_underscores

All other methods are shit and you should be hung drawn and quartered for using them.

[callanrockslol]

Australian English.

[LiamLime]

Code: Select all

private Color Color; //The player's colour

>starting class names with a capital letter but then not using camelCase for variable names

for shame

That's actually the correct way to do it in C# [1], which is the language I use most of the time nowadays. You use PascalCase for essentially everything except preprocessor directives (where you use underscore-delimitered upper-case) and method parameters (where you use camelCase). I think Java does use camelCase for the majority of these cases though, likely to make it easier to determine whether you are referending the class or a property/field. In the example I posted above, if I do...

Code: Select all

Color.red; 

...there is no way to determine whether I am getting a static field/static property/constant from the class "Color", or the value of a normal property / field from the object called "Color"

So whether I'm referring to "private Color Color" or "private Color Color". Honestly I'm not the biggest fan of C#'s coding standards, but whatever. There are only so many ways to spell things and loads of different features the language provides, so a 1 to 1 mapping is not possible.

[Ricotez]

I've just stuck with the Java standard for most of my coding, but I switched to underscores for BYOND coding because that seems to be the most used one in our code base

[MisterPerson]

Stop being nerds, nobody cares.

[LiamLime]

Stop being nerds, nobody cares.

But it's my job to be a nerd

[Poorman]

Game will run better if you use the american version.

It's the objective better answer.

[Ricotez]

Stop being nerds, nobody cares.

say this again after you've tried digging through unreadable code

[LiamLime]

Sticking to a language standard doesn't really help with readability though, unless someone does something like:

Code: Select all

class Butt{
	private Color color;

	public Butt(Color colour){
		color = Color.green;
		color.red = colour.red;
		colour.blue = (float)0x88 / 0xFF;
		color.green = Mathf.max(color.green, colour.green);
	}
}

But if they really do this then they deserve a very particular spot in hell... And yes, some people do that Sticking to a standard mostly helps when writing code which interacts with someone else's module or library.

Anyway, sticking to a standard helps with not having to look things up - for example if you are using someone else's library and you know it sticks to American English, you can be sure it's library.Color, and never have to look it up. When writing queries for databases it's the same - if you know all the tables are in singular, then you know to use "SELECT DISTINCT u.username FROM wp_user u, wp_ban b WHERE u.user_id = b.user_id", you don't have to look if it's wp_ban vs wp_bans or wp_user vs wp_users.

Of course people make mistakes and don't stick to their own standards sometimes... For example.

[MisterPerson]

Rewriting everything to a single standard is an absolutely atrocious use of anyone's time.

[LiamLime]

Every competent IDE features the ability to automatically refactor-rename things. And assuming the code wasn't originally written by chimpanzees, it should work fine once refactored. Some languages (python, javascript, PHP, DM) can't easily be refactored though, due to the way they work.

In any case, you don't set out to standardize this one specific thing. You either do it along the way - EG while rewriting sections of code, or you set out to do a major code cleanup/refactor and this is just one part of it. Rewriting things can be a fairly common thing for backend/toolchain/engine people to do as new features are requested or bugs discovered.

[PKPenguin321]

just changing it to hue would work wouldnt it

[LiamLime]

Not to get too far into this but hue is just one of three components of colour.

There are 4 commonly used systems to describe colour:
- RGB (red green blue, used in LCD screens)
- CMYK (cyan magenta yellow black, used with printers)
- HSL / HSV (hue saturation lightness/value, used in colour processing/editing, the difference is irrelevant)
- Lab (Lightness, a channel, b channel; used in CRT TVs)

You can mostly convert from one to another using simple math, especially between HSL and RGB, which we mostly use.

So HSL has three values: Hue, saturation and lightness.
Hue: 0: red; 0.33: green; 0.66: blue; 1: red; (and all the colours in between)
Saturation: says how much of the colour there is (0: no colour (grey scale), 1: full colour)
Lightness: says how light the colour is (0: completely black, 0.5: full colour, 1: white) - this is where L and V differ, one goes black-colour-white; the other goes black-colour


Here's a typical HSL selector. On the vertical bar you select the hue (0 at the bottom, 1 at the top), the plane's X axis is saturation (from greyscale on the left to full colour on the right) and the Y axis is lightness (from black at the bottom to full colour at the top).

As I said, not to get too deep into this~

[duncathan]

LiamLime is correct; whether you spell it with or without the u, colour is still the most accurate word for just about thriving it's used for in the codebase

[MrStonedOne]

Color:

Because there exists built-in vars with the name of color, that we can't change, and if we must keep it restricted to 1 unified spelling, then it should be all or nothing.

That being said, this bullshit around "atomic" prs is just that,

bull
fucking
shit.

If you touch code that uses relative pathing, you are not only allowed to fix the pathing, but required to.

If you touch code that uses same line conditional statements (if (blah) return), you are not only allowed to fix it in the same pr as your feature, but in most cases, required to.

But if you change something to a spelling that one of the maintainers doesn't like, apparently that's when we start complaining about atomic prs?

Bull. Fucking. Shit.

Calling that one right out as a prospective influenced double standard.

[Cheridan]

what color is jim's red gun?

[onleavedontatme]

Is this thread some big joke I'm missing out on?

[oranges]

yes, it's what happens when you develop in byond code too long

[srifenbyxp]

I dont know what the fuck is going on but I'm enjoying it

[LiamLime]

But if you change something to a spelling that one of the maintainers doesn't like, apparently that's when we start complaining about atomic prs?

PRs get denied because of SPELLING?

[EndgamerAzari]

what color is jim's red gun?

Green.