New Energy Weapon Charge Overlays

[Scones]

They look upsettingly bad. The HoS one is blurry, the lasers are confusing.

[lumipharon]

The hell is wrong with what we have?

[Scones]

They also broke gunlight UI buttons.

[Amelius]

One word. Blurovision.

What's wrong with the traditional lasers? It was simple and clear.

[NikNakFlak]

I made an image comparison

Top is new, bottom is old.

[Amelius]

I made an image comparison

Top is new, bottom is old.

That's another pertinent thing. The new lasers don't have an obvious charge indicator unless it's empty, whereas the standard ones have it turn progressively more orange the less ammo you have.

[NikNakFlak]

Everything shown is full charge on top with a half charge on the bottom

[Scones]

I liked the little detailed charge on the HOS laser, and the shaded bar on the Captain's

[Malkevin]

They look upsettingly bad. The HoS one is blurry, the lasers are confusing.

Everything in that picture looks blurred to me

[Jordie0608]

Here's a better comparison of the guns that had significant sprite changes (and the egun), all others guns look essentially the same as previous.

Before


After (The floral's charge bar is bugged, it should be shorter than that)

[Scones]

Standardization of gun directions was nice

But why not keep the current, more detailed versions of the Captain/HoS gun charge indiciators?

[Steelpoint]

The change removes the ability for more intricate customization of guns I think. More so empty reload animations and the like.

[lumipharon]

I don't see any difference in the egun, but honestly every other gun looks significantly worse.

All the guns that had a charge bar instead of pips look way shittier - especially the HoS gun (which went from raised edges like a 40k plasma gun to flat rectangle with 3 lines through it).
The laser was far easier to judge charge by the colour change.
The advanced egun has been made a lot fatter, by tacking on a new charge meter thing.

Making them all face the same direction is alright, but other then that, please revert post haste.

[Jordie0608]

But why not keep the current, more detailed versions of the Captain/HoS gun charge indiciators?

Shading charge bars of the Captain's Laser, normal laser, retro etc. was a victim an overlay based update_icon() using a single sprite to generate an entire charge bar. They could be returned, but it would somewhat defeat the purpose of making them into overlays in the first place.

The more notched charge bar of the HoS's gun was a victim of me copy-pasting from the taser and egun so I could be complete quicker. It could be returned, but it would defeat the purpose of me spilling hot chocolate while I was working on this.

The change removes the ability for more intricate customization of guns I think.

If you try to work only with the current update_icon() proc perhaps, depends on what customizations you have in mind. However additional icon features can be either added to the base proc or handled by a child's proc easily enough, again, depends what you have in mind. Examples?

More so empty reload animations and the like.

Unless I'm misunderstanding what you mean here there are still animations for when the guns are empty.

[Steelpoint]

I've seen the sprites in game and I really think some of them look awful.

Of the top of my hat the HoS gun looks very poor quality wise.

I still think the whole PR was not really needed, it only saved on 15kb's and now we've got poor looking sprites.

I appreciate the effort you went with this PR but I really dislike what its done, it ruined the aesthetic with many guns and many guns just look horrid.

[callanrockslol]

Here's a better comparison of the guns that had significant sprite changes (and the egun), all others guns look essentially the same as previous.

Before


After (The floral's charge bar is bugged, it should be shorter than that)

So, brighten the colours on the shot indicator because it needs to stand out and probably shouldn't be smudged, captain's laser/HoS gun needs to be made to look like the old HoS gun with the shot indicator because it looks cooler and more sci-fi, retro laser definitely has to keep the old look because "muh retros".

I still prefer if the originals were just touched up.

[Gun Hog]

To be honest, Jordie, I agree with what people are saying here and in the PR. It is not worth saving ~15KB to ruin the aesthetic of the weapons. The code can be kept, but the original overlays and sprites do need to be returned. A full revert is not needed, simply give the old overlays back.

[Jordie0608]

https://github.com/tgstation/-tg-station/pull/10790

[Steelpoint]

Thank you Jordie.