Pull and Grab Merged
- Takeguru
- Joined: Wed May 07, 2014 5:20 pm
- Byond Username: TakeGuru
-
- Joined: Sun Oct 26, 2014 5:13 am
- Byond Username: Lzimann
- Github Username: lzimann
Re: Pull and Grab Merged
The biggest issue is the agressive grab taking like 5 secs to grab, no real reason to that...
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Pull and Grab Merged
this would be easy to tweak but le feature freeze
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- Takeguru
- Joined: Wed May 07, 2014 5:20 pm
- Byond Username: TakeGuru
Re: Pull and Grab Merged
Feature freeze and it still got merged
Nice, not even sticking to their own rules
Nice, not even sticking to their own rules
- Grazyn
- Joined: Tue Nov 04, 2014 11:01 am
- Byond Username: Grazyn
Re: Pull and Grab Merged
wait so a feature is merged during freeze but it can't be tweaked because feature freeze?
you can't make this shit up guys
you can't make this shit up guys
- Takeguru
- Joined: Wed May 07, 2014 5:20 pm
- Byond Username: TakeGuru
Re: Pull and Grab Merged
Don't forget, it's bugged to shit
You can't upgrade your grabs with the hotkey, you have to actually click on the guy, and borgs can't pull at all
You can't upgrade your grabs with the hotkey, you have to actually click on the guy, and borgs can't pull at all
-
- Joined: Fri May 02, 2014 3:01 am
- Byond Username: Incomptinence
Re: Pull and Grab Merged
Oh well then I didn't know the next item on the anti silicon agenda was euthanasia for mediborgs.
Remove one section of pipe in atmos, AI and borg proofed now! YAAAAY!
Remove one section of pipe in atmos, AI and borg proofed now! YAAAAY!
- Cheridan
- Joined: Tue Apr 15, 2014 6:04 am
- Byond Username: Cheridan
Re: Pull and Grab Merged
It was a refactor, not meant to change any intended behavior. Which is perfectly fine.Takeguru wrote:Feature freeze and it still got merged
Nice, not even sticking to their own rules
https://github.com/tgstation/tgstation/ ... -221710982
He's allowed to make further tweaks.Grazyn wrote:wait so a feature is merged during freeze but it can't be tweaked because feature freeze?
you can't make this shit up guys
The duration now is what it "should" have been. The hotkey was enabling people to ignore the cooldowns.lzimann wrote:The biggest issue is the agressive grab taking like 5 secs to grab, no real reason to that...
you guys should work on getting educated first and getting mad second
- Grazyn
- Joined: Tue Nov 04, 2014 11:01 am
- Byond Username: Grazyn
Re: Pull and Grab Merged
Oh so it's one of those "bugfixes" to something that has been like that for years, i.e. a nerf
Also now you can't pull and grab at the same time, this smells like a nerf to me too
Also now you can't pull and grab at the same time, this smells like a nerf to me too
- Lumbermancer
- Joined: Fri Jul 25, 2014 3:40 am
- Byond Username: Lumbermancer
Re: Pull and Grab Merged
I never could upgrade the grab with hotkey anyway, I always had to click on the grab icon with mouse.Takeguru wrote:You can't upgrade your grabs with the hotkeyl
-
- Joined: Thu Oct 30, 2014 2:24 pm
- Byond Username: Cik
Re: Pull and Grab Merged
it's really buggy. i seem to lose passive grabs for no reason. it took me about 5 minutes to move the AI through security because it would randomly ungrab every 2-5 tiles
pls fix
pls fix
-
- Joined: Fri Mar 13, 2015 10:26 pm
- Byond Username: KorPhaeron
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
Actually I haven't fixed this particular case yet, will do asap.Cik wrote:it's really buggy. i seem to lose passive grabs for no reason. it took me about 5 minutes to move the AI through security because it would randomly ungrab every 2-5 tiles
pls fix
I'm a tgstation coding maintainer janitor
- Takeguru
- Joined: Wed May 07, 2014 5:20 pm
- Byond Username: TakeGuru
Re: Pull and Grab Merged
It doesn't matter if it was meant to or not, it's still a significant change to anything grab related in combatCheridan wrote:It was a refactor, not meant to change any intended behavior. Which is perfectly fine.Takeguru wrote:Feature freeze and it still got merged
Nice, not even sticking to their own rules
https://github.com/tgstation/tgstation/ ... -221710982
With this, there is now no reason to ever use a grab in combat, it can take an upward of ten seconds with lag and other factors to throw someone, and unless you're in a hazardous place throws are shit too
Good luck ever getting a chokehold on someone unless they're AFK or already unconscious because that takes even longer
Also, the grab sound effect whenever you just start pulling something and every living thing throwing off glaring red text in chat when you just want to pull it are annoying
- ShadowDimentio
- Joined: Thu May 08, 2014 3:15 am
- Byond Username: David273
- iamgoofball
- Github User
- Joined: Fri Apr 18, 2014 5:50 pm
- Byond Username: Iamgoofball
- Github Username: Iamgoofball
Re: Pull and Grab Merged
You're an idiot.ShadowDimentio wrote:Cheridan your changes have been fucking shit lately.
- Super Aggro Crag
- In Game PermaBanned
- Joined: Sat Mar 21, 2015 9:47 pm
- Byond Username: Super Aggro Crag
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
The changes are mine, Cheri only merged my PR.Cheridan your changes have been fucking shit lately.
People here seem to think that I care about every tiny change I made to gameplay. I actually don't, the gameplay was just in the way of my refactor.It doesn't matter if it was meant to or not, it's still a significant change to anything grab related in combat
With this, there is now no reason to ever use a grab in combat, it can take an upward of ten seconds with lag and other factors to throw someone, and unless you're in a hazardous place throws are shit too.
Good luck ever getting a chokehold on someone unless they're AFK or already unconscious because that takes even longer
Also, the grab sound effect whenever you just start pulling something and every living thing throwing off glaring red text in chat when you just want to pull it are annoying
You want no grab sound when doing a simple pull? Fine, I don't care either way.
You want grab upgrade to be faster? Fine, I don't care.
You want grab upgrade to not require you and your victim to stand still? It's doable, and I don't really care either way.
Make a poll or something, and I'll change the gameplay.
I'm a tgstation coding maintainer janitor
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Pull and Grab Merged
phil pretty much all the things you listed are good changes, i'd also like upgrading with the hotkey back if that's possible
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Pull and Grab Merged
Try to read the thread before blasting people SaCSuper Aggro Crag wrote:great feedback goofball you cockjuggling scat-clown
- DemonFiren
- Joined: Sat Dec 13, 2014 9:15 pm
- Byond Username: DemonFiren
Re: Pull and Grab Merged
Could it be that the grab """refactor""" made xenomming impossible?
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
Pretty much impossible since there's no longer an actual item in your hand when grabbing.i'd also like upgrading with the hotkey back if that's possible
It should work fine, I tested xeno devouring a human.Could it be that the grab """refactor""" made xenomming impossible?
If people want grab upgrades to not require both mob to stand still, I can change the system by using click cooldown instead of a timer. The downside would be that you wouldn't be able to click anything during the cooldown and since grab upgrade needs to be at least a couple seconds long, it would be noticeable.
I can reduce the upgrade time to 3 seconds, or even 2 seconds and counterbalance it by separating pull and passive grab again, which would mean you'd need to do one additional grab upgrade to reach the kill grab.
I could also make the timer/click cooldown variable depending on the grab level we're upgrading to, so upgrading to an agressive grab is faster than a kill grab.
I'm a tgstation coding maintainer janitor
- Anonmare
- Joined: Sun Mar 15, 2015 8:59 pm
- Byond Username: Anonmare
Re: Pull and Grab Merged
The second between ctrl+clicking and the grab actually happening is really throwing me off. It should be instant, plus the sound effect and red text makes people freak out.
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
I made the grab upgrades faster: https://github.com/tgstation/tgstation/pull/18038
The red text is here because I merged pull and passive grab together. Without it the only warning message the player'd get is the message that they've been aggressively grabbed (which means they are already restrained).
The whoosh sound when pulling is here for the same reason.
That shouldn't be happening, and it works fine for me, pulling IS instantaneous. Are you talking human grabbing human? If it happens to you again, make an issue report.The second between ctrl+clicking and the grab actually happening is really throwing me off. It should be instant, plus the sound effect and red text makes people freak out.
The red text is here because I merged pull and passive grab together. Without it the only warning message the player'd get is the message that they've been aggressively grabbed (which means they are already restrained).
The whoosh sound when pulling is here for the same reason.
I'm a tgstation coding maintainer janitor
-
- Joined: Fri Sep 25, 2015 12:18 am
- Byond Username: The unloved rock
- TechnoAlchemist
- Joined: Fri Nov 21, 2014 2:39 am
- Byond Username: TechnoAlchemist
Re: Pull and Grab Merged
Does ctrl+click grab? if not it should, that would be really nice so I don't have to switch intents.
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
It basically doesn't affect sleeping carp, I made sure not to change any functionality or gameplay balance.
ctrl+click pulls, which is technically a passive grab now. You can't aggressively grab with ctrl+click, it might be possible to change.
ctrl+click pulls, which is technically a passive grab now. You can't aggressively grab with ctrl+click, it might be possible to change.
I'm a tgstation coding maintainer janitor
- ShadowDimentio
- Joined: Thu May 08, 2014 3:15 am
- Byond Username: David273
Re: Pull and Grab Merged
I despise how long it takes to aggressive grab now. Make it instant and usable with the action key, I want tabling to be a thing again.
Spoiler:
- paprika
- Rarely plays
- Joined: Fri Apr 18, 2014 10:20 pm
- Byond Username: Paprka
- Location: in down bad
Re: Pull and Grab Merged
Tabling is kind of a shit game mechanic I'm glad it's dead as a tactical maneuver
Maybe someone can work it into a kung fu combo or something
Maybe someone can work it into a kung fu combo or something
Oldman Robustin wrote:It's an established meme that coders don't play this game.
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
1 second is too much for you?ShadowDimentio wrote:I despise how long it takes to aggressive grab now. Make it instant and usable with the action key, I want tabling to be a thing again.
I'm a tgstation coding maintainer janitor
- TechnoAlchemist
- Joined: Fri Nov 21, 2014 2:39 am
- Byond Username: TechnoAlchemist
Re: Pull and Grab Merged
One second is a long ass time compared to how it was before I must say
Re: Pull and Grab Merged
If you're pulling a cuffed person and someone (you included) bumps into them you'll lose the pull/grab and they'll dart off - this is a major sec nerf.
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
Remember that being able to get aggressive grab nearly instantly in the old system was due to an exploit with hotkeys. People who didn't use hotkeys in the old system had to wait 2 or 3 seconds to get their aggressive grab.
I'm a tgstation coding maintainer janitor
- DemonFiren
- Joined: Sat Dec 13, 2014 9:15 pm
- Byond Username: DemonFiren
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
Can't reproduce this bug, a pulled handcuffed person cannot be pushed or position swapped by a person other than the puller. But that other person can break your pull/grab by grabbing the handcuffed person themselves.Malkevin wrote:If you're pulling a cuffed person and someone (you included) bumps into them you'll lose the pull/grab and they'll dart off - this is a major sec nerf.
If you are the puller and don't want to push your victim away, stay on help or grab intent. I changed this so you could be able to swap position with your victim because getting stuck in a corridor because of the handcuffed person you're pulling is terrible. If you prefer the old system I can always revert that specific change.
I'm a tgstation coding maintainer janitor
-
- Joined: Fri Sep 25, 2015 12:18 am
- Byond Username: The unloved rock
Re: Pull and Grab Merged
you used to be able to instantly get people in a chokehold with sleeping carp, can you do that still?
- Lumbermancer
- Joined: Fri Jul 25, 2014 3:40 am
- Byond Username: Lumbermancer
Re: Pull and Grab Merged
When AI moves camera while the core is pulled, pull will be resisted and broken.
- phil235
- Joined: Thu Apr 17, 2014 11:39 am
- Byond Username: Phil235
Re: Pull and Grab Merged
You used to be able to because of an exploit using hotkeys. With the new system sleeping carp can still give you an instant agressive grab (which restrains the victim, making them drop the stuff in their hands and make them unable to use their hand).The unloved rock wrote:you used to be able to instantly get people in a chokehold with sleeping carp, can you do that still?
I'm a tgstation coding maintainer janitor
- ShadowDimentio
- Joined: Thu May 08, 2014 3:15 am
- Byond Username: David273
Re: Pull and Grab Merged
It still hadn't been merged at time of posting but yes, instant aggro grabs was fun and let you throw and table people. #makegrabsgreatagainphil235 wrote:1 second is too much for you?ShadowDimentio wrote:I despise how long it takes to aggressive grab now. Make it instant and usable with the action key, I want tabling to be a thing again.
Spoiler:
Who is online
Users browsing this forum: No registered users