Ideas for the /tg/ code repo

[paprika]

This isn't about the game, this is about the github repo itself ( https://github.com/tgstation/-tg-station )

Keep discussion about the game out of here, please.

There's really no place to properly discuss what needs to change in the code repo as far as issues and pull requests are concerned. The most you can do is just cross your fingers and hope HG or Cheridan hears you. It's honestly a fucking nightmare that we have to wait for these barely scheduled roundtables to discuss shit.

Things we REALLY NEED:

- MANDATORY changelogs for ANY PR tagged "Feature", "Balance", or "Map Edit". This ensures that NOTHING gets into the game without players who give a fuck knowing. I've been lazy about this because making changelogs when nobody else does is literally an afterthought nobody really gives much attention to. We also need someone to compile the changelog twice a week minimum.

- A proper, SMALL AND CONCISE format for issue/bug reports. I'd be more than happy to provide one, but our issue tracker is a fucking mess at the moment.

- REMOVE THE 24H LIMIT FOR PRS, IT SUCKS DICK AND ONLY HINDERS FIXES BY MAKING THEM QUICKLY FORGOTTEN ABOUT. The only real argument I can see for keeping the 24h limit around is so that all maintainers get a chance to look at it, but this is fucking stupid considering more than half of our current maintainers barely manage to log in 3-4 times a week. It's completely archaic and a waste of time to keep this here. We need to fix massive bugs quickly and it's hard to fix them when you know you'll have to wait 24h and potentially have your PR shit on by merge conflicts you have to fix.

[Vekter]

1) How hard is it to compile the changelog? Can someone who has minimal BYOND coding knowledge do it? I wouldn't mind doing this for you guys.

2) I'll write it up when I'm at my desktop, but I've basically been posting the server revision, a concise summary of the bug, steps to repro, expected outcome and actual outcome. I think this works well.

E: http://pastebin.com/FL2gZsds Feel free to propose changes. Also does anyone know of a good pastebin-like site that does collab?

3) Agreed. Only keep the 24hr rule if at least one maintainer can be active all the time.

[Not-Dorsidarf]

Vekter, WJ used one that I dont recall the name of while making MO13

I've been stopgapping this problem by occasionally reading off important PRs in OOC.

[Vekter]

Vekter, WJ used one that I dont recall the name of while making MO13

I've been stopgapping this problem by occasionally reading off important PRs in OOC.

I've been doing the same, but if WJ's fucked off/doesn't have time I don't mind doing it. I have an insane amount of free time right now.

[danno]

24h limit should be axed and things should be handled more case-by-case in that regard; there's so much small shit that really doesn't need the wait

how is it that at the same time there are enormous game changing PRs that squeak through with like, 2 hours of review from one maintainer cough coguh for example goonchem
There are some things that need to be scrutinized WAY harder than they are right now. Would have saved us a looooot of trouble.

[Drynwyn]

1) How hard is it to compile the changelog? Can someone who has minimal BYOND coding knowledge do it? I wouldn't mind doing this for you guys.

It's quite simple- you don't even need to go through the "setting up Git".

[Remie Richards]

1) How hard is it to compile the changelog? Can someone who has minimal BYOND coding knowledge do it? I wouldn't mind doing this for you guys.

It's quite simple- you don't even need to go through the "setting up Git".

Well yes, you do, because you need to commit the compiled changelog.

[Miauw]

i've been merging all reliable fixes as soon as they're one day old. the 24h limit should probably stay because we're sort of spread out across timezones, and it's ass when something is merged before you even get a look at it.

[oranges]

24H limit makes no sense, if you test a pull and it works, merge it?

A++ to changelogs, learn that shit and do it, ideally SoS would build the changelog when he updates, but that might be too much of a strain, especially because he'll have to force clean the repo afterwards to get rid of the changes (assuming they're not committed back)

[danno]

someone get the headcoders to look at this

[paprika]

They do, and cheridan agrees with the mandatory changelogs and mandatory changelog compiling before an update, but...

We're all doing it for free in the end and we're lazy shits.

[Not-Dorsidarf]

piratepad is a good real-time auto-saving postbin-like.
If whoever wanted it is still around.