Tl:Dr how to make Senpais notice my PR so it can be merged (or rejected).
Hi, a week ago I requested PR to fix genetics (monkeys despite wiki claim do not generate CRISPR charge. Instead of making a bug report I wanted to contribute to the game and made a quick fix. I pushed the branch and made Pull Request. It went silent and then went stale. I thought that maybe you need to announce it somewhere so I asked on Discord (no reply) and asked Mothblocks as it seems he is maintaining this part of game - no reply.
I know we all do have our stuff to do, and nobody has to be available 24/7, tough I have an idea that maybe I am doing something wrong that it didnt got noticed. Do I miss some steps, butt-licking, bribery etc to push forward my bugfix?
Need advice on pull request
- FantasticFwoosh
- Joined: Mon May 04, 2015 11:25 pm
- Byond Username: FantasticFwoosh
Re: Need advice on pull request
In all likelyhood, but its thoroughly up to them to manage their time so don't feel bad about about it. I imagine you meant this Url i've retrieved for you?: <https://github.com/tgstation/tgstation/pull/65552>I know we all do have our stuff to do, and nobody has to be available 24/7, tough I have an idea that maybe I am doing something wrong that it didnt got noticed. Do I miss some steps, butt-licking, bribery etc to push forward my bugfix?
It looks like a nifty bit of fix-work. Good Job.
Off Topic
Between now and your PR, the sussy airlock PR recieved more attention, take that as you will.
Spoiler:
-
- Joined: Tue Oct 20, 2020 4:21 pm
- Byond Username: MrNihil
Re: Need advice on pull request
Thanks for reply! Yeah, thats the one. Well guess I will have to be patient then
- TheFinalPotato
- Code Maintainer
- Joined: Sun Oct 13, 2019 7:58 am
- Byond Username: LemonInTheDark
Re: Need advice on pull request
If your pr is stale feel free to bully the maintainers on discord about it, we do often just miss things, get a lot of prs, and now that like a quarter of our active maints are headmins there's less time to go around
-
- Forum Soft Banned
- Joined: Sat Jun 02, 2018 10:27 am
- Byond Username: Cacogen
Re: Need advice on pull request
I just ask in Discord and link it and if they don't respond that time ask again later
Who is online
Users browsing this forum: No registered users