you can reverse one PR from TG. which do you choose and why?

Only Certified™ Players™ may post in here.
Forum rules
Only Certified™ Players™ may post in here.
If you are not able to post in here, you are not a Certified™ Player™. Play on a mainline /tg/ game server to gain posting powers in this forum. (certified gamers are only calculated once per day)
User avatar
EmpressMaia
Joined: Wed Mar 23, 2022 8:22 pm
Byond Username: EmpressMaia

you can reverse one PR from TG. which do you choose and why?

Post by EmpressMaia » #698862

Bottom post of the previous page:

id revert the PR that removed my ingame reference :)
User avatar
Jacquerel
Code Maintainer
Joined: Thu Apr 24, 2014 8:10 pm
Byond Username: Becquerel

Re: you can reverse one PR from TG. which do you choose and why?

Post by Jacquerel » #699071

RedBaronFlyer wrote: Sat Aug 12, 2023 10:50 pm
Jacquerel wrote: Sat Aug 12, 2023 7:23 pm
Imitates-The-Lizards wrote: Sat Aug 12, 2023 10:30 am 71023.

I railed on it before it was merged and I will continue to rail on it now. "Ayy lmao, what if we made it so miners have to spend a bunch of time in cargo staring at the walls instead of mining, because I want to increase the amount of time miners are on station to increase their vulnerability to things like kidnappings, but instead of adding a positive reason for them to be on station, I'm gonna increase the tedium in their job."

"Sounds good, ship it!"
but you can express order stuff now for exactly the cost that it was before this pr
That was only after a month and a half of people begging for it to be like that.
yeah but we're talking about reverting it now, in the present
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: you can reverse one PR from TG. which do you choose and why?

Post by oranges » #699109

User avatar
EmpressMaia
Joined: Wed Mar 23, 2022 8:22 pm
Byond Username: EmpressMaia

Re: you can reverse one PR from TG. which do you choose and why?

Post by EmpressMaia » #699120

oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
As head maintainer can't you just revert this
User avatar
Imitates-The-Lizards
Joined: Mon Oct 11, 2021 2:28 am
Byond Username: Typhnox

Re: you can reverse one PR from TG. which do you choose and why?

Post by Imitates-The-Lizards » #699133

oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
Why are you so tsundere about felinids, oranges? We know you love them.
Image
Image
User avatar
NecromancerAnne
In-Game Admin
Joined: Mon Sep 03, 2018 6:55 pm
Byond Username: NecromancerAnne
Location: Don't touch me, motherfucker...

Re: you can reverse one PR from TG. which do you choose and why?

Post by NecromancerAnne » #699137

The first mech refactor really broke a lot while also applying a lot of significant balance changes that were mostly negatives. I was not impressed by how that was handled. I don't think we can go back but there is a lot to untangle and I'll have to dedicate more time to that eventually.

I think the Midisecians pr for krav maga would have been funnier than my PR that got merged.
User avatar
EmpressMaia
Joined: Wed Mar 23, 2022 8:22 pm
Byond Username: EmpressMaia

Re: you can reverse one PR from TG. which do you choose and why?

Post by EmpressMaia » #699189

I think there's still some mech modules that don't woek
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: you can reverse one PR from TG. which do you choose and why?

Post by oranges » #699223

EmpressMaia wrote: Sun Aug 13, 2023 3:29 am
oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
As head maintainer can't you just revert this
no that's not really feasible at this stage.
User avatar
kinnebian
Joined: Tue Jan 19, 2021 2:15 pm
Byond Username: Kinnebian
Location: answering irelands call

Re: you can reverse one PR from TG. which do you choose and why?

Post by kinnebian » #699237

respect (let him do his thing)
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: you can reverse one PR from TG. which do you choose and why?

Post by oranges » #699243

kinnebian wrote: Sun Aug 13, 2023 9:49 pm
oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
https://github.com/tgstation/tgstation/pull/54991

SURRREEE
you're new so you probably dont know this but that PR was merged and reverted in one push, a common joke i played on people.
User avatar
kinnebian
Joined: Tue Jan 19, 2021 2:15 pm
Byond Username: Kinnebian
Location: answering irelands call

Re: you can reverse one PR from TG. which do you choose and why?

Post by kinnebian » #699249

oranges wrote: Sun Aug 13, 2023 10:17 pm
kinnebian wrote: Sun Aug 13, 2023 9:49 pm
oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
https://github.com/tgstation/tgstation/pull/54991

SURRREEE
you're new so you probably dont know this but that PR was merged and reverted in one push, a common joke i played on people.
:roll:
respect (let him do his thing)
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: you can reverse one PR from TG. which do you choose and why?

Post by oranges » #699254

I got glined from rizon for spamming html messages when goof joined with the built in irc client in byond because it rendrered all the tag slike blink and stuff.

luckily it was only 30 minutes.
Turbonerd
Joined: Wed Mar 02, 2022 3:18 pm
Byond Username: AccountName5

Re: you can reverse one PR from TG. which do you choose and why?

Post by Turbonerd » #699275

Tail entwining was never a thing? Sad.
BlueMemesauce
Joined: Fri Mar 01, 2019 2:05 pm
Byond Username: BlueMemesauce

Re: you can reverse one PR from TG. which do you choose and why?

Post by BlueMemesauce » #699441

oranges wrote: Sun Aug 13, 2023 10:17 pm
kinnebian wrote: Sun Aug 13, 2023 9:49 pm
oranges wrote: Sun Aug 13, 2023 2:35 am https://github.com/tgstation/tgstation/pull/10209

should be obvious
https://github.com/tgstation/tgstation/pull/54991

SURRREEE
you're new so you probably dont know this but that PR was merged and reverted in one push, a common joke i played on people.
explain this then https://github.com/tgstation/tgstation/pull/62763

pulling tails doesnt even make cats happy its fucking painful for them im still angry at this change
User avatar
oranges
Code Maintainer
Joined: Tue Apr 15, 2014 9:16 pm
Byond Username: Optimumtact
Github Username: optimumtact
Location: #CHATSHITGETBANGED

Re: you can reverse one PR from TG. which do you choose and why?

Post by oranges » #699443

are you saying kathy Ryals is a liar?
Locked

Who is online

Users browsing this forum: Actarys12, Bepis, DaBoss, Nabski