Misleading PR Titles
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Misleading PR Titles
We need a contribution rule that PRs that don't adequately convey what they do in the title get instaclosed (or force renamed). This misleading title meme has evolved so far that the head maintainer is using it. Obvious exceptions would be highly exploitable bugs (especially if they exist across servers) and shouldn't be announced.
Examples are things like steelpoints "Tweaks boxstation" (actually reshuffles the armory), sligneris' "Tweaks walls" (complete wall sprite redo, I'm sure that won't be controversial), cheridans "Tweaks C4" (balance change that removes the intentional feature of sticking C4 to embedding items), my "Implements Krav Maga" (gave all of sec krav maga roundstart, this didn't go through).
Examples are things like steelpoints "Tweaks boxstation" (actually reshuffles the armory), sligneris' "Tweaks walls" (complete wall sprite redo, I'm sure that won't be controversial), cheridans "Tweaks C4" (balance change that removes the intentional feature of sticking C4 to embedding items), my "Implements Krav Maga" (gave all of sec krav maga roundstart, this didn't go through).
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
-
- Joined: Sat Apr 19, 2014 5:19 am
- Byond Username: Gun Hog
Re: Misleading PR Titles
THIS. 1,000 times THIS. Even BIGGER examples are PR titles like "Removes Spears and Stunprods.", which is a blatant lie; It was actually just a deep fryer fix, ">2 cost for 4 second stun per sharp item held, instant aggro grabs, theft of items from hands into your own hand, 3 second stun on harm long distance, pudge hook on help" which was a nerf on changeling tencales, and "Nerfs ore spawns" which actually just added bananium to the ore list.
I am just as tired of this as you are, and it is about time the maintainers started banning for it.
I am just as tired of this as you are, and it is about time the maintainers started banning for it.
- Xhuis
- Github User
- Joined: Mon May 26, 2014 1:04 pm
- Byond Username: Xhuis
- Github Username: Xhuis
- Location: North Carolina
Re: Misleading PR Titles
Agreed. I'm sick of people like goofball making PRs like "removes some outdated chems" and then removing trekchems in a way that doesn't even compile.
I'm an ex-coder for /tg/. I made the original versions of clockcult, shadowlings, revenants, His Grace, and other stuff.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
Kraso wrote:hi gay
wubli wrote:xhuis you said you were feeling better but every thread you make makes me worry more about your sanity
ExcessiveUseOfCobblestone wrote:Sorry I was making fun of xhuis' """""compromise""""" who insisted that was the correct term to use.
CitrusGender wrote:We've ended up disabling clockcult on sybil and bagil now (terry is having some problems.) We will give Xhuis some time until he wishes to work upon it again. As of now, please use this thread for ideas and not for bickering.
wubli wrote:you are a cultist of the gay
IkeTG wrote:It's a reflection of humanity, like all of man's creation. You cannot divorce this act from yourself, in a way there's a big titty moth inside all of us.
wesoda25 wrote:yeah no one was curious what it was from. Imagine choosing being a degenerate as your forum gimmick, LOL
-
- Joined: Wed Apr 30, 2014 3:16 am
- Byond Username: WJohnston
Re: Misleading PR Titles
This is pretty much a non-issue. Almost all of these come from goofball, and they're always memes. The correct solution is to ban goofball if he keeps doing this.
Or just ban him right now because he won't stop ruining everything with his giant broken overhauls that KEEP. GETTING. M E R G E D.
Or just ban him right now because he won't stop ruining everything with his giant broken overhauls that KEEP. GETTING. M E R G E D.
Apparently I was an director or something.
- Xhuis
- Github User
- Joined: Mon May 26, 2014 1:04 pm
- Byond Username: Xhuis
- Github Username: Xhuis
- Location: North Carolina
Re: Misleading PR Titles
I agree, definitely just goofball.
No! Although he's the most outstanding example, misleading, non-helpful, or straight-up lying PR titles are commonplace when they shouldn't be. Out of many things that do, PR titles and bodies need better information about them. The most outstanding example is the first of those links, the /vg/ lighting port, which actually said that it was migrating the entire codebase over to /vg/ code, and was never changed because the lazy creator just couldn't be bothered. If you look in the comments, you can see that I was mocked for asking a question about the code because I didn't want to assume based off of it alone.
So, no. It's an issue, and it's not just one person.
No! Although he's the most outstanding example, misleading, non-helpful, or straight-up lying PR titles are commonplace when they shouldn't be. Out of many things that do, PR titles and bodies need better information about them. The most outstanding example is the first of those links, the /vg/ lighting port, which actually said that it was migrating the entire codebase over to /vg/ code, and was never changed because the lazy creator just couldn't be bothered. If you look in the comments, you can see that I was mocked for asking a question about the code because I didn't want to assume based off of it alone.
So, no. It's an issue, and it's not just one person.
I'm an ex-coder for /tg/. I made the original versions of clockcult, shadowlings, revenants, His Grace, and other stuff.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
Kraso wrote:hi gay
wubli wrote:xhuis you said you were feeling better but every thread you make makes me worry more about your sanity
ExcessiveUseOfCobblestone wrote:Sorry I was making fun of xhuis' """""compromise""""" who insisted that was the correct term to use.
CitrusGender wrote:We've ended up disabling clockcult on sybil and bagil now (terry is having some problems.) We will give Xhuis some time until he wishes to work upon it again. As of now, please use this thread for ideas and not for bickering.
wubli wrote:you are a cultist of the gay
IkeTG wrote:It's a reflection of humanity, like all of man's creation. You cannot divorce this act from yourself, in a way there's a big titty moth inside all of us.
wesoda25 wrote:yeah no one was curious what it was from. Imagine choosing being a degenerate as your forum gimmick, LOL
-
- Joined: Fri Sep 25, 2015 12:18 am
- Byond Username: The unloved rock
Misleading PR Descriptions exist too
>joan makes a pr with a title saying it fixes brass box sprite hinges
>also removes slowdown on the box in description
>also SILENTLY makes all clock cult tools fire/acidproof AND wordlessly makes the box 100% invisoble inhand
>IT GETS MERGED
>also removes slowdown on the box in description
>also SILENTLY makes all clock cult tools fire/acidproof AND wordlessly makes the box 100% invisoble inhand
>IT GETS MERGED
- cedarbridge
- Joined: Fri May 23, 2014 12:24 am
- Byond Username: Cedarbridge
Re: Misleading PR Titles
Probably half of those examples aren't actually misleading. They're just meh.Xhuis wrote:I agree, definitely just goofball.
No! Although he's the most outstanding example, misleading, non-helpful, or straight-up lying PR titles are commonplace when they shouldn't be. Out of many things that do, PR titles and bodies need better information about them. The most outstanding example is the first of those links, the /vg/ lighting port, which actually said that it was migrating the entire codebase over to /vg/ code, and was never changed because the lazy creator just couldn't be bothered. If you look in the comments, you can see that I was mocked for asking a question about the code because I didn't want to assume based off of it alone.
So, no. It's an issue, and it's not just one person.
- NikNakFlak
- In-Game Admin
- Joined: Thu Apr 17, 2014 5:08 pm
- Byond Username: NikNakflak
Re: Misleading PR Titles
Yea, your examples suck xhuis
-
- Github User
- Joined: Mon Nov 09, 2015 2:27 pm
- Byond Username: Slignerd
- Github Username: Slignerd
Re: Misleading PR Titles
What's misleading about tweaks to wall sprites in a PR called "wall tweaks"?
It would appear that I'm a high RP weeb who hates roleplay and anime.
- XDTM
- Github User
- Joined: Fri Mar 04, 2016 8:38 pm
- Byond Username: XDTM
- Github Username: XDTM
- Location: XDTM
Re: Misleading PR Titles
Mentioning that it's a sprite tweak could be better, i usually think of tweaks in mechanics if not stated otherwise.
a.k.a. Duke Hayka
Coder of golems, virology, hallucinations, traumas, nanites, and a bunch of miscellaneous stuff.
Coder of golems, virology, hallucinations, traumas, nanites, and a bunch of miscellaneous stuff.
- Qbopper
- Joined: Fri Jul 10, 2015 6:34 pm
- Byond Username: Qbopper
- Github Username: Qbopper
- Location: Canada
-
- Github User
- Joined: Fri Apr 18, 2014 1:50 pm
- Byond Username: Xxnoob
- Github Username: xxalpha
Re: Misleading PR Titles
As valid as this complaint might be, Wall tweaks isn't misleading, it's just vague.
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Misleading PR Titles
Basiclly we only do this so we can laugh at those of you who don't check the diff before making a comment.
- danno
- Joined: Wed Apr 16, 2014 5:07 pm
- Byond Username: Dannno
- Location: e-mail me if you want a pizza roll
Re: Misleading PR Titles
wall tweaks is a pretty accurate name...?
they tweaked the wall sprites.
???
they tweaked the wall sprites.
???
- Cobby
- Code Maintainer
- Joined: Sat Apr 19, 2014 7:19 pm
- Byond Username: ExcessiveUseOfCobby
- Github Username: ExcessiveUseOfCobblestone
Re: Misleading PR Titles
> basing your opinion on code from its title and not the code
????????????????????????????????????????????????????????????????
????????????????????????????????????????????????????????????????
Voted best trap in /tg/ 2014-current
- danno
- Joined: Wed Apr 16, 2014 5:07 pm
- Byond Username: Dannno
- Location: e-mail me if you want a pizza roll
Re: Misleading PR Titles
"complete wall sprite redo"
Here is the fucking quandary
You couldn't possibly have looked at the actual diff, because then there's no way you would have even made this thread.
Yet, it implies that you DID look and decide that it was a "complete wall sprite redo"
what the fuck are you doing, pk
Here is the fucking quandary
You couldn't possibly have looked at the actual diff, because then there's no way you would have even made this thread.
Yet, it implies that you DID look and decide that it was a "complete wall sprite redo"
what the fuck are you doing, pk
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Misleading PR Titles
Yeah I got pranked by that, the original PR was
Name: "Tweaks Walls"
Desc: Changes walls sprites, will post pictures soon
So yeah it was misleading
And no I can't look at .dmi files on my phone
Name: "Tweaks Walls"
Desc: Changes walls sprites, will post pictures soon
So yeah it was misleading
And no I can't look at .dmi files on my phone
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Misleading PR Titles
hahahah what a story mark
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Misleading PR Titles
youre my favorite customeroranges wrote:hahahah what a story mark
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
-
- Github User
- Joined: Mon Nov 09, 2015 2:27 pm
- Byond Username: Slignerd
- Github Username: Slignerd
Re: Misleading PR Titles
> PR is clearly simply unfinishedPKPenguin321 wrote:Yeah I got pranked by that, the original PR was
Name: "Tweaks Walls"
Desc: Changes walls sprites, will post pictures soon
So yeah it was misleading
And no I can't look at .dmi files on my phone
> no pictures yet, but name and description make it very clear what the PR does
> "hurr guys it's misleading"
It would appear that I'm a high RP weeb who hates roleplay and anime.
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Misleading PR Titles
The name and desc followed the exact formula that misleading PRs use, I'm sorry! It's like the boy who cried wolf only it's the PR that said it was a tweakSligneris wrote:> PR is clearly simply unfinishedPKPenguin321 wrote:Yeah I got pranked by that, the original PR was
Name: "Tweaks Walls"
Desc: Changes walls sprites, will post pictures soon
So yeah it was misleading
And no I can't look at .dmi files on my phone
> no pictures yet, but name and description make it very clear what the PR does
> "hurr guys it's misleading"
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- Shaps-cloud
- Code Maintainer
- Joined: Thu Aug 14, 2014 4:25 am
- Byond Username: Shaps
Re: Misleading PR Titles
it's tweaking the sprite jesus christ you're complaining about things just to complain
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Misleading PR Titles
That was one bad example but what I'm talking about is a real issue
Like I wouldn't have thought the walls thing was one if it wasn't such a common thing in the first place
Like I wouldn't have thought the walls thing was one if it wasn't such a common thing in the first place
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- ShadowDimentio
- Joined: Thu May 08, 2014 3:15 am
- Byond Username: David273
Re: Misleading PR Titles
If your title doesn't make it eminently obvious what you're doing in the PR it's a shit title and you need to change it.
Spoiler:
- Qbopper
- Joined: Fri Jul 10, 2015 6:34 pm
- Byond Username: Qbopper
- Github Username: Qbopper
- Location: Canada
Re: Misleading PR Titles
I don't think that's entirely fairShaps wrote:it's tweaking the sprite jesus christ you're complaining about things just to complain
He might have been wrong on that one but he apologized about it and still had other valid examples
Limey wrote:its too late.
- Haevacht
- Joined: Sat Apr 19, 2014 1:08 am
- Byond Username: Capital_H
Re: Misleading PR Titles
Cheridan and other maintainers are cracking down on this. Look at goofs latest prs.
1% of a coder, 2% of a spriter, 97% >:3c
Random name on Bagel, usually assistant.
Random name on Bagel, usually assistant.
- Screemonster
- Joined: Sat Jul 26, 2014 7:23 pm
- Byond Username: Scree
Re: Misleading PR Titles
or don'tHaevacht wrote:Cheridan and other maintainers are cracking down on this. Look at goofs latest prs.
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Misleading PR Titles
We're dealing with it, nothing more needs to be said.
- Xhuis
- Github User
- Joined: Mon May 26, 2014 1:04 pm
- Byond Username: Xhuis
- Github Username: Xhuis
- Location: North Carolina
Re: Misleading PR Titles
I guess this thread doesn't have a point, then.
So how about that clockcult, am I right?
So how about that clockcult, am I right?
I'm an ex-coder for /tg/. I made the original versions of clockcult, shadowlings, revenants, His Grace, and other stuff.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
I don't play, code, or participate in the community, but I occasionally post dumb stuff in the hut.
Kraso wrote:hi gay
wubli wrote:xhuis you said you were feeling better but every thread you make makes me worry more about your sanity
ExcessiveUseOfCobblestone wrote:Sorry I was making fun of xhuis' """""compromise""""" who insisted that was the correct term to use.
CitrusGender wrote:We've ended up disabling clockcult on sybil and bagil now (terry is having some problems.) We will give Xhuis some time until he wishes to work upon it again. As of now, please use this thread for ideas and not for bickering.
wubli wrote:you are a cultist of the gay
IkeTG wrote:It's a reflection of humanity, like all of man's creation. You cannot divorce this act from yourself, in a way there's a big titty moth inside all of us.
wesoda25 wrote:yeah no one was curious what it was from. Imagine choosing being a degenerate as your forum gimmick, LOL
- iamgoofball
- Github User
- Joined: Fri Apr 18, 2014 5:50 pm
- Byond Username: Iamgoofball
- Github Username: Iamgoofball
Re: Misleading PR Titles
yeah that's pretty much the only reason i do itoranges wrote:Basiclly we only do this so we can laugh at those of you who don't check the diff before making a comment.
its like watching people share false headlines on facebook
I reserve the right to make fun of those who don't research before sharing
- PKPenguin321
- Site Admin
- Joined: Tue Jul 01, 2014 7:02 pm
- Byond Username: PKPenguin321
- Github Username: PKPenguin321
- Location: U S A, U S A, U S A
Re: Misleading PR Titles
i think jokes are fine but it starts being an issue when it's done to sneak controversial shit in without anybody knowing until it's too lateiamgoofball wrote:yeah that's pretty much the only reason i do itoranges wrote:Basiclly we only do this so we can laugh at those of you who don't check the diff before making a comment.
its like watching people share false headlines on facebook
I reserve the right to make fun of those who don't research before sharing
i play Lauser McMauligan. clown name is Cold-Ass Honkey
i have three other top secret characters as well.
tell the best admin how good he is
i have three other top secret characters as well.
tell the best admin how good he is
Spoiler:
- Qbopper
- Joined: Fri Jul 10, 2015 6:34 pm
- Byond Username: Qbopper
- Github Username: Qbopper
- Location: Canada
Re: Misleading PR Titles
so, I guess that wraps the thread up thenPKPenguin321 wrote:i think jokes are fine but it starts being an issue when it's done to sneak controversial shit in without anybody knowing until it's too lateiamgoofball wrote:yeah that's pretty much the only reason i do itoranges wrote:Basiclly we only do this so we can laugh at those of you who don't check the diff before making a comment.
its like watching people share false headlines on facebook
I reserve the right to make fun of those who don't research before sharing
Limey wrote:its too late.
-
- Code Maintainer
- Joined: Fri Apr 18, 2014 4:42 pm
- Byond Username: Anturke
Re: Misleading PR Titles
I'm cracking down on this. Wasted enough time with these.
- danno
- Joined: Wed Apr 16, 2014 5:07 pm
- Byond Username: Dannno
- Location: e-mail me if you want a pizza roll
Re: Misleading PR Titles
nigga check the diffPKPenguin321 wrote:i think jokes are fine but it starts being an issue when it's done to sneak controversial shit in without anybody knowing until it's too lateiamgoofball wrote:yeah that's pretty much the only reason i do itoranges wrote:Basiclly we only do this so we can laugh at those of you who don't check the diff before making a comment.
its like watching people share false headlines on facebook
I reserve the right to make fun of those who don't research before sharing
????????????
- FantasticFwoosh
- Joined: Mon May 04, 2015 11:25 pm
- Byond Username: FantasticFwoosh
Re: Misleading PR Titles
Those suck, but im more upset about opportunities missed for funny titles & PR descriptions on the flipside. To show we aren't soulless and robotic.
Spoiler:
- Qbopper
- Joined: Fri Jul 10, 2015 6:34 pm
- Byond Username: Qbopper
- Github Username: Qbopper
- Location: Canada
Re: Misleading PR Titles
nothing stopping you from the format of "Meme title (actual title)"FantasticFwoosh wrote:Those suck, but im more upset about opportunities missed for funny titles & PR descriptions on the flipside. To show we aren't soulless and robotic.
Limey wrote:its too late.
- oranges
- Code Maintainer
- Joined: Tue Apr 15, 2014 9:16 pm
- Byond Username: Optimumtact
- Github Username: optimumtact
- Location: #CHATSHITGETBANGED
Re: Misleading PR Titles
To be honest the enforcement will be towards misleading or deceptive titles.
There will be some slack for meme titles, something I am naturally guilty of myself
There will be some slack for meme titles, something I am naturally guilty of myself
Who is online
Users browsing this forum: No registered users